Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

2010-11-11 Thread Andrei Emeltchenko
Hi, On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman wrote: > Emeltchenko Andrei writes: > >> From: Andrei Emeltchenko >> >> Define MDR1 register serial definitions used in serial and >> bluetooth drivers. Remove magic numbers there. > > Remove magic numbers where?  This patch doesn't remove anyth

[PATCH 4/4] arm: omap1: devices: need to return with a value

2010-11-11 Thread Tony Lindgren
From: Felipe Balbi Get rid of the following warning: arch/arm/mach-omap1/devices.c: In function 'omap_init_wdt': arch/arm/mach-omap1/devices.c:298: warning: 'return' with no value, in function returning non-void while at that, also change: platform_device_register(); return 0; into: return p

[PATCH 2/4] omap: dma: Add read-back to DMA interrupt handler to avoid spuriousinterrupts

2010-11-11 Thread Tony Lindgren
From: Mathias Nyman Flush the writes to IRQSTATUS_L0 register in the DMA interrupt handler by reading the register directly after write. This prevents the spurious DMA interrupts noted when using VDD_OPP 1 Signed-off-by: Mathias Nyman Acked-by: Santosh Shilimkar Signed-off-by: Tony Lindgren

[PATCH 3/4] OMAP1: camera.h: add missing include

2010-11-11 Thread Tony Lindgren
From: Janusz Krzysztofik #include directive is required to compile the dependant boards (board-ams-delta for now). Signed-off-by: Janusz Krzysztofik [t...@atomide.com: updated comments] Signed-off-by: Tony Lindgren --- arch/arm/mach-omap1/include/mach/camera.h |2 ++ 1 files changed, 2 i

[PATCH 0/4] omap fixes for v2.6.37-rc1

2010-11-11 Thread Tony Lindgren
Hi all, Here are few fixes for review. Regards, Tony --- Felipe Balbi (1): arm: omap1: devices: need to return with a value Janusz Krzysztofik (1): OMAP1: camera.h: add missing include Mathias Nyman (1): omap: dma: Add read-back to DMA interrupt handler to avoid spuriousin

[PATCH 1/4] OMAP2: Devkit8000: Fix mmc regulator failure

2010-11-11 Thread Tony Lindgren
From: Thomas Weber This patch fixes the following error: >regulator: VMMC1: 1850 <--> 3150 mV at 3000 mV normal standby >twl_reg twl_reg.6: can't register VMMC1, -22 >twl_reg: probe of twl_reg.6 failed with error -22 Signed-off-by: Thomas Weber Signed-off-by: Tony Lindgren --- arch/arm/mach-

Re: [PATCH v2 01/14] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-11 Thread Kevin Hilman
Thara Gopinath writes: [...] > +/** > * omap_vdd_info - Per Voltage Domain info > * > * @volt_data: voltage table having the distinct voltages > supported > @@ -95,9 +112,13 @@ struct vp_reg_val { > * vp registers > * @voltdm : pointer to

Re: [PATCH v2 01/14] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-11 Thread Kevin Hilman
Thara Gopinath writes: > This patch introduces a user list of devices associated with each > voltage domain instance. The user list is implemented using plist > structure with priority node populated with the voltage values. > This patch also adds an API which will take in a device and > requeste

Re: [PATCH v2 06/14] OMAP: Voltage layer changes to support DVFS.

2010-11-11 Thread Kevin Hilman
Thara Gopinath writes: > This patch introduces an API to take in the voltage domain and the > new voltage as parameter and to scale all the scalable devices > associated with the the voltage domain to the rate corresponding to the > new voltage and scale the voltage domain to the new voltage. > >

Re: [PATCH v3 04/13] OMAP2420: DMA: hwmod: add system DMA

2010-11-11 Thread Kevin Hilman
Kevin Hilman writes: > "G, Manjunath Kondaiah" writes: > >> Add OMAP2420 DMA hwmod structures. > > s/structures/data/ > > Also, as pointed out in many other hwmod reviews, when adding hwmod > data, subject should be something like: > > OMAP2420: hwmod_data: add system DMA > Oops... no un

Re: [PATCH v2 05/14] OMAP: Introduce device specific set rate and get rate in omap_device structure

2010-11-11 Thread Kevin Hilman
Thara Gopinath writes: > This patch extends the omap_device structure to contain > pointers to scale the operating rate of the > device and to retrieve the operating rate of the device. > This patch also adds the three new APIs in the omap device layer > namely omap_device_set_rate that can be ca

[PATCH 5/7] OMAP4: mux: Add CBS package data for OMAP4430 ES2

2010-11-11 Thread Benoit Cousson
Please note that the full muxmodes are re-defined for ES2 instead of using the subset. There are 81 differences among 204 pins. The subset fixup will have to iterate over the whole list for each subset entry, which can lead to an important number of iteration. On the other hand, it will take much m

[PATCH 7/7] OMAP4: pandaboard: Select CBL & CBS package and initialize mux

2010-11-11 Thread Benoit Cousson
From: sricharan The mux framework allows the change of pad configuration by drivers when needed. Prior to this the mux framework has to be initialised with all the mux parameters specific to the board. The mux init is already present in the board file for SDP. Adding the mux init for panda boards

[PATCH 6/7] OMAP4: sdp4430: Select CBS package for ES2

2010-11-11 Thread Benoit Cousson
Select the CBS package if SDP4430 is enabled during config. Use the proper package (CBL or CBS) based on chip revision. Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Santosh Shilimkar Cc: Anand Gadiyar --- arch/arm/mach-omap2/Kconfig |1 + arch/arm/mach-om

[PATCH 4/7] OMAP4: sdp4430: Select CBL package for ES1 and initialize mux

2010-11-11 Thread Benoit Cousson
Select the CBL package if SDP4430 is enabled during config. Initialize the mux framework during the board init. Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/Kconfig |1 + arch/arm/mach-omap2/board-4430sdp.c | 10 +

[PATCH 2/7] OMAP: mux: Add support for control module split in several partitions

2010-11-11 Thread Benoit Cousson
Starting on OMAP4, the pin mux configuration is located in two different partitions of the control module (CODE_PAD and WKUP_PAD). The first one is inside the core power domain whereas the second one is inside the wakeup. - Add the capability to add any number of partition during board init time de

[PATCH 1/7] OMAP: mux: Replace printk with pr_xxx macros

2010-11-11 Thread Benoit Cousson
Replace all the printk(KERN_XXX... with pr_xxx macros. Signed-off-by: Benoit Cousson Cc: Tony Lindgren Cc: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/mux.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/arm/mach

[PATCH 0/7] OMAP4: mux: Add the OMAP4430 ES1.0 & ES2.x support

2010-11-11 Thread Benoit Cousson
Hi Tony, Here is the version updated with your fixes. This is the first non RFC version to make Nishant M. happy;-) Thanks to you, the RX-51 is now handled properly and the low level API is still public like before for dynamic mux use. The pandaboard is now supported thanks to Sricharan, and a c

RE: Mistral AM37x (with AM3715) devel board networking broken

2010-11-11 Thread Rick Bronson
Hi, I've found the problem and below is the fix. It appears your SMSC9200 is faster than mine ;-) Once in a while mine gets through the smsc911x_soft_reset() in 100 us but most of the time it takes a full 250 ms. Rick --- linux/drivers/net/smsc911x.c.~1~2010-11-08 19:53:03.0 -0

Re: [PATCH v2 07/14] OMAP: Introduce dependent voltage domain support.

2010-11-11 Thread Kevin Hilman
Thara Gopinath writes: > There could be dependencies between various voltage domains for > maintaining system performance or hardware limitation reasons > like VDD should be at voltage v1 when VDD is at voltage v2. > This patch introduce dependent vdd information structures in the > voltage layer

Re: [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:53 PM, Tony Lindgren wrote: * Cousson, Benoit [101020 13:43]: On 10/20/2010 1:06 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: It takes into account your proposal to store partition information in a partition structure instead of inside every pad entries. The m

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:38 PM, Tony Lindgren wrote: * Cousson, Benoit [10 04:24]: Hi Tony, On 11/11/2010 2:56 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: Add data for OMAP4430 generated from HW pinout& register database. The data set is split in two partitions for both core and

Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

2010-11-11 Thread Tony Lindgren
* Cousson, Benoit [10 08:40]: > On 11/11/2010 5:35 PM, Tony Lindgren wrote: > > Oops yep, I forgot to remove the @id in the kerneldoc. > I was about to send the next revision, maybe I should wait a little > bit more. Well I think that's all I had to comment on these. Just please update the p

Re: [RFC v2 0/7] OMAP4: mux: Add the OMAP4430 ES1 & ES2 support

2010-11-11 Thread Tony Lindgren
* Cousson, Benoit [101020 13:43]: > > On 10/20/2010 1:06 AM, Tony Lindgren wrote: > >* Benoit Cousson [101019 15:14]: > >> > >>It takes into account your proposal to store partition > >>information in a partition structure instead of inside every pad entries. > >>The mechanism relies on the uniq

Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

2010-11-11 Thread Cousson, Benoit
On 11/11/2010 5:35 PM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: --- a/arch/arm/mach-omap2/mux.h +++ b/arch/arm/mach-omap2/mux.h + +/** + * struct mux_partition - contain partition related information + * @name: name of the current partition + * @flags: flags specific to this partit

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-11 Thread Tony Lindgren
* Cousson, Benoit [10 04:24]: > Hi Tony, > > On 11/11/2010 2:56 AM, Tony Lindgren wrote: > >* Benoit Cousson [101019 15:14]: > >>Add data for OMAP4430 generated from HW pinout& register database. > >>The data set is split in two partitions for both core and wkup. > > > >We should drop patch

Re: [RFC v2 3/7] OMAP: mux: Add support for control module split in several partitions

2010-11-11 Thread Tony Lindgren
* Benoit Cousson [101019 15:14]: > --- a/arch/arm/mach-omap2/mux.h > +++ b/arch/arm/mach-omap2/mux.h > + > +/** > + * struct mux_partition - contain partition related information > + * @name: name of the current partition > + * @flags: flags specific to this partition > + * @phys: physical address

Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

2010-11-11 Thread Kevin Hilman
Emeltchenko Andrei writes: > From: Andrei Emeltchenko > > Define MDR1 register serial definitions used in serial and > bluetooth drivers. Remove magic numbers there. Remove magic numbers where? This patch doesn't remove anything. > *v2 added OMAP keyword This info should go after the '---'

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-11 Thread Kevin Hilman
"Peter 'p2' De Schrijver" writes: > On Wed, Nov 10, 2010 at 06:32:53PM +0100, ext Kevin Hilman wrote: >> Jean Pihet writes: >> >> > l-o is currently broken wrt to suspend and idle. >> > Solutions are being worked on for the moment. >> > >> > Kevin, are there solutions available yet? >> >> The

Re: [PATCH 2/5] omap: control: add functions for DSP boot

2010-11-11 Thread Paul Walmsley
Hello Felipe, On Thu, 11 Nov 2010, Felipe Contreras wrote: > On Thu, Nov 11, 2010 at 2:00 AM, Paul Walmsley wrote: > > > > I see that you modified my original patch, but it seems that you also > > dropped my Signed-off-by:. > > Yes, because you didn't s-o-b my changes. I got that complaint from

[PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions

2010-11-11 Thread Emeltchenko Andrei
From: Andrei Emeltchenko Define MDR1 register serial definitions used in serial and bluetooth drivers. Remove magic numbers there. *v2 added OMAP keyword Signed-off-by: Andrei Emeltchenko --- include/linux/serial_reg.h | 12 1 files changed, 12 insertions(+), 0 deletions(-)

Re: [PATCH 00/02] staging: tidspbridge: 2.6.37-rcX fixes

2010-11-11 Thread Greg KH
On Wed, Nov 10, 2010 at 07:50:23PM -0600, Omar Ramirez Luna wrote: > Hi Greg, > > Please consider the following patch set for tidspbridge driver in > staging tree, the following has been tested on an omap3430 based board > + gst-dsp environment. Many thanks to Felipe Contreras for piling this up,

Re: [RFC v2 4/7] OMAP4: mux: Add CBL package data for OMAP4430 ES1

2010-11-11 Thread Cousson, Benoit
Hi Tony, On 11/11/2010 2:56 AM, Tony Lindgren wrote: * Benoit Cousson [101019 15:14]: Add data for OMAP4430 generated from HW pinout& register database. The data set is split in two partitions for both core and wkup. We should drop patch 3/7 and merge the following patch to your 4/7 patch.

Re: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-11 Thread Gregory CLEMENT
On 11/11/2010 10:34 AM, Hemanth V wrote: - Original Message - From: "Gregory CLEMENT" To: "spi-devel-general" ; "linux-omap" Cc: "David Brownell" ; "Grant Likely" ; "Kevin Hilman" Sent: Wednesday, November 10, 2010 4:02 PM Subject: [PATCH v2 2/2] spi: Force CS to be in inactive state a

Re: BeagleBoard not resuming from uart with latest pm-core ?

2010-11-11 Thread Peter 'p2' De Schrijver
On Wed, Nov 10, 2010 at 06:32:53PM +0100, ext Kevin Hilman wrote: > Jean Pihet writes: > > > l-o is currently broken wrt to suspend and idle. > > Solutions are being worked on for the moment. > > > > Kevin, are there solutions available yet? > > The solution to your previous problem (ensuring ru

Re: [PATCH 2/5] omap: control: add functions for DSP boot

2010-11-11 Thread Felipe Contreras
On Thu, Nov 11, 2010 at 2:00 AM, Paul Walmsley wrote: > Hello Felipe, > > On Sun, 7 Nov 2010, Felipe Contreras wrote: > >> From: Paul Walmsley >> >> Add two functions for OMAP2430/OMAP3 IVA2 DSP boot control.  These >> registers wound up in the System Control Module.  Other kernel code that >> wi

[PATCH] OMAP: Serial: Define OMAP uart MDR1 register definitions

2010-11-11 Thread Emeltchenko Andrei
From: Andrei Emeltchenko Define MDR1 register serial definitions used in serial and bluetooth drivers. Remove magic numbers there. Signed-off-by: Andrei Emeltchenko --- include/linux/serial_reg.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/include/linux

Re: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition

2010-11-11 Thread Hemanth V
- Original Message - From: "Gregory CLEMENT" To: "spi-devel-general" ; "linux-omap" Cc: "David Brownell" ; "Grant Likely" ; "Kevin Hilman" Sent: Wednesday, November 10, 2010 4:02 PM Subject: [PATCH v2 2/2] spi: Force CS to be in inactive state after off-mode transition When SPI w

RE: [PATCH v2] OMAP2+: PM: omap_device: API for set/get MSTANDBY mode

2010-11-11 Thread G, Manjunath Kondaiah
Hi Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Thursday, November 11, 2010 4:45 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@vger.kernel.org; Kevin Hilman; Gadiyar, Anand; > Cousson, Benoit > Subject: Re: [PATCH v2] OMAP2+: PM: omap_device: API fo