Re: [PATCH v2 3/4] mtd: devices: elm: Low power transition support

2013-02-09 Thread Russell King - ARM Linux
On Thu, Feb 07, 2013 at 06:06:57PM +0530, Philip Avinash wrote: +static int elm_suspend(struct device *dev) +{ + struct elm_info *info = dev_get_drvdata(dev); + wait_queue_head_t wq; + DECLARE_WAITQUEUE(wait, current); + + init_waitqueue_head(wq); + while (1) { +

Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-02-09 Thread Russell King - ARM Linux
On Wed, Feb 06, 2013 at 03:03:16PM -0600, Jon Hunter wrote: @@ -673,7 +702,7 @@ static int omap_dma_init(void) { int rc = platform_driver_register(omap_dma_driver); - if (rc == 0) { + if ((rc == 0) (!of_have_populated_dt())) { Looks good, the worst I can find is this

Re: Latest additional build warnings

2013-02-09 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 02:22:18PM +, Russell King - ARM Linux wrote: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'

Re: DT GPMC SRAM and NOR flash support ?

2013-02-09 Thread Ezequiel Garcia
Hi Mark, On Thu, Feb 7, 2013 at 6:51 AM, Mark Jackson mpfj-l...@mimc.co.uk wrote: Okay ... I have made some progress, but it's not ideal. Currently I've hacked the GPMC DT driver (gpmc_probe_dt(), etc) so it now handles setting up the chip selects and timings for NOR devices, e.g.

Re: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data

2013-02-09 Thread Grant Likely
On Thu, 10 Jan 2013 14:09:35 +0100, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Linus, On 01/10/2013 11:41 AM, Linus Walleij wrote: On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Use more coherent locking in the driver. Use bitfield to store the

Re: [PATCH v2] drivers/gpio: using common order: let 'static const' instead of 'const static'

2013-02-09 Thread Grant Likely
On Wed, 6 Feb 2013 16:17:24 +0530, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Wednesday 06 February 2013 04:14 PM, Chen Gang wrote: 'const static ' is not a common order, better to use 'static const' instead. building: make EXTRA_CFLAGS=-W ARCH=arm

Re: [PATCH 1/2] ARM: OMAP2+: Prevent potential crash if GPMC probe fails

2013-02-09 Thread Ezequiel Garcia
On Fri, Feb 08, 2013 at 04:56:19PM -0600, Jon Hunter wrote: On 02/01/2013 04:08 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130201 08:42]: If the GPMC probe fails, devices that use the GPMC (such as ethernet chips, flash memories, etc) can still allocate a GPMC chip-select

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Sekhar Nori
Hi Matt, This version introduces build/bisect issues. On 2/1/2013 11:52 PM, Matt Porter wrote: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx) as well. Signed-off-by: Matt Porter mpor...@ti.com Acked-by: Sekhar Nori nsek...@ti.com diff --git

[PATCH 0/7] ARM: omap2: GPMC cleanup

2013-02-09 Thread Ezequiel Garcia
This patchset is a small cleanup consisting in: * mark some functions as 'static' when appropriate * remove an unused function from gpmc.c * improve error messages when a CS request fails * migrate to dev_err and dev_warn It has been tested on a IGEP v2 board with OneNAND, which means the

[PATCH 1/7] ARM: omap2: gpmc: Mark local scoped functions static

2013-02-09 Thread Ezequiel Garcia
This patch marks a bunch of functions that are local to gpmc.c file only as static. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 14 +++--- arch/arm/mach-omap2/gpmc.h |7 --- 2 files changed, 7 insertions(+), 14 deletions(-)

[PATCH 2/7] ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function

2013-02-09 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index ffe3e1e..bd3bc93 100644 --- a/arch/arm/mach-omap2/gpmc.c

[PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Ezequiel Garcia
Fix gpmc_cs_reserved() so it returns 0 if the chip select is available (not reserved) or an error otherwise. This allows to use the return value directly and return a proper error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc.c | 12

[PATCH 4/7] ARM: omap2: gpmc-nand: Print something useful on CS request failure

2013-02-09 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[PATCH 5/7] ARM: omap2: gpmc-onenand: Print something useful on CS request failure

2013-02-09 Thread Ezequiel Garcia
If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[PATCH 6/7] ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err()

2013-02-09 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c index 0ee5317..4771945 100644 ---

[PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Ezequiel Garcia
Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Felipe Balbi
On Sat, Feb 09, 2013 at 01:38:12PM -0300, Ezequiel Garcia wrote: Fix gpmc_cs_reserved() so it returns 0 if the chip select is available (not reserved) or an error otherwise. This allows to use the return value directly and return a proper error code. Signed-off-by: Ezequiel Garcia

Re: [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Felipe Balbi
Hi, On Sat, Feb 09, 2013 at 01:38:16PM -0300, Ezequiel Garcia wrote: Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-onenand.c |2 +- 1 files

Re: [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Ezequiel Garcia
On Sat, Feb 09, 2013 at 06:55:32PM +0200, Felipe Balbi wrote: Hi, On Sat, Feb 09, 2013 at 01:38:16PM -0300, Ezequiel Garcia wrote: Since the condition is not an error but a warning, replace printk KERN_ERR with dev_warn. Signed-off-by: Ezequiel Garcia

Re: [PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Ezequiel Garcia
Hi Felipe, On Sat, Feb 09, 2013 at 06:53:35PM +0200, Felipe Balbi wrote: On Sat, Feb 09, 2013 at 01:38:12PM -0300, Ezequiel Garcia wrote: Fix gpmc_cs_reserved() so it returns 0 if the chip select is available (not reserved) or an error otherwise. This allows to use the return value

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Russell King - ARM Linux
On Sat, Feb 09, 2013 at 09:35:53PM +0530, Sekhar Nori wrote: On 2/1/2013 11:52 PM, Matt Porter wrote: + ret = of_address_to_resource(node, 1, res); of_address_to_resource() needs linux/of_address.h + if (IS_ERR_VALUE(ret)) This needs linux/err.h More importantly, is this the

[PATCH RFC 0/7] ARM: OMAP: add DT binding for gpmc-smsc911x

2013-02-09 Thread Javier Martinez Canillas
Hello, This is an RFC to add Device Tree support for SMSC LAN chips connected to OMAP processors though its General-Purpose Memory Controller. The patch-set is composed of the following patches: [PATCH RFC 1/7] platform: add a device node [PATCH RFC 2/7] net: smsc911x: add pinctrl support

[PATCH RFC 1/7] platform: add a device node

2013-02-09 Thread Javier Martinez Canillas
When using Device Trees, it is necessary to associate a device node with a platform device. Usually this device node has to used in the device probe function (e.g: to initizalize the pinctrl pads assocaited with the device). So, platform code needs to pass a device node as a platform device info

[PATCH RFC 2/7] net: smsc911x: add pinctrl support

2013-02-09 Thread Javier Martinez Canillas
If no pinctrl is available just report a warning since it may not needed in some cases (e.g: non-DT kernels). Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/net/ethernet/smsc/smsc911x.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-)

[PATCH RFC 3/7] ARM: OMAP: gpmc-smsc911x: add DT dev node init function

2013-02-09 Thread Javier Martinez Canillas
This patch adds a helper function to parse a device node that contains all the properties needed to initialize an smsc911x device connected to an OMAP processor through OMAP's GPMC. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk ---

[PATCH RFC 4/7] ARM: OMAP: gpmc-smsc911x: pass a dev node to platform registration

2013-02-09 Thread Javier Martinez Canillas
The smsc911x driver needs the GPMC smsc911x associated device node to set the OMAP mux pins using the pinctrl framework. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/mach-omap2/gpmc-smsc911x.c |5 - arch/arm/mach-omap2/gpmc-smsc911x.h |1 + 2

[PATCH RFC 5/7] ARM: OMAP: gpmc: add support for gpmc-smsc911x child nodes

2013-02-09 Thread Javier Martinez Canillas
Besides being used to interface with external memory devices, the General-Purpose Memory Controller can be used to connect Pseudo-SRAM devices to the OMAP processor that use the GPMC as a data bus. One of these devices is the smsc911x LAN chip. This patch allows an smsc911x LAN pheripheral to be

[PATCH RFC 6/7] ARM: dts: OMAP: Add an GPMC node for OMAP3

2013-02-09 Thread Javier Martinez Canillas
This patch adds a General-Purpose Memory Controller (GPMC) device node to be used for OMAP3 based SoC boards. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/boot/dts/omap3.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git

[PATCH RFC 7/7] ARM: dts: omap3-igep0020: Add SMSC911x LAN chip support

2013-02-09 Thread Javier Martinez Canillas
IGEPv2 boards has an SMSC LAN9221i ethernet chip connected to the OMAP3 processor though the General-Purpose Memory Controller. This patch adds a device node for the ethernet chip so the GPMC driver will call the gpmc-smsc911x setup code. Signed-off-by: Javier Martinez Canillas

Re: [PATCH 3/7] ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value

2013-02-09 Thread Felipe Balbi
Hi, On Sat, Feb 09, 2013 at 03:14:33PM -0300, Ezequiel Garcia wrote: static int gpmc_cs_reserved(int cs) { if (cs GPMC_CS_NUM) return -ENODEV; - return gpmc_cs_map (1 cs); + if (gpmc_cs_map (1 cs)) + return -EBUSY; + + return 0; you

Re: [PATCH 7/7] ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn()

2013-02-09 Thread Felipe Balbi
On Sat, Feb 09, 2013 at 03:05:31PM -0300, Ezequiel Garcia wrote: On Sat, Feb 09, 2013 at 06:55:32PM +0200, Felipe Balbi wrote: Hi, On Sat, Feb 09, 2013 at 01:38:16PM -0300, Ezequiel Garcia wrote: Since the condition is not an error but a warning, replace printk KERN_ERR with

Re: [GIT PULL] omap twl platform init changes for v3.9 merge window

2013-02-09 Thread Olof Johansson
On Wed, Feb 06, 2013 at 09:25:00AM -0800, Tony Lindgren wrote: The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311: Linux 3.8-rc5 (2013-01-25 11:57:28 -0800) are available in the git repository at:

Re: [PATCH RFC 1/7] platform: add a device node

2013-02-09 Thread Greg Kroah-Hartman
On Sat, Feb 09, 2013 at 09:44:25PM +0100, Javier Martinez Canillas wrote: When using Device Trees, it is necessary to associate a device node with a platform device. Usually this device node has to used in the device probe function (e.g: to initizalize the pinctrl pads assocaited with the

Re: [PATCH RFC 1/7] platform: add a device node

2013-02-09 Thread Javier Martinez Canillas
Hi Greg, Thanks a lot for your feedback. On 02/10/2013 02:02 AM, Greg Kroah-Hartman wrote: On Sat, Feb 09, 2013 at 09:44:25PM +0100, Javier Martinez Canillas wrote: When using Device Trees, it is necessary to associate a device node with a platform device. Usually this device node has to

Re: [GIT PULL] omap twl platform init changes for v3.9 merge window

2013-02-09 Thread Tony Lindgren
* Olof Johansson o...@lixom.net [130209 17:01]: On Wed, Feb 06, 2013 at 09:25:00AM -0800, Tony Lindgren wrote: The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311: Linux 3.8-rc5 (2013-01-25 11:57:28 -0800) are available in the git repository at:

Re: [PATCH 1/1] ARM: OMAP4: Add OMAP4 Blaze Tablet support

2013-02-09 Thread Tony Lindgren
Hi, * Ruslan Bilovol ruslan.bilo...@ti.com [130208 11:41]: The OMAP4 Blaze Tablet is TI OMAP4 processor-based development platform in a tablet formfactor. The platform contains many of the features found in present-day handsets (such as audio, video, wireless functions and user interfaces)

Re: Latest additional build warnings

2013-02-09 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [130209 03:53]: On Tue, Feb 05, 2013 at 02:22:18PM +, Russell King - ARM Linux wrote: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type

Re: Latest additional build warnings

2013-02-09 Thread Olof Johansson
On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [130209 03:53]: On Tue, Feb 05, 2013 at 02:22:18PM +, Russell King - ARM Linux wrote: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or

Re: [PATCH] arm: Include soc.h to fix compiling

2013-02-09 Thread Tony Lindgren
* André Hentschel n...@dawncrow.de [130206 14:46]: I needed this when compiling for pandaboard at commit: 0944c0a03465718909ba8e800a5230528aeabafb Signed-off-by: André Hentschel n...@dawncrow.deFrom: =?UTF-8?q?Andr=C3=A9=20Hentschel?= n...@dawncrow.de From:

Re: Latest additional build warnings

2013-02-09 Thread Tony Lindgren
* Olof Johansson o...@lixom.net [130209 19:08]: On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [130209 03:53]: On Tue, Feb 05, 2013 at 02:22:18PM +, Russell King - ARM Linux wrote:

Re: Latest additional build warnings

2013-02-09 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [130209 19:29]: From: Tony Lindgren t...@atomide.com Date: Sat, 9 Feb 2013 19:20:57 -0800 Subject: [PATCH] ARCH: OMAP2+: Make sure files with omap initcalls include soc.h Oops, will fix up the subject to say ARM: OMAP2+ instead of ARCH.. Looks like there

[GIT PULL] omap multiplatform warning fixes for v3.9 merge window

2013-02-09 Thread Tony Lindgren
The following changes since commit ad1bb1b4e01c5ecbe32133ce6921d0e76cb76dcf: ARM: OMAP2+: Remove now obsolete uncompress.h and debug-macro.S (2013-01-11 11:24:20 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap

Re: Latest additional build warnings

2013-02-09 Thread Olof Johansson
On Sat, Feb 9, 2013 at 7:22 PM, Tony Lindgren t...@atomide.com wrote: * Olof Johansson o...@lixom.net [130209 19:08]: On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [130209 03:53]: On Tue, Feb 05, 2013 at 02:22:18PM

Re: [GIT PULL] omap multiplatform warning fixes for v3.9 merge window

2013-02-09 Thread Olof Johansson
Hi, On Sat, Feb 9, 2013 at 8:19 PM, Tony Lindgren t...@atomide.com wrote: The following changes since commit ad1bb1b4e01c5ecbe32133ce6921d0e76cb76dcf: ARM: OMAP2+: Remove now obsolete uncompress.h and debug-macro.S (2013-01-11 11:24:20 -0800) are available in the git repository at:

Re: [GIT PULL] omap multiplatform warning fixes for v3.9 merge window

2013-02-09 Thread Tony Lindgren
* Olof Johansson o...@lixom.net [130209 20:31]: Hi, On Sat, Feb 9, 2013 at 8:19 PM, Tony Lindgren t...@atomide.com wrote: The following changes since commit ad1bb1b4e01c5ecbe32133ce6921d0e76cb76dcf: ARM: OMAP2+: Remove now obsolete uncompress.h and debug-macro.S (2013-01-11