Re: [PATCH 04/11] OMAP3: DMA: HWMOD: Add hwmod data structures

2010-08-04 Thread Cousson, Benoit
On 8/4/2010 2:35 AM, G, Manjunath Kondaiah wrote: Kevin, From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, August 04, 2010 3:27 AM Manjunatha GKmanj...@ti.com writes: This patch adds OMAP3 DMA hwmod structures. Signed-off-by: Manjunatha GKmanj...@ti.com [...]

Re: [PATCH 01/11] OMAP: DMA: Introduce DMA device attributes

2010-08-04 Thread Cousson, Benoit
On 7/30/2010 5:57 AM, G, Manjunath Kondaiah wrote: snip +/* Attributes for OMAP DMA Contrllers */ +#define ENABLE_1510_MODE (1 0) +#define DMA_LINKED_LCH (1 1) +#define GLOBAL_PRIORITY(1 2) +#define RESERVE_CHANNEL

Re: [PATCH 04/11] OMAP3: DMA: HWMOD: Add hwmod data structures

2010-08-04 Thread Cousson, Benoit
On 8/4/2010 12:15 PM, Shilimkar, Santosh wrote: From: Cousson, Benoit Sent: Wednesday, August 04, 2010 3:38 PM On 8/4/2010 2:35 AM, G, Manjunath Kondaiah wrote: Kevin, From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, August 04, 2010 3:27 AM Manjunatha GKmanj

Re: [PM-SR] [PATCH] OMAP: PM: Remove the usage of vdd id's.

2010-08-04 Thread Cousson, Benoit
On 8/4/2010 6:31 AM, Gopinath, Thara wrote: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, June 25, 2010 11:56 PM Thara Gopinathth...@ti.com writes: This patch removes the usage of vdd and sr id alltogether. This is achieved by introducing a separte voltage domain per

Re: [PATCH] OMAP4: HWMOD: Do omap_hwmod_late_init for OMAP4

2010-08-06 Thread Cousson, Benoit
Hi Charu, On 8/6/2010 2:31 PM, Varadarajan, Charulatha wrote: This patch includes cpu_is check for omap44xx cpu inorder to do omap_hwmod_late_init() without which hwmods initialization does not happen for omap4. Signed-off-by: Charulatha Vch...@ti.com Signed-off-by: Basak,

Re: [PATCH 7/8] : Hwmod api changes

2010-08-09 Thread Cousson, Benoit
On 8/6/2010 7:28 PM, Kalliguddi, Hema wrote: From: Hema HKhem...@ti.com Omap USBOTG modules has a requirement to set the auto idle bit only after setting smart idle bit. Is it a requirement or an errata? Could you provide more information (i.e. TRM page or errata number / description)?

Re: [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis

2010-08-09 Thread Cousson, Benoit
On 8/6/2010 5:54 PM, HEMA HK wrote: From: Hema HKhem...@ti.com Series of patches to port musb driver to use hwmod and runtime pm APIs for OMAP4 and OMAP3.These patches are tested on OMAP4430SDP and OMAP3630-ZOOM3 boards. The patch 1 and 2 are are the prerequisites for the hwmod changes. Patch

Re: [PATCH V2 4/8]usb : musb:Using omap_device_build for musb device registration

2010-08-09 Thread Cousson, Benoit
On 8/6/2010 5:57 PM, Kalliguddi, Hema wrote: From: Hema HKhem...@ti.com snip void __init usb_musb_init(struct omap_musb_board_data *board_data) { - if (cpu_is_omap243x()) { - musb_resources[0].start = OMAP243X_HS_BASE; - } else if (cpu_is_omap34xx()) { -

Re: [PATCH V2 6/8] usb: musb: Offmode fix for idle path

2010-08-09 Thread Cousson, Benoit
On 8/6/2010 7:27 PM, Kalliguddi, Hema wrote: From: Hema HKhem...@ti.com With OMAP core-off support musb was not functional as context was getting lost after wakeup from core-off. And also musb was blocking the core-off after loading the gadget driver even with no cable connected sometimes.

Re: [PATCH 8/8 ]usb : musb:Using runtime pm apis for musb.

2010-08-09 Thread Cousson, Benoit
On 8/6/2010 7:29 PM, Hema HK wrote: From: Hema HKhem...@ti.com Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. used omap_hwmod_enable_wakeup omap_hwmod_disable_wakeup apis to set/clear the wakeup enable bit. Also

Re: [PATCH 7/8] : Hwmod api changes

2010-08-09 Thread Cousson, Benoit
On 8/9/2010 11:37 AM, Nayak, Rajendra wrote: From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Monday, August 09, 2010 1:51 PM (cc Benoît) On Mon, 9 Aug 2010, Nayak, Rajendra wrote: Does it make sense for the framework itself to enable wakeup for all devices when the slave port is

Re: [PATCH 1/3] OMAP4: prcm: Add temporarily helper functions for rmw and read inside the PRM

2010-08-09 Thread Cousson, Benoit
On 8/9/2010 7:30 PM, Kevin Hilman wrote: Benoit Coussonb-cous...@ti.com writes: Since OMAP4 is using an absolute address, the current PRM accessors are not useable. OMAP4 adaptation for these API are currently ongoing, so define temp version until the proper ones are defined. Curious what

Re: [PATCH 01/13 v5] OMAP: GPIO: Modify init() in preparation for platform device implementation

2010-08-10 Thread Cousson, Benoit
On 8/10/2010 9:20 AM, Basak, Partha wrote: From: Varadarajan, Charulatha Sent: Tuesday, August 10, 2010 10:49 AM From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 10, 2010 3:51 AM Charulatha Vch...@ti.com writes: This is in prepartion for implementing GPIO as

Re: [PATCH v3 0/7] OMAP: hwmod: Full data set for OMAP4430 ES1 ES2

2010-08-11 Thread Cousson, Benoit
Hi Kevin, On 8/9/2010 9:11 PM, Kevin Hilman wrote: Benoit Coussonb-cous...@ti.com writes: Hi Kevin Paul, Here is the OMAP4430 ES1 ES2 hwmod data v3 series. Please note that there is no difference between the ES1 ES2 wrt hwmod. This series is re-organised in order to allow initial

Re: [PATCH v3 0/7] OMAP: hwmod: Full data set for OMAP4430 ES1 ES2

2010-08-12 Thread Cousson, Benoit
On 8/12/2010 2:34 AM, Kevin Hilman wrote: Cousson, Benoitb-cous...@ti.com writes: Hi Kevin, On 8/9/2010 9:11 PM, Kevin Hilman wrote: Benoit Coussonb-cous...@ti.com writes: Hi Kevin Paul, Here is the OMAP4430 ES1 ES2 hwmod data v3 series. Please note that there is no difference

Re: [PATCH] OMAP4: pm.c extensions for OMAP4 support

2010-08-16 Thread Cousson, Benoit
Hi Thara, On 8/16/2010 11:26 AM, Thara Gopinath wrote: OMAP4 has an iva device and a dsp devcice where as OMAP2/3 has only an iva device. In this file the iva device in the system is registered under the name dsp_dev and the API to retrieve the iva device is omap2_get_dsp_device. This patch

Re: DSS2 patch series

2010-08-17 Thread Cousson, Benoit
Hi Archit, On 8/17/2010 1:16 PM, Taneja, Archit wrote: Hi, Ok. Well, good that it's clear now =). How do you think we can clean things up? If I remember right, there's some kind of feature framework being worked on (or ready?), but I haven't looked at that at all. That may or may not suit

Re: [PATCH 3/3] OMAP: hwmod: Force a softreset during _setup

2010-08-18 Thread Cousson, Benoit
Hi Partha, On 8/17/2010 2:46 PM, Basak, Partha wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cousson, Benoit Sent: Thursday, August 05, 2010 3:43 AM Force the softreset of every IPs during the _setup phase. IPs that cannot support

Re: OMAP2PLUS dpll rate calculation.

2010-08-19 Thread Cousson, Benoit
Hi Thara, On 8/18/2010 8:46 AM, Gopinath, Thara wrote: Hello Paul/Kevin, Recently I noticed that the dpll rate calculation code in arch/arm/mach-omap2/clkt_dpll.c is as follows dpll_clk = (long long)dd-clk_ref-rate * dpll_mult; do_div(dpll_clk, dpll_div + 1); But the actual

Re: [PATCH 3/3] OMAP: hwmod: Force a softreset during _setup

2010-08-19 Thread Cousson, Benoit
On 8/19/2010 1:57 PM, Basak, Partha wrote: -Original Message- From: Cousson, Benoit Sent: Wednesday, August 18, 2010 8:31 PM To: Basak, Partha Cc: Nayak, Rajendra; Shilimkar, Santosh; linux-omap@vger.kernel.org; khil...@deeprootsystems.com; p...@pwsan.com Subject: Re: [PATCH 3/3] OMAP

Re: [PATCH 05/10] [PM-WIP-MMC] OMAP4 hwmod: Updating hwmod data for MMC controllers

2010-08-23 Thread Cousson, Benoit
Hi Kishore, On 8/20/2010 10:10 PM, Kadiyala, Kishore wrote: Update register offsets and dev attributes for MMC controllers on OMAP4 Cc: Kevin Hilmankhil...@deeprootsystems.com Cc: Benoit Coussonb-cous...@ti.com Signed-off-by: Kishore Kadiyalakishore.kadiy...@ti.com ---

Re: [RFC: PATCH] Fix to support multiple HWMODS for a single device

2010-08-23 Thread Cousson, Benoit
Hi Vijay, On 8/23/2010 12:46 PM, ABRAHAM, KISHON VIJAY wrote: The current HWMOD code expects multiple HWMODS to be filled in consecutive memory location before passing to omap_device_build_ss(). Just a minor comment: this is not the The current HWMOD code but the omap_device core code.

Re: [PATCH 3/3] OMAP: hwmod: Force a softreset during _setup

2010-08-23 Thread Cousson, Benoit
: + if (oh-flags HWMOD_CONTROL_OPT_CLKS_IN_RESET) + _disable_optional_clocks(oh); + + return ret; } /** -- 1.6.0.4 On 8/19/2010 1:57 PM, Basak, Partha wrote: From: Cousson, Benoit Sent: Wednesday, August 18, 2010 8:31 PM Hi Partha, On 8/17/2010 2:46 PM, Basak

Re: [RFC PATCH 00/20] HWMOD Adaptation for DSS

2010-08-23 Thread Cousson, Benoit
On 8/23/2010 5:57 PM, Guruswamy, Senthilvadivu wrote: From: Senthilvadivu Guruswamysvad...@ti.com Patch Base: === url = git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git branch pm-wip/hwmods-omap4 Commit id: f6f7f1103b80b4dc0ace8a0314d95d1b1ebca726 Description:

Re: [PATCH 15/20] Use platform device to get DSS base addr

2010-08-23 Thread Cousson, Benoit
On 8/23/2010 5:58 PM, Guruswamy, Senthilvadivu wrote: From: Senthilvadivu Guruswamysvad...@ti.com DSS Base addr got form platform device. Hardcoding of base addr could be removed. Signed-off-by: Senthilvadivu Guruswamysvad...@ti.com --- drivers/video/omap2/dss/dss.c |4 +++- 1 files

Re: [PATCH] Fix to support multiple HWMODS for a single device

2010-08-24 Thread Cousson, Benoit
+ Paul Hi Vijay, I just have a couple of minors comments. You should copy at least the file authors when submitting a patch. Paul is missing. You should correct the subject with something like: [PATCH] OMAP: omap_device: Fix to support multiple hwmods for a single device On 8/24/2010

Re: [PATCH] OMAP: HWMOD: Handle opt clocks using clk_add_alias

2010-08-25 Thread Cousson, Benoit
Re-sent to loml, the original email was sent to lkml... On 8/25/2010 1:30 PM, Cousson, Benoit wrote: On 8/25/2010 12:45 PM, Basak, Partha wrote: From: Cousson, Benoit Sent: Tuesday, August 24, 2010 1:45 AM Hi Partha, On 8/23/2010 5:44 PM, Basak, Partha wrote: From: Basak, Parthap-bas

Re: [PATCH 2/9] omap: mux: Add new style pin multiplexing code for omap3

2010-08-27 Thread Cousson, Benoit
On 8/27/2010 4:29 AM, rockefeller wrote: Hi Tony, In the implementation of omap_mux_init_signal(char *muxname, int val) in arch/arm/mach-omap2/mux.c, it will modify the muxname of caller that passed in and not recover it, did you mean to implement to do so?(I try to explain my point of view

Re: [PATCH] OMAP CPUIDLE: CPU Idle latency measurement

2010-08-27 Thread Cousson, Benoit
Hi Vishwa, On 8/28/2010 12:08 AM, vishwanath.sripa...@linaro.org wrote: From: Vishwanath BSvishwanath.sripa...@linaro.org This patch has instrumentation code for measuring latencies for various CPUIdle C states for OMAP. Idea here is to capture the timestamp at various phases of CPU Idle and

Re: [PATCH 10/20] Move rfbi init to rfbi probe

2010-08-27 Thread Cousson, Benoit
On 8/23/2010 5:57 PM, Guruswamy, Senthilvadivu wrote: From: Senthilvadivu Guruswamysvad...@ti.com RFBI init and exit moved to rfbi probe and remove. Signed-off-by: Senthilvadivu Guruswamysvad...@ti.com --- drivers/video/omap2/dss/core.c | 21 +++-- 1 files changed, 11

Re: [RFC: PATCH] OMAP: hwmod: New API to modify the autoidle bits of sysconfig register

2010-08-31 Thread Cousson, Benoit
On 8/31/2010 4:41 PM, ABRAHAM, KISHON VIJAY wrote: On Tuesday 31 August 2010 01:43 PM, Felipe Balbi wrote: On Tue, 31 Aug 2010 10:53:36 +0530, kishona0393...@ti.com wrote: Though driver shouldn't be using hwmod directly, there is no corresponding API in omap_device to do the same.

Re: [PATCH 10/20] Move rfbi init to rfbi probe

2010-08-31 Thread Cousson, Benoit
On 8/31/2010 2:57 PM, Guruswamy, Senthilvadivu wrote: -Original Message- From: Cousson, Benoit Sent: Friday, August 27, 2010 7:25 PM To: Guruswamy, Senthilvadivu Cc: linux-omap@vger.kernel.org; tomi.valkei...@nokia.com; p...@pwsan.com; Hilman, Kevin Subject: Re: [PATCH 10/20] Move

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-03 Thread Cousson, Benoit
Hi Kishore, On 8/30/2010 7:48 PM, Kadiyala, Kishore wrote: OMAP4 not only have newly added hsmmc registers but also have registers which were there in OMAP3 and which doesn't have a common offset deviation compared to OMAP3. For generic handling, OMAP3 and OMAP4 has different array's of

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-03 Thread Cousson, Benoit
On 9/3/2010 5:44 PM, Kevin Hilman wrote: kishore kadiyalakishorek.kadiy...@gmail.com writes: Hi Benoit snip + while (!(omap_readl(base + reg_off) MMCHS_SYSSTATUS_RESETDONE)) cpu_relax(); Why does that series not seems to be

Re: [PATCH v2 00/11] OMAP: DMA: HWMOD and DMA as platform driver

2010-09-03 Thread Cousson, Benoit
(669d24d412380528158ba5d15522c9858f4b81a2). -Manjunath -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of G, Manjunath Kondaiah Sent: Tuesday, August 24, 2010 4:34 PM To: linux-omap@vger.kernel.org Cc: Cousson, Benoit; Kevin Hilman; Shilimkar

Re: [PATCH 7/7] omap3: make coresight register save across OFF modes a sysfs option

2010-09-04 Thread Cousson, Benoit
Hi Tony, On 8/6/2010 2:47 PM, Tony Lindgren wrote: * Alexander Shishkinvirtu...@slind.org [100806 15:30]: On Sun, Jul 25, 2010 at 08:05:20 +0300, Alexander Shishkin wrote: This adds a sysfs file at /sys/power/coresight_save which is used to control if the ETM and debug components' states

Re: [PATCH v2 04/11] OMAP3: DMA: HWMOD: Add hwmod data structures

2010-09-04 Thread Cousson, Benoit
Hi Kevin, On 9/3/2010 10:51 PM, Kevin Hilman wrote: Manjunatha GKmanj...@ti.com writes: [...] +static struct omap_hwmod omap3xxx_dma_system_hwmod = { + .name = dma, + .class =omap3xxx_dma_hwmod_class, + .mpu_irqs = omap3xxx_dma_system_irqs, +

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Cousson, Benoit
Hi Santosh, On 9/9/2010 1:42 PM, Felipe Balbi wrote: Hi, On Thu, Sep 09, 2010 at 06:23:10AM -0500, Santosh Shilimkar wrote: @@ -308,6 +308,16 @@ static void __init omap4_check_revision(void) hawkeye = (idcode 12) 0x; rev = (idcode 28) 0xff; + /* +*

Re: [PATCH 2/7] omap4: Temporary fix silicon version detection

2010-09-09 Thread Cousson, Benoit
On 9/9/2010 2:07 PM, Balbi, Felipe wrote: Hi Santosh, On Thu, Sep 09, 2010 at 07:02:46AM -0500, Shilimkar, Santosh wrote: Felipe is suggesting not to add this support where as you want to have this support. Sorry if I haven't understood the comment. Care to clarify no, I suggested not to

Re: [PATCH v5 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-15 Thread Cousson, Benoit
Hi Charu, On 9/15/2010 7:26 AM, Varadarajan, Charulatha wrote: From: Benoit Coussonb-cous...@ti.com Add watchdog timer hwmod data for OMAP4 chip Signed-off-by: Benoit Coussonb-cous...@ti.com Signed-off-by: Charulatha Vch...@ti.com --- This patch is extracted from the below patch sent by

Re: [PATCH v5 1/6] OMAP3: hwmod data: Add watchdog timer

2010-09-15 Thread Cousson, Benoit
On 9/15/2010 7:26 AM, Varadarajan, Charulatha wrote: Add watchdog timer hwmod data for OMAP3 chip Signed-off-by: Charulatha Vch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 61 arch/arm/mach-omap2/prcm-common.h |4 ++ 2 files

Re: [PATCH v5 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-15 Thread Cousson, Benoit
On 9/15/2010 7:26 AM, Varadarajan, Charulatha wrote: From: Benoit Coussonb-cous...@ti.com Add watchdog timer hwmod data for OMAP4 chip Signed-off-by: Benoit Coussonb-cous...@ti.com Signed-off-by: Charulatha Vch...@ti.com --- This patch is extracted from the below patch sent by Benoit OMAP4:

Re: [PATCH v5 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs

2010-09-15 Thread Cousson, Benoit
On 9/15/2010 7:26 AM, Varadarajan, Charulatha wrote: Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks, sysconfig settings instead of using clock FW APIs. Signed-off-by: Charulatha Vch...@ti.com --- drivers/watchdog/omap_wdt.c | 42

Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device registration

2010-09-16 Thread Cousson, Benoit
, Manjunath Kondaiah Cc: Balbi, Felipe; Kevin Hilman; linux-omap@vger.kernel.org; Cousson, Benoit; Shilimkar, Santosh Subject: Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device registration Hi, On Thu, Sep 16, 2010 at 01:32:58AM -0500, G, Manjunath Kondaiah wrote: #define dma_read(reg

Re: [PATCH v5 6/6] OMAP: WDT: Use PM runtime APIs instead of clk FW APIs

2010-09-16 Thread Cousson, Benoit
On 9/16/2010 3:37 PM, Varadarajan, Charulatha wrote: From: Cousson, Benoit Sent: Thursday, September 16, 2010 3:11 AM On 9/15/2010 7:26 AM, Varadarajan, Charulatha wrote: Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks, sysconfig

Re: [PATCH v2 09/11] OMAP: DMA: Implement generic errata handling

2010-09-17 Thread Cousson, Benoit
Hi Manjunath, On 9/17/2010 7:05 AM, G, Manjunath Kondaiah wrote: Kevin, -Original Message- From: G, Manjunath Kondaiah Sent: Tuesday, September 14, 2010 3:42 PM To: G, Manjunath Kondaiah; Kevin Hilman Cc: linux-omap@vger.kernel.org; Cousson, Benoit; Shilimkar, Santosh Subject: RE

Re: [PATCH v5 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-17 Thread Cousson, Benoit
Hi Charu, On 9/17/2010 11:23 AM, Varadarajan, Charulatha wrote: -Original Message- From: Cousson, Benoit Sent: Thursday, September 16, 2010 2:49 AM To: Varadarajan, Charulatha Cc: t...@atomide.com; w...@iguana.be; linux-watch...@vger.kernel.org; khil...@deeprootsystems.com; p

Re: [PATCH v2 09/11] OMAP: DMA: Implement generic errata handling

2010-09-17 Thread Cousson, Benoit
On 9/17/2010 10:09 AM, G, Manjunath Kondaiah wrote: Hi Benoit, ... I assume you are ok with option #1. Let me know if you have any issues/concenrs with above approach. I am in the process of consolidating all the review comments and addressing all applicable review comments. Not

Re: [PATCH v2 09/11] OMAP: DMA: Implement generic errata handling

2010-09-17 Thread Cousson, Benoit
On 9/17/2010 1:28 PM, G, Manjunath Kondaiah wrote: From: Cousson, Benoit Sent: Friday, September 17, 2010 3:59 PM On 9/17/2010 10:09 AM, G, Manjunath Kondaiah wrote: Hi Benoit, ... I assume you are ok with option #1. Let me know if you have any issues/concenrs with above approach. I am

Re: [PATCH v2 09/11] OMAP: DMA: Implement generic errata handling

2010-09-17 Thread Cousson, Benoit
On 8/24/2010 1:04 PM, G, Manjunath Kondaiah wrote: This patch introduces generic way of handling all OMAP DMA errata's which are applicable for OMAP1 and OMAP2PLUS processors. ... diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index f369bee..8832bd1 100644 ---

Re: [PATCH 05/13] OMAP: Introduce device specific set rate and get rate in device opp structures.

2010-09-18 Thread Cousson, Benoit
Hi Thara, On 9/17/2010 4:55 PM, Gopinath, Thara wrote: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 16, 2010 8:58 PM Gopinath, Tharath...@ti.com writes: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, September 03, 2010 5:12 AM

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-20 Thread Cousson, Benoit
Hi Kishore On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: The offset handling implementation of omap4 mmc registers which was already present can't be reused once hwmod modifications are done for mmc driver. Since hwmod data file for OMAP4 is an auto generated the base address for MMC will

Re: [RFC v.4] omap: hwspinlock: Added hwspinlock driver

2010-09-21 Thread Cousson, Benoit
On 9/20/2010 7:30 PM, Kevin Hilman wrote: Ohad Ben-Coheno...@wizery.com writes: Hi Hari, On Thu, Aug 12, 2010 at 12:44 AM, Kanigeri, Harih-kanige...@ti.com wrote: +/* Attempt to acquire a spinlock once */ +int hwspinlock_trylock(struct hwspinlock *handle) +{ + int retval = 0; + +

Re: [PATCH 0/3] OMAP: hwmod: Add hardreset and softreset management

2010-09-21 Thread Cousson, Benoit
Hi Paul, On 9/21/2010 7:03 AM, Paul Walmsley wrote: Hi Benoît, I regret the delay - Considering the job you did on that reset series, you are already forgiven :-) On Thu, 5 Aug 2010, Benoit Cousson wrote: Here are a reset management series. - The first patch will be removed as soon

Re: [PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 6:57 PM, Cousson, Benoit wrote: Hi Paul, Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6 hwmod_hardreset_dev If you are OK with these, I'll

Re: [PATCH] OMAP: hwmod: Fix softreset for modules with optional clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 7:07 PM, Paul Walmsley wrote: Hi Benoit, one minor comment here - On Tue, 21 Sep 2010, Benoit Cousson wrote: Some modules (like GPIO, DSS...) require optionals clock to be enabled in order to complete the sofreset properly. Add a HWMOD_CONTROL_OPT_CLKS_IN_RESET flag to force all

Re: [PATCH] OMAP: hwmod: softreset fixes with opt clocks

2010-09-21 Thread Cousson, Benoit
On 9/21/2010 7:05 PM, Paul Walmsley wrote: Hi Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: Here are some fixes for the softreset issues that were highlighted on some IPs like GPIO or DSS. For the moment they are still based on your previous series: git://git.pwsan.com/linux-2.6

Re: [PATCH v7 4/6] OMAP4: hwmod data: Add watchdog timer

2010-09-21 Thread Cousson, Benoit
Hi Charu, On 9/21/2010 3:37 PM, Varadarajan, Charulatha wrote: From: Benoit Coussonb-cous...@ti.com Add watchdog timer hwmod data for OMAP4 chip Signed-off-by: Benoit Coussonb-cous...@ti.com Signed-off-by: Charulatha Vch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 135

Re: [PATCH] OMAP4: clock: Add optional clock nodes

2010-09-22 Thread Cousson, Benoit
Hi Paul, On 9/22/2010 9:29 AM, Paul Walmsley wrote: Hi Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: OMAP4 IP optional clocks require explicit enable in module CTRLCLK register. In order to allow that we have to create artificial clock nodes that represent this clock inputs in the IP.

Re: [PATCH] OMAP4: clock: Fix missing optional clocks

2010-09-22 Thread Cousson, Benoit
On 9/22/2010 9:25 AM, Paul Walmsley wrote: Hi Benoît, On Tue, 21 Sep 2010, Benoit Cousson wrote: Please note that the diff is pretty bad for the clock table. It looks like everything has changed. I don't know if there is a way to have a better diff with git. It's due to an extra tab that

Re: Branch with the recent OMAP4 clock and PRCM patches for testing

2010-09-22 Thread Cousson, Benoit
Hi Paul, On 9/22/2010 9:37 AM, Paul Walmsley wrote: Hi Rajendra, Benoît, in case it is useful, here is a branch based on v2.6.36-rc5 with the hwmod fixes included, and the OMAP4 clock/PRCM patches that we've discussed today: git://git.pwsan.com/linux-2.6 omap4_2.6.37 Tomorrow, I will

Re: [PATCH 1/5] OMAP4: PM: Update PRCM register bitshits and masks for ES2

2010-09-22 Thread Cousson, Benoit
On 9/22/2010 8:43 AM, Nayak, Rajendra wrote: From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Wednesday, September 22, 2010 11:47 AM Hi Rajendra On Thu, 16 Sep 2010, Rajendra Nayak wrote: This patch updates the PRM and CM register bitshifts and masks for OMAP4430 ES2.0. Signed-off-by:

Re: [PATCH 7/9 v3] OMAP: Hwmod api changes

2010-09-22 Thread Cousson, Benoit
Hi Hema, On 9/23/2010 2:30 AM, Kalliguddi, Hema wrote: OMAP USBOTG modules has a requirement to set the auto idle bit only after setting smart idle bit. Modified the _sys_enable api to set the smart idle first and then the autoidle bit. Setting this will not have any impact on the other

Re: [PATCH 4/9 v3] usb: musb: HWMOD database structures addition for OMAP4

2010-09-22 Thread Cousson, Benoit
On 9/23/2010 2:28 AM, Kalliguddi, Hema wrote: From: Cousson, Benoitb-cous...@ti.com OMAP4 hwmod data stuctures are populated with base address, L3 and L4 typo: structures interface clocks, IRQs,and sysconfig register details. missing space after comma. Signed-off-by: Cousson,

Re: [PATCHv3 8/17] dmtimer: register mappings moved to hwmod database

2010-09-23 Thread Cousson, Benoit
On 9/23/2010 11:34 AM, Basak, Partha wrote: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 23, 2010 3:10 AM G, Manjunath Kondaiahmanj...@ti.com writes: Hi Tarun, From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf

Re: [PATCH] OMAP4: PM: Declare idle modules as functional too

2010-09-24 Thread Cousson, Benoit
On 9/24/2010 9:28 AM, Paul Walmsley wrote: Hi Rajendra, Partha, Benoît, On Fri, 24 Sep 2010, Rajendra Nayak wrote: The omap4_cm_wait_module_ready function would only check for the modules to be completely functional before declaring them ready to be accessed. There might also be instances

Re: [RFC 4/5] OMAP4: mux: Select CBL package for SDP4430 with ES1

2010-09-27 Thread Cousson, Benoit
On 9/25/2010 1:14 AM, Anand Gadiyar wrote: Benoit Cousson wrote: Signed-off-by: Benoit Coussonb-cous...@ti.com Cc: Tony Lindgrent...@atomide.com Cc: Paul Walmsleyp...@pwsan.com Cc: Kevin Hilmankhil...@deeprootsystems.com --- arch/arm/mach-omap2/Kconfig |1 +

Re: [RFC 3/5] OMAP4: mux: Add data for OMAP4430 ES1

2010-09-27 Thread Cousson, Benoit
On 9/25/2010 1:18 AM, Gadiyar, Anand wrote: diff --git a/arch/arm/mach-omap2/mux44xx.c b/arch/arm/mach-omap2/mux44xx.c new file mode 100644 index 000..839a905 --- /dev/null +++ b/arch/arm/mach-omap2/mux44xx.c @@ -0,0 +1,944 @@ +\ Stray change? Yes, indeed. Thanks, Benoit -- To

Re: [RFC 1/5] OMAP: mux: Add support for control module split in several partitions

2010-09-27 Thread Cousson, Benoit
Hi Tony, On 9/27/2010 5:46 PM, Tony Lindgren wrote: * Tony Lindgrent...@atomide.com [100924 17:14]: * Benoit Coussonb-cous...@ti.com [100924 02:07]: If we wanted to use only the offset in the data, we could initialize the various sections separately. But then omapX_mux_init() would have to

Re: [RFC 1/5] OMAP: mux: Add support for control module split in several partitions

2010-09-27 Thread Cousson, Benoit
On 9/27/2010 7:36 PM, Tony Lindgren wrote: * Cousson, Benoitb-cous...@ti.com [100927 10:15]: OK for that one, that will save the extra id to store the partition in each static data, but then you will still have to store it during the init? For mux.c internal data, we can have an array of

Re: [PATCH 05/13] OMAP: Introduce device specific set rate and get rate in device opp structures.

2010-09-29 Thread Cousson, Benoit
Hi Thara, On 9/29/2010 1:16 PM, Gopinath, Thara wrote: -Original Message- From: Cousson, Benoit Sent: Saturday, September 18, 2010 3:43 PM To: Gopinath, Thara Cc: Kevin Hilman; Paul Walmsley; linux-omap@vger.kernel.org; Sripathy, Vishwanath; Sawant, Anand Subject: Re: [PATCH 05/13

Re: [PATCH] OMAP4: Extend clock data.

2010-09-30 Thread Cousson, Benoit
Hi Thara, On 9/30/2010 10:57 AM, Paul Walmsley wrote: Hello Thara, On Thu, 30 Sep 2010, Thara Gopinath wrote: This patch extends the OMAP4 clock data to include various x2 clock nodes as the clock framework skips a *2 whie calculating the dpll locked frequency. Signed-off-by: Thara

Re: [PATCH] OMAP4: Extend clock data.

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 11:16 AM, Cousson, Benoit wrote: Hi Thara, On 9/30/2010 10:57 AM, Paul Walmsley wrote: Hello Thara, On Thu, 30 Sep 2010, Thara Gopinath wrote: This patch extends the OMAP4 clock data to include various x2 clock nodes as the clock framework skips a *2 whie calculating the dpll

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 3:55 PM, Kevin Hilman wrote: Cousson, Benoitb-cous...@ti.com writes: Hi Charu, On 9/30/2010 10:11 AM, Varadarajan, Charulatha wrote: With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 6:32 PM, Varadarajan, Charulatha wrote: Benoit, snip With OMAP2PLUS watchdog implemented in hwmod fw way, the module is reset during init. In that case hwmod fw just highlighted the real behavior that was hidden so far by the X-loader. Yes. You should as well add a link to

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-09-30 Thread Cousson, Benoit
On 9/30/2010 5:55 PM, Varadarajan, Charulatha wrote: Tony/ Benoit, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch description, this patch does a disable of

Re: [PATCHv3 0/17] OMAP dmtimer hwmod

2010-09-30 Thread Cousson, Benoit
Hi Tarun, On 9/21/2010 10:50 AM, Tarun Kanti DebBarma wrote: This patch series implements dmtimer hwmod. Maybe the description should be a little bit more detailed: Something like Adapt dmtimer code to platform_driver using omap_device / omap_hwmod abstraction Benoit Version 3 *

Re: [PATCHv3 1/17] OMAP2/3/4:dmtimer:add device names to flck nodes

2010-09-30 Thread Cousson, Benoit
On 9/21/2010 10:51 AM, DebBarma, Tarun Kanti wrote: From: Thara Gopinathth...@ti.com This patch adds device name info to OMAP2 dmtimer fclk nodes so You should avoid using that patch in a changelog, since we already know it is a patch. You can read 4.c in The perfect patch from Andrew

Re: [PATCHv3 2/17] dmtimer: infrastructure to support hwmod

2010-09-30 Thread Cousson, Benoit
On 9/21/2010 10:51 AM, DebBarma, Tarun Kanti wrote: This patch introduces data structures and new fields on existing data structures to support dmtimer conversion to platform driver and support hwmod database for the diferent OMAP platforms. Signed-off-by: Tarun Kanti DebBarmatarun.ka...@ti.com

Re: [PATCHv3 3/17] dmtimer: add omap2420 hwmod database

2010-09-30 Thread Cousson, Benoit
On 9/21/2010 10:51 AM, DebBarma, Tarun Kanti wrote: From: Thara Gopinathth...@ti.com This patch adds hwmod database for OMAP2420. Same comment: no patch in a a patch changelog... In the hwmod class definition .rev field is initialized with timer ip version to distinguish the timers in

Re: [PATCHv3 4/17] dmtimer: add omap2430 hwmod database

2010-09-30 Thread Cousson, Benoit
All the comments of the previous patch are applicable here too. + a new one that I forgot in previous patches... On 9/21/2010 10:52 AM, DebBarma, Tarun Kanti wrote: From: Thara Gopinathth...@ti.com This patch adds hwmod database for OMAP2430. In the hwmod class definition .rev field is

Re: [PATCHv3 5/17] dmtimer: add omap3xxx hwmod database

2010-09-30 Thread Cousson, Benoit
All the comments of the previous patch are applicable here too. + some more... On 9/21/2010 10:52 AM, DebBarma, Tarun Kanti wrote: From: Thara Gopinathth...@ti.com This patch adds hwmod database for OMAP3xxx. In the hwmod class definition .rev field is initialized with timer ip version to

Re: [PATCHv3 6/17] dmtimer: add omap44xx hwmod database

2010-09-30 Thread Cousson, Benoit
All the comments of the previous patch are applicable here too. + some more... On 9/21/2010 10:53 AM, DebBarma, Tarun Kanti wrote: From: Thara Gopinathth...@ti.com I wrote the original patch for the OMAP4 hwmod data, so I should still be the author. You should add as well a reference to the

Re: [PATCHv3 11/17] dmtimer: early boot infrastructure

2010-09-30 Thread Cousson, Benoit
On 9/21/2010 10:54 AM, DebBarma, Tarun Kanti wrote: During dmtimer early init, when device model is not up yet and dmtimer devices are not yet registered, the initialization routine is unable to read clock sources supported by the dmtimers using clk_get() because it searches the list using

RE: [PATCHv3 1/17] OMAP2/3/4:dmtimer:add device names to flck nodes

2010-10-01 Thread Cousson, Benoit
Hi Charu, From: Varadarajan, Charulatha Sent: Friday, October 01, 2010 7:27 AM Benoit, This patch adds device name info to OMAP2 dmtimer fclk nodes so You should avoid using that patch in a changelog, since we already know it is a patch. You can read 4.c in The perfect patch from

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-01 Thread Cousson, Benoit
On 10/1/2010 3:28 PM, Nayak, Rajendra wrote: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 30, 2010 9:37 PM To: Tony Lindgren; Nayak, Rajendra Cc: linux-omap@vger.kernel.org; Varadarajan, Charulatha; Raja, Govindraj Subject: Re:

Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

2010-10-01 Thread Cousson, Benoit
On 10/1/2010 4:43 PM, Kevin Hilman wrote: Varadarajan, Charulathach...@ti.com writes: Tony, Benoit, Kevin, I think that disabling it should be done only if the CONFIG_OMAP_WDT is not set. How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT is set? As given in the patch

Re: Dropping omap3430 ES1.0 support in mainline

2010-10-04 Thread Cousson, Benoit
On 10/2/2010 12:28 AM, Anand Gadiyar wrote: Paul Walmsley wrote: On Sat, 2 Oct 2010, Anand Gadiyar wrote: Okay, so we're aligned that you guys don't have an ES1 board to test, and TI doesn't have any either. :) I'd still like to know if anyone in the wild still cares about the board. (I

Re: [PATCHv3 3/17] dmtimer: add omap2420 hwmod database

2010-10-04 Thread Cousson, Benoit
Hi Paul, On 10/2/2010 12:25 AM, Paul Walmsley wrote: On Thu, 30 Sep 2010, Cousson, Benoit wrote: On 9/21/2010 10:51 AM, DebBarma, Tarun Kanti wrote: #include omap_hwmod_common_data.h #include prm-regbits-24xx.h @@ -121,6 +123,614 @@ static struct omap_hwmod omap2420_l4_wkup_hwmod

Re: [PATCH 08/10] OMAP: split plat-omap/common.c

2010-10-04 Thread Cousson, Benoit
Hi Paul, On 10/1/2010 11:35 PM, Paul Walmsley wrote: Split plat-omap/common.c into three pieces: 1. the 32KiHz sync timer and clocksource code, which now lives in plat-omap/32ksynctimer.c; 2. the OMAP2+ common code, which has been moved to mach-omap2/common.c; 3. and the remainder of the

Re: [PATCH 08/10] OMAP: split plat-omap/common.c

2010-10-04 Thread Cousson, Benoit
Hi Tarun, On 10/4/2010 11:35 AM, DebBarma, Tarun Kanti wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Cousson, Benoit Sent: Monday, October 04, 2010 2:39 PM To: Paul Walmsley Cc: linux-omap@vger.kernel.org

Re: [PATCHv3 17/17] dmtimer: remove OCP config code from plat-omap

2010-10-04 Thread Cousson, Benoit
On 9/21/2010 10:56 AM, DebBarma, Tarun Kanti wrote: This patch removes the ocp config code from omap-plat because they are supposed to be taken care of by the hwmod framework. Specifically, following changes are incorporated: (1) setting of smart-idle and wakeup-enable is already taken care in

Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c

2010-10-05 Thread Cousson, Benoit
Hi Paul, On 10/5/2010 8:01 AM, Paul Walmsley wrote: Hello Benoît, Rajendra, Kevin, On Fri, 1 Oct 2010, Cousson, Benoit wrote: The issue is that 2420 idlest does not reflect the real status of the OCP bus clock, but just the fact that the idle_req is asserted or not. So potentially, the IP

Re: [PATCH 3/7] [RFC] OMAP: MCBSP: hwmod database for 4xxx devices

2010-10-06 Thread Cousson, Benoit
Hi Kishon, On 10/5/2010 6:37 PM, ABRAHAM, KISHON VIJAY wrote: From: Benoit Coussonb-cous...@ti.com MCBSP hwmod data values are auto-generated. The order of omap44xx_mcbsp3_slaves contents are changed since the driver uses the base address of omap44xx_l4_abe__mcbsp3_dma. You should not do

Re: [PATCH 4/7] [RFC] OMAP: hwmod implementation for MCBSP

2010-10-06 Thread Cousson, Benoit
On 10/5/2010 6:37 PM, Kishon Vijay Abraham I wrote: Signed-off-by: Kishon Vijay Abraham Ikis...@ti.com Signed-off-by: Charulatha Vch...@ti.com Signed-off-by: Shubhrajyoti Dshubhrajy...@ti.com Cc: Partha Basakp-bas...@ti.com --- arch/arm/mach-omap2/mcbsp.c | 251

Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver

2010-10-07 Thread Cousson, Benoit
Hi Senthil, On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote: From: Premi, Sanjeev Sent: Wednesday, October 06, 2010 7:49 PM To: Guruswamy, Senthilvadivu; khil...@deeprootsystems.com; tomi.valkei...@nokia.com; p...@pwsan.com; Hiremath, Vaibhav; linux- o...@vger.kernel.org Subject: RE:

Re: [PATCH v1 12/16] OMAP3: hwmod DSS: DISPC Move init,exit to driver

2010-10-07 Thread Cousson, Benoit
On 10/7/2010 10:44 AM, Guruswamy, Senthilvadivu wrote: From: Cousson, Benoit Sent: Thursday, October 07, 2010 12:47 PM Hi Senthil, On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote: From: Premi, Sanjeev From: linux-omap-ow...@vger.kernel.org From: Senthilvadivu Guruswamysvad

Re: [PATCH 1/7] [RFC] OMAP: MCBSP: hwmod database for 2xxx devices

2010-10-08 Thread Cousson, Benoit
Hi Charu, On 10/8/2010 8:20 AM, Varadarajan, Charulatha wrote: From: Peter Ujfalusi [mailto:peter.ujfal...@nokia.com] Sent: Wednesday, October 06, 2010 12:47 PM To: Varadarajan, Charulatha Cc: linux-omap@vger.kernel.org; alsa-de...@alsa-project.org; Kamat, Nishant; Datta, Shubhrajyoti;

Re: [PATCH 6/7] [RFC] OMAP: hwmod: SYSCONFIG register modification for MCBSP

2010-10-08 Thread Cousson, Benoit
Hi Kishon, On 10/5/2010 6:37 PM, ABRAHAM, KISHON VIJAY wrote: MCBSP 2 and 3 in OMAP3 has sidetone feature which requires autoidle to be disabled before starting the sidetone. Also SYSCONFIG register has to be set with smart idle or no idle depending on the dma op mode (threshold or element

Re: [PATCHv3 17/17] dmtimer: remove OCP config code from plat-omap

2010-10-11 Thread Cousson, Benoit
On 10/11/2010 11:41 AM, DebBarma, Tarun Kanti wrote: ... In summary, I will make following updates: .clockact = 0x2 SYSC_HAS_CLOCKACTIVITY flag should be included. After going through the code I realized that this flag is already there. I am not sure where you observed this flag missing?

  1   2   3   4   5   6   7   8   9   10   >