Re: [PATCH] spi: spi-omap2-mcspi.c: Add dts for slave device configuration.

2013-05-14 Thread Illia Smyrnov
@@ -745,6 +781,11 @@ static int omap2_mcspi_setup_transfer(struct spi_device *spi, mcspi = spi_master_get_devdata(spi-master); spi_cntrl = mcspi-master; + if (!cd spi-dev.of_node) { + cd = omap2_mcspi_get_slave_ctrldata(spi); +

[PATCH v2 0/2] spi: omap2-mcspi: add FIFO buffer support

2013-06-11 Thread Illia Smyrnov
set. Illia Smyrnov (2): spi: omap2-mcspi: Move bytes per word calculation to the function spi: omap2-mcspi: Add FIFO buffer support Documentation/devicetree/bindings/spi/omap-spi.txt |8 + drivers/spi/spi-omap2-mcspi.c | 173 +--- 2 files changed

[PATCH v2 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-11 Thread Illia Smyrnov
. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Documentation/devicetree/bindings/spi/omap-spi.txt |8 + drivers/spi/spi-omap2-mcspi.c | 154 +-- 2 files changed, 145 insertions(+), 17 deletions(-) diff --git a/Documentation/devicetree/bindings/spi/omap

[PATCH v2 1/2] spi: omap2-mcspi: Move bytes per word calculation to the function

2013-06-11 Thread Illia Smyrnov
it with inline function with clear name to improve code legibility. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/spi/spi-omap2-mcspi.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2

[PATCH v3 0/2] spi: omap2-mcspi: add FIFO buffer support

2013-06-14 Thread Illia Smyrnov
transfer; * ti,spi-fifo-enabled parameter in MCSPI DT node to enable FIFO; * no FIFO settings in SPI slaves nodes in DT; * Matthias Brugger patch was excluded from patch set. Illia Smyrnov (2): spi: omap2-mcspi: Move bytes per word calculation to the function spi: omap2-mcspi: Add FIFO buffer

[PATCH v3 1/2] spi: omap2-mcspi: Move bytes per word calculation to the function

2013-06-14 Thread Illia Smyrnov
it with inline function with clear name to improve code legibility. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/spi/spi-omap2-mcspi.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2

[PATCH v3 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-14 Thread Illia Smyrnov
be used for the SPI transfers in DMA mode if: calculated FIFO buffer size is less then 2 bytes or the FIFO buffer size isn't multiple of the SPI word length. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/spi/spi-omap2-mcspi.c | 147 - 1

Re: [PATCH v2 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-14 Thread Illia Smyrnov
On 06/12/2013 06:47 PM, Mark Brown wrote: On Tue, Jun 11, 2013 at 08:09:15PM +0300, Illia Smyrnov wrote: The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt handler and improve data throughput. This patch adds FIFO buffer support for SPI transfers in DMA mode

[PATCH v4] spi: omap2-mcspi: Add FIFO buffer support

2013-06-17 Thread Illia Smyrnov
be used for the SPI transfers in DMA mode if: calculated FIFO buffer size is less then 2 bytes or the FIFO buffer size isn't multiple of the SPI word length. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- v4: * rebased on topic/omap branch drivers/spi/spi-omap2-mcspi.c | 147

Re: [PATCH v3 2/2] spi: omap2-mcspi: Add FIFO buffer support

2013-06-17 Thread Illia Smyrnov
On 06/17/2013 12:16 PM, Mark Brown wrote: On Fri, Jun 14, 2013 at 07:12:08PM +0300, Illia Smyrnov wrote: The MCSPI controller has a built-in FIFO buffer to unload the DMA or interrupt handler and improve data throughput. This patch adds FIFO buffer support for SPI transfers in DMA mode

[PATCH 0/2] Input: omap-keypad: Cleanup - remove hardcoded values and IRQ enabling/disabling

2013-07-19 Thread Illia Smyrnov
From: Illia Smyrnov illia.smyr...@ti.com Replace unclear hardcoded values with bit field and remove unnecessary IRQ enabling/disabling. Based on top of v3.10-rc1. Tested on OMAP4 SDP. Illia Smyrnov (2): Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values Input: omap

[PATCH 2/2] Input: omap-keypad: Cleanup - remove unnecessary IRQ enabling/disabling

2013-07-19 Thread Illia Smyrnov
From: Illia Smyrnov illia.smyr...@ti.com Remove unnecessary IRQ enabling/disabling for certain keyboard events. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 15 --- 1 files changed, 4 insertions(+), 11 deletions(-) diff --git

[PATCH 1/2] Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values

2013-07-19 Thread Illia Smyrnov
From: Illia Smyrnov illia.smyr...@ti.com Use bitfiled instead of hardcoded values to set KBD_CTRL, use BIT macro, remove unused defines. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 25 +++-- 1 files changed, 11 insertions

Re: [PATCH 0/2] Input: omap-keypad: Cleanup - remove hardcoded values and IRQ enabling/disabling

2013-07-19 Thread Illia Smyrnov
On 07/19/2013 04:03 PM, Illia Smyrnov wrote: From: Illia Smyrnov illia.smyr...@ti.com Replace unclear hardcoded values with bit field and remove unnecessary IRQ enabling/disabling. Based on top of v3.10-rc1. Sorry, it is typo here. Based on v3.11-rc1. Tested on OMAP4 SDP. Illia Smyrnov

Re: [PATCH 2/2] Input: omap-keypad: Cleanup - remove unnecessary IRQ enabling/disabling

2013-07-22 Thread Illia Smyrnov
Hi, On 07/19/2013 04:26 PM, Felipe Balbi wrote: Hi, [...] please don't remove this code. It'll be good to have this around when we move the driver to threaded IRQs without IRQF_ONESHOT. In fact, it would be very simple to implement such a change, wanna take it up ? It should be doable in few

[PATCH v2 0/3] Input: omap-keypad: Convert to threaded IRQ and cleanup

2013-07-23 Thread Illia Smyrnov
Replace unclear hardcoded values with bit field, convert to threaded IRQ and clear pending interrupts when open the keypad. Based on top of v3.11-rc2. Tested on OMAP4 SDP. Illia Smyrnov (3): Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values Input: omap-keypad

[PATCH v2 3/3] Input: omap-keypad: Clear pending interrupts on open

2013-07-23 Thread Illia Smyrnov
Clear pending interrupts when open keypad. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index

[PATCH v2 2/3] Input: omap-keypad: Convert to threaded IRQ

2013-07-23 Thread Illia Smyrnov
Convert to use threaded IRQ. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b

[PATCH v2 1/3] Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values

2013-07-23 Thread Illia Smyrnov
Use bitfiled instead of hardcoded values to set KBD_CTRL, use BIT macro, remove unused defines. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH v3 1/3] Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values

2013-07-24 Thread Illia Smyrnov
Use bitfiled instead of hardcoded values to set KBD_CTRL, use BIT macro, remove unused defines. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 25 +++-- 1 files changed, 11 insertions

[PATCH v3 0/3] Input: omap-keypad: Convert to threaded IRQ and cleanup

2013-07-24 Thread Illia Smyrnov
Replace unclear hardcoded values with bit field, convert to threaded IRQ and clear interrupts when open the keypad. Based on top of v3.11-rc2. Tested on OMAP4 SDP. Illia Smyrnov (3): Input: omap-keypad: Cleanup - use bitfiled instead of hardcoded values Input: omap-keypad: Convert

[PATCH v3 3/3] Input: omap-keypad: Clear interrupts on open

2013-07-24 Thread Illia Smyrnov
request. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index b876a0d..0244262 100644 --- a/drivers

[PATCH v3 2/3] Input: omap-keypad: Convert to threaded IRQ

2013-07-24 Thread Illia Smyrnov
Convert to use threaded IRQ. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git

[PATCH 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-07-26 Thread Illia Smyrnov
://patchwork.kernel.org/patch/2832913/ Axel Haslam (2): Input: omap-keypad: errata i689: Correct debounce time Input: omap-keypad: Set irq to level instead of edge Illia Smyrnov (1): Input: omap-keypad: Enable wakeup capability for keypad. drivers/input/keyboard/omap4-keypad.c | 50

[PATCH 2/3] Input: omap-keypad: errata i689: Correct debounce time

2013-07-26 Thread Illia Smyrnov
the appropriate actions. Silicon revisions impacted: OMAP4430 ES 1.0,2.0,2.1,2.2,2.3 OMAP4460 ES 1.0,1.1 OMAP5430 ES 1.0 Signed-off-by: Axel Haslam axelhas...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc2

[PATCH 3/3] Input: omap-keypad: Set irq to level instead of edge

2013-07-26 Thread Illia Smyrnov
From: Axel Haslam axelhas...@ti.com Set mpu irq to level instead of edge, since if mpu is in low power an edge detection may be lost if the event is a wkup event. Signed-off-by: Axel Haslam axelhas...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc2

[PATCH 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-26 Thread Illia Smyrnov
Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/input/keyboard/omap4

Re: [PATCH 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-26 Thread Illia Smyrnov
Sorry, this patch is incomplete and was sent by mistake. I will sent v2 On 07/26/2013 07:29 PM, Illia Smyrnov wrote: Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4

[PATCH v2 3/3] Input: omap-keypad: Set irq to level instead of edge

2013-07-26 Thread Illia Smyrnov
From: Axel Haslam axelhas...@ti.com Set mpu irq to level instead of edge, since if mpu is in low power an edge detection may be lost if the event is a wkup event. Signed-off-by: Axel Haslam axelhas...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc2

[PATCH v2 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-07-26 Thread Illia Smyrnov
://patchwork.kernel.org/patch/2832913/ Axel Haslam (2): Input: omap-keypad: errata i689: Correct debounce time Input: omap-keypad: Set irq to level instead of edge Illia Smyrnov (1): Input: omap-keypad: Enable wakeup capability for keypad. drivers/input/keyboard/omap4-keypad.c | 55

[PATCH v2 2/3] Input: omap-keypad: errata i689: Correct debounce time

2013-07-26 Thread Illia Smyrnov
the appropriate actions. Silicon revisions impacted: OMAP4430 ES 1.0,2.0,2.1,2.2,2.3 OMAP4460 ES 1.0,1.1 OMAP5430 ES 1.0 Signed-off-by: Axel Haslam axelhas...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc2

[PATCH v2 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-26 Thread Illia Smyrnov
Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 43 + 1 file changed, 43 insertions(+) diff --git a/drivers/input/keyboard/omap4

[PATCH v3 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-07-29 Thread Illia Smyrnov
://patchwork.kernel.org/patch/2832913/ Axel Haslam (1): Input: omap-keypad: errata i689: Correct debounce time Illia Smyrnov (2): Input: omap-keypad: Enable wakeup capability for keypad. Input: omap-keypad: Setup irq type from DT drivers/input/keyboard/omap4-keypad.c | 52

[PATCH v3 3/3] Input: omap-keypad: Setup irq type from DT

2013-07-29 Thread Illia Smyrnov
OMAP4 is DT only, so read the keypad IRQ type from DT instead hardcoding it in driver. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc3 Depends on: Input: omap-keypad: Convert to threaded IRQ https://patchwork.kernel.org/patch

[PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Illia Smyrnov
Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 43 + 1 file changed, 43 insertions(+) diff --git a/drivers/input/keyboard/omap4

[PATCH v3 2/3] Input: omap-keypad: errata i689: Correct debounce time

2013-07-29 Thread Illia Smyrnov
the appropriate actions. Silicon revisions impacted: OMAP4430 ES 1.0,2.0,2.1,2.2,2.3 OMAP4460 ES 1.0,1.1 OMAP5430 ES 1.0 Signed-off-by: Axel Haslam axelhas...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- Based on top of v3.11-rc3

Re: [PATCH v3 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-08-27 Thread Illia Smyrnov
debounce time Thanks. On 07/29/2013 07:45 PM, Illia Smyrnov wrote: This patchset adds wake up capability for the keypad and workaround for i689 errata. Based on top of v3.11-rc3 Depends on: Input: omap-keypad: Convert to threaded IRQ https://patchwork.kernel.org/patch/2832920/ Input: omap-keypad

[PATCH] spi: omap2-mcspi: Fix FIFO support for transmit-and-receive mode

2013-10-09 Thread Illia Smyrnov
both AEL and AFL need to be set in CHCONF0 register. Signed-off-by: Illia Smyrnov illia.smyr...@globallogic.com --- drivers/spi/spi-omap2-mcspi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index

[PATCH] ARM: OMAP4: hwmod: Fix SOFTRESET logic for OMAP4

2014-02-05 Thread Illia Smyrnov
is successfully finished. Signed-off-by: Illia Smyrnov illia.smyr...@globallogic.com --- arch/arm/mach-omap2/omap_hwmod.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 42d8188..1f33f5d