Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Jean Pihet
To: Jean Pihet Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR -Original Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Tuesday, February 01, 2011 4:53 PM To: Santosh Shilimkar Cc: linux-omap

Re: [linux-pm] [PATCH] PM: export suspend_set_ops, suspend_valid_only_mem

2011-05-30 Thread Jean Pihet
is not loaded and the user attempts to suspend? In that case suspend_ops is NULL and suspending has no effect (pm_suspend returns -ENODEV). Note that this also happens after the module unload. Is that the expected behavior? Rafael Regards, Jean Reported-by: Jean Pihet j-pi...@ti.com Signed

Re: [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature

2011-05-30 Thread Jean Pihet
code as well. Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Agree! Acked-by: Jean Pihet j-pi...@ti.com Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at  http

Re: [PATCH/RFC 2/4] OMAP2: PM debug: remove register dumping

2011-05-30 Thread Jean Pihet
changed, 2 insertions(+), 127 deletions(-) ... OK for this change. Is it the intention to use the omapconf tool as the replacement for the regs dump code? Acked-by: Jean Pihet j-pi...@ti.com Regards, Jean -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH/RFC 3/4] OMAP3: PM debug: remove register dumping

2011-05-30 Thread Jean Pihet
+ - userspace /dev/mem-based tools (like omapconf) can do this much better Fully agree and indeed it doesn't scale for OMAP4. Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Ok. Same comment about the use of omaconf as a debug/investigation tool. Acked-by: Jean Pihet j-pi...@ti.com

Re: [PATCH/RFC 4/4] OMAP2: PM debug: move wakeup timer into clockevent code

2011-05-30 Thread Jean Pihet
are eventually converted to be a driver, the wakeup timer feature can be made to be a driver-specific feature using the driver's suspend method. Excellent idea and patch. Never crossed my mind that we could have used CLOCK_EVT_MODE_SHUTDOWN instead of our long old hack. Great! Acked-by: Jean

Re: [PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups

2011-05-27 Thread Jean Pihet
On Fri, May 27, 2011 at 1:02 AM, Kevin Hilman khil...@ti.com wrote: Inspired by Jean's work to move PM code to modules, I decided it's time to remove a bunch of ugly and difficult to maintain code from PM debug. Indeed this code is a spaghetti mess and makes pm-debug difficult to be

Re: [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature

2011-05-27 Thread Jean Pihet
On Fri, May 27, 2011 at 1:02 AM, Kevin Hilman khil...@ti.com wrote: Remove the OMAP-specific PM debug 'sleep_while_idle' feature which is currently available as an OMAP-specific debugfs entry. This duplicates existing ARM-generic functionality available as a boot-time option using the boot

Re: [PATCH 08/13] OMAP2+: PM: provide the next timer event API to PM modules

2011-05-27 Thread Jean Pihet
On Fri, May 27, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Provide omap_pm_tick_nohz_get_sleep_length_us so that the code from the OMAP PM modules can use it. Signed-off-by: Jean Pihet j-pi...@ti.com This patch

Re: [PATCH 09/13] OMAP2+: PM: export suspend_set_ops to PM modules

2011-05-27 Thread Jean Pihet
On Fri, May 27, 2011 at 1:09 AM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Export the suspend_set_ops API as omap_pm_suspend_set_ops in the pm generic code, under CONFIG_SUSPEND. Note -hack warning-: since

Re: [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature

2011-05-27 Thread Jean Pihet
On Fri, May 27, 2011 at 5:26 PM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: On Fri, May 27, 2011 at 1:02 AM, Kevin Hilman khil...@ti.com wrote: Remove the OMAP-specific PM debug 'sleep_while_idle' feature which is currently available as an OMAP-specific

Re: [PATCH 10/13] OMAP3: PM: export the v7_flush_dcache_all API to modules

2011-05-25 Thread Jean Pihet
Hi Santosh, On Thu, May 19, 2011 at 10:04 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: On 5/18/2011 11:02 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihetj-pi...@ti.com Provide the the assembly function v7_flush_dcache_all to the OMAP3 PM module, under CONFIG_CPU_V7.

Re: [PATCH 08/13] OMAP2+: PM: provide the next timer event API to PM modules

2011-05-19 Thread Jean Pihet
Hi Santosh, On Thu, May 19, 2011 at 9:59 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Jean, On 5/18/2011 11:02 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihetj-pi...@ti.com Provide omap_pm_tick_nohz_get_sleep_length_us so that the code from the OMAP PM modules can use it.

[RFC/PATCH 00/13] OMAP2+: PM: isolate PM code in modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com First attempt at isolation of the OMAP2+ PM code RFC quality code but successfully tested on board as a proof of concept 1) provide PM functionality as modules To allow for the PM functionality to be built and used as modules a clean-up and isolation task first

[PATCH 01/13] perf: export power_start and power_end tracepoints

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com If used in a module both tracepoints need to be exported by the kernel. Fixed a typo in CONFIG_EVENT_POWER_TRACING_DEPRECATED to really export the tracepoints. Signed-off-by: Jean Pihet j-pi...@ti.com Acked-by: Ingo Molnar mi...@elte.hu Cc: Thomas Renninger tr

[PATCH 02/13] OMAP2+: PM: isolate PM code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Isolate the PM code under CONFIG_PM. This includes the following: - core PM, - powerdomain, - clockdomain, - smartreflex, - voltagedomain, - OPP. This cleans up the PM code in order to allow it to be built as a module. Signed-off-by: Jean Pihet j-pi...@ti.com

[PATCH 03/13] OMAP2+: PM: clean up usage of SRAM functions

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Clean-up SRAM functions usage to better isolate PM code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm34xx.c |1 + arch/arm/plat-omap/sram.c|2 -- 2 files changed, 1 insertions(+), 2

[PATCH 04/13] OMAP2+: cpuidle: register the board specific C-states table

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Register the board specific cpuidle C-states table for the cpuidle driver to use it later at cpuidle init time. This also cleans up the cpuidle code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2

[PATCH 06/13] OMAP2+: PM: isolate the scratchpad save function from the PM code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com This patch provides the omap3_save_scratchpad_contents function as a service from the common control code. The PM code calls the service to store the appropriate data in the scratchpad area, including the restore pointer from OFF/OSWR modes and the secure RAM

[PATCH 07/13] OMAP2+: PM: move the powerdomains time stats to powerdomain code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Move the powerdomains time accounting code from in pm-debug to the powerdomain code. The pm-debug code only displays the information on request. This also cleans up the core PM code, in order to allow it to be used as a module. Signed-off-by: Jean Pihet j-pi

[PATCH 05/13] OMAP2+: PM: move common code from pm-debug.c to pm.c

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Move variables and functions that are by the arch code to the common pm.c code. Moved: . PM knobs variables: - enable_off_mode - omap2_pm_debug - sleep_while_idle - wakeup_timer_seconds - wakeup_timer_milliseconds . omap2_pm_wakeup_on_timer function

[PATCH 08/13] OMAP2+: PM: provide the next timer event API to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provide omap_pm_tick_nohz_get_sleep_length_us so that the code from the OMAP PM modules can use it. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm-debug.c |7 --- arch/arm/mach-omap2/pm.c | 15 +++ arch/arm/mach

[PATCH 09/13] OMAP2+: PM: export suspend_set_ops to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Export the suspend_set_ops API as omap_pm_suspend_set_ops in the pm generic code, under CONFIG_SUSPEND. Note -hack warning-: since the 'suspend_valid_only_mem' function is not exported to modules, fill the 'valid' field value of 'struct platform_suspend_ops

[PATCH 10/13] OMAP3: PM: export the v7_flush_dcache_all API to modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Provide the the assembly function v7_flush_dcache_all to the OMAP3 PM module, under CONFIG_CPU_V7. v7_flush_dcache_all is used by the low level sleep code. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm.c |4 arch/arm/mach-omap2/pm.h

[PATCH 12/13] OMAP2+: PM: export functions and variables to PM modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Addition of EXPORT_SYMBOL for functions and variables used by the code in PM modules. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/kernel/setup.c|1 + arch/arm/kernel/smp_tlb.c |2 ++ arch/arm/mach-omap2/clockdomain.c |7

[PATCH 11/13] OMAP2+: PM: implement modules insertion and removal code

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Clean-up of used resources to allow clean insertion and removal of the PM modules. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 14 +- arch/arm/mach-omap2/pm-debug.c| 22 +- arch/arm/mach

[PATCH 13/13] OMAP2+: PM: build PM functionality as modules

2011-05-18 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com A new config option CONFIG_OMAP_PM is defined. This option allows for the whole OMAP2+ PM to completely enabled, disabled or be built as modules. The PM functionality is split into the following modules: - omap_pm_debug - omap2_pm - omap3_pm - omap4_pm

Re: [RFC PATCH v3] Consolidate SRAM support

2011-05-13 Thread Jean Pihet
On Thu, May 12, 2011 at 7:45 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: This version fixes the davinci pm free, and adds updates for the davinci pcm driver. As I don't know what's happening with Jean's patch tweaking the genpool allocator, I've kept my version. Sorry

Re: [RFC PATCH v3] Consolidate SRAM support

2011-05-13 Thread Jean Pihet
On Fri, May 13, 2011 at 11:11 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, May 13, 2011 at 09:30:14AM +0200, Jean Pihet wrote: On Thu, May 12, 2011 at 7:45 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote:    This version fixes the davinci pm free, and adds

Re: [PATCH] perf: export power_start and power_end tracepoints

2011-05-13 Thread Jean Pihet
Adding l-o and linux-pm MLs. The original post is at http://www.spinics.net/lists/kernel/msg1186554.html On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar mi...@elte.hu wrote: * jean.pi...@newoldbits.com jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com If used in a module both

[PATCH v3 0/4] OMAP: cpuidle code clean-up

2011-05-09 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Rework of the OMAP2+ cpuidle code v3: rework after comments on linux-omap ML: - renamed the C-state driver data variables as 'cx', - retain C1 as the only always valid state and safe state, - rework of the C-states definition. v2: rework after comments on linux

[PATCH 1/4] OMAP3: clean-up mach specific cpuidle data structures

2011-05-09 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com - sleep_latency and wake_latency are not used, replace them by exit_latency which is used by cpuidle. exit_latency simply is the sum of sleep_latency and wake_latency, - replace threshold by target_residency, - changed the OMAP3 specific cpuidle code

[PATCH 2/4] OMAP3: cpuidle: re-organize the C-states data

2011-05-09 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The current implementation defines an internal structure and a C-states array. Using those structures is redundant to the structs used by the cpuidle framework. This patch provides a clean-up of the internal struct, removes the internal C-states array, stores

[PATCH 3/4] OMAP3: cpuidle: code rework for improved readability

2011-05-09 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com - fix single and multi-lines comments format - removed the omap3_idle_bm_check function and replaced the test in omap3_enter_idle_bm by the equivalent code - re-organize omap3_enter_idle_bm code path, assign local variables only when needed - reword some

[PATCH 4/4] OMAP3: cpuidle: change the power domains modes determination logic

2011-05-09 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The achievable power modes of the power domains in cpuidle depends on the system wide 'enable_off_mode' knob in debugfs. Upon changing enable_off_mode, do not change the C-states 'valid' field but instead dynamically restrict the power modes when entering idle

[RFC/PATCH] OMAP PM: remove OMAP_PM_NONE config option

2011-05-06 Thread Jean Pihet
The current code base is not linking with the OMAP_PM_NONE option set. Since the option OMAP_PM_NOOP provides a no-op/debug layer, OMAP_PM_NONE can be removed. OMAP_PM_NOOP is enabled by default by Kconfig. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/plat-omap/Kconfig

Re: [RFC/PATCH] OMAP PM: remove OMAP_PM_NONE config option

2011-05-06 Thread Jean Pihet
Please note that this code is based on khilman's for_2.6.40/pm-cleanup branch. Jean On Fri, May 6, 2011 at 11:11 AM, Jean Pihet jean.pi...@newoldbits.com wrote: The current code base is not linking with the OMAP_PM_NONE option set. Since the option OMAP_PM_NOOP provides a no-op/debug layer

Re: [RFC/PATCH] OMAP PM: remove OMAP_PM_NONE config option

2011-05-06 Thread Jean Pihet
Hi Paul, On Fri, May 6, 2011 at 6:16 PM, Paul Walmsley p...@pwsan.com wrote: Salut Jean On Fri, 6 May 2011, Jean Pihet wrote: The current code base is not linking with the OMAP_PM_NONE option set. Since the option OMAP_PM_NOOP provides a no-op/debug layer, OMAP_PM_NONE can be removed

[PATCH v2 0/4] OMAP: cpuidle code clean-up

2011-05-05 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Rework of the OMAP2+ cpuidle code v2: rework after comments on linux-omap ML: - remove useless macros, - replace the C-state common data fill-in helper macro by an inline function, for better readability, - update commits description. v1: - optimize

[PATCH 1/4] OMAP3: clean-up mach specific cpuidle data structures

2011-05-05 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com - sleep_latency and wake_latency are not used, replace them by exit_latency which is used by cpuidle. exit_latency simply is the sum of sleep_latency and wake_latency, - replace threshold by target_residency, - changed the OMAP3 specific cpuidle code

[PATCH 2/4] OMAP3: cpuidle: re-organize the C-states data

2011-05-05 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The current implementation defines an internal structure and a C-states array. Using those structures is redundant to the structs used by the cpuidle framework. This patch provides a clean-up of the internal struct, removes the internal C-states array, stores

[PATCH 3/4] OMAP3: cpuidle: code rework for improved readability

2011-05-05 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com - fix single and multi-lines comments format - removed the omap3_idle_bm_check function and replaced the test in omap3_enter_idle_bm by the equivalent code - re-organize omap3_enter_idle_bm code path, assign local variables only when needed - reword some

[PATCH 4/4] OMAP3: cpuidle: change the power domains modes determination logic

2011-05-05 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The achievable power modes of the power domains in cpuidle depends on the system wide 'enable_off_mode' knob in debugfs. Upon changing enable_off_mode, do not change the C-states 'valid' field but instead dynamically restrict the power modes when entering idle

[PATCH v4 0/8] OMAP: add PM_CONSTRAINTS framework

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating a unified API which calls omap_device_set_dev_constraint for all classes of constraints (devices wake-up latency, devices throughput...). The implementation of the constraints framework

[PATCH 2/8] OMAP2+: powerdomain: control power domains next state

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com When a wake-up latency constraint is requested or removed the omap device layer dispatches the updated strongest constraint value to the corresponding power domain. The power domains get the next power state programmed directly in the registers via

[PATCH 4/8] OMAP2+: omap_hwmod: manage the omap_devices the wake-up latency constraints

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Hwmod is queried from the omap device layer to manage the power domains wake-up latency constraints. Hwmod retrieves the correct power domain and if it exists it calls the corresponding power domain function. Tested on OMAP3 Beagleboard in RET/OFF using wake-up

[PATCH 5/8] OMAP: PM CONSTRAINTS: add an enum for the classes of constraint

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Defined values in the enum: - OMAP_PM_CONSTRAINT_WKUP_LAT - OMAP_PM_CONSTRAINT_THROUGHPUT More classes can be added later if needed. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi

[PATCH 1/8] OMAP PM: create a PM layer plugin for per-device constraints

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Created arch/arm/plat-omap/omap-pm-constraints.c file from arch/arm/plat-omap/omap-pm-noop.c and the associated Kconfig option OMAP_PM_CONSTRAINTS. Based on the original patch from Vishwanath, cf. https://patchwork.kernel.org/patch/327312/ Cc: Vishwanath BS

[PATCH 3/8] OMAP3: powerdomain data: add wake-up latency figures

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Figures are added to the power domains structs. Note: the figures are preliminary figures. More accurate measurements are needed. Also the conditions of measurements shall be investigated and described. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency

[PATCH 6/8] OMAP2+: omap_device: implement the constraints management code

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The code at omap device level manages the constraints: storage, tracking of requesters and dispatching to the low level code (e.g. powerdomain for the wake-up latency constraints). Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU

[PATCH 7/8] OMAP: PM CONSTRAINTS: implement wake-up latency constraints

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Implement the wake-up latency constraints using an internal unified function _set_dev_constraint at OMAP PM level, which calls the corresponding function at omap device level. The actual constraints management code is at the omap device level. Note: the bus

[PATCH 8/8] OMAP PM: early init of the pwrdms states

2011-05-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The powerdomains next states are initialized in pwrdms_setup as a late_initcall. Because the wake-up constraint can be requested early in the boot sequence, the power domains next states can be overwritten by pwrdms_setup. This patch fixes it by initializing

Re: [PATCH v9 0/9] OMAP3: PM: TWL4030 power scripts and workaround for TWL erratum 27

2011-05-03 Thread Jean Pihet
On Thu, Apr 14, 2011 at 2:27 PM, Lesly A M lesl...@ti.com wrote: Patch series for TWL4030 power scripts and workaround for TWL erratum 27. Changes for implementing TWL4030 power scripts recommended by hardware team. Introduced a new TWL4030 power script file, which can be used by different

[PATCH 0/5] OMAP: cpuidle code clean-up

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Rework the cpuidle code: - optimize the cpuidle C-states data registration and storage, - change the interaction with the debugfs 'enable_off_mode' knob and the use of the C-states 'valid' internal field, - remove dead code, - improve code readability. Tested

[PATCH 2/5] OMAP3: clean-up mach specific cpuidle data structures

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com - sleep_latency and wake_latency are not used, replace them by exit_latency which is used by cpuidle. exit_latency simply is the sum of sleep_latency and wake_latency, - replace threshold by target_residency, - changed the OMAP3 specific cpuidle code

[PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The achievable power modes of the power domains in cpuidle depends on the system wide 'enable_off_mode' knob in debugfs. Upon changing enable_off_mode, do not change the C-states 'valid' field but instead dynamically restrict the power modes when entering idle

[PATCH 3/5] OMAP3: cpuidle: re-organize the C-states data

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The current implementation defines an internal structure and a C-states array. Using those structures is redundant to the structs used by the cpuidle framework. This patch provides a clean-up of the internal struct, removes the internal C-states array, stores

[PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The cpuidle states settings can be overriden by some board- specific settings, by calling omap3_pm_init_cpuidle. Remove the 3430SDP specific states settings registration since the figures are identical to the default ones (in cpuidle34xx.c). Signed-off-by: Jean

[PATCH 4/5] OMAP3: cpuidle: code rework for improved readability

2011-04-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 52 +--- 1 files changed, 19 insertions(+), 33 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c

Re: [PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic

2011-04-29 Thread Jean Pihet
Hi Santosh, On Fri, Apr 29, 2011 at 1:29 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: On 4/29/2011 2:56 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihetj-pi...@ti.com The achievable power modes of the power domains in cpuidle depends on the system wide 'enable_off_mode' knob

[PATCH 1/8] OMAP PM: create a PM layer plugin for per-device constraints

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Created arch/arm/plat-omap/omap-pm-constraints.c file from arch/arm/plat-omap/omap-pm-noop.c and the associated Kconfig option OMAP_PM_CONSTRAINTS. Based on the original patch from Vishwanath, cf. https://patchwork.kernel.org/patch/327312/ Cc: Vishwanath BS

[PATCH 2/8] OMAP2+: powerdomain: control power domains next state

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com When a wake-up latency constraint is requested or removed the omap device layer dispatches the updated strongest constraint value to the corresponding power domain. The power domains get the next power state programmed directly in the registers via

[PATCH 3/8] OMAP3: powerdomain data: add wake-up latency figures

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Figures are added to the power domains structs. Note: the figures are preliminary figures. More accurate measurements are needed. Also the conditions of measurements shall be investigated and described. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency

[PATCH 4/8] OMAP2+: omap_hwmod: manage the omap_devices the wake-up latency constraints

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Hwmod is queried from the omap device layer to manage the power domains wake-up latency constraints. Hwmod retrieves the correct power domain and if it exists it calls the corresponding power domain function. Tested on OMAP3 Beagleboard in RET/OFF using wake-up

[PATCH 6/8] OMAP2+: omap_device: implement the constraints management code

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The code at omap device level manages the constraints: storage, tracking of requesters and dispatching to the low level code (e.g. powerdomain for the wake-up latency constraints). Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU

[PATCH 7/8] OMAP: PM CONSTRAINTS: implement wake-up latency constraints

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Implement the wake-up latency constraints using an internal unified function _set_dev_constraint at OMAP PM level, which calls the corresponding function at omap device level. The actual constraints management code is at the omap device level. Note: the bus

[PATCH 5/8] OMAP: PM CONSTRAINTS: add an enum for the classes of constraint

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Defined values in the enum: - OMAP_PM_CONSTRAINT_WKUP_LAT - OMAP_PM_CONSTRAINT_THROUGHPUT More classes can be added later if needed. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi

[PATCH v3 0/8] OMAP: add PM CONSTRAINTS framework

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating a unified API which calls omap_device_set_dev_constraint for all classes of constraints (devices wake-up latency, devices throughput...). The implementation of the constraints framework

[PATCH 8/8] OMAP PM: early init of the pwrdms states

2011-03-30 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com The powerdomains next states are initialized in pwrdms_setup as a late_initcall. Because the wake-up constraint can be requested early in the boot sequence, the power domains next states can be overwritten by pwrdms_setup. This patch fixes it by initializing

Re: [PATCH/RFC 00/19] OMAP: voltage layer cleanup and restructure

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: This series is the begining of a voltage layer cleanup and restruture with the primary goal of splitting up voltage domain, voltage processor (VP) and voltage controller (VC) code. It would be nice to give a bit more detail on

Re: [PATCH/RFC 01/19] OMAP2+: hwmod: remove unused voltagedomain pointer

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: The voltage domain pointer currently in struct omap_hwmod is not used and does not belong here.  Instead, voltage domains will be associated Extra space with powerdomains in forthcoming patches. Acked-by: Paul Walmsley

Re: [PATCH/RFC 04/19] OMAP2+: voltage: start towards a new voltagedomain layer

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: Start cleaning up the voltage layer to have a voltage domain layer that resembles thae structure of the existing clock and power domain s/thae/the layers.  To that end: Extra space - move the 'struct voltagedomain' out of

Re: [PATCH/RFC 10/19] OMAP3: powerdomain data: add voltage domains

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: Add voltage domain name to indicate which voltagedomain each powerdomain is in.  A missing voltage domain name means that that powerdomain is not in one of the currently scalable voltage domains. Is that the role of the

Re: [PATCH/RFC 12/19] OMAP2+: powerdomain: add voltage domain lookup during register

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: When a powerdomain is registered, lookup the voltage domain by name and keep a pointer to the containing voltagedomain in the powerdomain structure. Modeled after similar method between powerdomain and clockdomain layers.

Re: [PATCH/RFC 13/19] OMAP2+: voltage: keep track of powerdomains in each voltagedomain

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: When a powerdomain is registered and it has an associated voltage domain, add the powerdomain to the voltagedomain using voltdm_add_pwrdm(). Also add voltagedomain iterator helper functions to iterate over all registered

Re: [PATCH/RFC 14/19] OMAP2+: voltage: split voltage controller (VC) code into dedicated layer

2011-03-25 Thread Jean Pihet
On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: As part of the voltage layer cleanup, split out VC specific code into a dedicated VC layer.  This patch primarily just moves VC code from voltage.c into vc.c, and adds prototypes to vc.h. No functional changes. For

Re: [PATCH/RFC 04/19] OMAP2+: voltage: start towards a new voltagedomain layer

2011-03-25 Thread Jean Pihet
On Fri, Mar 25, 2011 at 4:48 PM, Kevin Hilman khil...@ti.com wrote: Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: Start cleaning up the voltage layer to have a voltage domain layer that resembles thae structure

Re: [PATCH/RFC 10/19] OMAP3: powerdomain data: add voltage domains

2011-03-25 Thread Jean Pihet
On Fri, Mar 25, 2011 at 4:51 PM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: On Thu, Mar 24, 2011 at 1:00 AM, Kevin Hilman khil...@ti.com wrote: Add voltage domain name to indicate which voltagedomain each powerdomain is in.  A missing voltage domain name

Re: [PATCH/RFC 13/19] OMAP2+: voltage: keep track of powerdomains in each voltagedomain

2011-03-25 Thread Jean Pihet
On Fri, Mar 25, 2011 at 4:56 PM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: [...] + +/** + * voltdm_for_each - call function on each registered voltagedomain + * @fn: callback function * + * + * Call the supplied function @fn for each registered

Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators

2011-03-16 Thread Jean Pihet
finding this one David. Great! Acked-by: Jean Pihet j-pi...@ti.com Thanks, Jean ---  arch/arm/mach-omap2/board-omap4panda.c |   28  1 files changed, 0 insertions(+), 28 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board

Re: [GIT PULL] OMAP PM updates for 2.6.39

2011-03-11 Thread Jean Pihet
Hi Kevin, On Fri, Mar 11, 2011 at 1:59 AM, Kevin Hilman khil...@ti.com wrote: Tony, Please pull the following OMAP PM related changes for the upcoming 2.6.39 merge window. Kevin The following changes since commit a5abba989deceb731047425812d268daf7536575:  Linux 2.6.38-rc8 (2011-03-07

Re: [GIT PULL] OMAP PM updates for 2.6.39

2011-03-11 Thread Jean Pihet
On Fri, Mar 11, 2011 at 5:32 PM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: Hi Kevin, On Fri, Mar 11, 2011 at 1:59 AM, Kevin Hilman khil...@ti.com wrote: Tony, Please pull the following OMAP PM related changes for the upcoming 2.6.39 merge window

Re: [PATCH] perf: add OMAP support for the new power events

2011-03-10 Thread Jean Pihet
Hi Paul, On Thu, Mar 10, 2011 at 2:04 AM, Paul Walmsley p...@pwsan.com wrote: On Thu, 3 Mar 2011, Jean Pihet wrote: The patch adds the new power management trace points for the OMAP architecture. The trace points are for: - default idle handler. Since the cpuidle framework

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-10 Thread Jean Pihet
Hi Paul, On Thu, Mar 10, 2011 at 5:03 AM, Paul Walmsley p...@pwsan.com wrote: Hello Jean Thanks for working on this stuff.  Some comments based on a quick look... On Wed, 9 Mar 2011, Jean Pihet wrote: Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating a unified API

[PATCH v2 0/7] OMAP: add PM CONSTRAINTS framework

2011-03-10 Thread Jean Pihet
constraints. Jean Pihet (7): OMAP PM: create a PM layer plugin for per-device constraints OMAP: PM CONSTRAINTS: add an enum for the classes of constraint OMAP: PM CONSTRAINTS: implement wake-up latency constraints OMAP: PM CONSTRAINTS: implement the constraints management code OMAP: PM

[PATCH v2 1/7] OMAP PM: create a PM layer plugin for per-device constraints

2011-03-10 Thread Jean Pihet
-by: Jean Pihet j-pi...@ti.com --- arch/arm/plat-omap/Kconfig |7 + arch/arm/plat-omap/Makefile |1 + arch/arm/plat-omap/omap-pm-constraints.c | 363 ++ 3 files changed, 371 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat

[PATCH v2 3/7] OMAP: PM CONSTRAINTS: implement wake-up latency constraints

2011-03-10 Thread Jean Pihet
but currently is a no-op. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/plat-omap/omap-pm-constraints.c | 174 -- 1 files changed, 91 insertions(+), 83 deletions

[PATCH v2 4/7] OMAP: PM CONSTRAINTS: implement the constraints management code

2011-03-10 Thread Jean Pihet
The code at omap device level manages the constraints: storage, tracking of requesters and dispatching to the low level code (e.g. powerdomain for the wake-up latency constraints). Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean

[PATCH v2 5/7] OMAP: PM CONSTRAINTS: add a power domains state update function in hwmod

2011-03-10 Thread Jean Pihet
. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 29 +- arch/arm/plat-omap/include/plat/omap_hwmod.h |1 + 2 files changed, 29 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2

[PATCH v2 7/7] OMAP: PM CONSTRAINTS: add power domains wake-up latency figures

2011-03-10 Thread Jean Pihet
. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/powerdomains3xxx_data.c | 63 +++ 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c b/arch/arm/mach-omap2/powerdomains3xxx_data.c index e1bec56

[PATCH v2 6/7] OMAP: PM CONSTRAINTS: control power domains next state

2011-03-10 Thread Jean Pihet
the next power state via cpuidle, which get the strongest wake-up latency constraint by querying PM QOS. The usage of PM QOS is temporary, until a generic solution is in place. Tested on OMAP3 Beagleboard in RET/OFF using wake-up latency constraints on MPU, CORE and PER. Signed-off-by: Jean Pihet j-pi

[PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-09 Thread Jean Pihet
constraint by querying PM QOS. The usage of PM QOS is temporary, until a generic solution is in place. Based on Vibhore's original patch, adapted to omap_device, omap_hwmod and PM QOS frameworks. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Vibhore Vardhan vvard...@ti.com --- arch/arm/mach-omap2

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-09 Thread Jean Pihet
Hi, This patch is sent as en early review request, the testing is still on-going. I will post the updated series (with a new revision number) as soon as possible. I have some inlined comments, questions and concerns about it. Can you please check? On Wed, Mar 9, 2011 at 8:19 PM, Jean Pihet

Re: [PATCH 2/2] OMAP: PM: implement devices wakeup latency constraints APIs

2011-03-08 Thread Jean Pihet
On Tue, Mar 8, 2011 at 3:15 AM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating similar APIs at the omap_device and omap_hwmod levels. The omap_hwmod level call is the layer with access

Re: [patch v3 3/3] arm: omap4: support pmu

2011-03-07 Thread Jean Pihet
--- Looks good. Acked-by: Santosh Shilimkar santosh.shilim...@ti.com Great! Acked-by: Jean Pihet j-pi...@ti.com Thanks, Jean  arch/arm/mach-omap2/devices.c              |   82 +++-  arch/arm/plat-omap/include/plat/omap44xx.h |    2 +  2 files changed, 81 insertions

[PATCH 1/2] OMAP PM: create a PM layer plugin for the devices wakeup latency constraints

2011-03-04 Thread Jean Pihet
-by: Jean Pihet j-pi...@ti.com --- Based on khilman's pm-core branch arch/arm/plat-omap/Kconfig |7 + arch/arm/plat-omap/Makefile |1 + arch/arm/plat-omap/omap-pm-constraints.c | 363 ++ 3 files changed, 371 insertions(+), 0 deletions

[PATCH 2/2] OMAP: PM: implement devices wakeup latency constraints APIs

2011-03-04 Thread Jean Pihet
to omap_device, omap_hwmod and PM QOS frameworks. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Vibhore Vardhan vvard...@ti.com --- Based on khilman's pm-core branch arch/arm/mach-omap2/omap_hwmod.c | 62 - arch/arm/mach-omap2/powerdomain.c | 197

[PATCH 0/2] OMAP: PM: implement devices wakeup latency constraints APIs

2011-03-04 Thread Jean Pihet
pwrdm_wakeuplat_update_pwrst. Note about PM QOS: the MPU and CORE power domains get the next power state via cpuidle, which get the strongest wake-up latency constraint by querying PM QOS. The usage of PM QOS is temporary, until a generic solution is in place. Jean Pihet (2): OMAP PM: create a PM layer

[PATCH] perf: add OMAP support for the new power events

2011-03-03 Thread Jean Pihet
clocks changes (enable, disable, set_rate), - power domain states: the desired target state and -if different- the actually hit state. Because of the generic nature of the changes, OMAP3 and OMAP4 are supported. Tested on OMAP3 with suspend/resume, cpuidle, basic DVFS. Signed-off-by: Jean Pihet

Re: [PATCH] perf: add OMAP support for the new power events

2011-02-28 Thread Jean Pihet
Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Monday, February 21, 2011 2:14 PM To: Santosh Shilimkar Cc: Kevin Hilman; Thomas Renninger; linux-omap@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Jean Pihet-XID Subject: Re: [PATCH] perf: add OMAP support

<    2   3   4   5   6   7   8   9   10   >