RE: [PATCH 2/2] omap: zoom: Move new code introduced by ASoC m-c to board-zoom-peripherals

2010-09-24 Thread Lopez Cruz, Misael
...@gmail.com Cc: Vikram Pandita vikram.pand...@ti.com Cc: Lopez Cruz, Misael x0052...@ti.com Cc: Jorge Eduardo Candelaria jorge.candela...@ti.com Cc: Tony Lindgren t...@atomide.com --- I don't have this HW so not tested. Tested on zoom2 using the 2 patches of your series, compilation break is gone

RE: [PATCH 2/2] omap: zoom: Move new code introduced by ASoC m-c to board-zoom-peripherals

2010-10-01 Thread Lopez Cruz, Misael
Liam Girdwood wrote: On Fri, 2010-09-24 at 11:31 -0500, Lopez Cruz, Misael wrote: Hi Jarkko, ASoC Multi-Component Support moves some code from sound/soc/omap/zoom2.c into arch/arm/mach-omap2/board-zoom2.c. However, that code should go to board-zoom-peripherals.c

RE: [PATCH] ALSA: SoC: Add support for TI SDP3430

2008-11-20 Thread Lopez Cruz, Misael
On Thursday 20 November 2008, [EMAIL PROTECTED] wrote: +   tristate SoC Audio support for Texas Instruments SDP3430 +   depends on SND_OMAP_SOC MACH_OMAP_3430SDP +   select SND_OMAP_SOC_MCBSP +   select SND_SOC_TWL4030 depends also on TWL4030_CORE, yes? The machine

RE: busybox output to display

2008-11-22 Thread Lopez Cruz, Misael
We accidentally saw this behavior when saving bootargs like: setenv bootargs='...' instead of setenv bootargs '...' Try removing '=' Misa -Original Message- From: [EMAIL PROTECTED] [mailto:linux-omap- [EMAIL PROTECTED] On Behalf Of Sudipta GHOSH Sent: Saturday, November 22, 2008

RE: [PATCH][OMAPZOOM] OMAP3: Initialize XCCR and RCCR registers for McBSP DAI driver

2008-11-24 Thread Lopez Cruz, Misael
This patch initializes XCCR and RCCR registers for OMAP McBSP DAI driver for OMAP 2430/34xx platforms. Those registers were being set to 0 as they were not properly initialized. Signed-off-by: Misael Lopez Cruz [EMAIL PROTECTED] This version includes Anand and Chandra's comments. -- To

[PATCH] ARM: OMAP3: Initialize XCCR and RCCR McBSP registers for McBSP DAI driver

2008-12-18 Thread Lopez Cruz, Misael
This patch enables XCCR and RCCR McBSP register writing in OMAP 24xx/34xx platforms. It also explicitly initializes those registers to their default values in ASoC McBSP DAI driver. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- arch/arm/plat-omap/include/mach/mcbsp.h |6 ++

[PATCH] ARM: OMAP3: Enable writing to XCCR and RCCR McBSP registers for OMAP 2430/34xx

2008-12-18 Thread Lopez Cruz, Misael
This patch enables writing to McBSP Transmit Configuration Control Register (XCCR) and Receive Configuration Control Register (RCCR) for 2430/34xx platforms. It also adds XCCR, RCCR entries in McBSP register configuration structure and bit definitions for both registers. Signed-off-by: Misael

SoC: OMAP: Initialize XCCR and RCCR registers in McBSP DAI driver

2008-12-18 Thread Lopez Cruz, Misael
This patch explicitly initializes McBSP Transmit Configuration Control Register (XCCR) and Receive Configuration Control Register (RCCR) to their reset values. Reset values are 26 ns of DX delay and Transmit DMA disabled for XCCR register; receive full cycle mode enabled and Receive DMA disabled

[PATCH] SoC: OMAP: Initialize XCCR and RCCR registers in McBSP DAI driver

2009-01-23 Thread Lopez Cruz, Misael
This patch explicitly initializes McBSP Transmit Configuration Control Register (XCCR) and Receive Configuration Control Register (RCCR) to their reset values. Reset values are 26 ns of DX delay and Transmit DMA disabled for XCCR register; receive full cycle mode enabled and Receive DMA disabled

RE: [PATCH] ASoC: Replace snd_soc_machine by snd_soc_card structure in SDP3430 machine driver

2009-02-09 Thread Lopez Cruz, Misael
On Tue, 10 Feb 2009 00:57:00 +0100 ext Lopez Cruz, Misael x0052...@ti.com wrote: This patch replaces snd_soc_machine structure by snd_soc_card in SP3430 driver. This change is needed in SDP3430 driver to reflect changes introduced by ASoC: Rename snd_soc_card to snd_soc_machine patch

[PATCH] ASoC: Replace snd_soc_machine by snd_soc_card structure in SDP3430 machine driver

2009-02-10 Thread Lopez Cruz, Misael
This patch replaces snd_soc_machine structure by snd_soc_card in SP3430 driver. This change is needed in SDP3430 driver to reflect changes introduced by ASoC: Rename snd_soc_card to snd_soc_machine patch (875065491fba8eb13219f16c36e79a6fb4e15c68). Signed-off-by: Misael Lopez Cruz x0052...@ti.com

RE: Configuring a TWL GPIO pin as an interrupt

2009-02-22 Thread Lopez Cruz, Misael
I'm interested in bringing headset detection feature for audio. The detection is done through TWL GPIO_2. How can I configure a GPIO pin to generate an interrupt? Is there any API? Could you please point out another driver using that functionality so I can use as reference? In the setup()

RE: Configuring a TWL GPIO pin as an interrupt

2009-02-23 Thread Lopez Cruz, Misael
On Sunday 22 February 2009, Lopez Cruz, Misael wrote: In the particular case of ALSA SoC, could the machine/board driver be a better place to handle all GPIO/IRQ configuration? That driver also contains only board specific code. It'd be best of the ASoC stuff could sit with all

RE: Configuring a TWL GPIO pin as an interrupt

2009-02-24 Thread Lopez Cruz, Misael
If these are CPU side GPIOs that you're talking about you'll also want to write the standard utility for using gpiolib for jack detection that I've not got round to doing yet :) The GPIOs belong to a submodule of TWL4030, but they are configured using standard gpiolib. About adding GPIO

[PATCH 0/3] GPIO for jack reporting interface

2009-02-25 Thread Lopez Cruz, Misael
The following patch set implements GPIO support for SoC jack reporting interface and uses it in SDP3430 machine driver. The jack detection interface is used in SDP3430 driver to handle headset events. That requires DAPM machine widgets to be added to the machine driver before the actual use of

[PATCH 1/3] ASoC: Add GPIO support for jack reporting interface

2009-02-25 Thread Lopez Cruz, Misael
Add GPIO support for jack reporting framework in ASoC, by using gpiolib calls. It's only required to append GPIO information (gpio number, irq handler and flags) to standard jack_pin declaration. GPIO request, data direction configuration and irq request are handled by the utility. The minimal

[PATCH 2/3] ASoC: Add DAPM machine widgets to SDP3430 driver

2009-02-25 Thread Lopez Cruz, Misael
Add DAPM machine domain widgets to SDP3430 machine driver. Current interconection: * Ext Mic: MAINMIC, SUBMIC * Ext Spk: HFL, HFR * Headset Jack: HSMIC, HSOL, HSOR Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 61 ++

[PATCH 3/3] ASoC: Add headset jack detection for SDP3430 machine driver

2009-02-25 Thread Lopez Cruz, Misael
Add headset jack detection for SDP3430 boards using SoC jack reporting interface. Headset detection on SDP3430 board is achieved through TWL4030 GPIO_2 pin. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 31 ++- 1 files changed, 30

RE: [alsa-devel] [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface

2009-02-27 Thread Lopez Cruz, Misael
struct snd_soc_jack_pin { + struct snd_soc_jack *jack; + struct snd_soc_jack_gpio *gpio_pin; struct list_head list; const char *pin; int mask; bool invert; + /* GPIO */ + unsigned int gpio; + unsigned int irq; + unsigned long irqflags; +

RE: [alsa-devel] [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface

2009-03-02 Thread Lopez Cruz, Misael
Could we leave the actual implementation of this report function to the machine driver? Since the things being done in detection function are common (even if other status are wanted to be updated), then probably machine driver could define a specific function (action) for doing extra

RE: [alsa-devel] [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface

2009-03-02 Thread Lopez Cruz, Misael
That sounds like adding a callback for power updates on the jack itself to me (which isn't a bad idea), rather than changing the report function of the jack detection method. The need for machine-specific extra actions probably isn't specific to jacks that are detected via GPIOs.

[PATCH 1/2] ASoC: Add DAPM machine widgets to SDP3430 driver

2009-03-04 Thread Lopez Cruz, Misael
Add DAPM machine domain widgets to SDP3430 machine driver. Interconnection: * Ext Mic: MAINMIC, SUBMIC * Ext Spk: HFL, HFR * Headset Jack: HSMIC, HSOL, HSOR Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 64 ++ 1

[PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver

2009-03-04 Thread Lopez Cruz, Misael
Add headset jack detection for SDP3430 boards using SoC jack reporting interface. Headset detection on SDP3430 board is achieved through TWL4030 GPIO_2 pin. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 49 - 1 files

RE: [PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver

2009-03-04 Thread Lopez Cruz, Misael
+ ret = snd_soc_jack_new(snd_soc_sdp3430, SDP3430 headset jack, + SND_JACK_HEADSET, hs_jack); + if (ret) + return ret; This leaks the jack. If hs_jack is declared as a direct static variable instead, then no mem leaks, isn't it? Or do you mean to

[PATCH 2/2] ASoC: Add headset jack detection for SDP3430 machine driver

2009-03-05 Thread Lopez Cruz, Misael
Add headset jack detection for SDP3430 boards using SoC jack reporting interface. Headset detection on SDP3430 board is achieved through TWL4030 GPIO_2 pin. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/omap/sdp3430.c | 43 +-- 1 files

[PATCH] ASoC: Declare Headset as Mic and Headphone widgets for SDP3430

2009-03-19 Thread Lopez Cruz, Misael
Headset was declared previously as a Headphone widget connecting HSMIC and HSOL/HSOR pins of TWL4030 codec in SDP430 machine driver. The capture path becomes invalid as the Headphone widget is not a valid input endpoint. Instead of that, the Headset is declared as separate Microphone and

[PATCH 1/3] ASoC: TWL6030: Add twl6030 codec driver

2009-09-14 Thread Lopez Cruz, Misael
Initial version of TWL6030 codec driver. The TWL6030 codec uses a propietary digital audio interface called McPDM. TWL6030 codec has two power modes: low-power and high-performance, this initial version only supports high-performance mode. Signed-off-by: Misael Lopez Cruz x0052...@ti.com ---

[PATCH 3/3] ASoC: TWL6030: Handle power-up seq completion thru audio interrupt

2009-09-14 Thread Lopez Cruz, Misael
NAUDINT interrupt line is provided by the TWL6030 codec to signal externally events like headset plug/unplug, hook, power-up sequence completion, etc. When the codec is powered-up through external AUDPWRON line it will start its power-up sequence. The completion of the sequence is signaled

[PATCH 2/3] ASoC: TWL6030: Add support for low-power mode

2009-09-14 Thread Lopez Cruz, Misael
TWL6030 codec supports two power modes: low-power and high-performance. In low-power mode, headset downlink must be the only path enabled and components in that path (headset DAC and driver) should be in that mode too. In this mode, codec can stream audio at 44.1 and 48 kHz if sys clock is

RE: [PATCH 1/3] ASoC: TWL6030: Add twl6030 codec driver

2009-09-15 Thread Lopez Cruz, Misael
Mark Brown wrote: On Mon, Sep 14, 2009 at 12:00:25PM -0500, Lopez Cruz, Misael wrote: +/* propietary formats */ +#define SND_SOC_DAIFMT_MCPDM 0x10 /* Texas Instruments McPDM */ This should really be split out into a separate patch. Are you absolutely positive

RE: [alsa-devel] [PATCH 1/3] ASoC: TWL6030: Add twl6030 codec driver

2009-09-15 Thread Lopez Cruz, Misael
Mark Brown wrote: On Tue, Sep 15, 2009 at 12:59:44PM -0500, Lopez Cruz, Misael wrote: Mark Brown wrote: On Mon, Sep 14, 2009 at 12:00:25PM -0500, Lopez Cruz, Misael wrote: +/* propietary formats */ +#define SND_SOC_DAIFMT_MCPDM 0x10 /* Texas Instruments McPDM */ This should

[PATCHv2 0/7] TWL6030 audio codec initial support

2009-09-25 Thread Lopez Cruz, Misael
Following patch series adds initial support for TWL6030 codec driver. TWL6030 codec depends on TWL6030_CORE, which is not accepted yet. The main intention then is to get comments, I'll repost the patches of this series when TWL6030_CORE support gets accepted and rework patches as needed. Changes

[PATCHv2 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-09-25 Thread Lopez Cruz, Misael
In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data is required: - audpwron_gpio: gpio line used to power-up/down the codec. A low-to-high transition powers codec up. Setting

[PATCHv2 2/7] ASoC: Add PDM DAI format definition

2009-09-25 Thread Lopez Cruz, Misael
Add DAI format definition for PDM interfaces. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- include/sound/soc-dai.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index 352d7ee..9239cb0 100644 ---

[PATCHv2 3/7] ASoC: TWL6030: Add twl6030 codec driver

2009-09-25 Thread Lopez Cruz, Misael
Initial version of TWL6030 codec driver. The TWL6030 codec uses a propietary PDM-based digital audio interface. TWL6030 codec has two power modes: low-power and high-performance, this initial version only supports high-performance mode. Signed-off-by: Misael Lopez Cruz x0052...@ti.com ---

[PATCHv2 4/7] ASoC: TWL6030: Manual power-up/down sequences

2009-09-25 Thread Lopez Cruz, Misael
TWL6030 codec device can be powered-up/down through a specific register writes sequence. These sequences can be used when no gpio line is provided for AUDPWRON. When the codec is powered-up in this way, automatic power-down sequence (triggered by thermal shutdown) is not possible. Signed-off-by:

[PATCHv2 5/7] ASoC: TWL6030: Add support for low-power mode

2009-09-25 Thread Lopez Cruz, Misael
TWL6030 codec supports two power modes: low-power and high performance. In low-power mode, headset downlink must be the only path enabled and components in that path (headset DAC and driver) should be in that mode too. In this mode, codec can stream audio at 44.1 and 48 kHz if sys clock from

[PATCHv2 6/7] ASoC: TWL6030: Enable audio interrupt

2009-09-25 Thread Lopez Cruz, Misael
NAUDINT interrupt line is provided by the TWL6030 codec to signal externally events like headset plug/unplug, hook, power-up sequence completion, etc. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/codecs/twl6030.c | 78 +++-

[PATCHv2 7/7] ASoC: TWL6030: Power-up seq completion through audio interrupt

2009-09-25 Thread Lopez Cruz, Misael
When the codec is powered-up through external AUDPWRON line it starts its power-up sequence. The completion of the sequence is signaled through the audio interrupt, and then codec is operational. CODEC driver starts a wait_for_completion just after AUDPWRON line transitions from low to high. It's

RE: [PATCHv2 0/7] TWL6030 audio codec initial support

2009-09-28 Thread Lopez Cruz, Misael
Santosh, Shilimkar, Santosh wrote: Misa, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Lopez Cruz, Misael Sent: Saturday, September 26, 2009 7:32 AM To: alsa-de...@alsa-project.org; linux-omap@vger.kernel.org Cc

RE: [alsa-devel] [PATCHv2 5/7] ASoC: TWL6030: Add support for low-power mode

2009-09-29 Thread Lopez Cruz, Misael
Mark, Mark Brown wrote: On Fri, Sep 25, 2009 at 09:03:30PM -0500, Lopez Cruz, Misael wrote: TWL6030 codec supports two power modes: low-power and high performance. In low-power mode, headset downlink must be the only path enabled and components in that path (headset DAC and driver) should

[PATCHv3 0/7] TWL6030 audio codec initial support

2009-10-06 Thread Lopez Cruz, Misael
Following patch series adds initial support for TWL6030 codec driver. Changes from v2: - CODEC now handles scenarios where no platform data is passed - Removed GPIOLIB dependency of codec driver - Removed magic values, register reads instead - Added runtime constraints depending on sysclk - Added

[PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-06 Thread Lopez Cruz, Misael
In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data may be passed: - audpwron_gpio: gpio line used to power-up/down the codec. A low-to-high transition powers codec up. Setting

[PATCHv3 2/7] ASoC: TWL6030: Add twl6030 codec driver

2009-10-06 Thread Lopez Cruz, Misael
Initial version of TWL6030 codec driver. The TWL6030 codec uses a propietary PDM-based digital audio interface. Audio paths supported are: - Input: Main Mic, Sub Mic, Headset Mic, Auxiliary-FM Left/Right - Output: Headset Left/Right, Handsfree Left/Right Signed-off-by: Misael Lopez Cruz

[PATCHv3 3/7] ASoC: TWL6030: Manual power-up/down sequences

2009-10-06 Thread Lopez Cruz, Misael
TWL6030 codec device can be powered-up/down through a specific register writes sequence. These sequences can be used when no gpio line is provided for AUDPWRON. When the codec is powered-up in this way, automatic power-down sequence (triggered by thermal shutdown) is not possible. Signed-off-by:

[PATCHv3 4/7] ASoC: TWL6030: Add support for low-power PLL

2009-10-06 Thread Lopez Cruz, Misael
TWL6030 codec sysclk can be provided by: low-power or high performance PLL. The low-power PLL takes a low-frequency input at 32,768 Hz and generates an approximate of 17.64 or 19.2 MHz. The high-performance PLL generates an exact 19.2 MHz clock signal from high-frequency input at 12/19.2/26/38.4

[PATCHv3 5/7] ASoC: TWL6030: Add restrictions for low-power playback mode

2009-10-06 Thread Lopez Cruz, Misael
Low-power playback mode is a special scenario where only headset path (headset DAC and driver) is active. Only in this mode the codec can support 44.1 and 48 kHz, low-power PLL should provide sysclk signal. Currently, handsfree DAC and driver are the only components that can prevent codec to

[PATCHv3 6/7] ASoC: TWL6030: Enable audio interrupt

2009-10-06 Thread Lopez Cruz, Misael
NAUDINT interrupt line is provided by the TWL6030 codec to signal externally events like headset plug/unplug, hook, power-up sequence completion, etc. Signed-off-by: Misael Lopez Cruz x0052...@ti.com --- sound/soc/codecs/twl6030.c | 70 ---

[PATCHv3 7/7] ASoC: TWL6030: Detect power-up sequence completion

2009-10-06 Thread Lopez Cruz, Misael
When the codec is powered-up through external AUDPWRON line it starts its power-up sequence. The completion of the sequence is signaled through the audio interrupt, and then codec is operational. If NAUDINT irq is provided, CODEC driver starts a wait_for_completion just after AUDPWRON line

RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-06 Thread Lopez Cruz, Misael
Peter Ujfalusi wrote: On Tuesday 06 October 2009 10:29:39 ext Lopez Cruz, Misael wrote: In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data may be passed: - audpwron_gpio

RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Lopez Cruz, Misael
Krishnamoorthy, Balaji T wrote: CONFIG_TWL6030_CORE and CONFIG_TWL4030_CORE is merged to CONFIG_TWL_CORE As two different build config was not encouraged. Now switch twl_class_is_6030() will be used to decide at runtime time to support for 6030 related drivers, Similarly twl_class_is_4030()