[PATCH 0/4] fixes for twl4030-irq in mainline

2011-11-26 Thread NeilBrown
less critical issues like a typo in a comment :-) Thanks, NeilBrown --- NeilBrown (4): twl4030-irq: fix typo twl4030-irq: set tertiary interrupts to be nested/threaded. twl4030-irq: use request_threaded_irq in place of irq_set_chained_handler. twl4030-irq: Base interrupt

[PATCH 1/4] twl4030-irq: Base interrupt must be one-shot

2011-11-26 Thread NeilBrown
-by: NeilBrown ne...@suse.de --- drivers/mfd/twl4030-irq.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index f062c8c..3d3d6ed 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -733,8 +733,9 @@ int

Re: [PATCH] gpio/omap: fix invalid context restore of gpio bank-0

2012-07-02 Thread NeilBrown
and looks sensible. Tested-by: NeilBrown ne...@suse.de Thanks, NeilBrown signature.asc Description: PGP signature

Infinite looping in omap2430.c USB driver

2012-07-06 Thread NeilBrown
if you like, but I suspect you can come up with a much better approach. Thanks, NeilBrown signature.asc Description: PGP signature

[PATCH] MFD: twl-core: move device_init_wakeup to after platform_device_add.

2012-07-06 Thread NeilBrown
to platform_device_add(). Making this change causes correct names to appear in the wakeup_sources file. Signed-off-by: NeilBrown ne...@suse.de diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 6fc90be..b012efd 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -568,7

bisected regression: arm: omap3: voltage: fix channel configuration

2012-07-23 Thread NeilBrown
the real problem is and to find a proper fix, I'm happy to help. Thanks, NeilBrown signature.asc Description: PGP signature

Re: bisected regression: arm: omap3: voltage: fix channel configuration

2012-07-23 Thread NeilBrown
On Mon, 23 Jul 2012 17:24:54 +0300 Tero Kristo t-kri...@ti.com wrote: Hi Neil, On Mon, 2012-07-23 at 21:06 +1000, NeilBrown wrote: My GTA04 (mobile phone using OMAP3 and TWL4030 PMIC) has difficulty rebooting with 3.5. The first boot (after power on) works fine. But when I reboot

Re: bisected regression: arm: omap3: voltage: fix channel configuration

2012-07-24 Thread NeilBrown
On Tue, 24 Jul 2012 09:28:24 +0300 Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-07-24 at 11:30 +1000, NeilBrown wrote: Might there be some way to get it to scale higher than 600MHz? The first message from U-boot says: OMAP3630/3730-GP ES2.1, CPU-OPP2, L3-165MHz, Max CPU Clock 1 Ghz

[PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-29 Thread NeilBrown
1/ if regulator_get fails, return an error. This is important if it failed with EPROBE_DEFER, as the probe needs to be deferred. 2/ Don't set .set_power until the regulator has been found, or the deferred probe will not bother calling omap_hsmmc_reg_get(). Signed-off-by: NeilBrown ne

Re: Infinite looping in omap2430.c USB driver

2012-07-29 Thread NeilBrown
Hi Felipe, have you had a chance to look at this problem in omap2430_mbus_set_vbus yet? Are you the person responsible? thanks, NeilBrown On Mon, 9 Jul 2012 01:32:33 -0700 Tony Lindgren t...@atomide.com wrote: * NeilBrown ne...@suse.de [120706 15:44]: Hello `./scripts/get_maintainer.pl

[PATCH] OMAP/serial: Add support for driving a GPIO as DTR.

2012-07-29 Thread NeilBrown
a work-queue to effect the change, and I currently use the 'qos_work' rather than adding another work handler. As both the qos_work and the gpio work tasks are idempotent and rare, this seems reasonable. Is it OK? should I make another work_struct? or something else? Thanks, NeilBrown

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-30 Thread NeilBrown
On Mon, 30 Jul 2012 10:50:36 +0530 Rajendra Nayak rna...@ti.com wrote: On Monday 30 July 2012 05:42 AM, NeilBrown wrote: 1/ if regulator_get fails, return an error. This is important if it failed with EPROBE_DEFER, as the probe needs to be deferred. 2/ Don't set .set_power

Re: [PATCH] MMC/omap_hsmmc: handle failure of regulator_get better.

2012-07-30 Thread NeilBrown
On Mon, 30 Jul 2012 12:07:09 +0530 Rajendra Nayak rna...@ti.com wrote: On Monday 30 July 2012 11:54 AM, NeilBrown wrote: On Mon, 30 Jul 2012 10:50:36 +0530 Rajendra Nayakrna...@ti.com wrote: On Monday 30 July 2012 05:42 AM, NeilBrown wrote: 1/ if regulator_get fails, return an error

Re: debug needed: twl4030 RTC wakeups: repeated attempts fail on Beagle

2012-08-10 Thread NeilBrown
for one of the multitude of conferences there? NeilBrown signature.asc Description: PGP signature

Re: Infinite looping in omap2430.c USB driver

2012-08-12 Thread NeilBrown
On Thu, 9 Aug 2012 14:15:51 +0300 Felipe Balbi ba...@ti.com wrote: hehe, that's nasty. Please send a patch converting to a try count and a udelay_range(), or something. how's this? Thanks, NeilBrown From: NeilBrown ne...@suse.de Date: Mon, 13 Aug 2012 12:32:58 +1000 Subject: [PATCH

Re: Infinite looping in omap2430.c USB driver

2012-08-13 Thread NeilBrown
On Mon, 13 Aug 2012 17:32:34 +0300 Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Aug 13, 2012 at 12:34:53PM +1000, NeilBrown wrote: On Thu, 9 Aug 2012 14:15:51 +0300 Felipe Balbi ba...@ti.com wrote: hehe, that's nasty. Please send a patch converting to a try count

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-08-26 Thread NeilBrown
On Sun, 26 Aug 2012 09:47:50 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: + Jon, On Sat, Aug 25, 2012 at 5:14 PM, NeilBrown ne...@suse.de wrote: Current kernel will wake from suspend on an event on any active GPIO even if enable_irq_wake() wasn't called

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-05 Thread NeilBrown
On Mon, 3 Sep 2012 22:59:06 -0700 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Sun, Aug 26, 2012 at 6:29 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Sun, Aug 26, 2012 at 3:53 PM, NeilBrown ne...@suse.de wrote: On Sun, 26 Aug 2012 09:47:50 +0530 Shilimkar, Santosh

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-06 Thread NeilBrown
On Thu, 6 Sep 2012 12:57:46 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Thu, Sep 6, 2012 at 12:32 PM, NeilBrown ne...@suse.de wrote: On Thu, 6 Sep 2012 11:18:09 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Thu, Sep 6, 2012 at 8:35 AM, NeilBrown ne

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-09 Thread NeilBrown
On Fri, 07 Sep 2012 14:37:16 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: Hi Neil, NeilBrown ne...@suse.de writes: On Thu, 6 Sep 2012 11:18:09 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Thu, Sep 6, 2012 at 8:35 AM, NeilBrown ne...@suse.de wrote: On Mon

Seeking clarity on IRQCHIP_MASK_ON_SUSPEND

2012-09-10 Thread NeilBrown
... I don't think will compile. It is only used by pm8921-core.c, and that requires #include linux/msm_ssbi.h, which doesn't exist in mainline. Is anyone able to give a definitive answer on this? Should IRQCHIP_MASK_ON_SUSPEND be removed? Thanks, NeilBrown signature.asc Description: PGP signature

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-10 Thread NeilBrown
On Thu, 6 Sep 2012 16:26:06 +0300 Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Sep 06, 2012 at 05:02:45PM +1000, NeilBrown wrote: On Thu, 6 Sep 2012 11:18:09 +0530 Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Thu, Sep 6, 2012 at 8:35 AM, NeilBrown ne...@suse.de wrote

Re: Seeking clarity on IRQCHIP_MASK_ON_SUSPEND

2012-09-10 Thread NeilBrown
On Mon, 10 Sep 2012 12:28:35 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Mon, 10 Sep 2012, NeilBrown wrote: The IRQCHIP_MASK_ON_SUSPEND flag seems to be hard to use correctly, so either I'm understanding it wrongly, or it could be made easier to use. If the first case

Re: Seeking clarity on IRQCHIP_MASK_ON_SUSPEND

2012-09-11 Thread NeilBrown
On Tue, 11 Sep 2012 15:20:53 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Tue, 11 Sep 2012, NeilBrown wrote: On Mon, 10 Sep 2012 12:28:35 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: You might be looking for a different functionality. Can you explain what you

Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-05-03 Thread NeilBrown
and tested-by: in case that helps. Thanks, NeilBrown From: Thomas Gleixner t...@linutronix.de Date: Wed, 25 Apr 2012 12:54:54 +0200 Subject: [PATCH] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts. Level triggered interrupts do not cause IRQS_PENDING to be set when they fire-while

Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-05-08 Thread NeilBrown
On Fri, 4 May 2012 18:01:22 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: Neil, On Fri, 4 May 2012, NeilBrown wrote: On Wed, 25 Apr 2012 14:54:54 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: Why not simply managing the pending bit for level irqs ? Hi

Re: [PATCH 0/6] twl4030: Various fixes for charing-from-USB

2012-05-09 Thread NeilBrown
On Thu, 10 May 2012 09:24:23 +0800 Peter Chen peter.c...@freescale.com wrote: On Wed, Apr 25, 2012 at 05:33:10PM +1000, NeilBrown wrote: Following are a collection of patches that I've need using for a while to make sure the charge-from-usb on my GTA04 works. Hopefully I've included

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-06-13 Thread NeilBrown
set up yet, so restoring from it broke things. Initialising bank-context_loss_count seems sensible and would ensure that we didn't try to restore the context until it has actually been lost. Thanks, NeilBrown signature.asc Description: PGP signature

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-06-20 Thread NeilBrown
On Thu, 14 Jun 2012 23:24:10 +0530 DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Thu, Jun 14, 2012 at 5:45 AM, NeilBrown ne...@suse.de wrote: On Fri, 11 May 2012 17:30:48 -0700 Kevin Hilman khil...@ti.com wrote: Hi Grant, Here's the final round of GPIO cleanups for v3.5

Re: [GIT PULL] gpio/omap: cleanups for v3.5

2012-06-25 Thread NeilBrown
On Thu, 21 Jun 2012 12:04:26 +0530 DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Thu, Jun 21, 2012 at 8:46 AM, NeilBrown ne...@suse.de wrote: On Thu, 14 Jun 2012 23:24:10 +0530 DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Thu, Jun 14, 2012 at 5:45 AM, NeilBrown ne...@suse.de

[PATCH 1/2] ARM: omap_hdq: Fix some error/debug handling.

2012-04-24 Thread NeilBrown
- sometimes a message is printed when there is no error, rather than when there is one. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers

[PATCH 2/2] ARM: omap_hdq: use wait_event_timeout to wait for read to complete.

2012-04-24 Thread NeilBrown
There is no gain in having a loop - there is no risk of missing the interrupt with wait_event_timeout. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b

[PATCH 0/3] Ensure twl4030 interrupts are lost during suspend.

2012-04-24 Thread NeilBrown
? --- NeilBrown (3): twl4030: enable wakeup on twl4030 IRQ. IRQ: allow check_wakeup_irqs to notice level-triggered interrupts. ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. arch/arm/mach-omap2/irq.c |1 + drivers/mfd/twl4030-irq.c |1 + kernel/irq/pm.c

[PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.

2012-04-24 Thread NeilBrown
() is called and succeeds, check_wakuep_irqs() will abort the suspend if the interrupt has fired. Signed-off-by: NeilBrown ne...@suse.de --- arch/arm/mach-omap2/irq.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 65f0d257..b0790a9

[PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-04-24 Thread NeilBrown
that it is still asserted will not cause the suspend to abort. So if any wakeup interrupt is masked, unmask it when checking wakeup irqs. If the interrupt is asserted, suspend will abort. Signed-off-by: NeilBrown ne...@suse.de --- kernel/irq/pm.c |6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ.

2012-04-24 Thread NeilBrown
it will be ignored. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl4030-irq.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 5d656e8..ad733d7 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c

[PATCH 0/6] twl4030: Various fixes for charing-from-USB

2012-04-25 Thread NeilBrown
ties ID to ground via a resistor - charge while device is suspended, or when no gadget module is loaded (i.e. when the USB side thinks the phy should be powered down). Questions and comments more welcome. Thanks, NeilBrown --- NeilBrown (6): twl4030-usb: Don't report EVENT_ID when

[PATCH 1/6] twl4030_charger: Fix some typos

2012-04-25 Thread NeilBrown
Signed-off-by: NeilBrown ne...@suse.de --- drivers/power/twl4030_charger.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c index fdad850..3e6e991 100644 --- a/drivers/power/twl4030_charger.c +++ b

[PATCH 2/6] twl4030_charger: add backup-battery charging.

2012-04-25 Thread NeilBrown
-by: NeilBrown ne...@suse.de --- drivers/power/twl4030_charger.c | 59 +++ include/linux/i2c/twl.h |2 + 2 files changed, 61 insertions(+) diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c index 3e6e991..0511610 100644

[PATCH 3/6] twl4030_charger: allow charging whenever VBUS is present.

2012-04-25 Thread NeilBrown
the charge pump provides VBUS that doesn't get reflected in HW_CONDITIONS, so we should be safe to ignore the ID pin. Signed-off-by: NeilBrown ne...@suse.de --- drivers/power/twl4030_charger.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/power/twl4030_charger.c b

[PATCH 4/6] twl4030_charger: Allow charger to control the regulator that feeds it.

2012-04-25 Thread NeilBrown
The charger needs usb3v1 to be running, so add a new consumer to keep it running. This allows the charger to draw current even when the USB driver has powered down. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl-core.c |9 + drivers/power/twl4030_charger.c

[PATCH 5/6] twl4030-usb: Don't power down phy when it is in-use by charger.

2012-04-25 Thread NeilBrown
The USB phy is used both for data transfer and to charge the battery. If the charger it active it will hold a reference to usb3v1. In that case we don't want to power-down the phy. This allows charging to continue while the device is suspended. Signed-off-by: NeilBrown ne...@suse.de

[PATCH 6/6] twl4030-usb: Don't report EVENT_ID when there is VBUS.

2012-04-25 Thread NeilBrown
in that case, ignore the fact that ID is low. This assumes that VBUS_PRES isn't asserted when the charge pump is providing VBUS. The document isn't clear on this and some experiments suggest that it isn't. Signed-off-by: NeilBrown ne...@suse.de --- drivers/usb/otg/twl4030-usb.c | 19

Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-04-25 Thread NeilBrown
On Wed, 25 Apr 2012 10:50:15 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Wed, 25 Apr 2012, NeilBrown wrote: Level triggered interrupts do not cause IRQS_PENDING to be set, so check_wakeup_irqs ignores them. They don't need to set IRQS_PENDING as the level stays high which

Re: [PATCH 6/6] twl4030-usb: Don't report EVENT_ID when there is VBUS.

2012-04-25 Thread NeilBrown
On Wed, 25 Apr 2012 11:05:27 +0300 Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Apr 25, 2012 at 05:33:11PM +1000, NeilBrown wrote: Some USB chargers tie the ID pin low via various resistors. So they can cause VBUS to be high and ID to be low. The 'A' end of an OTG cable never

Re: [PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-04-25 Thread NeilBrown
On Wed, 25 Apr 2012 14:54:54 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Wed, 25 Apr 2012, NeilBrown wrote: On Wed, 25 Apr 2012 10:50:15 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Wed, 25 Apr 2012, NeilBrown wrote: Level triggered interrupts do

Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.

2012-04-26 Thread NeilBrown
On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman khil...@ti.com wrote: NeilBrown ne...@suse.de writes: All interrupts can wake-from-sleep (I think) so it should be permissible to call enable_irq_wake(). Setting this flag allows that. It is needed because without this, an interrupt

Re: [PATCH 0/6] twl4030: Various fixes for charing-from-USB

2012-04-29 Thread NeilBrown
On Wed, 25 Apr 2012 14:31:13 +0300 Grazvydas Ignotas nota...@gmail.com wrote: On Wed, Apr 25, 2012 at 10:33 AM, NeilBrown ne...@suse.de wrote: Following are a collection of patches that I've need using for a while to make sure the charge-from-usb on my GTA04 works. Hopefully I've included

Re: [PATCH 3/6] twl4030_charger: allow charging whenever VBUS is present.

2012-04-29 Thread NeilBrown
On Wed, 25 Apr 2012 14:33:25 +0300 Grazvydas Ignotas nota...@gmail.com wrote: On Wed, Apr 25, 2012 at 10:33 AM, NeilBrown ne...@suse.de wrote: We currently refuse to charge if the USB ID pin is grounded, even though VBUS might be present. However some chargers do pull the ID pin low

Re: [PATCH 4/6] twl4030_charger: Allow charger to control the regulator that feeds it.

2012-04-30 Thread NeilBrown
if no-one else cares :-) Thanks, NeilBrown -Tero On Wed, 2012-04-25 at 17:33 +1000, NeilBrown wrote: The charger needs usb3v1 to be running, so add a new consumer to keep it running. This allows the charger to draw current even when the USB driver has powered down. Signed-off

Re: [PATCH 2/2] ARM: omap_hdq: use wait_event_timeout to wait for read to complete.

2012-05-02 Thread NeilBrown
On Wed, 2 May 2012 01:42:19 +0400 Evgeniy Polyakov z...@ioremap.net wrote: On Wed, Apr 25, 2012 at 12:41:53PM +1000, NeilBrown (ne...@suse.de) wrote: There is no gain in having a loop - there is no risk of missing the interrupt with wait_event_timeout. Signed-off-by: NeilBrown ne

[PATCH 2/4] twl4030-irq: use request_threaded_irq in place of irq_set_chained_handler.

2011-11-26 Thread NeilBrown
. Tested on GTA04 Phoenux. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl4030-irq.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 3d3d6ed..29f11e0 100644 --- a/drivers/mfd/twl4030-irq.c

[PATCH 3/4] twl4030-irq: set tertiary interrupts to be nested/threaded.

2011-11-26 Thread NeilBrown
As tertiary interrupts are handled by handle_twl4030_sih calling handle_nested_irq, they do not need their own separate irq thread. So mark them as 'nested_thread' interrupts to avoid the extra thread creation. Tested on GTA04 Pheonux. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd

[PATCH 4/4] twl4030-irq: fix typo

2011-11-26 Thread NeilBrown
overwriten - overwritten Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl4030-irq.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 3ac7216..b69bb51 100644 --- a/drivers/mfd/twl4030-irq.c +++ b

Re: [PATCH] MFD: TWL: add power off functionality

2011-12-04 Thread NeilBrown
On Sun, 04 Dec 2011 11:56:44 +0200 Igor Grinberg grinb...@compulab.co.il wrote: Hi Neil, On 12/03/11 03:35, NeilBrown wrote: On Sun, 27 Nov 2011 11:42:17 +0200 Igor Grinberg grinb...@compulab.co.il wrote: ping! pong ... Hi, I've been trying this patch out on my GTA04

Re: [PATCH] MFD: TWL: add power off functionality

2011-12-04 Thread NeilBrown
On Sun, 4 Dec 2011 21:58:59 +1100 NeilBrown ne...@suse.de wrote: On Sun, 04 Dec 2011 11:56:44 +0200 Igor Grinberg grinb...@compulab.co.il wrote: Hi Neil, On 12/03/11 03:35, NeilBrown wrote: On Sun, 27 Nov 2011 11:42:17 +0200 Igor Grinberg grinb...@compulab.co.il wrote

Re: [regression] Re: [PATCH 3/7] mfd: twl4030-irq: drop the kthread

2011-12-07 Thread NeilBrown
posted to linux-kernel on Nov 27: Subject: [PATCH 0/4] fixes for twl4030-irq in mainline and following http://lkml.org/lkml/2011/11/26/92 I think I hit exactly the same bug and you and (eventually) fix it (that was a fun learning experience). NeilBrown signature.asc Description: PGP

Commit 09d28d2c19 introduces set-after-free in arch/arm/mach-omap2/mcbsp.c

2011-12-10 Thread NeilBrown
= omap2_mcbsp1_mux_rx_clk; omap_mcbsp_count++; return 0; } which sets another field. Should these settings just be moved up before the call to omap_device_build_ss?? Doing that removes [0.196014] Slab corruption: size-32 start=ded3edc0, len=32 warning. Thanks, NeilBrown signature.asc

Should I worry about omap-mcbsp.2: alias fck already exists or is it expected?

2011-12-11 Thread NeilBrown
to add an alias 'fsck' to that same device, and the second will always give a warning. Is this actually a bug, or should we silence the warning on second and subsequent calls to omap_alloc_device()? Like this? Thanks, NeilBrown omap: don't try to register the main clock twice

Re: [PATCH 0/4] fixes for twl4030-irq in mainline

2011-12-12 Thread NeilBrown
On Mon, 12 Dec 2011 18:38:19 +0100 Samuel Ortiz sa...@linux.intel.com wrote: Hi Neil, On Sun, Nov 27, 2011 at 07:17:41AM +1100, NeilBrown wrote: Hi, The recent tidying up of twl4030-irq seems to have left it broken. At least it doesn't work for me on my gta04 (www.gta04.org

Re: problem with twl4030 GPIO irqs

2011-12-15 Thread NeilBrown
who knows irq code better look at this? I think this should reproduce on beagle too. Try this. I wrote it for a slightly different reason, but I think it applies here. NeilBrown From f7f05b87364d0316f1f6ddad0d7387b25f5d21b9 Mon Sep 17 00:00:00 2001 From: NeilBrown ne...@suse.de Date: Fri, 2

[PATCH] omap: add rcu_locking to omap2_set_init_voltage.

2011-12-29 Thread NeilBrown
opp_find_freq_ceil and opp_get_voltage are documented as requiring rcu_lock to be held. So hold it. Signed-off-by: NeilBrown ne...@suse.de diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 00bff46..470976e 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2

[PATCH] omap_hsmmc - use threaded irq handler for card-detect.

2011-12-29 Thread NeilBrown
...@gmail.com Signed-off-by: NeilBrown ne...@suse.de diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index d5fe43d..56f6cfc 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -24,7 +24,6 @@ #include linux/delay.h #include linux/dma-mapping.h

[PATCH] omap2430 musb: Make musb_otg_notification non-blocking

2011-12-29 Thread NeilBrown
This callback is on an 'atomic notificaitons' queue but is written as a blocking notifier. Convert to use a work-queue to run from non-atomic context. Signed-off-by: NeilBrown ne...@suse.de diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index b3c065a..fb90d94 100644

[PATCH] video/omap2. dispc_mgr_enable needs runtime PM

2011-12-29 Thread NeilBrown
When dispc_mgr_enable is called during shutdown the device might be asleep, which causes problems. So ensure it is awake. Signed-off-by: NeilBrown ne...@suse.de diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c index 5c81533..75a767f 100644 --- a/drivers/video

[PATCH] OMAP/I2C - Fix timeout problem during suspend.

2011-12-29 Thread NeilBrown
: [ 69.603912] musb-omap2430 musb-omap2430: EARLY power domain resume [ 70.610473] omap_i2c omap_i2c.1: controller timed out [ 70.626129] twl: i2c_write failed to transfer all messages etc. So don't disable interrupts for I2C. Signed-off-by: NeilBrown ne...@suse.de diff --git a/drivers/i2c

[PATCH 0/5] Improvements to bq27000 management on OMAP

2011-12-29 Thread NeilBrown
has changed (typically capacity but even VOLTAGE_NOW can change a little bit). Thanks, NeilBrown --- NeilBrown (5): bq27x00 - don't report power-supply change so often. omap_hdq: handle case where isr sees a 0 status byte. omap_hdq: use wait_event_timeout to wait for read

[PATCH 1/5] Fix w1_bq27000

2011-12-29 Thread NeilBrown
-off-by: NeilBrown ne...@suse.de --- drivers/w1/slaves/w1_bq27000.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c index 8f4c91f..8f10fd2 100644 --- a/drivers/w1/slaves/w1_bq27000.c +++ b

[PATCH 2/5] omap_hdq: Fix some error/debug handling.

2011-12-29 Thread NeilBrown
- some debug messages missed spaces - sometimes no error was returned when it should have been - sometimes a message is printed when there is no error, rather than when there is one. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c | 15 --- 1 files

[PATCH 3/5] omap_hdq: use wait_event_timeout to wait for read to complete.

2011-12-29 Thread NeilBrown
There is no gain in having a loop - there is no risk of missing the interrupt with wait_event_timeout. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b

[PATCH 4/5] omap_hdq: handle case where isr sees a 0 status byte.

2011-12-29 Thread NeilBrown
, intuit what must have caused the interrupt. If we were trying to write, assume it completed. If we were trying to read and go something other than 0xFF, assume the read completed. If we read 0xFF, assume the read timed-out. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c

[PATCH 5/5] bq27x00 - don't report power-supply change so often.

2011-12-29 Thread NeilBrown
A power_supply_changed should only be reported on significant changes such as transition between charging and not. Incremental changes such as charge increasing should not be reported - that can easily be polled for. Signed-off-by: NeilBrown ne...@suse.de --- drivers/power/bq27x00_battery.c

Re: [PATCH 5/5] bq27x00 - don't report power-supply change so often.

2012-01-02 Thread NeilBrown
something else. Also CCing Anton (the maintainer). On Fri, Dec 30, 2011 at 2:58 AM, NeilBrown ne...@suse.de wrote: A power_supply_changed should only be reported on significant changes such as transition between charging and not. Incremental changes such as charge increasing should

Re: [PATCH] OMAP/I2C - Fix timeout problem during suspend.

2012-01-04 Thread NeilBrown
On Wed, 04 Jan 2012 14:19:48 -0800 Kevin Hilman khil...@ti.com wrote: +Felipe NeilBrown ne...@suse.de writes: On a board with OMAP3 processor and TWL4030 Power management, we need to talk to the TWL4030 during late suspend but cannot because the I2C interrupt is disabled (as late

Re: [PATCH] video/omap2. dispc_mgr_enable needs runtime PM

2012-01-04 Thread NeilBrown
On Wed, 04 Jan 2012 09:50:56 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: (dropping the Tony and Kevin, as they're probably not interested in this) Thanks takes a while to figure who cares about what :-) On Fri, 2011-12-30 at 12:37 +1100, NeilBrown wrote: When

[PATCH] omap: add rcu_locking to omap2_set_init_voltage.

2012-01-08 Thread NeilBrown
opp_find_freq_ceil and opp_get_voltage are documented as requiring rcu_lock to be held. So hold it. Signed-off-by: NeilBrown ne...@suse.de diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 00bff46..470976e 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2

[PATCH] ARM: omap: add rcu_locking to omap2_set_init_voltage.

2012-01-08 Thread NeilBrown
opp_find_freq_ceil and opp_get_voltage are documented as requiring rcu_lock to be held. So hold it. Signed-off-by: NeilBrown ne...@suse.de -- This time with the proper ARM: prefix - sorry :-( diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 00bff46..470976e 100644

Re: DSS2/PM on 3.2 broken?

2012-01-09 Thread NeilBrown
wouldn't be at all surprised if you declined. NeilBrown signature.asc Description: PGP signature

Re: DSS2/PM on 3.2 broken?

2012-01-11 Thread NeilBrown
On Wed, 11 Jan 2012 06:43:04 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: cc Kevin On Tue, 10 Jan 2012, NeilBrown wrote: It seems that when cpuidle on an omap3 tries to switch to lower power states, various things misbehave: - UARTs lose characters Is this with off-mode enabled

Re: DSS2/PM on 3.2 broken?

2012-01-13 Thread NeilBrown
On Fri, 13 Jan 2012 03:05:03 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: cc Tero, Govindraj On Thu, 12 Jan 2012, NeilBrown wrote: On Wed, 11 Jan 2012 06:43:04 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: I spent some time exploring why cpuidle never drops below state 0

Re: DSS2/PM on 3.2 broken?

2012-01-13 Thread NeilBrown
On Fri, 13 Jan 2012 04:31:37 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Fri, 13 Jan 2012, NeilBrown wrote: Also, the HDQ access to the battery 'fuel gauge' is working fine, so presumably that gets disturbed by one of the lower power states (3,4,5). I guess it is 4,5,6 when CORE

Re: DSS2/PM on 3.2 broken?

2012-01-13 Thread NeilBrown
be something like: bits_per_byte = number of data bits + 1 bit if parity is used + number of stop bits + 1 for the start bit. NeilBrown signature.asc Description: PGP signature

Re: DSS2/PM on 3.2 broken?

2012-01-17 Thread NeilBrown
On Sat, 14 Jan 2012 10:09:15 +1100 NeilBrown ne...@suse.de wrote: On Fri, 13 Jan 2012 04:31:37 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Fri, 13 Jan 2012, NeilBrown wrote: Also, the HDQ access to the battery 'fuel gauge' is working fine, so presumably that gets disturbed

Re: DSS2/PM on 3.2 broken?

2012-01-18 Thread NeilBrown
On Wed, 18 Jan 2012 09:13:59 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-13 at 22:20 +1100, NeilBrown wrote: Having CPUIDLE makes the DSS2 problem worse: lots of [ 21.085113] omapdss DISPC error: SYNC_LOST on channel lcd, restarting the output with video

Re: DSS2/PM on 3.2 broken?

2012-01-18 Thread NeilBrown
On Wed, 18 Jan 2012 13:42:20 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-01-18 at 22:15 +1100, NeilBrown wrote: On Wed, 18 Jan 2012 09:13:59 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-13 at 22:20 +1100, NeilBrown wrote: Having CPUIDLE makes

Re: DSS2/PM on 3.2 broken?

2012-01-21 Thread NeilBrown
On Thu, 19 Jan 2012 16:22:37 -0800 Kevin Hilman khil...@ti.com wrote: NeilBrown ne...@suse.de writes: On Thu, 19 Jan 2012 11:37:39 -0800 Kevin Hilman khil...@ti.com wrote: Joe Woodward j...@terrafix.co.uk writes: [...] If I do (either from the console or via a button press

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-21 Thread NeilBrown
complaining about losing SYNC, and notice that omap_96m_fck was being enabled and disabled in hardware. omap_96m_fck is upstream for dss_96m_fck which provides the tv_dac_clk. Could it be this clock turning on and off which causes the problem? Thanks, NeilBrown signature.asc Description: PGP

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-22 Thread NeilBrown
which is the problem. I guess I could selective try denying idle on each clock domain until I find the one that is the problem.. NeilBrown signature.asc Description: PGP signature

Re: DSS2/PM on 3.2 broken?

2012-01-22 Thread NeilBrown
On Sat, 21 Jan 2012 17:07:18 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Wed, 18 Jan 2012, NeilBrown wrote: Oh - another thing. Sometimes during early boot I get: [0.158447] omap_hwmod: usbtll_fck: missing clockdomain for usbtll_fck. [0.176879] omap_hwmod: hdq

OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-24 Thread NeilBrown
On Sat, 21 Jan 2012 17:07:18 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Wed, 18 Jan 2012, NeilBrown wrote: Oh - another thing. Sometimes during early boot I get: [0.158447] omap_hwmod: usbtll_fck: missing clockdomain for usbtll_fck. [0.176879] omap_hwmod: hdq

Re: DSS2/PM on 3.2 broken?

2012-01-24 Thread NeilBrown
On Mon, 23 Jan 2012 14:11:16 -0800 Kevin Hilman khil...@ti.com wrote: NeilBrown ne...@suse.de writes: On Thu, 19 Jan 2012 16:22:37 -0800 Kevin Hilman khil...@ti.com wrote: NeilBrown ne...@suse.de writes: On Thu, 19 Jan 2012 11:37:39 -0800 Kevin Hilman khil...@ti.com wrote

Re: [PATCH] omap2430 musb: Make musb_otg_notification non-blocking

2012-01-24 Thread NeilBrown
On Tue, 24 Jan 2012 10:56:12 +0200 Felipe Balbi ba...@ti.com wrote: On Fri, Dec 30, 2011 at 12:36:28PM +1100, NeilBrown wrote: This callback is on an 'atomic notificaitons' queue but is written as a blocking notifier. Convert to use a work-queue to run from non-atomic context

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-27 Thread NeilBrown
On Thu, 26 Jan 2012 07:19:19 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Tue, 24 Jan 2012, NeilBrown wrote: On Sat, 21 Jan 2012 17:07:18 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Wed, 18 Jan 2012, NeilBrown wrote: Oh - another thing. Sometimes during

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-27 Thread NeilBrown
On Fri, 27 Jan 2012 15:58:40 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: On Sat, 28 Jan 2012, NeilBrown wrote: Here's a theory: perhaps the MPU powerdomain is hitting a low-power state while waiting for an HDQ interrupt. When the MPU powerdomain is in a low power state, so

Re: [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend

2012-01-30 Thread NeilBrown
the iclk is being turned off. Timeouts are because the interrupt is disabled or ignored. good luck, NeilBrown On Wed, Dec 7, 2011 at 9:37 PM, Kevin Hilman khil...@ti.com wrote: Felipe Balbi ba...@ti.com writes: Hi, On Mon, Nov 28, 2011 at 04:56:30PM -0800, Kevin Hilman wrote

Re: GPIO debounce problems on 3.2

2012-01-31 Thread NeilBrown
. My TRM says - in section 12.3.1.3 Power Management The MPU subsystem INTC belongs to the CORE power domain. This is: AM/DM37x Multimedia Device Silicon Revision 1.x Version N Is it wrong, are you wrong, or am I confused? Thanks, NeilBrown So neither the MPU nor

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-31 Thread NeilBrown
- the HDQ keeps working. (it's a bit smoke-and-mirrors though .. I want fclk to stay on, so let's make sure iclk doesn't autoidle, because we *know* they have the same source :-) Thanks, NeilBrown signature.asc Description: PGP signature

Re: patch tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA added to tty tree

2012-02-02 Thread NeilBrown
direction to my expectations. So there is something odd here... ideas? NeilBrown p.s. who should I formally submit OMAP-UART patches to? I have a couple of others such as the below that I should submit somewhere. diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index

Re: patch tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA added to tty tree

2012-02-03 Thread NeilBrown
On Thu, 2 Feb 2012 22:45:53 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: Hello Neil. On Fri, 3 Feb 2012, NeilBrown wrote: Can I comment??... They are good but I've tried two approaches to getting serial behaviour that I am happy with. They are with and without runtime pm

Re: patch tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 12:26:14 +0530 Govindraj govindraj...@gmail.com wrote: On Fri, Feb 3, 2012 at 9:37 AM, NeilBrown ne...@suse.de wrote: On Thu, 2 Feb 2012 13:03:01 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: Hi Greg, On Thu, 26 Jan 2012, Paul Walmsley wrote: On Thu, 26 Jan

  1   2   3   >