Hi Dmitry,
On 09/06/2012 07:19 PM, Dmitry Torokhov wrote:
In patch 6 you added a stub for of_find_node_by_name(), so do you really
need this #ifdef?
True. I'll resend the series since I left the #ifdef also in other patch.
Otherwise it looks good.
Acked-by: Dmitry Torokhov
Hi Tony,
On 09/06/2012 10:10 PM, Tony Lindgren wrote:
Hi Peter,
* Peter Ujfalusi peter.ujfal...@ti.com [120905 02:02]:
With pinctrl-single,bits it is possible to update just part of the register
within the pinctrl-single,function-mask area.
This is useful when one register configures mmore
Hi Janusz,
On 09/09/2012 10:57 PM, Janusz Krzysztofik wrote:
On Tue, 4 Sep 2012 15:08:00 Peter Ujfalusi wrote:
Enable the element mode (thus allowing mono playback and probably
unblocking
OMAP1, OMAP2420) in OMAP dmaengine and omap-pcm.
Janusz: would it be possible for you to test
This commit adds an empty of_find_node_by_name() function for !CONFIG_OF
builds.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/of.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/of.h b/include/linux/of.h
index 1b11632..5c7a158 100644
We no longer have users for the set_hs_extmute callback which has been
replaced by hs_extmute_gpio so the codec driver can handle the external
mute if it is needed by the board.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h| 2 --
sound/soc/codecs/twl4030.c
Access the pdata via a pointer within the twl4030_priv structure.
In preparation for DeviceTree support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/twl4030
Allocate the private data with devm_kzalloc.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 27ccea4..413e698 100644
When the kernel has been booted with DT blob the platform data is NULL for
the driver.
We need to construct the pdata based on the DT information for runtime use.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 55
Remove the use of set_hs_extmute callback and let the codec driver to
handle the extmute GPIO.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Acked-by: Tony Lindgren t...@atomide.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 9 ++---
arch/arm/mach-omap2/include/mach/board
Support for loading the twl4030 audio module via devicetree.
Sub devices for codec and vibra will be created as mfd devices once the
core MFD driver is loaded when the kernel is booted with a DT blob.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
.../devicetree/bindings/mfd/twl4030
, and with
the upcoming DT audio support for BeagleBoard).
Regards,
Peter
---
Peter Ujfalusi (14):
MFD: twl4030-audio: Clean up MODULE_* and platform_driver part
MFD: twl4030-audio: Convert to use devm_kzalloc
MFD: twl4030-audio: Rearange and clean-up the probe function
MFD: twl-core: Add API to query
To clean up the module probe and remove functions.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
index ac04b4f
-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 32
include/linux/i2c/twl.h | 1 +
2 files changed, 33 insertions(+)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 1c32afe..f162b68 100644
--- a/drivers/mfd/twl-core.c
Add support when the kernel has been booted with DT blob. In this case the
pdata is NULL, we need to reach up to the core node and check if the codec
part has been enabled to determine if we need to coexist with the codec or
not.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Acked
The external mute (if it is in use) is handled by a GPIO line. Prepare to
remove the set_hs_extmute callback and replace it with:
hs_extmute_gpio: the GPIO number to use for external mute
When the users of set_hs_extmute has been converted the callback can be removed.
Signed-off-by: Peter
twl-core has API to get the boot time configured HFCLK rate which has the
same rate as the audio MCLK.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd
To facilitate the device tree support the probe function need to be rearanged.
Small cleanup in the APLL frequency selection part as well.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 34 --
1 file changed, 16 insertions
Place the MODULE_* lines in the same block and add MODULE_DESCRIPTION.
Rearange the platform_driver structure at the same time.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
Hi Benoit,
On 09/10/2012 11:07 AM, Benoit Cousson wrote:
Hi Tony,
On 09/08/2012 12:29 AM, Tony Lindgren wrote:
* Peter Ujfalusi peter.ujfal...@ti.com [120905 04:59]:
+
+ ocp {
+ mcbsp1: mcbsp@48074000 {
+ compatible = ti,omap2420-mcbsp
On 09/07/2012 07:55 PM, Tony Lindgren wrote:
* Peter Ujfalusi peter.ujfal...@ti.com [120907 08:13]:
On 09/06/2012 10:10 PM, Tony Lindgren wrote:
Is it now safe to assume that we always have width of three if
pinctrl-single,bits is specified? The reason I'm asking is..
@@ -657,18 +664,29
With pinctrl-single,bits it is possible to update just part of the register
within the pinctrl-single,function-mask area.
This is useful when one register configures mmore than one pin's mux.
pinctrl-single,bits takes three parameters:
reg offset, value, sub-mask
Signed-off-by: Peter Ujfalusi
Likely grant.lik...@secretlab.ca
Cc: Omar Ramirez Luna omar.rami...@ti.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Tomi Valkeinen tomi.valkei...@ti.com
Cc: Florian Tobias Schandinat florianschandi...@gmx.de
Cc: Peter Ujfalusi peter.ujfal...@ti.com
Cc: Jarkko Nikula jarkko.nik
not broken it?
Ricardo: Can you test the omap-hmdi if it is still working?
Regards,
Peter
---
Peter Ujfalusi (11):
dmaengine: omap: Support for element mode in cyclic DMA
ASoC: omap-mcbsp: Use sDMA packet mode instead of frame mode
ASoC: omap-pcm: Select sDMA synchronization based on packet_size
omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
that it was paused (or
whether the data in the FIFO read from memory is simply
discarded.)
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
sound/soc/omap/Kconfig| 3 +-
sound/soc/omap/omap-pcm.c | 279
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/dma/omap-dma.c | 5 -
1 file changed, 4 insertions
The omap-pcm platform driver no longer needs this parameter to select
between ELEMENT and PACKET mode. The selection is based on the configured
packet_size.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 1 -
sound/soc/omap/omap-hdmi.c | 1 -
sound/soc
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
Since we only have element or packet synchronization we can use the
dma_data-packet_size to select the desired mode:
if packet_size is 0 we use ELEMENT mode
if packet_size is not 0 we use PACKET mode for sDMA synchronization.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap
When McBSP is configured in threshold mode we can use sDMA packet mode in
all cases.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcbsp.c | 47 -
1 file changed, 17 insertions(+), 30 deletions(-)
diff --git a/sound/soc
On 09/12/2012 03:00 PM, Russell King - ARM Linux wrote:
On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote:
2. Pause/Resume
OMAP DMA engine backend does not support pausing and resuming
an in-progress transfer. It is unclear from the specs what
effect clearing the enable
On 09/12/2012 03:53 PM, Peter Ujfalusi wrote:
I need to look at this, but at first look we do wait for the drain in
omap_stop_dma(). We used to use omap_stop_dma/omap_start_dma for pause/resume
operations.
But sDMA also have a bit: CDPi: PAUSE_LINK_LIST which should do what we are
looking
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hello Tony,
While rebasing my series on top of your devel-cleanup branch,
I found this compillation error.
You can pick it right away, or I can queue this within my series.
But I still waiting for Samuel's saying on the series, so it might
,
but added them as s-o-b without e-mail address.
For the McPDM driver replacement, I forced git to create a complete rewrite
patch to help with the review.
Regards,
Peter
---
Misael Lopez Cruz (1):
ASoC: omap-mcpdm: Replace legacy driver
Peter Ujfalusi (2):
OMAP: McPDM: Convert McPDM device
.
Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com
Signed-off-by: Liam Girdwood l...@ti.com
Signed-off-by: Sebastien Guiriec s-guir...@ti.com
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/Makefile |2 +-
sound/soc/omap/mcpdm.c | 470
McPDM device is converted to omap device.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Jorge Eduardo Candelaria
Signed-off-by: Margarita Olaya Cabrera
Signed-off-by: Liam Girdwood l...@ti.com
Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com
---
arch/arm/mach-omap2
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Jorge Eduardo Candelaria
Signed-off-by: Margarita Olaya Cabrera
Signed-off-by: Liam Girdwood l...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch
From: Misael Lopez Cruz misael.lo...@ti.com
---
drivers/input/misc/twl6040-vibra.c | 57 ---
1 files changed, 26 insertions(+), 31 deletions(-)
diff --git a/drivers/input/misc/twl6040-vibra.c
b/drivers/input/misc/twl6040-vibra.c
index fb46bf4..2612019 100644
From: Misael Lopez Cruz misael.lo...@ti.com
TWL6040 IC provides analog high-end audio codec functions for
handset applications. It contains several audio analog inputs
and outputs as well as vibrator support. It's connected to the
host processor via PDM interface for audio data communication.
The
From: Misael Lopez Cruz misael.lo...@ti.com
Add twl6040_vibra as a child of MFD device twl6040_codec. This
implementation covers the PCM-to-PWM mode of TWL6040 vibrator
module.
Signed-off-by: Jorge Eduardo Candelaria jorge.candela...@ti.com
Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com
From: Misael Lopez Cruz misael.lo...@ti.com
Convert TWL6040 CODEC driver into a TWL6040 MFD child, it implies
that MFD-level operations like register accesses, clock setting
and power management are done through MFD APIs, not directly by
CODEC driver anymore. To avoid conflicts with the other MFD
From: Misael Lopez Cruz misael.lo...@ti.com
Squash with input: Add initial support for TWL6040 vibrator.
---
drivers/input/misc/twl6040-vibra.c | 165
include/linux/i2c/twl.h|7 ++
2 files changed, 154 insertions(+), 18 deletions(-)
diff
From: Misael Lopez Cruz misael.lo...@ti.com
Blaze/SDP4430 contains two 10-Ohms vibrator motors, both supplied
by VBAT_PROC (3.75V).
Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com
---
arch/arm/mach-omap2/board-4430sdp.c | 37 ++-
1 files changed, 36
/alsa-devel/2011-July/041687.html
Br,
Peter
---
Peter Ujfalusi (4):
OMAP: McPDM: Convert McPDM device to omap_device
OMAP4: hwmod: enable mcpdm hwmod device.
ASoC: omap-mcpdm: Fix threshold and dma configuration
ASoC: OMAP4: McPDM: Convert to hwmod/omap_device
arch/arm/mach-omap2/devices.c
McPDM device is converted to omap device.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Jorge Eduardo Candelaria
Signed-off-by: Margarita Olaya Cabrera
Signed-off-by: Liam Girdwood l...@ti.com
Signed-off-by: Misael Lopez Cruz misael.lo...@ti.com
Acked-by: Mark Brown broo
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Signed-off-by: Jorge Eduardo Candelaria
Signed-off-by: Margarita Olaya Cabrera
Signed-off-by: Liam Girdwood l...@ti.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Benoit Cousson b-cous...@ti.com
---
arch/arm/mach-omap2
-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 17 -
1 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c
index bed09c2..7727de0 100644
--- a/sound/soc/omap/omap-mcpdm.c
+++ b/sound
-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/mcpdm.c | 38 +-
sound/soc/omap/mcpdm.h |1 -
sound/soc/omap/omap-mcpdm.c |2 +-
sound/soc/omap/sdp4430.c|2 +-
4 files changed, 23 insertions(+), 20 deletions(-)
diff --git
to
`omap4430_phy_suspend'
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Hi Russel, Tony,
This patch fixes the linking error caused by the twl-common.c file,
when the kernel is built for OMAP2/3/4 only.
Regards,
Peter
---
arch/arm/mach-omap2/twl-common.c | 78
Use the device name and driver_data to identify
the TPA model supported by the driver.
Board files should use either tpa6130a2 or
tpa6140a2 as device name to specify the model
in used on the specific board.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/tpa6130a2.c
Hello,
Small cleanup for the tpa6130a2 driver for model handling:
Remove the model_id from platform_data, and use the device name/device_data
to distinguish between the supported models of TPA.
Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: tpa6130a2: Model support cleanup
OMAP: RX51: No need
The TPA driver now uses the name for model support.
n900 has tpa61030a2 model of TPA.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/board-rx51-peripherals.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51
The model_id is no longer needed within the platform_data
for the TPA driver since the model of TPA specified
with the device name (tpa6130a2/tpa6140a2).
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/sound/tpa6130a2-plat.h |6 --
sound/soc/codecs/tpa6130a2.c |5
On 09/13/2012 09:52 AM, Linus Walleij wrote:
On Wed, Sep 12, 2012 at 10:27 PM, Tony Lindgren t...@atomide.com wrote:
* Peter Ujfalusi peter.ujfal...@ti.com [120911 01:54]:
With pinctrl-single,bits it is possible to update just part of the register
within the pinctrl-single,function-mask area
On 09/13/2012 11:11 AM, Mark Brown wrote:
On Wed, Sep 12, 2012 at 02:46:56PM +0300, Peter Ujfalusi wrote:
Hello,
This series will switch the OMAP audio to use dmaengine.
The final patch which does the switch was based on Russell King's earlier
patch.
I'm fine with this from the ASoC side
The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA.
This method has been used for years on OMAP based products.
We only allow pause/resume when the DMA has been configured in cyclic mode
which is used by the audio stack.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation to disable all audio
related interrupts.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Nicolas Ferre
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
Original author: Russell King rmk+ker...@arm.linux.org.uk
Switch the omap-pcm to use dmaengine.
Certain features are not supported by after dmaengine conversion:
1. No period wakeup mode
DMA engine has no way to communicate this information through
standard channels.
Signed-off-by: Peter
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap
The patches has been generated against:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7
Janusz: Can you retest this series on OMAP1 to be sure I have not broken it?
Ricardo: Can you test the omap-hmdi if it is still working?
Regards,
Peter
---
Peter Ujfalusi (15):
dmaengine
When McBSP is configured in threshold mode we can use sDMA packet mode in
all cases.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcbsp.c | 47 -
1 file changed, 17 insertions(+), 30 deletions(-)
diff --git a/sound/soc
The omap-pcm platform driver no longer needs this parameter to select
between ELEMENT and PACKET mode. The selection is based on the configured
packet_size.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 1 -
sound/soc/omap/omap-hdmi.c | 1 -
sound/soc
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 27 +++
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc
Since we only have element or packet synchronization we can use the
dma_data-packet_size to select the desired mode:
if packet_size is 0 we use ELEMENT mode
if packet_size is not 0 we use PACKET mode for sDMA synchronization.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap
When requested disable all DMA interrupts for the channel. In this mode
user space does not expect periodic reports from kernel about the progress
of the audio stream - PulseAudio for example support this type of mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker
patch will change
the device_prep_dma_cyclic() callback parameters to pass this information
towards the dma drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Lars-Peter Clausen l...@metafoo.de
---
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 3 ++-
2 files
On 09/14/2012 06:24 AM, Vinod Koul wrote:
On Thu, 2012-09-13 at 16:37 +0300, Peter Ujfalusi wrote:
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation to disable
Hi,
On 09/13/2012 06:27 PM, Lars-Peter Clausen wrote:
On 09/13/2012 03:37 PM, Peter Ujfalusi wrote:
The dmaengine_prep_dma_cyclic() function primarily used by audio for cyclic
transfer required by ALSA.
With this new parameter it is going to be possible to enable
On 09/13/2012 06:38 PM, Russell King - ARM Linux wrote:
On Thu, Sep 13, 2012 at 05:27:09PM +0200, Lars-Peter Clausen wrote:
Hm... Do you think it would work as well if we implement this by setting the
callback for the descriptor to NULL? If the callback is NULL there is
nothing to at the end
On 09/14/2012 06:26 AM, Vinod Koul wrote:
On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote:
Hi,
Hm... Do you think it would work as well if we implement this by
setting the
callback for the descriptor to NULL? If the callback is NULL there is
nothing to at the end of a
Hi,
On 09/14/2012 11:50 AM, Vinod Koul wrote:
Well, the idea was that the driver would disable interrupts if there is no
callback to call, since there would be nothing to do in the interrupt
handler anyway. But I guess the flags approach should work fine as well.
Yes we _could_ do that, but
When McBSP is configured in threshold mode we can use sDMA packet mode in
all cases.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcbsp.c | 47 -
1 file changed, 17 insertions(+), 30 deletions(-)
diff --git a/sound/soc
Original author: Russell King rmk+ker...@arm.linux.org.uk
Switch the omap-pcm to use dmaengine.
Certain features are not supported by after dmaengine conversion:
1. No period wakeup mode
DMA engine has no way to communicate this information through
standard channels.
Signed-off-by: Peter
omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
When requested (DMA_PREP_INTERRUPT is cleared in flags) disable all DMA
interrupts for the channel. In this mode user space does not expect
periodic reports from kernel about the progress of the audio stream.
PulseAudio for example support this type of mode.
Signed-off-by: Peter Ujfalusi
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 27 +++
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
not broken it?
Ricardo: Can you test the omap-hmdi if it is still working?
Regards,
Peter
---
Peter Ujfalusi (15):
dmaengine: omap: Support for element mode in cyclic DMA
dmaengine: omap: Add support for pause/resume in cyclic dma mode
dmaengine: Add flags parameter
The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA.
This method has been used for years on OMAP based products.
We only allow pause/resume when the DMA has been configured in cyclic mode
which is used by the audio stack.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the flags coming from clients.
This feature can be used during audio operation to disable all audio
related interrupts when the DMA_PREP_INTERRUPT is cleared from the flags.
Signed-off-by: Peter Ujfalusi
(if DMA_PREP_INTERRUPT is cleared) when it is supported
on the platform.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Lars-Peter Clausen l...@metafoo.de
---
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 6 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff
The omap-pcm platform driver no longer needs this parameter to select
between ELEMENT and PACKET mode. The selection is based on the configured
packet_size.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 1 -
sound/soc/omap/omap-hdmi.c | 1 -
sound/soc
Since we only have element or packet synchronization we can use the
dma_data-packet_size to select the desired mode:
if packet_size is 0 we use ELEMENT mode
if packet_size is not 0 we use PACKET mode for sDMA synchronization.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap
-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hello Mike,
This driver is going to be used by the OMAP McPDM driver when we moved to common
clock framework.
To avoid merge conflicts I'm going to send the patch needed for the twl6040 MFD
core driver to register the platform device for the clk driver
On 09/17/2012 09:34 AM, Shawn Guo wrote:
On Thu, Sep 13, 2012 at 04:37:54PM +0300, Peter Ujfalusi wrote:
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation
Hi Vinod,
On 09/17/2012 06:13 AM, Vinod Koul wrote:
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote:
- /* FIXME: not supported by platform private API */
- return -EINVAL;
+ /* Pause/Resume only allowed with cyclic mode */
+ if (!c-cyclic
Hi Vinod,
On 09/17/2012 06:17 AM, Vinod Koul wrote:
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote:
Hello,
dmaengine parts look good to me. How do you want to get this merged,
dmaengine or ASoC tree?
Thank you, I would prefer it to go via ASoC if it is not a problem
401 - 500 of 1965 matches
Mail list logo
