Re: [PATCH v6] OMAP4 HSMMC: Adding Card detect support for MMC1 on OMAP4

2010-08-05 Thread kishore kadiyala
Madhu, On Thu, Aug 5, 2010 at 4:26 AM, Madhusudhan madhu...@ti.com wrote: snip  arch/arm/mach-omap2/board-4430sdp.c |    7 +++-  drivers/mfd/twl6030-irq.c           |   76 +++  drivers/mmc/host/omap_hsmmc.c       |    4 +-  include/linux/i2c/twl.h  

Re: [PATCH v3 9/9] omap: zoom: add mmc3/wl1271 device support

2010-08-11 Thread kishore kadiyala
Ohad, On Wed, Aug 11, 2010 at 9:08 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com wrote: +               .ocr_mask       = MMC_VDD_165_195, Do we really need to specify ocr_mask here? Since you specified the voltage source

Re: [PATCH v3 9/9] omap: zoom: add mmc3/wl1271 device support

2010-08-11 Thread kishore kadiyala
Oops didn't notice ,,, Thanks, Kishore On Thu, Aug 12, 2010 at 1:42 AM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Kishore, On Wed, Aug 11, 2010 at 11:09 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Since you specified the voltage source is fixed, and if MMC3 has any dedicated

[pm-wip/mmc][PATCH 00/10] OMAP MMC Hwmod Runtime patches

2010-08-20 Thread kishore kadiyala
on OMAP4430 SDP with omap3_defconfig Currently working on runtime for MMC and will update later. Kishore Kadiyala (7): [PM-WIP-MMC] OMAP2 HWMOD: Updating MMC Controller data [PM-WIP-MMC] OMAP3 HWMOD: Updating MMC controller data [PM-WIP-MMC] OMAP2/OMAP3: Updating hwmod name for MMC controller

[PATCH 01/10] [PM-WIP-MMC] OMAP2 HWMOD: Updating MMC Controller data

2010-08-20 Thread kishore kadiyala
Updating OMAP2 hwmod data file with correct register offsets for MMC controllers. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c |5 +++-- 1 files changed

[PATCH 02/10] [PM-WIP-MMC] OMAP3 HWMOD: Updating MMC controller data

2010-08-20 Thread kishore kadiyala
Updating OMAP3 hwmod data file with correct register offsets for MMC controllers. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |5 +++-- 1 files changed

[PATCH 03/10] [PM-WIP-MMC] OMAP2/OMAP3: Updating hwmod name for MMC controller

2010-08-20 Thread kishore kadiyala
Updating oh_name for MMC controller with mmcx instead of mmcx_hwmod. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2

[PATCH 04/10] [PM-WIP-MMC] OMAP4 hwmod: Adding hwmod data for MMC controller

2010-08-20 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Adding hwmod data for 5 MMC controllers on OMAP4. Cc: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 320

[PATCH 05/10] [PM-WIP-MMC] OMAP4 hwmod: Updating hwmod data for MMC controllers

2010-08-20 Thread kishore kadiyala
Update register offsets and dev attributes for MMC controllers on OMAP4 Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 17 +++-- 1 files

Subject: [PATCH 06/10] [PM-WIP-UART] OMAP4 hwmod : Adding hwmod data for UART

2010-08-20 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Adding HWMOD data for UART on OMAP4 Cc: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 234

[PATCH 09/10] [PM-WIP-MMC] OMAP MMC : Fix crash with CONFIG_PM_RUNTIME

2010-08-20 Thread kishore kadiyala
Crash if enabled CONFIG_PM_RUNTIME and power_saving set. Use get_sync/put_sync properly so that host-nesting_cnt gets updated properly. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- drivers/mmc/host

[PATCH 10/10] [PM-WIP-MMC] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-08-20 Thread kishore kadiyala
-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 9447644..3a0dafd 100644

Re: Subject: [PATCH 06/10] [PM-WIP-UART] OMAP4 hwmod : Adding hwmod data for UART

2010-08-20 Thread kishore kadiyala
Please ignore , will send with proper subject Regards, Kishore From: Benoit Cousson b-cous...@ti.com Adding HWMOD data for UART on OMAP4 Cc: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com

[PATCH 06/10] [PM-WIP-UART] OMAP4 hwmod : Adding hwmod data for UART

2010-08-20 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Adding HWMOD data for UART on OMAP4 Cc: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 234

Re: [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning

2010-08-27 Thread kishore kadiyala
Hi Manju, Patch already posted here : https://patchwork.kernel.org/patch/118871/ Regards, Kishore On Fri, Aug 27, 2010 at 2:26 AM, G, Manjunath Kondaiah manj...@ti.com wrote: From: Manjunatha GK manj...@ti.com Fixes warning due to unused variable. drivers/mmc/host/omap_hsmmc.c: In function

Re: [pm-wip/mmc][PATCH 00/10] OMAP MMC Hwmod Runtime patches

2010-08-27 Thread kishore kadiyala
Thanks Kevin, I will take up things for MMC from here. Currently working on runtime for MMC and post out once done. Regards, Kishore On Fri, Aug 27, 2010 at 4:47 AM, Kevin Hilman khil...@deeprootsystems.com wrote: kishore kadiyala kishore.kadiy...@ti.com writes: Hi, 1) The patch series has

Re: [PATCH 08/10] [PM-WIP-MMC] OMAP MMC: Register offset handling

2010-08-27 Thread kishore kadiyala
On Fri, Aug 27, 2010 at 4:52 AM, Kevin Hilman khil...@deeprootsystems.com wrote: kishore kadiyala kishore.kadiy...@ti.com writes: Since OMAP4 has added new set of registers , this patch adds different array's for OMAP3 and OMAP4 and choose the right one during run time.Newly added registers

Re: [PATCH 09/10] [PM-WIP-MMC] OMAP MMC : Fix crash with CONFIG_PM_RUNTIME

2010-08-27 Thread kishore kadiyala
On Fri, Aug 27, 2010 at 4:53 AM, Kevin Hilman khil...@deeprootsystems.com wrote: kishore kadiyala kishore.kadiy...@ti.com writes: Crash if enabled CONFIG_PM_RUNTIME and power_saving set. Use get_sync/put_sync properly so that host-nesting_cnt gets updated properly. blushThis one is my

Re: [PATCH 10/10] [PM-WIP-MMC] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-08-27 Thread kishore kadiyala
On Fri, Aug 27, 2010 at 4:54 AM, Kevin Hilman khil...@deeprootsystems.com wrote: kishore kadiyala kishore.kadiy...@ti.com writes: From: Benoit Cousson b-cous...@ti.com Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Adrian Hunter

Re: [PATCH 05/10] [PM-WIP-MMC] OMAP4 hwmod: Updating hwmod data for MMC controllers

2010-08-27 Thread kishore kadiyala
Benoit, On Mon, Aug 23, 2010 at 1:30 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore, On 8/20/2010 10:10 PM, Kadiyala, Kishore wrote: Update register offsets and dev attributes for MMC controllers on OMAP4 Cc: Kevin Hilmankhil...@deeprootsystems.com Cc: Benoit

[PATCH 1/3] omap4 hsmmc : Adding card detect support for MMC1

2010-08-30 Thread kishore kadiyala
detect call back function provides card present/absent status by reading MMC Control register. Cc: Tony Lindgren t...@atomide.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Kishore Kadiyala kishore.kadiy

[PATCH 0/3] OMAP hsmmc : card detect and Register offset handling

2010-08-30 Thread kishore kadiyala
Hi, The patch series includes : adding carddetect feature for MMC1 controller on OMAP4 and register offset handling for OMAP3 OMAP4 and followed by a fix when CONFIG_MMC_OMAP_HS not selected for OMAP4. Patch series has been tested on OMAP3430SDP and OMAP4430SDP Kishore Kadiyala (2): omap4

[PATCH 2/3] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-08-30 Thread kishore kadiyala
Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Cc: Tony Lindgren t...@atomide.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala

[PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-08-30 Thread kishore kadiyala
. Cc: Tony Lindgren t...@atomide.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c | 30 +++-- arch/arm/mach-omap2

Re: [PATCH 1/3] omap4 hsmmc : Adding card detect support for MMC1

2010-08-31 Thread kishore kadiyala
Oops my fault will correct it and repost ... Regards, Kishore On Tue, Aug 31, 2010 at 11:25 AM, Matt Fleming m...@console-pimps.org wrote: On Mon, Aug 30, 2010 at 11:18:23PM +0530, kishore kadiyala wrote: Adding card detect callback function and card detect configuration function

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-01 Thread kishore kadiyala
On Wed, Sep 1, 2010 at 5:56 PM, Adrian Hunter adrian.hun...@nokia.com wrote: kishore kadiyala wrote: OMAP4 not only have newly added hsmmc registers but also have registers which were there in OMAP3 and which doesn't have a common offset deviation compared to OMAP3. For generic handling

Re: [PATCH 3/3] omap3/omap4 hsmmc: Register offset handling

2010-09-06 Thread kishore kadiyala
Hi Benoit, On Fri, Sep 3, 2010 at 1:51 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Benoit snip +               while (!(omap_readl(base + reg_off)                          MMCHS_SYSSTATUS_RESETDONE))                         cpu_relax(); Why does that series not seems

Re: [PATCH 6/7] omap4: Workaround for CMD line reset.

2010-09-14 Thread kishore kadiyala
Hi Madhu, On Thu, Sep 9, 2010 at 4:53 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: From: Madhusudhan Chikkature madhu...@ti.com Add a delay after CMD line reset to accomdate the reset to complete. The SYSCTL seems to reflect SRC immediately which might not really be indicating the

[PATCH v2 0/4] OMAP4 hsmmc :card detect and Register offset handling

2010-09-18 Thread kishore kadiyala
Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit Cousson (1); omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set arch/arm/mach-omap2/board-4430sdp.c

[PATCH v2 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-18 Thread kishore kadiyala
detect call back function provides card present/absent status by reading MMC Control register. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |7 +++- drivers/mfd/twl6030-irq.c | 76 +++ drivers/mmc/host

[PATCH v2 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-18 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files changed, 7 insertions(+), 1

[PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-18 Thread kishore kadiyala
should be updated in the hsmmc driver. The omap-mmc platform data is updated with a register offset which will be updated and used in the driver accordingly. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2

[PATCH v2 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-18 Thread kishore kadiyala
, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when turned ON. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |1

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-21 Thread kishore kadiyala
Hi Benoit, On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: The offset handling implementation of omap4 mmc registers which was already present can't be reused once hwmod modifications are done for mmc

Re: [PATCH v2 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
Hi balbi, On Wed, Sep 22, 2010 at 2:21 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Sat, Sep 18, 2010 at 11:33:56AM -0500, kishore kadiyala wrote: @@ -223,6 +224,81 @@ int twl6030_interrupt_mask(u8 bit_mask, u8 offset) } EXPORT_SYMBOL(twl6030_interrupt_mask); +int

[PATCH v3 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-22 Thread kishore kadiyala
-archive.com/linux-omap@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit Cousson (1); omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

[PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
to the probe thus making it generic for both OMAP3 OMAP4. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |7 +++- drivers/mfd/twl6030-irq.c | 72 +++ drivers/mmc/host/omap_hsmmc.c |4

[PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-22 Thread kishore kadiyala
From: Benoit Cousson b-cous...@ti.com Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files changed, 7 insertions(+), 1

[PATCH v3 3/4] omap4 hsmmc: Register offset handling

2010-09-22 Thread kishore kadiyala
implementation as well as once the driver undergoes hwmod adaptation. Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |8 +++- arch/arm/mach-omap2/hsmmc.c

[PATCH v3 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-22 Thread kishore kadiyala
register, eMMC will not get detected. Thus the platform data for MMC2 is updated with ocr mask and same will be communicated to core which will set the regulator to always operate at 3V when ever turned ON. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board

Re: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-22 Thread kishore kadiyala
Hi Hari, On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari h-kanige...@ti.com wrote: Kishore, +int twl6030_mmc_card_detect(struct device *dev, int slot) +{ +     int ret = -EIO; +     u8 read_reg = 0; +     struct platform_device *pdev = to_platform_device(dev); + +     switch (pdev-id) {

Re: [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-24 Thread kishore kadiyala
On Wed, Sep 22, 2010 at 11:35 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. kishore kadiyala wrote: From: Benoit Cousson b-cous...@ti.com Avoid possible crash if CONFIG_MMC_OMAP_HS is not set Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala

Re: [PATCH v3 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread kishore kadiyala
Hi Hari, On Thu, Sep 23, 2010 at 11:22 AM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Hari, On Thu, Sep 23, 2010 at 1:19 AM, Kanigeri, Hari h-kanige...@ti.com wrote: Kishore, +int twl6030_mmc_card_detect(struct device *dev, int slot) +{ +     int ret = -EIO; +     u8

[PATCH v4 0/4] omap4 hsmmc: Card detect and Register offset handling

2010-09-24 Thread kishore kadiyala
-archive.com/linux-omap@vger.kernel.org/msg35135.html V1: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg34040.html Kishore Kadiyala (3): omap4 hsmmc : Adding card detect support for MMC1 omap4 hsmmc: Register offset handling omap4 hsmmc: Update ocr mask for MMC2 for regulator to use Benoit

[PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-24 Thread kishore kadiyala
to the probe thus making it generic for both OMAP3 OMAP4. Cc: Tony Lindgren t...@atomide.com Cc: Andrew Morton a...@linux-foundation.org Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach

[PATCH v4 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set

2010-09-24 Thread kishore kadiyala
...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index a49f285..7978a79 100644 --- a/arch

[PATCH v4 4/4] omap4 hsmmc: Update ocr mask for MMC2 for regulator to use

2010-09-24 Thread kishore kadiyala
Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |1 + drivers/mmc/host/omap_hsmmc.c | 12 2 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH v4 3/4] omap4 hsmmc: Register offset handling

2010-09-24 Thread kishore kadiyala
in for current implementation as well as once the driver undergoes hwmod adaptation. Cc: Tony Lindgren t...@atomide.com Cc: Andrew Morton a...@linux-foundation.org Cc: Madhusudhan Chikkature madhu...@ti.com Cc: Adrian Hunter adrian.hun...@nokia.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Tony, On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100924 10:05]: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Cc: Samuel Ortiz sa...@linux.intel.com On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala kishore.kadiy...@ti.com wrote: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial configuration

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-28 Thread kishore kadiyala
Hi Samuel, Could you please review this patch which touches mfd/twl6030-irq.c for card detect support of MMC1 controller on OMAP4. Regards, Kishore On Mon, Sep 27, 2010 at 1:25 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Cc: Samuel Ortiz sa...@linux.intel.com On Fri, Sep 24, 2010

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-29 Thread kishore kadiyala
Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Samuel, Could you please review this patch which touches mfd/twl6030-irq.c for card detect support of MMC1 controller on OMAP4. Regards, Kishore On Mon, Sep 27

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Ping !! On Wed, Sep 29, 2010 at 4:11 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Gentle Reminder ! Regards, Kishore On Tue, Sep 28, 2010 at 12:22 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi Samuel, Could you please review this patch which touches mfd/twl6030

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
Samuel, Sorry , I will ensure to CC you for MFD related changes in future. Regards, Kishore On Fri, Oct 1, 2010 at 4:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Fri, Oct 01, 2010 at 12:29:48PM +0530, kishore kadiyala wrote: Ping !! Applied !! BTW, please add the full patch when you

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-10-01 Thread kishore kadiyala
On Fri, Oct 1, 2010 at 8:11 PM, Varadarajan, Charulatha ch...@ti.com wrote: snip diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h index 6de90bf..e64894c 100644 --- a/include/linux/i2c/twl.h +++ b/include/linux/i2c/twl.h @@ -141,6 +141,16 @@  #define

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-10-01 Thread kishore kadiyala
will be updated and used in the driver accordingly. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  arch/arm/mach-omap2/devices.c         |    8 +++-  arch/arm/mach-omap2/hsmmc.c           |    4  arch/arm/plat-omap/include/plat/mmc.h |    3 +++  drivers/mmc/host

omap4: hsmmc: Fix improper card detection while booting

2010-11-15 Thread kishore kadiyala
the issue. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Acked-by: Felipie Balbi ba...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Chris Ball c...@laptop.org Cc: Madhusudhan Chikkature madhu...@ti.com --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 0/4] omap4: hsmmc: Adding ADMA support

2011-01-18 Thread Kishore Kadiyala
on OMAP4430SDP OMAP3430SDP. Kishore Kadiyala (4): omap: hsmmc: Rename use_dma to xfer_type and define possible transfers omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup omap4: hsmmc: Adding ADMA support for MMC1 MMC2 controllers omap4: hsmmc: enable ADMA for MMC1 MMC2 arch/arm/mach

[PATCH 1/4] omap: hsmmc: Rename use_dma to xfer_type and define possible transfers

2011-01-18 Thread Kishore Kadiyala
OMAP4 introduces dedicated internal DMA which is ADMA for its MMC controllers HSMMC1 HSMMC2. Renaming use_dma member of the struct omap_hsmmc_host to xfer_type and defining the transfer modes PIO/SDMA/ADMA that can be used by the MMC controller. Signed-off-by: Kishore Kadiyala kishore.kadiy

[PATCH 2/4] omap: hsmmc: Rename and cleanup omap_hsmmc_dma_cleanup

2011-01-18 Thread Kishore Kadiyala
Renaming omap_hsmmc_dma_cleanup as omap_hsmmc_xfer_cleanup and doing some cleanup by handling the error success scenarios during a transfer for different xfer_type. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com --- drivers/mmc/host

[PATCH 3/4] omap4: hsmmc: Adding ADMA support for MMC1 MMC2 controllers

2011-01-18 Thread Kishore Kadiyala
[based on attributes]. Base address of Descriptor table in stored in MMCHS_ADMASAL register. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com

[PATCH 4/4] omap4: hsmmc: enable ADMA for MMC1 MMC2

2011-01-18 Thread Kishore Kadiyala
Enable ADMA support for MMC1 MMC2 controller on omap4 by updating features of struct omap_mmc_platform_data. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Reviewed-by: Sukumar Ghorai s-gho...@ti.com --- arch/arm/mach-omap2/hsmmc.c | 13

Re: [PATCH] omap3: nand: bch ecc support added

2011-01-21 Thread Kishore Kadiyala
Ghorai, snip  #ifdef CONFIG_MTD_PARTITIONS diff --git a/drivers/mtd/nand/omap_bch_decoder.c b/drivers/mtd/nand/omap_bch_decoder.c new file mode 100644 index 000..da42bda --- /dev/null +++ b/drivers/mtd/nand/omap_bch_decoder.c @@ -0,0 +1,393 @@ +/* + *

[PATCH 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-02 Thread Kishore Kadiyala
. Currently omap2_hsmmc_init call is missing in the board files, but updating it is not helping though. Investigation is under progress and any pointers on working version of MMC/SD on OMAP2420/2430 SDP would be helpful. Kishore Kadiyala (2): OMAP2420: hwmod data: Add HSMMC OMAP: devices: Modify

[PATCH 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 88

[PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-02 Thread Kishore Kadiyala
attribute. 4) Update the driver to use dev_attr to find whether controller supports dual volt cards. 5) Moving omap_mmc_add api from plat-omap/devices.c to mach-omap1/devices.c Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
From: Benoit Cousson b-cous...@ti.com Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339

[PATCH 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-02 Thread Kishore Kadiyala
-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 files changed, 155 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c index 8ecfbcd..1fbc5c4

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-04 Thread Kishore Kadiyala
Manju, Line wrapped, looks like your .muttrc needs to be configured for 80 characters limit. Regards, Kishore On Fri, Feb 4, 2011 at 7:02 PM, G, Manjunath Kondaiah manj...@ti.com wrote: On Thu, Feb 03, 2011 at 09:19:53AM -0800, Dmitry Torokhov wrote: On Thu, Feb 03, 2011 at 08:54:05AM -0800,

[PATCH v2 2/5] OMAP2430: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 155 1 files changed, 155 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c index 8ecfbcd..166391d

[PATCH v2 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-08 Thread Kishore Kadiyala
attribute. 4) Update the driver to use dev_attr to find whether controller supports dual volt cards. 5) Moving omap_mmc_add api from plat-omap/devices.c to mach-omap1/devices.c Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH v2 1/5] OMAP2420: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
Update the omap2420 hwmod data with the HSMMC info. Add a device attribute structure which will be used by the host driver to find whether the HSMMC controller supports DUAL VOLT cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 80

[PATCH v2 3/5] OMAP3: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Paul Walmsley p...@pwsan.com Update the omap3 hwmod data with the HSMMC info. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Rajendra Nayak rna...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch

[PATCH v2 4/5] OMAP4: hwmod data: Add HSMMC

2011-02-08 Thread Kishore Kadiyala
From: Benoit Cousson b-cous...@ti.com Update the omap4 hwmod data with the HSMMC info. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 339 1 files changed, 339

[PATCH v2 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-08 Thread Kishore Kadiyala
, the patch series has dependency on https://patchwork.kernel.org/patch/538301/ Testing on N8x0 is pending due to unavailability of working ones. Will be thankful if some body test this series on N8x0. V1: --- http://www.spinics.net/lists/linux-mmc/msg05689.html Kishore Kadiyala (2): OMAP2420

Re: [PATCH] OMAP2: add regulator for MMC1

2011-02-08 Thread Kishore Kadiyala
On Mon, Feb 7, 2011 at 9:38 PM, Balaji T K balaj...@ti.com wrote: Add regulator VMMC1 used by SD/MMC card slot1 in 2430sdp. Signed-off-by: Balaji T K balaj...@ti.com Tested-by: Kishore Kadiyala kishore.kadiy...@ti.com Regards, Kishore --- Tested on OMAP2430 SDP with busybox filesystem

[PATCH] OMAP: Fix for bus width which improves SD card's peformance.

2010-02-11 Thread kishore kadiyala
the issue and improves the performance of SD cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- Here are my experiment numbers, on a Class 6 SDHC card: Read peformance is increased by 220% Write Performance is increased by 52% drivers/mmc/host/omap_hsmmc.c |2 +- 1 files

Re: MMC not working on 3430SDP

2009-02-03 Thread kishore kadiyala
Hi , On 3430 SDP , the MMC card insertion and removal is not working on the linux -omap tree ! It seems like interrupts are not getting triggered on Card insertion removal ! I wonder if it has to do something with GPIO library ! Also whether the GPIO library takes care of the requests to

Re: MMC not working on 3430SDP

2009-02-03 Thread kishore kadiyala
Hi , On 3430 SDP , the MMC card insertion and removal is not working on the linux -omap tree ! It seems like interrupts are not getting triggered on Card insertion removal ! I wonder if it has to do something with GPIO library ! Also whether the GPIO library takes care of the requests to

Re: [PATCH]omap hsmmc: fix incorrect capability reporting

2010-03-30 Thread kishore kadiyala
please drop this patch , as correct patch is available at https://patchwork.kernel.org/patch/78713/ Regards, Kishore On Wed, Mar 31, 2010 at 12:12 AM, Venkatraman S svenk...@ti.com wrote: Nishanth Menon n...@ti.com wrote: S, Venkatraman had written, on 03/30/2010 01:11 PM, the following: [..]

[PATCH-V2] OMAP: Fix for bus width which improves SD card's peformance.

2010-03-31 Thread kishore kadiyala
the issue and improves the performance of SD cards. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com Signed-off-by: Venkatraman S svenk...@ti.com Acked-by: Madhusudhan Chikkature madhu...@ti.com --- In V2 : Appended Signed-off by Venkat and Ack by Madhu Here are my experiment numbers

Re: [PATCH-V2] OMAP: Fix for bus width which improves SD card's peformance.

2010-03-31 Thread kishore kadiyala
Sorry for that and here's the Updated one. From: Kishore Kadiyala kishore.kadiy...@ti.com This patch improves low speeds for SD cards. OMAP-MMC controller's can support maximum bus width of '8'. when bus width is mentioned as 8 in controller data,the SD stack will check whether bus width is 4

[RFC] OMAP4-hsmmc: card-detect/regulator changes

2010-03-31 Thread kishore kadiyala
Hi, I am trying to implement card-detect and regulator changes for HSMMC driver on OMAP4. In OMAP4, hsmmc doesn't use any gpio line for card detect and instead uses interrupt line from TWL6030 which also provides a register for status[Inserted/removed] of the removable Card. Currently all the

Re: [RFC] OMAP4-hsmmc: card-detect/regulator changes

2010-03-31 Thread kishore kadiyala
Small correction below On Wed, Mar 31, 2010 at 5:21 PM, kishore kadiyala kishorek.kadiy...@gmail.com wrote: Hi, I am trying to implement card-detect and regulator changes for HSMMC driver on OMAP4. In OMAP4, hsmmc doesn't use any gpio line for card detect and instead uses interrupt line

Re: [PATCH-V2] OMAP: Fix for bus width which improves SD card's peformance.

2010-04-01 Thread kishore kadiyala
On Wed, Mar 31, 2010 at 10:07 PM, Madhusudhan madhu...@ti.com wrote: -Original Message- From: kishore kadiyala [mailto:kishorek.kadiy...@gmail.com] Sent: Wednesday, March 31, 2010 2:03 AM To: Vimal Singh Cc: Madhusudhan; t...@atomide.com; svenk...@ti.com; linux- o

[PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

2010-04-05 Thread kishore kadiyala
From: Kishore Kadiyala kishore.kadiy...@ti.com This patch improves low speeds for SD cards. OMAP-MMC controller's can support maximum bus width of '8'. when bus width is mentioned as 8 in controller data,the SD stack will check whether bus width is 4 and if not it will set bus width to 1

[PATCH v4] OMAP: Fix for bus width which improves SD card's peformance.

2010-04-19 Thread kishore kadiyala
The previous patch was Line wrapped , resending correct patch. NM, Sorry I miss spelled your name correcting this time. Regards, Kishore From: Kishore Kadiyala kishore.kadiy...@ti.com This patch improves low speeds for SD cards. OMAP-MMC controller's can support maximum bus width of '8'. when

[PATCH 0/7] Adding MMC Support on OMAP4430 SDP

2010-04-21 Thread kishore kadiyala
://www.mail-archive.com/linux-omap@vger.kernel.org/msg26256.html [2] http://www.mail-archive.com/linux-...@vger.kernel.org/msg02755.html [3] https://patchwork.kernel.org/patch/79967/ Kishore Kadiyala (5): OMAP4-HSMMC: FIX for MMC5 Controller IRQ Base OMAP4-HSMMC: Adding HSMMC support for OMAP4430

[PATCH 1/7] OMAP4-HSMMC: FIX for MMC5 Controller IRQ Base

2010-04-21 Thread kishore kadiyala
This patch fixes HSMMC Controller5 IRQ Base. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 23e4d77..2271b9b

[PATCH 2/7] OMAP4-HSMMC: Adding HSMMC support for OMAP4430 Board file

2010-04-21 Thread kishore kadiyala
This patch adds MMC1 and MMC2 Controller support for OMAP4430 Board file. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/Makefile|3 +- arch/arm/mach-omap2/board-4430sdp.c | 39 +++--- 2 files changed, 33 insertions(+), 9

[PATCH 3/7] OMAP4-HSMMC: Adding Card detect support

2010-04-21 Thread kishore kadiyala
-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |1 + arch/arm/mach-omap2/hsmmc.c | 74 + arch/arm/mach-omap2/hsmmc.h |1 + arch/arm/plat-omap/include/plat/mmc.h |3 +- drivers/mmc/host/omap_hsmmc.c

[PATCH 4/7] OMAP4-HSMMC: Addind MMC-TWL regulator changes

2010-04-21 Thread kishore kadiyala
This patch adds PBIAS Configuration during POWER ON and OFF. Also it adds MMC1 Card detect configuration on Phoenix Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/hsmmc.c | 145 +++-- arch/arm/plat-omap/include/plat

[PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers

2010-04-21 Thread kishore kadiyala
This patch adds dummy Interface clocks for MMC controllers Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach

[PATCH 7/7] OMAP4-HSMMC: Adding OMAP4 Support

2010-04-21 Thread kishore kadiyala
This patch adds HSMMC support in OMAP4430 Defconfig. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com --- arch/arm/configs/omap_4430sdp_defconfig | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/arm/configs/omap_4430sdp_defconfig b/arch/arm

Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers

2010-04-21 Thread kishore kadiyala
On Thu, Apr 22, 2010 at 6:44 AM, Paul Walmsley p...@pwsan.com wrote: Kishore, On Wed, 21 Apr 2010, kishore kadiyala wrote: This patch adds dummy Interface clocks for MMC controllers Um, your patch removes the existing dummy interface clocks and adds them back again.  Or is there some other

Re: [PATCH 2/7] OMAP4-HSMMC: Adding HSMMC support for OMAP4430 Board file

2010-05-04 Thread kishore kadiyala
On Thu, Apr 22, 2010 at 12:17 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100421 11:15]: This patch adds MMC1 and MMC2 Controller support for OMAP4430 Board file. Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com ---  arch/arm/mach-omap2

Re: [PATCH 4/7] OMAP4-HSMMC: Addind MMC-TWL regulator changes

2010-05-04 Thread kishore kadiyala
On Thu, Apr 22, 2010 at 2:30 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100421 11:16]: This patch adds PBIAS Configuration during POWER ON and OFF. Also it adds MMC1 Card detect configuration on Phoenix Signed-off-by: Kishore Kadiyala kishore.kadiy

Re: [PATCH 3/7] OMAP4-HSMMC: Adding Card detect support

2010-05-04 Thread kishore kadiyala
On Thu, Apr 22, 2010 at 12:38 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100421 11:16]: Since OMAP4's card detection doesn't support GPIO,this patch basically moves card detection API from driver to Board file so that it can handle in both GPIO

Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers

2010-05-04 Thread kishore kadiyala
On Thu, Apr 22, 2010 at 12:09 PM, Russell King r...@arm.linux.org.uk wrote: On Wed, Apr 21, 2010 at 11:50:56PM +0530, kishore kadiyala wrote: This patch adds dummy Interface clocks for MMC controllers Looks to me as if it changes the formatting; it doesn't seem to be adding anything. I have

  1   2   >