Hi Sekhar,
On 11/14/2014 06:03 PM, Sekhar Nori wrote:
I think I have asked this before, and I am still not sure why this call
to pm_runtime_get_sync() is needed here. From my testing today, this
does seem to be a a no-op and this call returns from rpm_resume()
because of this check:
Hi,
On 08/26/2014 08:36 AM, Sekhar Nori wrote:
On Friday 22 August 2014 01:16 PM, Dave Gerlach wrote:
Thanks for pushing that forward!
+static int edma_pm_suspend(struct device *dev)
+{
+int j, r;
+
+r = pm_runtime_get_sync(dev);
+if (r 0) {
+dev_err(dev, %s:
, annotations had to be dropped.
[n...@ti.com: added error handling for runtime + suspend_late/early_resume]
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Daniel Mack zon...@gmail.com
Tested-by: Joel Fernandes jo...@ti.com
Acked-by: Joel Fernandes jo...@ti.com
---
Changes from v8
Hi Tony,
On 07/23/2014 10:54 AM, Tony Lindgren wrote:
* Daniel Mack zon...@gmail.com [140712 03:57]:
This is needed to instanciate fixed clocks in the DT.
Makes sense to me. Does this fix some regression or hang
that's needed for the -rc series?
No, it's a feature addition. No need
This is needed to instanciate fixed clocks in the DT.
Signed-off-by: Daniel Mack zon...@gmail.com
---
arch/arm/mach-omap2/board-generic.c | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/mach-omap2/board-generic.c
b/arch/arm/mach-omap2/board-generic.c
index 5606fa2..39f154a
On 07/11/2014 04:55 AM, Dave Gerlach wrote:
This series adds suspend/resume support for am335x. Version 3 of this
series can be found at [1]. I apologize for the large delay between this
and the previous revision. This code has been heavily refined
since the last version based on the various
(+ George)
On 06/19/2014 11:56 AM, Tony Lindgren wrote:
Looks like commit ca88fc2ef0d7 (usb: musb: add a work_struct
to recover from babble errors) causes MUSB gadgets to stop
enumerating at least on omap3. Reverting the the commit fixes
the issue.
Hmm, so do you see babble errors occuring?
Hi Tony,
On 06/19/2014 12:31 PM, Tony Lindgren wrote:
* Daniel Mack dan...@zonque.org [140619 03:10]:
On 06/19/2014 11:56 AM, Tony Lindgren wrote:
Looks like commit ca88fc2ef0d7 (usb: musb: add a work_struct
to recover from babble errors) causes MUSB gadgets to stop
enumerating at least
On 06/19/2014 12:43 PM, Tony Lindgren wrote:
* Daniel Mack dan...@zonque.org [140619 03:38]:
On 06/19/2014 12:31 PM, Tony Lindgren wrote:
* Daniel Mack dan...@zonque.org [140619 03:10]:
On 06/19/2014 11:56 AM, Tony Lindgren wrote:
But that also raises a question: Were these patches merged
Hi George,
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation of
silicon version is done by checking the BABBLE_CTL register.
For newer silicon the register default value read is 0x4
On 05/13/2014 01:57 PM, George Cherian wrote:
On 5/13/2014 3:16 PM, Daniel Mack wrote:
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation of
silicon version is done by checking
Hi George,
On 05/13/2014 02:57 PM, George Cherian wrote:
I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL reg.
can you try with the following patch.
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 1ae6681..1160cd1 100644
---
On 05/13/2014 03:24 PM, George Cherian wrote:
Basically, there are 2 types of babble conditions.
1) Transient babble condition - which could be recovered from without an
IP reset .
2) Babble condition - which could be recovered from only by doing an IP
reset.
Ok, thanks for the
Hi Geroge,
On 05/08/2014 11:35 AM, George Cherian wrote:
-static inline void musb_platform_reset(struct musb *musb)
+static inline int musb_platform_reset(struct musb *musb)
{
- if (musb-ops-reset)
- musb-ops-reset(musb);
+ if (!musb-ops-reset)
+ return
This should probably be done implicitly through mmc_of_parse(), but that
doesn't play well along with the multi-slot model the hsmmc driver
features. Hence, for now, do it manually. The properties are already
documented in Documentation/devicetree/bindings/mmc/mmc.txt.
Signed-off-by: Daniel Mack
On 02/18/2014 03:36 PM, Balaji T K wrote:
On Monday 17 February 2014 05:06 PM, Daniel Mack wrote:
This should probably be done implicitly through mmc_of_parse(), but that
doesn't play well along with the multi-slot model the hsmmc driver
features. Hence, for now, do it manually. The properties
This should probably be done implicitly through mmc_of_parse(), but that
doesn't play well along with the multi-slot model the hsmmc driver
features. Hence, for now, do it manually. The properties are already
documented in Documentation/devicetree/bindings/mmc/mmc.txt.
Signed-off-by: Daniel Mack
On 01/18/2014 04:12 PM, Daniel Mack wrote:
On 01/17/2014 05:27 PM, Ezequiel Garcia wrote:
On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote:
While doing some experiments with the stk1160 driver (for Easycap TV video
capture devices), ran into problems using v3.13-rc4
Hi Ezequiel,
On 01/17/2014 05:27 PM, Ezequiel Garcia wrote:
On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote:
Hello,
While doing some experiments with the stk1160 driver (for Easycap TV video
capture devices), ran into problems using v3.13-rc4. The problem is that the
stk1160
On 11/29/2013 09:08 AM, Brian Murphy wrote:
On 11/27/2013 02:56 PM, Daniel Mack wrote:
This patch makes the edma driver resume correctly after suspend. Tested
on an AM33xx platform with cyclic audio streams and omap_hsmmc.
Can I ask which git this patch is relative to? There is no
suspend
On 11/27/2013 02:22 PM, Sekhar Nori wrote:
+ Kevin
On Monday 25 November 2013 11:04 PM, Joel Fernandes wrote:
On 11/17/2013 04:19 PM, Daniel Mack wrote:
This patch makes the edma driver resume correctly after suspend. Tested
on an AM33xx platform with cyclic audio streams and omap_hsmmc
Hi Sekhar,
On 11/27/2013 02:35 PM, Sekhar Nori wrote:
On Monday 18 November 2013 03:49 AM, Daniel Mack wrote:
+static int edma_pm_suspend(struct device *dev)
+{
+int j, r;
+
+r = pm_runtime_get_sync(dev);
+if (IS_ERR_VALUE(r)) {
So IS_ERR_VALUE() is only for functions which
, annotations had to be dropped.
[n...@ti.com: added error handling for runtime + suspend_late/early_resume]
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Daniel Mack zon...@gmail.com
Tested-by: Joel Fernandes jo...@ti.com
Acked-by: Joel Fernandes jo...@ti.com
---
v6 - v7:
* Addressed
On 11/26/2013 11:50 AM, Sergei Shtylyov wrote:
On 25-11-2013 23:39, Daniel Mack wrote:
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however. So add a bit in struct
On 11/25/2013 10:32 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 10:30:37PM +0100, Daniel Mack wrote:
On 11/25/2013 10:29 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 10:26:43PM +0100, Daniel Mack wrote:
+static int dsps_resume(struct device *dev)
+{
+ struct dsps_glue *glue
v2 - v3:
* removed a development left-over
v3 - v4:
* one hunk removed that sneaked in during rebasing
Daniel Mack (4):
usb: musb: unconditionally save and restore the context on suspend
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: dsps: add {tx,rx}_mode to wrapper
on this
platform, but musb_port_reset() should not be called from glue layers.
Hence, introduce a flag in struct musb_hdrc_config for this.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c| 57 +
drivers/usb/musb/musb_host.c
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however, and because it should cause any trouble
on other platforms, do it unconditionally.
Signed-off-by: Daniel Mack zon...@gmail.com
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 3 +++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 0a43329..a8ded57 100644
--- a/drivers/usb/musb
board.
Thanks,
Daniel
Daniel Mack (5):
usb: musb: conditionally save and restore the context on suspend
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: dsps: add {tx,rx}_mode to wrapper
usb: musb: dsps: add support for suspend and resume
usb: musb: dsps: indentation
, so
this function has to be made non-static.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.h| 1 +
drivers/usb/musb/musb_dsps.c| 59 +
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 2 +-
4
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 361ddf8
On 11/25/2013 08:46 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack
On 11/25/2013 08:49 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 08:39:53PM +0100, Daniel Mack wrote:
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions
On 11/25/2013 08:48 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 08:39:52PM +0100, Daniel Mack wrote:
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know
On 11/25/2013 08:44 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however. So add a bit
On 11/25/2013 09:01 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 08:58:22PM +0100, Daniel Mack wrote:
On 11/25/2013 08:46 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
Make musb_port_suspend() externally available, and call it when to host
goes
On 11/25/2013 09:08 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 09:04:16PM +0100, Daniel Mack wrote:
diff --git a/drivers/usb/musb/musb_virthub.c
b/drivers/usb/musb/musb_virthub.c
index e977441..24e46c0 100644
--- a/drivers/usb/musb/musb_virthub.c
+++ b/drivers/usb/musb/musb_virthub.c
On 11/25/2013 09:13 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 09:08:51PM +0100, Daniel Mack wrote:
On 11/25/2013 08:44 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
It appears not all platforms featuring a musb core need to save
On 11/25/2013 09:41 PM, Alan Stern wrote:
On Mon, 25 Nov 2013, Daniel Mack wrote:
What if you have a mounted file system on a pendrive ? Should we allow
suspend in that case ?
Well, I would have expected that, but in fact, the opposite is true.
With 3.12, mounting a filesystem on a USB
On 11/25/2013 09:01 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 08:58:22PM +0100, Daniel Mack wrote:
In 3.13, something about the parition table reading seems to be broken
currently, I'll have a closer look.
cool
Ah, and forget about this one. I didn't look close enough. There's
On 11/25/2013 09:46 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 09:26:55PM +0100, Daniel Mack wrote:
On 11/25/2013 09:08 PM, Felipe Balbi wrote:
On Mon, Nov 25, 2013 at 09:04:16PM +0100, Daniel Mack wrote:
diff --git a/drivers/usb/musb/musb_virthub.c
b/drivers/usb/musb
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however, and because it shouldn't cause any
trouble on other platforms, do it unconditionally for all of them.
Signed-off-by: Daniel Mack
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
on this
platform, but musb_port_reset() should not be called from glue layers.
Hence, introduce a flag in struct musb_hdrc_config for this.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c| 60 +
drivers/usb/musb/musb_host.c
'
Daniel Mack (4):
usb: musb: unconditionally save and restore the context on suspend
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: dsps: add {tx,rx}_mode to wrapper
usb: musb: dsps: add support for suspend and resume
drivers/usb/musb/musb_core.c| 14 -
drivers
On 11/25/2013 10:29 PM, Felipe Balbi wrote:
Hi,
On Mon, Nov 25, 2013 at 10:26:43PM +0100, Daniel Mack wrote:
+static int dsps_resume(struct device *dev)
+{
+struct dsps_glue *glue = dev_get_drvdata(dev);
+const struct dsps_musb_wrapper *wrp = glue-wrp;
+struct musb *musb
Hi Nishanth,
On 11/15/2013 03:39 PM, Nishanth Menon wrote:
To trigger the fail, I created a custom Test case on TI vendor kernel
based on v3.12 tag:
On beagleBone-Black
test scenario (BBB):
Boot from SD card
ensure firmware is loaded (rev 0x182)
run LTP fsstress [1] in
, annotations had to be dropped.
[n...@ti.com: added error handling for runtime + suspend_late/early_resume]
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Daniel Mack zon...@gmail.com
Tested-by: Joel Fernandes jo...@ti.com
Acked-by: Joel Fernandes jo...@ti.com
---
v6:
amended version from
On 11/08/2013 01:02 AM, Kevin Hilman wrote:
Daniel Mack zon...@gmail.com writes:
+.resume_noirq = edma_pm_resume,
+};
Also, I believe it was already suggested by Nishanth, but the late/early
callbacks are probably more appropriate here than the noirq callbacks.
Unless there's
On 11/07/2013 02:30 PM, Gururaja Hebbar wrote:
On Wednesday 06 November 2013 11:06 PM, Joel Fernandes wrote:
Hi Vaibhav,
On 10/31/2013 05:25 PM, Vaibhav Bedia wrote:
Hi Daniel,
On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote:
[...]
+
+static SIMPLE_DEV_PM_OPS
On 11/07/2013 04:18 PM, Nishanth Menon wrote:
Tested this on a vendor V3.12 tag based kernel:
Test patch: http://pastebin.com/AmnktQ7B
test: echo -n 1/sys/power/pm_print_times; rtcwake -d /dev/rtc0 -m
mem -s 5
with the current patch: http://pastebin.com/RujarRLV
suspend_late and
Hi Joel,
On 11/07/2013 05:34 PM, Joel Fernandes wrote:
Thanks for your followup patch on this. It looks much better now using
existing
functions to save/restore the state.
Yes, thanks for the suggesting it in the first place.
On 10/30/2013 03:21 PM, Daniel Mack wrote:
diff --git a/arch
, annotations had to be dropped.
Signed-off-by: Daniel Mack zon...@gmail.com
---
Ok, here is v5.
v4 - v5:
* dropped pm_runtime_* function calls entirely
* moved the function pointers to .suspend/resume _noirq
Again, thanks for the reviews. I'm still uncertain which function order
On 11/08/2013 05:07 AM, Gururaja Hebbar wrote:
On Thursday 07 November 2013 11:07 PM, Daniel Mack wrote:
I'm running long-time tests here on a device
which has a mwifiex connected to omap_hsmmc. The test procedure includes:
a) a script on the device that puts the device to sleep some seconds
, annotations had to be dropped.
Signed-off-by: Daniel Mack zon...@gmail.com
---
There was actually only a v3 ever, I made a mistake when formating the
first version of this patch. To prevent confusion though, I named this
one v4.
v3 - v4:
* dropped extra allocations, and reconstruct register
On 10/18/2013 11:59 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
v3 of my musb_dsps suspend patches.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume.
This works
is
not crucial for this series.
* added another cosmetic cleanup patch (#5)
Daniel Mack (5):
usb: musb: call musb_port_suspend from musb_bus_suspend
usb: musb: conditionally save and restore the context on suspend
usb: musb: dsps: add {tx,rx}_mode to wrapper
usb: musb: dsps: add support
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index e5ad77d..fea6ecd 100644
--- a/drivers/usb/musb
, so
this function has to be made non-static.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.h| 1 +
drivers/usb/musb/musb_dsps.c| 59 +
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 2 +-
4
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index ce5bbc6
On 10/18/2013 11:58 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index da21a4e..ce5bbc6 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -632,11
On 10/18/2013 11:59 AM, Sebastian Andrzej Siewior wrote:
On 10/18/2013 11:39 AM, Daniel Mack wrote:
v3 of my musb_dsps suspend patches.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume.
This works
On 10/09/2013 10:14 PM, Joel Fernandes wrote:
On 10/09/2013 09:12 AM, Joel Fernandes wrote:
On 10/09/2013 02:38 AM, Daniel Mack wrote:
[..]
(And the 'v3' in the subject is really my bad, sorry - I only sent one
version of this patch ever).
I can respin the patch on top of the proper driver
On 09.10.2013 08:41, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:08 [+0200]:
Patch #1 restores more registers on resume time.
Patch #2 is a cosmetic cleanup that emerged while digging through the
driver and gaining a basic idea of how it's implemented. Nothing fancy
On 09.10.2013 09:28, Sebastian Andrzej Siewior wrote:
On 10/09/2013 09:23 AM, Daniel Mack wrote:
Ok, thank you very much for the update :) I can of course test
alternative patches if you have any.
Could you actually reproduce the issue I described by sending your board
to suspend?
No, I
October 2013 09:58 AM, Joel Fernandes wrote:
On 10/01/2013 10:04 AM, Daniel Mack wrote:
AFAIK, Suspend/resume should be quick. Allocating and
deallocating on every iterating would be useless and time
consuming.
Nobody said allocate and deallocate on every iteration. Allocate
once during
On 30.09.2013 18:25, Felipe Balbi wrote:
On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote:
So are you happy with this v2?
It's just a cosmetic cleanup after all ...
I can't see v2 anywhere... The only version I have is the one with
DEV_PM_OPS still in it.
Seen them this time
Hi Sebastian,
On 02.10.2013 10:29, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:11 [+0200]:
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7747bf7..6decf34 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -586,6 +586,9 @@ static int
On 02.10.2013 12:20, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:31:08 [+0200]:
Patch #3, however, gives me headaches. I can't fully explain what's
going on, but I can tell for sure that if fixes a problem that I stared
on for many hours.
The problem is that on resume
On 02.10.2013 12:49, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:39:54 [+0200]:
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Sorry for asking this stupid
On 02.10.2013 12:46, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-10-01 15:39:53 [+0200]:
musb_port_reset() sleeps, so we can't call it from atomic context. It
is, however, called from places inside musb_hub_control() while
musb-lock is held, which leads to a scheduling while atomic
On 02.10.2013 12:25, Sebastian Andrzej Siewior wrote:
On 10/02/2013 11:19 AM, Daniel Mack wrote:
Once the system is booted up and the USB media is detected, I send the
system to sleep mode with cat mem /sys/power/state. After wakeup, I
access the media by mounting and unmounting it once
On 02.10.2013 14:01, Sebastian Andrzej Siewior wrote:
On 10/02/2013 01:14 PM, Daniel Mack wrote:
On 02.10.2013 12:49, Sebastian Andrzej Siewior wrote:
What happens if the device is unplugged while the host is suspended and
not there on resume?
That condition is detected and a full teardown
Hi Sebastian,
sorry for the long delay, I got distracted by other things.
On 26.09.2013 10:26, Sebastian Andrzej Siewior wrote:
* Daniel Mack | 2013-09-22 16:50:03 [+0200]:
cdd-cd and cdd-descs_phys are allocated DESCS_AREAS times from
init_descs() and freed as often from purge_descs
With active users over suspend/resume cycles, it turns out that
more registers, in particular DMA_TDFDQ and RXHPCRA0, have to be
restored on resume.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers
Use cppi41_pop_desc() when appropriate instead of open-coding the same
functionality again. That makes the code more readable. The function has
to be moved some lines up for this change.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 23 +++
1 file
a comment on this? I'll post the musb patches
that are necessary as well now, and I'd appreciate more testers here.
Many thanks,
Daniel
Daniel Mack (3):
dma: cppi41: restore more registers
dma: cppi41: use cppi41_pop_desc() where possible
dma: cppi41: move -EAGAIN in tear_down
drivers/dma
to false.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/dma/cppi41.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 7747bf7..6decf34 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -586,6 +586,9
mode and CPPI41 enabled configurations,
together with my cppi41 patches that I posted here:
http://marc.info/?l=linux-usbm=138063429219730w=2
More testing is certainly appreciated.
Thanks,
Daniel
Daniel Mack (5):
usb: musb: move port reset to worker
usb: musb: call musb_port_suspend from
-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c | 17 -
include/linux/usb/musb.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 2b9f4b4..f17604e 100644
--- a/drivers/usb/musb
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git
called directly.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.c| 7 +++
drivers/usb/musb/musb_core.h| 3 +++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_virthub.c | 13 -
4 files changed, 20 insertions(+), 5 deletions(-)
diff
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers
in the final
driver, or maybe anyone wants to include that intermediate hack for the
time being.
Successfully tested on an AM335x board with davinci-mcasp enabled
audio. A patch to make the latter work after suspend has been posted
on alsa-devel.
Thanks,
Dainel
Daniel Mack (1):
ARM: omap
This patch makes the edma driver resume correctly after suspend. Tested
on an AM33xx platform with cyclic audio streams.
The code was shamelessly taken from an ancient BSP tree.
Signed-off-by: Daniel Mack zon...@gmail.com
---
arch/arm/common/edma.c | 133
On 01.10.2013 16:59, Felipe Balbi wrote:
On Tue, Oct 01, 2013 at 03:39:57PM +0200, Daniel Mack wrote:
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core
This patch makes the edma driver resume correctly after suspend. Tested
on an AM33xx platform with cyclic audio streams.
The code was shamelessly taken from an ancient BSP tree.
Signed-off-by: Daniel Mack zon...@gmail.com
---
arch/arm/common/edma.c | 133
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb
On 01.10.2013 18:22, Sebastian Andrzej Siewior wrote:
On 10/01/2013 03:09 PM, Daniel Mack wrote:
A simplified version of the code as it stands is:
for (i = 0; i DESCS_AREAS; i++)
cdd-cd = dma_alloc_coherent(dev, ..., cdd-descs_phys, GFP_KERNEL);
for (i = 0; i DESCS_AREAS; i
On 30.09.2013 18:25, Felipe Balbi wrote:
On Fri, Sep 27, 2013 at 08:47:10PM +0200, Daniel Mack wrote:
On 25.09.2013 15:48, Felipe Balbi wrote:
On Tue, Sep 24, 2013 at 08:57:08AM +0200, Daniel Mack wrote:
On 23.09.2013 23:20, Felipe Balbi wrote:
On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel
This makes bfin_pm_ops const and will stub the struct out in case
CONFIG_PM_SLEEP is not set.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/blackfin.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb
1 - 100 of 362 matches
Mail list logo
