Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-23 Thread David Miller
From: "David Rivshin (Allworx)" Date: Tue, 22 Dec 2015 19:36:31 -0500 > Testing by anyone who has real hardware using phy-handle or dual_emac > with fixed-link would be appreciated. I'm going to wait for such testing before applying this series. Thanks. -- To

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: > Add support for fixed-link PHY") added initial fixed-link PHY support > for CPSW, but missed a few considerations. > > This

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-17 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > I have tested on the following hardware configurations: > - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID > - single emac with fixed-link using RGMII > Testing of other

Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x

2015-11-20 Thread David Miller
From: Tony Lindgren Date: Wed, 18 Nov 2015 17:27:25 -0800 > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") started using of_machine_is_compatible for detecting > type but missed at dm8148 causing Ethernet to stop working. > >

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

2015-11-04 Thread David Miller
From: Markus Brunner Date: Tue, 03 Nov 2015 22:09:51 +0100 > Add support for a fixed-link devicetree sub-node in case the the > cpsw MAC is directly connected to a non-mdio PHY/device. > > Signed-off-by: Markus Brunner

Re: [PATCH] drivers: net: cpsw: use module_platform_driver

2015-10-23 Thread David Miller
From: Grygorii Strashko Date: Fri, 23 Oct 2015 14:41:12 +0300 > There is no reasons to probe cpsw from late_initcall level > and it's not recommended. Hence, use module_platform_driver() > to register and probe cpsw driver from module_init() level. > > Cc: Tony

Re: [net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread David Miller
From: Mugunthan V N Date: Mon, 21 Sep 2015 15:56:49 +0530 > Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. > Pushed a branch [3] for others to test the patch. > > [1]: http://pastebin.ubuntu.com/12513420/ > [2]: http://pastebin.ubuntu.com/12513428/ > [3]:

Re: [net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

2015-09-15 Thread David Miller
From: Mugunthan V N Date: Mon, 7 Sep 2015 15:16:44 +0530 > In DRA72x EVM, by default slave 1 is connected to the onboard > phy, but slave 2 pins are also muxed with video input module > which is controlled by pcf857x gpio and currently to select slave > 0 to connect to phy

Re: [PATCH] net/smsc911x: Fix deferred probe for interrupt

2015-08-29 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Fri, 28 Aug 2015 11:50:15 -0700 The interrupt handler may not be available when smsc911x probes if the interrupt handler is a GPIO controller for example. Let's fix that by adding handling for -EPROBE_DEFER. Cc: Steve Glendinning

Re: [net-next PATCH 0/3] Add AM335x PG1.0 CPSW errata workaround

2015-08-13 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 12 Aug 2015 15:22:52 +0530 With commit 870915feabdc (drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself), CPSW on AM335x beagle bone white is broken as there is a errata for AM335x PG1.0. This patch series

Re: [net-next PATCH] net: Reserve skb headroom and set skb-dev even if using __alloc_skb

2015-05-13 Thread David Miller
From: Alexander Duyck alexander.h.du...@redhat.com Date: Wed, 13 May 2015 13:34:13 -0700 When I had inlined __alloc_rx_skb into __netdev_alloc_skb and __napi_alloc_skb I had overlooked the fact that there was a return in the __alloc_rx_skb. As a result we weren't reserving headroom or setting

Re: [PATCH 1/2] net: davinci_mdio: add hibernation callbacks

2015-03-01 Thread David Miller
From: grygorii.stras...@linaro.org Date: Fri, 27 Feb 2015 13:19:44 +0200 From: Grygorii Strashko grygorii.stras...@linaro.org Setting a dev_pm_ops suspend_late/resume_early pair but not a set of hibernation functions means those pm functions will not be called upon hibernation. Fix this by

Re: [PATCH 2/2] net: ti: cpsw: add hibernation callbacks

2015-03-01 Thread David Miller
From: grygorii.stras...@linaro.org Date: Fri, 27 Feb 2015 13:19:45 +0200 From: Grygorii Strashko grygorii.stras...@linaro.org Setting a dev_pm_ops suspend/resume pair but not a set of hibernation functions means those pm functions will not be called upon hibernation. Fix this by using

Re: [PATCH 0/3] Changes to cpsw and davinci_emac for getting MAC address

2015-01-30 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Wed, 28 Jan 2015 11:33:03 -0800 Here are a few patches to add common code for cpsw and davinci_emac for getting the MAC address. Looks like we can also now add code to get the MAC address on 3517 but in a slightly different way. Applied to net-next,

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-19 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 19 Jan 2015 08:40:17 -0600 On Sun, Jan 18, 2015 at 01:07:50AM -0500, David Miller wrote: From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:12 -0600 CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked

Re: [patch-net-next v3] net: ethernet: ti: cpsw: fix buld break when NET_POLL_CONTROLLER

2015-01-19 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 19 Jan 2015 11:52:36 -0600 Commit c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't use) left one build breakage when NET_POLL_CONTROLLER is enabled. Fix this build break by referring to the correct irqs_table array. Fixes:

Re: [patch-net-next v3 1/2] net: ethernet: cpsw: unroll IRQ request loop

2015-01-17 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:11 -0600 This patch is in preparation for a nicer IRQ handling scheme where we use different IRQ handlers for each IRQ line (as it should be). Later, we will also drop IRQs offset 0 and 3 because they are always disabled in this

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-17 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:12 -0600 CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked in their appropriate IRQ Enable register. Instead of allocating an IRQ that never fires, it's best to remove that code altogether and

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-15 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Thu, 15 Jan 2015 09:20:53 -0600 On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote: On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote: CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked in their

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-15 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Thu, 15 Jan 2015 19:28:52 -0600 On Thu, Jan 15, 2015 at 06:16:15PM -0500, David Miller wrote: Indeed, I agree that adding something as a placeholder that just gets immediately removed should be avoided unless it is extremely difficult to do so. what

Re: [PATCHv2 0/6] Fixes for davinci_emac

2015-01-15 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Thu, 15 Jan 2015 14:45:08 -0800 Here's a repost of the fixes for davinci_emac with patches updated for comments and acks collected. Series applied, thanks Tony. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [patch-net-next 1/3] net: ethernet: cpsw: unroll IRQ request loop

2015-01-13 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 13 Jan 2015 13:44:46 -0600 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt, + 0, dev_name(pdev-dev), priv); When a function call spans multiple lines, the argument on the second and subsequent lines must start on the

Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency

2015-01-13 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Tue, 13 Jan 2015 11:54:16 -0800 * Tom Lendacky thomas.lenda...@amd.com [150113 11:51]: On 01/13/2015 01:29 PM, Tony Lindgren wrote: We only use clk_get() to get the frequency, the rest is done by the runtime PM calls. Let's free the clock too. Cc:

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

2015-01-06 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 6 Jan 2015 11:43:32 -0600 CPSW completely hangs if we add, and later remove, VLAN ID #1. What happens is that after removing VLAN ID #1, no packets will be received by CPSW rendering network unusable. In order to fix the issue, we're returning

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

2015-01-06 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 6 Jan 2015 14:31:19 -0600 What you're saying here is that you prefer to drop a feature that works for all other 1023 IDs because 1 ID is quirky. Sounds like overkill to me. The other option is to software fallback only for VLAN 1. -- To unsubscribe

Re: [PATCH] net: ethernet: cpsw: fix hangs with interrupts

2015-01-04 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 16:15:59 -0600 The CPSW IP implements pulse-signaled interrupts. Due to that we must write a correct, pre-defined value to the CPDMA_MACEOIVECTOR register so the controller generates a pulse on the correct IRQ line to signal the End Of

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

2015-01-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 12:10:24 -0600 In any case, patch 1 should go in during the -rc an get backported all the way back to v3.9, while the other patches can (should) be delayed for v3.20 merge window. If that's what you want, the way you submitted these

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

2015-01-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 15:53:35 -0600 On Fri, Jan 02, 2015 at 04:45:36PM -0500, David Miller wrote: You should instead submit patch #1 all by itself, correctly targetting 'net'. Then, after the next time I merge 'net' into 'net-next', you can submit the rest

Re: [PATCH v2] drivers: net : cpsw: Update Kconfig for CPSW

2014-12-09 Thread David Miller
From: Lokesh Vutla lokeshvu...@ti.com Date: Thu, 4 Dec 2014 10:24:29 +0530 CPSW is present in AM33xx, AM43xx, DRA7xx. Updating the Kconfig to depend on ARCH_OMAP2PLUS instead of listing all SoC's. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Applied to net-next, thanks. -- To unsubscribe

Re: [PATCH] net: smc91x: Fix gpios for device tree based booting

2014-10-29 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Mon, 27 Oct 2014 13:25:56 -0700 +/** + * of_try_set_control_gpio - configure a gpio if it exists + */ +static int try_toggle_control_gpio(struct device *dev, +struct gpio_desc **desc, +

Re: [PATCH RESEND v6 0/7] net: cpsw: Support for am335x chip MACIDs

2014-09-29 Thread David Miller
From: Markus Pargmann m...@pengutronix.de Date: Mon, 29 Sep 2014 08:53:12 +0200 Another resend of this series to add the netdev list. This series adds support to the cpsw driver to read the MACIDs of the am335x chip and use them as fallback. These addresses are only used if there are no mac

Re: [PATCH RESEND v6 0/7] DT doc: net: cpsw mac-address is optional

2014-09-28 Thread David Miller
From: Markus Pargmann m...@pengutronix.de Date: Sun, 28 Sep 2014 18:59:14 +0200 This is a resend of v6 of this series. I added the Acked-by of Tony Lindgren for patch 5/7. There are no other changes. This series adds support to the cpsw driver to read the MACIDs of the am335x chip and use

Re: [PATCH v2 0/6] Add CPTS support for AM437x

2014-05-05 Thread David Miller
From: George Cherian george.cher...@ti.com Date: Fri, 2 May 2014 12:01:58 +0530 The series adds CPTS support for AM4372. Patch 1 - DT changes w.r.t clock changes for AM33xx. Patch 2 - CPTS clock name harcoding in the driver is removed. Easier to pass the clock name from dt rather

Re: [PATCH] net: micrel : ks8851-ml: add vdd-supply support

2014-03-23 Thread David Miller
From: Nishanth Menon n...@ti.com Date: Fri, 21 Mar 2014 01:52:48 -0500 Few platforms use external regulator to keep the ethernet MAC supplied. So, request and enable the regulator for driver functionality. Fixes: 66fda75f47dc (regulator: core: Replace direct ops-disable usage) Reported-by:

Re: [PATCH 1/1] net: cpsw: fix cpdma rx descriptor leak on down interface

2014-03-03 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 3 Mar 2014 16:19:06 +0530 From: Schuyler Patton spat...@ti.com This patch fixes a CPDMA RX Descriptor leak that occurs after taking the interface down when the CPSW is in Dual MAC mode. Previously the CPSW_ALE port was left open up which

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: enable promiscuous mode support

2014-01-23 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 23 Jan 2014 00:03:12 +0530 Enable promiscuous mode support for CPSW. Signed-off-by: Mugunthan V N mugunthan...@ti.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [net-next PATCH 1/1] drivers: net: cpsw: enable promiscuous mode support

2014-01-21 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 20 Jan 2014 17:38:38 +0530 + if (!enable ((priv-slaves[0].ndev-flags IFF_PROMISC) || + (priv-slaves[1].ndev-flags IFF_PROMISC))) { This assumption that there are exactly 2 slaves is not valid. Use

Re: [net PATCH v3 1/1] drivers: net : cpsw: pass proper device name while requesting irq

2013-12-22 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 18 Dec 2013 21:33:50 +0530 During checking the interrupts with cat /proc/interrupts, it is showing device name as (null), this change was done with commit id aa1a15e2d where request_irq is changed to devm_request_irq also changing the irq name

Re: [PATCH 1/1] drivers: net cpsw: Enable In Band mode in cpsw for 10 mbps

2013-12-18 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 13 Dec 2013 18:42:55 +0530 This patch adds support for enabling In Band mode in 10 mbps speed. RGMII supports 1 Gig and 100 mbps mode for Forced mode of operation. For 10mbps mode it should be configured to in band mode so that link status,

Re: [net PATCH v2 1/1] drivers: net : cpsw: pass proper device name while requesting irq

2013-12-17 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 13 Dec 2013 14:35:27 +0530 During checking the interrupts with cat /proc/interrupts, it is showing device name as (null), this change was done with commit id aa1a15e2d where request_irq is changed to devm_request_irq also changing the irq name

Re: [PATCH 2/2] drivers: net: cpsw: fix for cpsw crash when build as modules

2013-12-12 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Wed, 11 Dec 2013 22:09:05 -0600 From: Mugunthan V N mugunthan...@ti.com When CPSW and Davinci MDIO are build as modules, CPSW crashes when accessing CPSW registers in CPSW probe. The same is working in built-in as the CPSW clocks are enabled in Davindi

Re: [PATCH 1/2] net: eth: davinci_cpdma: 64-bit phys/dma_addr_t cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:20 -0800 Silences the below warnings when building with ARM_LPAE enabled, which gives longer dma_addr_t by default: drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create':

Re: [PATCH] net: eth: cpsw: 64-bit phys_addr_t and sparse cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:58:07 -0800 Minor fix for printk format of a phys_addr_t, and the switch of two local functions to static since they're not used outside of the file. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from

Re: [PATCH 2/2] net: eth: davinci_cpdma: Mark a local variable static

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:21 -0800 Only used locally. Found by sparse. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

2013-12-09 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 9 Dec 2013 14:59:05 +0530 commit 50a5fb068 This commit doesn't appear in any tree. And any change which makes a real struct device return NULL for dev_name() is broken. I'm not applying this patch, you have completely failed to provide any

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

2013-12-06 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 6 Dec 2013 12:28:27 +0530 From: George Cherian george.cher...@ti.com Use netdev_name while requesting irq so that eth* name is shown in /proc/interrupts. Previously it was showing device name as (null) for cpsw interrupts. For using

Re: [PATCH] net: davinci_emac: Fix platform data handling and make usable for am3517

2013-12-05 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Tue, 3 Dec 2013 15:13:02 -0800 When booted with device tree, we may still have platform data passed as auxdata. For am3517 this is needed for passing the interrupt_enable and interrupt_disable callbacks that access the omap system control module

Re: [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet

2013-12-02 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 2 Dec 2013 12:53:39 +0530 When only one port of the two port is pinned out, then dt probe is failing because second port phy is not found. fixing this by checking the number of slaves and breaking the loop. Signed-off-by: Mugunthan V N

Re: [net PATCH 1/1] drivers: net: cpsw: fix kernel warn during iperf test with interrupt pacing

2013-10-21 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sun, 20 Oct 2013 12:32:26 +0530 When interrupt pacing is enabled, receive/transmit statistics are not updated properly by hardware which leads to ISR return with IRQ_NONE and inturn kernel disables the interrupt. This patch removed the checking of

Re: [net-next PATCH 0/4] cpsw: support for control module register

2013-09-24 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sat, 21 Sep 2013 00:50:37 +0530 This patch series adds the support for configuring GMII_SEL register of control module to select the phy mode type and also to configure the clock source for RMII phy mode whether to use internal clock or the

Re: [PATCH 0/4] cpsw: support for control module register

2013-08-22 Thread David Miller
Patch #3 doesn't apply to net-next because it makes changes to a file include/linux/platform_data/cpsw.h which doesn't exist. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: Add support for new CPSW IP version

2013-08-05 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 5 Aug 2013 17:30:05 +0530 The new IP version has a minor changes and the offsets are same as the previous version, so adding new IP version support in the driver. Signed-off-by: Mugunthan V N mugunthan...@ti.com Reviewed-by: Felipe Balbi

Re: [net PATCH 1/1] net: ethernet: davinci_emac: drop IRQF_DISABLED

2013-08-03 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sat, 3 Aug 2013 16:39:45 +0530 IRQF_DISABLED is a no-op by now and should be removed. Signed-off-by: Mugunthan V N mugunthan...@ti.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [PATCH] net: ethernet: cpsw: drop IRQF_DISABLED

2013-08-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Aug 2013 10:44:10 +0300 IRQF_DISABLED is a no-op by now and should be removed. Signed-off-by: Felipe Balbi ba...@ti.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [net-next PATCH 1/1] drivers: net: cpsw: Add support for new CPSW IP version

2013-07-31 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 31 Jul 2013 17:42:26 +0530 The new IP version has a minor changes and the offsets are same as the previous version, so instead of adding CPSW version number in the driver, make the driver to fall through to the latest versions so that the

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: add support to show hw stats via ethtool

2013-07-24 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 23 Jul 2013 15:38:17 +0530 Add support to show CPSW hardware statistics to user via ethtool so user can find if there were any error reported by hardware or the system is over loaded duing high data rate transfer. Signed-off-by: Mugunthan V

Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs

2013-07-19 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 19 Jul 2013 19:37:21 +0530 Add support to show CPSW hardware statistics to user via ethtool get_regs ops so user can find if there were any error reported or the system is over loaded duing hagh data rate transfer. Signed-off-by: Mugunthan

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

2013-06-13 Thread David Miller
From: Linus Walleij linus.wall...@linaro.org Date: Mon, 10 Jun 2013 17:48:16 +0200 On Fri, Jun 7, 2013 at 4:49 PM, Mugunthan V N mugunthan...@ti.com wrote: If you want to merge the direct networking parts of this series into another tree, I'm fine with that: Acked-by: David S. Miller

Re: [net PATCH 0/2] Fixes for davinci MDIO on suspend/resume

2013-06-13 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 11 Jun 2013 15:32:03 +0530 This patch series fixes the following issues with Davinci MDIO * Bring up MDIO driver earlier than Ethernet driver so that ethernet driver can communicate with the phy as soon as it is resumed. * On suspend/resume

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

2013-06-07 Thread David Miller
From: Linus Walleij linus.wall...@linaro.org Date: Fri, 7 Jun 2013 09:31:58 +0200 On Thu, Jun 6, 2013 at 10:50 AM, Mark Brown broo...@kernel.org wrote: On Thu, Jun 06, 2013 at 11:29:39AM +0530, Mugunthan V N wrote: On 6/6/2013 12:53 AM, Mark Brown wrote: Linus Walleij posted some patches

Re: [net-next PATCH 0/8] add phy driver for Atheros AR8031 and CPSW phy-mode DT enhancement

2013-06-04 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 4 Jun 2013 11:40:03 +0530 This patch series adds the following feature * Atheros phy driver code cleanup * Add AT8031 phy driver to at803x driver * Add RGMII tx delay support via phy_if * Add phy_if DT enhancement to CPSW Driver and DT

Re: [net-next PATCH 1/1] drivers: net: davinci_cpdma: remove CRC bytes from skb added by CPDMA

2013-05-31 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 30 May 2013 11:52:01 +0530 Additional 4 bytes found in the skb is the CRC calculated by the CPDMA hardware, check the CRC bit in CPDMA status field of Descriptor and remove the CRC length from the skb. This extra 4 byte can be seen when

Re: [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support

2013-05-26 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 23 May 2013 18:00:23 +0530 From: Hebbar Gururaja gururaja.heb...@ti.com Amend cpsw controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume - sleep on suspend() This should make it

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-23 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 21 May 2013 15:24:58 +0530 + priv-pins_default = pinctrl_lookup_state(priv-pinctrl, + PINCTRL_STATE_DEFAULT); This is not indented correctly. Argument on the second, and subsequent,

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

2013-05-23 Thread David Miller
From: Hebbar, Gururaja gururaja.heb...@ti.com Date: Thu, 23 May 2013 11:28:38 + On Thu, May 23, 2013 at 12:27:41, David Miller wrote: From: Mugunthan V N mugunthan...@ti.com Date: Tue, 21 May 2013 15:24:58 +0530 + priv-pins_default = pinctrl_lookup_state(priv-pinctrl

Re: [net-next PATCH 0/6] Adding pinctrl PM support for CPSW and Davinci MDIO drivers

2013-05-03 Thread David Miller
Please read: http://marc.info/?l=linux-netdevm=136730964130303w=2 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

2013-04-30 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 30 Apr 2013 14:57:28 +0530 With the commit a11fbba (net/cpsw: fix irq_disable() with threaded interrupts) from Sebastian Siewior, a kernel warning is generated as below. This warning is generated as the irq_enabled is not initialized for the

Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

2013-04-29 Thread David Miller
From: Sebastian Andrzej Siewior bige...@linutronix.de Date: Fri, 26 Apr 2013 14:03:24 +0200 David, how did this happen? The patch I've sent http://www.spinics.net/lists/netdev/msg234240.html adds this to the probe function, according to the net-next tree it was added to

Re: [net-next PATCH 1/3] drivers: of: add phy fixup support in DT

2013-04-25 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 22 Apr 2013 23:50:36 +0530 In earlier case phy fixup are added in board file as this is no more the case so adding support for phy register fixup in Device Tree Signed-off-by: Mugunthan V N mugunthan...@ti.com When people put a series of

Re: [net PATCH 1/1] drivers: net: ethernet: cpsw: get slave VLAN id from slave node instead of cpsw node

2013-04-15 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 15 Apr 2013 23:01:28 +0530 Dual EMAC slave VLAN id must be got from slave node instead of cpsw node as VLAN id for each slave will be different. Reported-by: Mark Jackson mpfj-l...@mimc.co.uk Signed-off-by: Mugunthan V N mugunthan...@ti.com

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-03 Thread David Miller
From: Kishon Vijay Abraham I kis...@ti.com Date: Wed, 3 Apr 2013 11:29:53 +0530 Hi, On Friday 29 March 2013 12:01 AM, David Miller wrote: You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. I was CC'ing whatever get_maintainer shows. I'll make

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-03 Thread David Miller
From: Kishon Vijay Abraham I kis...@ti.com Date: Wed, 3 Apr 2013 12:05:30 +0530 This patch series is about drivers/phy which will be used for now by usb, sata and maybe some video PHY's. Network itself has a comprehensive PHY in drivers/net/phy which we'd like to merge it with drivers/phy so

Re: [PATCH v4 0/6] Generic PHY Framework

2013-03-28 Thread David Miller
You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: ethernet: ti: sparse warning fix for ti ethernet drivers

2013-03-27 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 27 Mar 2013 15:28:07 +0530 @@ -179,7 +179,7 @@ cpdma_desc_pool_create(struct device *dev, u32 phys, u32 hw_addr, } else { pool-cpumap = dma_alloc_coherent(dev, size, pool-phys,

Re: [net-next PATCH 0/2] network performance improvement patches for TI CPSW and Davinci EMAC drivers

2013-03-27 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 27 Mar 2013 20:11:58 +0530 This patch series improves network performance of TI CPSW and Davinci EMAC drivers during bulk transfer. During heavy Tx load CPDMA may run out of descriptors and tx queue is stopped. When it descriptors are

Re: [net PATCH 1/1] drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()

2013-03-17 Thread David Miller
From: Prabhakar Lad prabhakar.cse...@gmail.com Date: Sat, 16 Mar 2013 12:43:14 +0530 Hi Mugunthan Thanks for the patch! On Fri, Mar 15, 2013 at 7:40 PM, Mugunthan V N mugunthan...@ti.com wrote: Fix which was done in the following commit in cpsw driver has to be taken forward to davinci

Re: [PATCH v2 0/5] cpsw interrupt pacing and get/set phy setting implementation

2013-03-13 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 12 Mar 2013 14:46:33 +0530 This patch serires implements the following features in CPSW driver * get/set phy link settings * interrupt pacing * get phy id via ioctl cmd SIOCGMIIPHY Changes from initial version * Made active-slave common

Re: [PATCH v3 net-next 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

2013-02-18 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 18 Feb 2013 13:49:20 +0530 CPDMA interrupts are not properly acknowledged which leads to interrupt storm, only cpdma interrupt 0 is acknowledged in Davinci CPDMA driver. Changed cpdma_ctlr_eoi api to acknowledge 1 and 2 interrupts which are

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

2013-02-15 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 14 Feb 2013 23:56:46 +0530 +enum { + CPDMA_EOI_RX_THRESH = 0, + CPDMA_EOI_RX, + CPDMA_EOI_TX, + CPDMA_EOI_MISC, +}; Do not use enumerations for hardware register values, which must be exact, otherwise you are potentially

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

2013-02-15 Thread David Miller
Also please indicate, clearly, what tree your patch is targetted at. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

2013-02-15 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 15 Feb 2013 12:18:59 -0800 On Fri, 2013-02-15 at 15:05 -0500, David Miller wrote: From: Mugunthan V N mugunthan...@ti.com Date: Thu, 14 Feb 2013 23:56:46 +0530 +enum { + CPDMA_EOI_RX_THRESH = 0, + CPDMA_EOI_RX, + CPDMA_EOI_TX

Re: [PATCH 0/3] Dual EMAC mode implementation of CPSW

2013-02-12 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 12 Feb 2013 01:22:17 +0530 This patch series implements Dual EMAC mode implementation of CPSW which acts as two standalone EMAC by segregating the switch using VIDs and port VLAN Mugunthan V N (3): driver: net: ethernet: davinci_cpdma:

Re: [PATCH v4 0/2] Add CPSW VLAN Support

2013-02-06 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 5 Feb 2013 23:56:46 +0530 CPSW is capable of filtering VLAN packets in hardware. This patch series implements VLAN support to CPSW driver. This patch series is tested on net-next with AM335x EVM with ping test. Series applied. -- To

Re: [PATCH v3 2/2] drivers: net:ethernet: cpsw: add support for VLAN

2013-02-04 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 1 Feb 2013 00:33:20 +0530 diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt index 6ddd028..99696bf 100644 --- a/Documentation/devicetree/bindings/net/cpsw.txt +++

Re: [PATCH v2 0/2] cpts fixes for v3.8-rc2

2012-12-26 Thread David Miller
From: Richard Cochran richardcoch...@gmail.com Date: Mon, 24 Dec 2012 08:19:08 +0100 Changed in v2: Use clk_prepare_enable instead of clk_prepare + clk_enable. The new cpts driver has two small issues, but it otherwise seems to be working in -rc1. Both applied, thanks. -- To unsubscribe

Re: cpts: Fix build error caused by include of plat/clock.h

2012-12-14 Thread David Miller
From: Richard Cochran richardcoch...@gmail.com Date: Fri, 14 Dec 2012 12:09:18 +0100 On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote: Op 14 dec. 2012, om 08:13 heeft Richard Cochran richardcoch...@gmail.com het volgende geschreven: On Thu, Dec 13, 2012 at 01:36:41PM -0800,

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

2012-12-11 Thread David Miller
You cannot do this. After your changes the driver no longer does any TX flow control. It never stops the TX queue and never wakes it up later. It just drops packets on the floor when it runs out of descriptors. This breaks everything, and in particular packet schedulers and TCP. I'm not

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

2012-12-11 Thread David Miller
From: David Miller da...@davemloft.net Date: Tue, 11 Dec 2012 13:30:58 -0500 (EST) You cannot do this. After your changes the driver no longer does any TX flow control. It never stops the TX queue and never wakes it up later. It just drops packets on the floor when it runs out

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

2012-12-11 Thread David Miller
From: Eric Dumazet erdnet...@gmail.com Date: Tue, 11 Dec 2012 10:54:56 -0800 Suggested fix : add a TCQ_F_MQSLAVE flag to allow dequeue_skb() to test the netif_xmit_frozen_or_stopped() status _before_ dequeing packet from qdisc. This sounds fine to me. -- To unsubscribe from this list: send

Re: [PATCH 1/1] net: ethernet: cpsw: fix build warnings for CPSW when CPTS not selected

2012-11-28 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 27 Nov 2012 23:23:40 +0530 CC drivers/net/ethernet/ti/cpsw.o drivers/net/ethernet/ti/cpsw.c: In function 'cpsw_ndo_ioctl': drivers/net/ethernet/ti/cpsw.c:881:20: warning: unused variable 'priv' The build warning is generated when

Re: [PATCH V5 0/7] ARM: AM33XX: net: Add DT support to CPSW and MDIO driver

2012-11-14 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 15 Nov 2012 00:37:53 +0530 This patch-series adds support for, [1/7]: Typo mistake in CPSW driver while invoking runtime_pm api's [2/7]: Adds parent-child relation between CPSW MDIO module inside cpsw driver, as in case of AM33XX,

Re: [PATCH 0/2] Add device tree support for davinci_mdio driver and fix cpsw DT binding documentation

2012-08-07 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 6 Aug 2012 20:35:56 +0530 This patch set adds support for device tree for Davinci MDIO driver and fixes CPSW DT binding documentation to make it copy pastable to dts file. This patch set is tested with the following git tree on AM335X Beagle

Re: [PATCH v3 0/2] net: ethernet: davinci_emac: fixups + pm_runtime

2012-07-22 Thread David Miller
From: Mark A. Greer mgr...@animalcreek.com Date: Fri, 20 Jul 2012 18:19:20 -0700 From: Mark A. Greer mgr...@animalcreek.com This series fixes a compile error in, and adds pm_runtime support to, the davinci_emac driver. To test on a davinci platform, you will need another patch just

Re: [PATCH] ethernet: add export.h in davinci_cpdma.c

2012-07-01 Thread David Miller
From: Kim, Milo milo@ti.com Date: Mon, 2 Jul 2012 01:17:03 + To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header. ... @@ -19,6 +19,7 @@ #include linux/err.h #include linux/dma-mapping.h #include linux/io.h +#include linux/export.h You aren't generating

Re: [PATCH] ethernet: add export.h in davinci_cpdma.c

2012-07-01 Thread David Miller
Also, networking patches should always be CC:'d to net...@vger.kernel.org -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ks8851: Fix NOHZ local_softirq_pending 08 warning

2012-02-13 Thread David Miller
From: Benoit Cousson b-cous...@ti.com Date: Mon, 13 Feb 2012 18:37:12 +0100 This fix a similar problem as in 72092cc45378176ba700034c91b7af2db524df26 and 481a8199142c050b72bff8a1956a49fd0a75bbe0 (can: fix NOHZ local_softirq_pending 08 warning). This fix replaces netif_rx() with netif_rx_ni()

Re: [PATCH 2/2 v5] net/smsc911x: Add regulator support

2011-11-29 Thread David Miller
From: Robert Marklund robert.markl...@stericsson.com Date: Thu, 24 Nov 2011 12:03:07 +0100 Add some basic regulator support for the power pins, as needed by the ST-Ericsson Snowball platform that powers up the SMSC911 chip using an external regulator. Platforms that use regulators and the

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-03 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Wed, 2 Nov 2011 16:40:28 -0700 Subject: [PATCH] net: Add back alignment for size for __alloc_skb Applied, thanks a lot! -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 02 Nov 2011 23:55:11 +0100 There is a problem with your kmalloc() or alignments on your architecture. What is the SMP_CACHE_BYTES value ? kmalloc() behavior doesn't have anything to do with this bug. The issue is calculation of skb-end,

Re: [PATCH] net: Add back alignment for size for __alloc_skb

2011-11-02 Thread David Miller
From: David Miller da...@davemloft.net Date: Wed, 02 Nov 2011 19:09:55 -0400 (EDT) From: Eric Dumazet eric.duma...@gmail.com Date: Wed, 02 Nov 2011 23:55:11 +0100 There is a problem with your kmalloc() or alignments on your architecture. What is the SMP_CACHE_BYTES value ? kmalloc

  1   2   >