Re: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread T Krishnamoorthy, Balaji
On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja wrote: > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > Other platforms like TI81xx, OMAP4 may need this as-well. This depends > on the HSMMC IP timing closure done for the high speed cards. > > From AM335x TRM (SPRUH73F - 1

Re: [PATCH 2/2] mmc: omap_hsmmc: cleanup the bitmap definitions of Interrupt Register

2012-08-28 Thread T Krishnamoorthy, Balaji
On Tue, Aug 28, 2012 at 6:49 PM, Venkatraman S wrote: > Define the most frequently used bitmasks of the Interrupt Enable / > Interrupt Status register with consistent naming ( with _EN suffix). > > Use meaningful concatenation of bitfields for INT_EN_MASK, which shows > which interrupts are enable

Re: [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs

2012-08-21 Thread T Krishnamoorthy, Balaji
On Sat, Aug 18, 2012 at 12:22 AM, Venkatraman S wrote: > Flushing spurious IRQs from HSMMC IP is done twice in > omap_hsmmc_irq and omap_hsmmc_do_irq. spurious IRQ is flushed in start of omap_hsmmc_do_irq and irq acked at the end of omap_hsmmc_do_irq > Consolidate them to one location. if you w

Re: am3517: geting MMC working

2012-07-20 Thread T Krishnamoorthy, Balaji
On Fri, Jul 20, 2012 at 3:08 AM, Paul Walmsley wrote: > On Thu, 19 Jul 2012, S, Venkatraman wrote: > >> >From this, one can only infer that the card is not responding at all, >> and all attempts >> are returning with a timeout (CTO=Command Time Out). > > Looks to me like the card is responding to

Re: am3517: geting MMC working

2012-07-19 Thread T Krishnamoorthy, Balaji
On Thu, Jul 19, 2012 at 2:27 PM, S, Venkatraman wrote: > On Thu, Jul 19, 2012 at 1:45 PM, Yegor Yefremov > wrote: >> Waiting for root device /dev/mmcblk0p2... >> mmc0: starting CMD0 arg flags 00c0 >> omap_hsmmc omap_hsmmc.0: mmc0: CMD0, argument 0x >> > > From this, one can

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread T Krishnamoorthy, Balaji
On Wed, Jul 11, 2012 at 4:20 PM, Joe Woodward wrote: > -Original Message- > From: Kevin Hilman > To: "Joe Woodward" > Cc: "linux-omap\@vger.kernel.org" > Date: Tue, 10 Jul 2012 16:58:18 -0700 > Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC? > >> "Joe Woodwar

Re: [PATCH 0/3] mmc: omap: driver registration cleanups

2012-05-10 Thread T Krishnamoorthy, Balaji
On Tue, May 8, 2012 at 5:05 PM, Venkatraman S wrote: > Cleanups for the legacy omap mmc driver to remove clutter and > make it well behaved as module. > > Venkatraman S (3): >  mmc: omap: convert to per instance workqueue >  mmc: omap: make it behave well as module >  mmc: omap: convert to module_

Re: [RFC 00/12] OMAP DMA engine conversion

2012-05-09 Thread T Krishnamoorthy, Balaji
On Mon, Apr 23, 2012 at 9:34 PM, Russell King - ARM Linux wrote: > For the full text, please see > > http://lists.arm.linux.org.uk/lurker/message/20120418.100954.7fa7acf8.en.html > > This version contains updates for some of the comments received from the > previous round, and adds the OMAP1/2 MMC

Re: [PATCH v2] arm: omap4: hsmmc: check for null pointer

2012-04-25 Thread T Krishnamoorthy, Balaji
On Mon, Apr 23, 2012 at 8:13 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 23, 2012 at 08:11:07PM +0530, Balaji T K wrote: >> +int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers) >> +{ >> +     struct omap2_hsmmc_info *c; >> + >> +     omap_hsmmc_init(controllers); >> +     f

Re: [PATCH 00/19] ARM: OMAP4 device off support

2012-04-20 Thread T Krishnamoorthy, Balaji
On Fri, Apr 20, 2012 at 3:03 PM, Tero Kristo wrote: > Hi, > > First version for this work. Applies on top of mainline + iochain set + > OMAP4 core retention set. Working tree available here: > tree: git://gitorious.org/~kristo/omap-pm/omap-pm-work.git > branch: mainline-3.4-omap4-dev-off > > Teste

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: >> Hi, >> >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed > > Does this driver make use of this p

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 3:42 PM, Russell King wrote: > DMAengine uses the DMA engine device structure when mapping/unmapping > memory for DMA, so the MMC devices do not need their DMA masks > initialized (this reflects hardware: the MMC device is not the device > doing DMA.) > > Signed-off-by: Rus

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread T Krishnamoorthy, Balaji
On Wed, Apr 11, 2012 at 3:33 PM, Rajendra Nayak wrote: > of_have_populated_dt() is not expected to be used in drivers but > instead only in early platform init code. > Drivers on the other hand should rely on dev->of_node or of_match_device(). > Besides usage of of_have_populated_dt() also throws

Re: omap-hsmmc build broken with OF enabled in latest kernel

2012-04-10 Thread T Krishnamoorthy, Balaji
On Tue, Apr 10, 2012 at 7:33 PM, Chris Ball wrote: > Hi, > > On Tue, Apr 10 2012, Russell King - ARM Linux wrote: >> This commit: >> >> commit 46856a68dcb5f67c779d211fd6bcb5d7a2a7f19b >> Author: Rajendra Nayak >> Date:   Mon Mar 12 20:32:37 2012 +0530 >> >>     mmc: omap_hsmmc: Convert hsmmc driv

Re: [PATCH RESEND 4/8] mmc: omap: context save after enabling runtime pm

2012-03-16 Thread T Krishnamoorthy, Balaji
On Thu, Mar 15, 2012 at 8:42 PM, Shubhrajyoti wrote: > On Thursday 15 March 2012 08:03 PM, Venkatraman S wrote: >> From: Balaji T K >> >> call context save api after enabling runtime pm >> to make sure register access in context save api > If I am not mistaken  the api  would > store the number o

Re: [PATCH 1/6] mmc: host: omap_hsmmc: trivial cleanups

2012-03-15 Thread T Krishnamoorthy, Balaji
On Thu, Mar 15, 2012 at 7:30 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 15, 2012 at 07:20:22PM +0530, T Krishnamoorthy, Balaji wrote: >> On Wed, Mar 14, 2012 at 2:48 PM, Felipe Balbi wrote: >> > a bunch of non-functional cleanups to the omap_hsmmc >> > driver.

Re: [PATCH 1/6] mmc: host: omap_hsmmc: trivial cleanups

2012-03-15 Thread T Krishnamoorthy, Balaji
On Wed, Mar 14, 2012 at 2:48 PM, Felipe Balbi wrote: > a bunch of non-functional cleanups to the omap_hsmmc > driver. > > It basically decreases indentation level, drop unneded > dereferences and drop unneded accesses to the platform_device > structure. > > Signed-off-by: Felipe Balbi > --- >  dr

Re: [PATCH v2 0/4] omap hsmmc device tree support

2012-03-13 Thread T Krishnamoorthy, Balaji
On Mon, Mar 12, 2012 at 8:32 PM, Rajendra Nayak wrote: > The series adds device tree support for OMAP hsmmc > driver. > > Changes in V2: > -1- Minor fixes based on comments from Grant. > -2- Added a seperate compatible for omap3. > -3- Added a new binding "ti,needs-special-reset" > to handle some

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-08 Thread T Krishnamoorthy, Balaji
On Wed, Mar 7, 2012 at 9:12 PM, Chris Ball wrote: > Hi Balaji, > > On Wed, Mar 07 2012, T Krishnamoorthy, Balaji wrote: >> OMAP4 and OMAP3 HSMMC IP registers differ by 0x100 offset. >> Addng the offset to platform_device resource structure >> increments the sta

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-07 Thread T Krishnamoorthy, Balaji
On Mon, Mar 5, 2012 at 3:55 PM, T Krishnamoorthy, Balaji wrote: > On Mon, Mar 5, 2012 at 2:46 PM, Rajendra Nayak wrote: >> On Friday 02 March 2012 10:52 PM, Tony Lindgren wrote: >>> >>> BTW, with -rc5, looks like re-inserting omap_hsmmc on omap4 fails >>> to

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-05 Thread T Krishnamoorthy, Balaji
On Mon, Mar 5, 2012 at 2:46 PM, Rajendra Nayak wrote: > On Friday 02 March 2012 10:52 PM, Tony Lindgren wrote: >> >> BTW, with -rc5, looks like re-inserting omap_hsmmc on omap4 fails >> to detect any cards, and then fails to unload. This works on omap3 >> just fine. Any ideas why that would be? >

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread T Krishnamoorthy, Balaji
On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote: > Define dt bindings for the ti-omap-hsmmc, and adapt > the driver to extract data (which was earlier passed as > platform_data) from device tree. > > Signed-off-by: Rajendra Nayak > --- >  .../devicetree/bindings/mmc/ti-omap-hsmmc.txt      |

Re: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data

2012-02-24 Thread T Krishnamoorthy, Balaji
On Fri, Feb 24, 2012 at 3:56 PM, Rajendra Nayak wrote: > On Friday 24 February 2012 03:46 PM, T Krishnamoorthy, Balaji wrote: >>> >>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >>> index 29f4589..9204f60 100644 >>> --- a/arch

Re: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data

2012-02-24 Thread T Krishnamoorthy, Balaji
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 29f4589..9204f60 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -25,6 +25,11 @@ >                serial1 = &uart2; >                serial2 = &uart3; >                serial3 =

Re: [PATCH 0/6] mmc: omap_hsmmc: Clean up use/abuse of pdev->id

2012-02-10 Thread T Krishnamoorthy, Balaji
On Tue, Feb 7, 2012 at 3:32 PM, S, Venkatraman wrote: > On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak wrote: >> This series mainly cleans up all instances of hardcoding's in >> the driver based on pdev->id. This is cleanup leading to the >> DT adaptation of omap_hsmmc driver. >> >> Patches are b

Re: [PATCH] ARM: OMAP2+ i2c NACK without STP

2011-12-27 Thread T Krishnamoorthy, Balaji
On Tue, Jun 14, 2011 at 4:24 PM, Jan Weitzel wrote: > On OMAP4 OMAP_I2C_STAT_NACK is causing a timeout on the next access. > The isr cleans all flags in OMAP_I2C_CON_REG by setting OMAP_I2C_CON_STP > OMAP_I2C_CON_STP is also set in omap_i2c_xfer_msg on the last message. > > According to the TI TSR

Re: [PATCH] ARM: OMAP: hsmmc: add max_freq field

2011-12-23 Thread T Krishnamoorthy, Balaji
On Wed, Dec 14, 2011 at 6:52 PM, Daniel Mack wrote: > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 101cd31..8215ef9 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1927,8 +1927,12 @@ static int __init omap_hsmmc_probe(s

Re: [PATCH v2 01/11] TWL6030: Add mapping for auxiliary regs

2011-12-01 Thread T Krishnamoorthy, Balaji
On Thu, Dec 1, 2011 at 5:44 AM, Sergio Aguirre wrote: > Signed-off-by: Sergio Aguirre > --- >  drivers/mfd/twl-core.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index bfbd660..e26b564 100644 > --- a/drivers/mfd/

Re: [PATCH v8 00/24] gpio/omap: driver cleanup and fixes

2011-11-30 Thread T Krishnamoorthy, Balaji
On Tue, Nov 29, 2011 at 8:45 PM, Kevin Hilman wrote: > "DebBarma, Tarun Kanti" writes: > >> On Fri, Nov 4, 2011 at 2:57 PM, DebBarma, Tarun Kanti >> wrote: >>> On Fri, Nov 4, 2011 at 3:14 AM, Kevin Hilman wrote: Tarun Kanti DebBarma writes: > This series is continuation of cleanu

Re: omap_hsmmc noisy/broken for suspend resume

2011-11-04 Thread T Krishnamoorthy, Balaji
On Fri, Nov 4, 2011 at 2:54 AM, Kevin Hilman wrote: > > Hello, > > Using Linus' master branch, I was testing PM functionality on OMAP3/4 > and noticed that the MMC driver is now rather noisy during suspend on > OMAP3[1], but seems to work. > > On OMAP4, MMC seems to prevent suspend/resume all toge

Re: [PATCH 1/2] arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF

2011-09-30 Thread T Krishnamoorthy, Balaji
On Thu, Sep 29, 2011 at 9:50 PM, Tony Lindgren wrote: > * Balaji T K [110929 07:11]: >> MMC1 data line IO's are powered down in before set regulator function. >> IO's should not be powered ON when regulator is OFF. >> Keep the IO's in power pown mode after regulator OFF. >> Delete incorrect comme

Re: [PATCH 0/2] arm: omap4: hsmmc: pbias fixes

2011-09-29 Thread T Krishnamoorthy, Balaji
> From: Balaji T K Will resend this series as my email id is garbled. > > MMC1 pbias and speed control fix for SDMMC1 extended I/O cell > > Balaji T K (2): >  arm: omap4: hsmmc: Fix Pbias configuration on regulator OFF >  arm: omap4: hsmmc: configure SDMMC1_DR0 properly > >  arch/arm/mach-omap2/h

Re: [PATCH V2 11/16] mmc: omap_hsmmc: ensure pbias configuration is always done

2011-09-29 Thread T Krishnamoorthy, Balaji
On Fri, May 6, 2011 at 2:44 PM, Adrian Hunter wrote: > Go through the driver's set_power() functions rather than > calling regulator_enable/disable() directly because otherwise > pbias configuration for MMC1 is not done. Hi Chris, Are you OK to queue this patch as bug fix. Rest of the patches of

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-09-28 Thread T Krishnamoorthy, Balaji
Hi Tony, Can you queue this patch ? On Fri, Sep 9, 2011 at 7:34 PM, T Krishnamoorthy, Balaji wrote: > On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan wrote: >> On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala >> wrote: >>> >>> On Fri, Jul 22, 2011 at 12

Re: [RFC PATCH 1/6] usb: musb: omap: Configure OTG_INTERFSEL for proper charger detection

2011-09-19 Thread T Krishnamoorthy, Balaji
On Fri, Sep 16, 2011 at 7:43 PM, Greg KH wrote: > On Fri, Sep 16, 2011 at 07:21:41PM +0530, ABRAHAM, KISHON VIJAY wrote: >> Sergei, >> >> Thanks for your comments. >> >> On Fri, Sep 16, 2011 at 3:18 PM, Sergei Shtylyov >> wrote: >> > Hello. >> > >> > On 15-09-2011 18:19, Kishon Vijay Abraham I w

Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1

2011-09-09 Thread T Krishnamoorthy, Balaji
On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan wrote: > On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala > wrote: >> >> On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley wrote: >> > Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRDNZ mode for >> > MMC1_PBIAS and associated extended

Re: [PATCH 3/5] OMAP: I2C: Remove the reset in the init path

2011-07-21 Thread T Krishnamoorthy, Balaji
On Thu, Jul 21, 2011 at 12:23 PM, Shubhrajyoti D wrote: > The reset in the driver at init is not needed > anymore as the hwmod framework takes care of > reseting it. > > Signed-off-by: Shubhrajyoti D > --- >  drivers/i2c/busses/i2c-omap.c |   57 > +++-- >  1 f

Re: [PATCH 5/5] OMAP: I2C: Restore only if context is lost

2011-07-21 Thread T Krishnamoorthy, Balaji
On Thu, Jul 21, 2011 at 12:23 PM, Shubhrajyoti D wrote: > Currently restore is done always. > Adding conditional restore.The restore is done only if the context is lost. > > Signed-off-by: Shubhrajyoti D > --- > @@ -261,6 +263,18 @@ static inline u16 omap_i2c_read_reg(struct omap_i2c_dev > *i2c_

Re: [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-07-01 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 4:53 AM, Kevin Hilman wrote: > Balaji T K writes: > >> +static int omap_hsmmc_runtime_resume(struct device *dev) >> +{ >> +     struct omap_hsmmc_host *host; >> + >> +     host = platform_get_drvdata(to_platform_device(dev)); >> +     omap_hsmmc_context_restore(host); >> +

Re: [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-06-30 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 1:06 AM, Cousson, Benoit wrote: > Hi Balaji, > > On 6/30/2011 9:04 PM, Krishnamoorthy, Balaji T wrote: >> >> Removing the custom state machine - lazy disable framework in omap_hsmmc >> to make way for runtime pm to handle host controller >> power states. >> This allows mmc_h

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-30 Thread T Krishnamoorthy, Balaji
On Thu, Jun 30, 2011 at 10:01 AM, T Krishnamoorthy, Balaji wrote: > On Wed, Jun 29, 2011 at 11:26 PM, Kevin Hilman wrote: >> "T Krishnamoorthy, Balaji" writes: >> >>> On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman wrote: >>>> +Rajendra >>&

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 11:26 PM, Kevin Hilman wrote: > "T Krishnamoorthy, Balaji" writes: > >> On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman wrote: >>> +Rajendra >>> >>> Balaji T K writes: >>> >>>> add runtime pm support to

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 8:12 PM, Paul Walmsley wrote: > On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: > >> On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley wrote: >> > On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: >> > >> >> On Tue, Jun

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 2:00 AM, Kevin Hilman wrote: > "T Krishnamoorthy, Balaji" writes: > >> On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: >>> (cc'ing Adrian also) >>> >>> Hi Balaji >>> >>> On Wed, 22 Jun 2011

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley wrote: > On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: > >> On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: >> > >> > On Wed, 22 Jun 2011, Balaji T K wrote: >> > >> >> Use ru

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman wrote: > +Rajendra > > Balaji T K writes: > >> add runtime pm support to HSMMC host controller >> Use runtime pm API to enable/disable HSMMC clock >> Use runtime autosuspend APIs to enable auto suspend delay >> >> Based on OMAP HSMMC runtime implement

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-28 Thread T Krishnamoorthy, Balaji
On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley wrote: > (cc'ing Adrian also) > > Hi Balaji > > On Wed, 22 Jun 2011, Balaji T K wrote: > >> Use runtime autosuspend APIs to enable auto suspend delay > > Does this really need to use runtime autosuspend?  Seems to me that since > PM runtime is just c

Re: [PATCH 3/3] MMC: OMAP: HSMMC: Remove unused iclk

2011-06-27 Thread T Krishnamoorthy, Balaji
On Wed, Jun 22, 2011 at 9:57 PM, Cousson, Benoit wrote: > On 6/22/2011 4:18 PM, Krishnamoorthy, Balaji T wrote: >> >> After runtime conversion to handle clk, >> iclk node is not used >> However fclk node is still used to get clock rate. >> >> Signed-off-by: Balaji T K >> --- >>  drivers/mmc/host/o

Re: [PATCH 1/3] MMC: OMAP: HSMMC: Remove lazy_disable

2011-06-23 Thread T Krishnamoorthy, Balaji
On Wed, Jun 22, 2011 at 11:56 PM, Kevin Hilman wrote: > Balaji T K writes: > >> lazy_disable framework in OMAP HSMMC manages multiple low power states >> and Card is powered off after inactivity time of 8 seconds. >> Based on previous discussion on the list Card power(regulator) > > needs some pu

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-23 Thread T Krishnamoorthy, Balaji
On Thu, Jun 23, 2011 at 12:08 AM, Kevin Hilman wrote: > Balaji T K writes: > >> @@ -1880,18 +1873,12 @@ static int __init omap_hsmmc_probe(struct >> platform_device *pdev) >> >>       mmc->caps |= MMC_CAP_DISABLE; >> >> -     if (clk_enable(host->iclk) != 0) { >> -             clk_put(host->icl

Re: [PATCH 1/2] OMAP4 :TWL6030: Regulator set the default behavior of LDO's

2011-06-22 Thread T Krishnamoorthy, Balaji
On Wed, Jun 22, 2011 at 5:54 AM, Girish S G wrote: > TWL6030 below table shows the default state each LDO's can > be put into. > >        +---+ >        | LDO   |       Usage           |       state                   | >        +-

Re: [PATCH 4/8] mfd: twl6040: Add initial support

2011-06-01 Thread T Krishnamoorthy, Balaji
On Wed, Jun 1, 2011 at 4:47 PM, Peter Ujfalusi wrote: > From: Misael Lopez Cruz > > TWL6040 IC provides analog high-end audio codec functions for > handset applications. It contains several audio analog inputs > and outputs as well as vibrator support. It's connected to the > host processor via P

Re: [PATCH 1/2] ARM: OMAP4: MMC: increase delay for pbias

2011-06-01 Thread T Krishnamoorthy, Balaji
On Wed, Jun 1, 2011 at 1:11 PM, Tony Lindgren wrote: > * Balaji T K [110530 07:23]: >> 4 micro seconds is not enough for PBIAS if MMC regulator is >> enabled from MMC regulator OFF. >> Increase the delay for PBIAS to stabilize. >> Wait for PBIAS and timeout if not. >> >> Resolves MMC/SD failure o

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread T Krishnamoorthy, Balaji
On Tue, May 31, 2011 at 6:56 PM, Tony Lindgren wrote: > * Balaji T K [110530 07:23]: >> eMMC does not handle power off when not in sleep state, >> Skip regulator disable during probe when eMMC is >> not in known state - state left by bootloader. >> >> Resolves eMMC failure on OMAP4 >> mmc0: error

Re: V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression

2011-05-30 Thread T Krishnamoorthy, Balaji
On Mon, May 30, 2011 at 6:03 PM, Santosh Shilimkar wrote: > While trying out V3.0-rc1, I noticed couple of regressions. Am > posting this in case anybody come across same issues. > > 1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error > continuously. > > Balaji is planning post

Re: [PATCH v3 1/2] REGULATOR: TWL6025: add support to twl-regulator

2011-05-20 Thread T Krishnamoorthy, Balaji
On Thu, May 19, 2011 at 12:02 AM, Graeme Gregory wrote: > Adding support for the twl6025. Major difference in the twl6025 is the > group functionality has been removed from the chip so this affects how > regulators are enabled and disabled. > > The names of the regulators also changed. > > The DCD

Re: [PATCH v2 3/4] REGULATOR: TWL6025: add support to twl-regulator

2011-05-16 Thread T Krishnamoorthy, Balaji
On Thu, May 12, 2011 at 6:57 PM, Graeme Gregory wrote: > Adding support for the twl6025. Major difference in the twl6025 is the > group functionality has been removed from the chip so this affects how > regulators are enabled and disabled. > > The names of the regulators also changed. > > The DCDC