Re: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Igor Grinberg
Hi, Already replied to Sergei on the comments below, so please see the answer in my reply to Sergei. On 09/29/10 17:46, Gupta, Ajay Kumar wrote: > Hi, > > [...] >>> + devconf2 &= ~CONF2_OTGMODE; >>> + switch (musb_mode) { >>> +#ifdef CONFIG_USB_MUSB_OTG >>> + case MUSB_OTG: /*

RE: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Gupta, Ajay Kumar
Hi, > > > > +config USB_MUSB_AM35X > > + boolean "AM35X MUSB support" > > + depends on USB_MUSB_HDRC && MACH_OMAP3517EVM > > As I've already said, depending on the board type won't scale... :-( ..and to scale it up we need to add "select USB_MUSB_AM35X" in arch/arm/mach-omap2/Kconfig for

Re: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Igor Grinberg
Hi, On 09/29/10 17:38, Sergei Shtylyov wrote: > Hello. > > Igor Grinberg wrote: > >>> AM35x has musb interface and uses CPPI4.1 DMA engine. >>> Current patch supports only PIO mode. DMA support can be >>> added later once basic CPPI4.1 DMA patch is accepted. > >>> Also added USB_MUSB_AM35X which

RE: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Gupta, Ajay Kumar
Hi, [...] > > + devconf2 &= ~CONF2_OTGMODE; > > + switch (musb_mode) { > > +#ifdef CONFIG_USB_MUSB_OTG > > + case MUSB_OTG: /* Don't override the VBUS/ID comparators */ > > + devconf2 |= CONF2_NO_OVERRIDE; > > This does nothing, can be removed... Yes, but it's good t

Re: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Sergei Shtylyov
Hello. Igor Grinberg wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Also added USB_MUSB_AM35X which is required to differentiate musb ips between OMAP3x and AM35x. Thi

Re: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Also added USB_MUSB_AM35X which is required to differentiate musb ips between OMAP3x and AM35x.

Re: [PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Igor Grinberg
On 09/29/10 14:45, Ajay Kumar Gupta wrote: > AM35x has musb interface and uses CPPI4.1 DMA engine. > Current patch supports only PIO mode. DMA support can be > added later once basic CPPI4.1 DMA patch is accepted. > > Also added USB_MUSB_AM35X which is required to differentiate musb ips > between

[PATCH 2/3 v4] musb: add musb support for AM35x

2010-09-29 Thread Ajay Kumar Gupta
AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Also added USB_MUSB_AM35X which is required to differentiate musb ips between OMAP3x and AM35x. This config would be used to for belo