RE: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-20 Thread Tomi Valkeinen
On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > Hi, > Any more comments on this patch? I'm not sure if enabling kernel options by default is a good thing. Somehow I remember that enabling things by default is not looked kindly at. Shouldn't they be enabled in the arch/arm/config

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-18 Thread Tony Lindgren
* Paul Mundt [101118 10:29]: > On Thu, Nov 18, 2010 at 08:44:14AM -0800, Tony Lindgren wrote: > > * Paul Mundt [101117 22:09]: > > > Unless you can say with certainty that all OMAP3 boards are going to want > > > DSS enabled or modular by default, it's almost always better to just > > > leave it

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-18 Thread Paul Mundt
On Thu, Nov 18, 2010 at 08:44:14AM -0800, Tony Lindgren wrote: > * Paul Mundt [101117 22:09]: > > Unless you can say with certainty that all OMAP3 boards are going to want > > DSS enabled or modular by default, it's almost always better to just > > leave it up to the defconfigs. > > I wish we cou

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-18 Thread Tony Lindgren
* Paul Mundt [101117 22:09]: > On Wed, Nov 17, 2010 at 02:28:11PM +0200, Tomi Valkeinen wrote: > > On Tue, 2010-11-16 at 21:10 +0100, ext Tony Lindgren wrote: > > > Sure a module would be even better. My point is that the selection of > > > all the features should be enabled by default and the boa

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-17 Thread Paul Mundt
On Wed, Nov 17, 2010 at 02:28:11PM +0200, Tomi Valkeinen wrote: > On Tue, 2010-11-16 at 21:10 +0100, ext Tony Lindgren wrote: > > Sure a module would be even better. My point is that the selection of > > all the features should be enabled by default and the board options come > > from platform_data

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-17 Thread Tomi Valkeinen
On Tue, 2010-11-16 at 21:10 +0100, ext Tony Lindgren wrote: > * Kevin Hilman [101116 11:45]: > > Tony Lindgren writes: > > > > > * Tomi Valkeinen [101116 05:41]: > > >> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > > >> > Hi, > > >> > Any more comments on this patch? > > >>

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-16 Thread Tony Lindgren
* Kevin Hilman [101116 11:45]: > Tony Lindgren writes: > > > * Tomi Valkeinen [101116 05:41]: > >> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > >> > Hi, > >> > Any more comments on this patch? > >> > >> I'm not sure if enabling kernel options by default is a good thing. >

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-16 Thread Kevin Hilman
Tony Lindgren writes: > * Tomi Valkeinen [101116 05:41]: >> On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: >> > Hi, >> > Any more comments on this patch? >> >> I'm not sure if enabling kernel options by default is a good thing. >> Somehow I remember that enabling things by def

Re: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-16 Thread Tony Lindgren
* Tomi Valkeinen [101116 05:41]: > On Tue, 2010-11-16 at 07:09 +0100, ext Nilofer, Samreen wrote: > > Hi, > > Any more comments on this patch? > > I'm not sure if enabling kernel options by default is a good thing. > Somehow I remember that enabling things by default is not looked kindly > at.

RE: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-11-15 Thread Nilofer, Samreen
Hi, Any more comments on this patch? Warm Regards, Samreen Nilofer, Samreen wrote: > The defconfig options for display are taken in the respective > Kconfig to enable display by default on OMAP3 platforms > > Signed-off-by: Samreen > --- > Version4: >Remove the enabling of the displa

[PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3

2010-10-25 Thread Samreen
The defconfig options for display are taken in the respective Kconfig to enable display by default on OMAP3 platforms Signed-off-by: Samreen --- Version4: Remove the enabling of the display panels by default. Version3: Eliminate the separate default number of FBs for different a