Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-23 Thread Felipe Balbi
Hi, please break your lines at 80-characters. Also the [Hiremath, Vaibhav] is unnecessary. On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote: don't you need some locking on the irq handler ? a mutex maybe ? Just wondering... [Hiremath, Vaibhav] Yes definitely we do need

RE: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-23 Thread Hiremath, Vaibhav
Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support Hi, please break your lines at 80-characters. Normally I do take care of this, but missed this time. I will be more careful in the future. Also the [Hiremath, Vaibhav] is unnecessary. On Mon, Aug 23, 2010 at 06:58

RE: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-22 Thread Hiremath, Vaibhav
) Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support Hi, On Sat, Aug 21, 2010 at 02:30:27PM +0200, ext hvaib...@ti.com wrote: +static irqreturn_t s35390a_irq_thread(int irq, void *handle) +{ +char buf[1]; +struct s35390a *s35390a = handle; +struct i2c_client

Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support

2010-08-21 Thread Felipe Balbi
Hi, On Sat, Aug 21, 2010 at 02:30:27PM +0200, ext hvaib...@ti.com wrote: +static irqreturn_t s35390a_irq_thread(int irq, void *handle) +{ + char buf[1]; + struct s35390a *s35390a = handle; + struct i2c_client *client = s35390a-client[0]; don't you need some locking on the