Hello Rajendra,
here are a few more comments on the CPUIdle patch set. Many of these, we
discussed today. A closer look at patch 11/11 reveals that it will need
some additional attention.
- Paul
General
---
1. Please separate the context save/restore patches from the CPUIdle
Serial and gpio clock disabling and gpio_prepare/resume can
be removed
from omap3_pm_idle because they are already done in omap_sram_idle.
And if omap_serial_can_sleep is removed from
omap3_can_sleep it should
be added to omap3_pm_idle.
Omap3_pm_idle can be also put behind
ext Rajendra Nayak [EMAIL PROTECTED] writes:
Check wether serial can sleep is missing from
omap3_enter_idle and it should be removed from omap3_can_sleep:
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index a02da6d..16ff30b 100644
---
Doing this would make serial console to work faster.
Yes, I removed these in my patches and put in the changes suggested by
Richard
in 8250.c
I doubt that your changes to 8250.c will be applied. I have understood
that omap specific changes are not accepted to generic 8250
driver.
Hi Richard,
ext Woodruff, Richard [EMAIL PROTECTED] writes:
Doing this would make serial console to work faster.
Yes, I removed these in my patches and put in the changes suggested by
Richard
in 8250.c
I doubt that your changes to 8250.c will be applied. I have understood
that omap
-Original Message-
From: Woodruff, Richard [mailto:[EMAIL PROTECTED]
Sent: Wednesday, August 13, 2008 6:06 PM
To: Högander Jouni; Nayak, Rajendra
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH 00/11] OMAP3 CPUidle patches - ver 2
Doing this would make serial console
Check wether serial can sleep is missing from
omap3_enter_idle and it should be removed from omap3_can_sleep:
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
b/arch/arm/mach-omap2/cpuidle34xx.c
index a02da6d..16ff30b 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++
On ke, 2008-08-06 at 18:42 +0530, ext Rajendra Nayak wrote:
Hi,
Re-posting a refreshed version of these patches.
I'm getting this error when trying to apply these patches with 'git-am'
command:
$ git-am ~/.evolution/mail/local/stage
Applying Basic cpuidle driver
fatal: patch fragment
Did some idle measurements with these..
VDD1 : 2.0 mA
VDD2 : 2.3 mA
The numbers are on the higher side as the thresholds are still not optimal.
Currently C6 has a threshold set to 300 ms which seems to be very low.
We are working on deriving the optimal thresholds for each C state.
ext Woodruff, Richard [EMAIL PROTECTED] writes:
[x] Has anyone fixed the broken gpio wakeup enable code?
Right now this might even kill you as it will clear you
wakeup enable register. This could stop you from waking
from a partially idle/clock stop
It is not so clear if gpio that hack is even needed on OMAP3. There
is some warning about spurious interrupts when going to RET/OFF for
OMAP2. I don't recall for OMAP3. didn't those prepare functions dink
with wake up masks in fear of spurious interrupts. So, wasn't the
result for you
ext Woodruff, Richard [EMAIL PROTECTED] writes:
I am still trying to find my way thru the codebase in GIT; but here is
what I can suggest based on similar problem diagnosed (still under
test) on the OMAP3EVM:
1) Save/restore the GPIO_IRQENABLE1, GPIO_IRQENABLE2
2) Save/restore the
ext Woodruff, Richard [EMAIL PROTECTED] writes:
For sure save/restore of IRQENABLE is needed. Our Labrador board
which has Ethernet on per-gpio would stop to function after an OFF
mode transition with out this save and restore (using CDP reference
code).
I think this is not related
[x] Has anyone fixed the broken gpio wakeup enable code?
Right now this might even kill you as it will clear you
wakeup enable register. This could stop you from waking
from a partially idle/clock stop condition on the L3?
The problem was actually related
On pe, 2008-07-04 at 15:15 +0530, ext Rajendra Nayak wrote:
...
ext Högander Jouni [EMAIL PROTECTED] writes:
...
So Rajendra sent his uImage and it works quite ok what comes to off
mode on my sdp board. I still see problems with serial console (slow)
and on boot I need to generate
Kalle Jokiniemi [EMAIL PROTECTED] writes:
On pe, 2008-07-04 at 15:15 +0530, ext Rajendra Nayak wrote:
...
ext Högander Jouni [EMAIL PROTECTED] writes:
...
So Rajendra sent his uImage and it works quite ok what comes to off
mode on my sdp board. I still see problems with serial
-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Kalle Jokiniemi [EMAIL PROTECTED] writes:
On pe, 2008-07-04 at 15:15 +0530, ext Rajendra Nayak wrote:
...
ext Högander Jouni [EMAIL PROTECTED] writes:
...
So Rajendra sent his uImage and it works quite ok what comes
I am still trying to find my way thru the codebase in GIT; but here is
what I can suggest based on similar problem diagnosed (still under
test) on the OMAP3EVM:
1) Save/restore the GPIO_IRQENABLE1, GPIO_IRQENABLE2
2) Save/restore the GPIO_IRQSTATUS1, GPIO_IRQSTATUS2
For sure save/restore of
Hi Rajendra,
ext Rajendra Nayak [EMAIL PROTECTED] writes:
-Original Message-
From: Peter 'p2' De Schrijver [mailto:[EMAIL PROTECTED]
Sent: Wednesday, July 02, 2008 9:13 PM
To: ext Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Hi
, 2008 9:13 PM
To: ext Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Hi Rajendra,
Not sure, but you can try with my .config while I try with yours.
I was doing some more testing today, and I saw a hang after
a while of
idle activity
-Original Message-
From: Högander Jouni [mailto:[EMAIL PROTECTED]
Sent: Friday, July 04, 2008 3:02 PM
To: ext Rajendra Nayak
Cc: 'Peter 'p2' De Schrijver'; linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Let's continue this discussion in here to make
ext Rajendra Nayak [EMAIL PROTECTED] writes:
-Original Message-
From: Högander Jouni [mailto:[EMAIL PROTECTED]
Sent: Friday, July 04, 2008 3:02 PM
To: ext Rajendra Nayak
Cc: 'Peter 'p2' De Schrijver'; linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
So Rajendra sent his uImage and it works quite ok what comes to off
mode on my sdp board. I still see problems with serial console (slow)
and on boot I need to generate manually interrupts to get it to
boot. Otherwise board hangs at this point:
eth0: link up
Sending DHCP requests ., OK
ext Rajendra Nayak [EMAIL PROTECTED] writes:
-Original Message-
From: Högander Jouni [mailto:[EMAIL PROTECTED]
Sent: Friday, July 04, 2008 3:02 PM
To: ext Rajendra Nayak
Cc: 'Peter 'p2' De Schrijver'; linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
ext Rajendra Nayak [EMAIL PROTECTED] writes:
Hi,
The following patches define and enable all of the below mentioned C states
for OMAP3.
These are tested with a minimal kernel config on OMAP3430sdp as most drivers
today don't have context save/restore in place and
some even lack
-Original Message-
From: Peter 'p2' De Schrijver [mailto:[EMAIL PROTECTED]
Sent: Wednesday, July 02, 2008 9:13 PM
To: ext Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Hi Rajendra,
Not sure, but you can try with my .config
-Original Message-
From: Högander Jouni [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 03, 2008 11:28 AM
To: ext Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
ext Rajendra Nayak [EMAIL PROTECTED] writes:
Hi
-Original Message-
From: Peter 'p2' De Schrijver [mailto:[EMAIL PROTECTED]
Sent: Wednesday, July 02, 2008 6:41 PM
To: ext Rajendra Nayak
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/11] OMAP3 CPUidle patches
Hi Rajendra,
On Tue, Jul 01, 2008 at 07:46:01PM +0530
Hi Rajendra,
Not sure, but you can try with my .config while I try with yours.
I was doing some more testing today, and I saw a hang after a while of
idle activity with OFF being attempted multiple times.
Using lauterbach showed me it being stuck up in prcm_interrupt_handler trying
to
29 matches
Mail list logo
