Re: [PATCH 1/3] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

On 12/23/2015 10:35 AM, Uri Mashiach wrote: > The power function uses a consumer regulator access to update the WiFi > enable GPIO value. > > Fix the below Oops when trying to modprobe wlcore_spi. > The oops occurs because the wl1271_power_{off,on}() > function doesn't check the power() function

Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support

On 12/23/2015 10:35 AM, Uri Mashiach wrote: > Add DT support for the wl1271 SPI WiFi. > > Add documentation file for the wl1271 SPI WiFi. > > Signed-off-by: Uri Mashiach > Acked-by: Igor Grinberg > --- >

[PATCH 1/3] ti-st: use device handles and add device tree binding

- Add support for getting the platform data which includes the uart used and gpio pin used for enable from device tree. - Fix the implementation for using device handle for the uart and gpiod for the enable pin, instead of device name (as string) used for the uart and pio number which are

[PATCH 2/3] ARM: dts: am335x-evm: add shared transport device tree bindings

The shared Shared Transport (ST) software enables BT and GPS protocols or software components to interact with their respective cores over single physical port. Add the uart and enable pin device tree bindings Signed-off-by: Eyal Reizer --- arch/arm/boot/dts/am335x-evm.dts | 12

[PATCH 3/3] ARM: dts: am437x-gp-evm: add shared transport device tree bindings

The shared Shared Transport (ST) software enables BT and GPS protocols or software components to interact with their respective cores over single physical port. Add the uart and enable pin device tree bindings Signed-off-by: Eyal Reizer --- arch/arm/boot/dts/am437x-gp-evm.dts |

Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

On Wed, Dec 23, 2015 at 11:58:36AM +0100, Paul Kocialkowski wrote: > Some devices don't hook the DVS pin to a GPIO but to ground or VCC. > In those cases, it is not a problem to have no DVS GPIO. I would expect the driver at least needs to know how the pins or strapped, or otherwise have

Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

Le mercredi 23 décembre 2015 à 11:41 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:36AM +0100, Paul Kocialkowski wrote: > > Some devices don't hook the DVS pin to a GPIO but to ground or VCC. > > In those cases, it is not a problem to have no DVS GPIO. > > I would expect the driver

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > + gpio = lp->pdata->enable_gpio; > + if (!gpio_is_valid(gpio)) > + return 0; > + > + /* Always set enable GPIO high. */ > + ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X >

Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

On Wed, Dec 23, 2015 at 12:50:20PM +0100, Paul Kocialkowski wrote: > Le mercredi 23 décembre 2015 à 11:41 +, Mark Brown a écrit : > > I would expect the driver at least needs to know how the pins or > > strapped, or otherwise have configuration for ignoring the input on the > > pins. This

Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support

Hi Grygorii, On 12/23/2015 12:25 PM, Grygorii Strashko wrote: On 12/23/2015 10:35 AM, Uri Mashiach wrote: Add DT support for the wl1271 SPI WiFi. Add documentation file for the wl1271 SPI WiFi. Signed-off-by: Uri Mashiach Acked-by: Igor Grinberg

Re: [PATCH 1/3] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

Hi Grygorii, On 12/23/2015 12:08 PM, Grygorii Strashko wrote: On 12/23/2015 10:35 AM, Uri Mashiach wrote: The power function uses a consumer regulator access to update the WiFi enable GPIO value. Fix the below Oops when trying to modprobe wlcore_spi. The oops occurs because the

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

Hi, * Paul Kocialkowski [151223 03:00]: > The LG Optimus Black (P970) codename sniper is a smartphone that was designed > and manufactured by LG Electronics (LGE) and released back in 2011. > It is using an OMAP3630 SoC, GP version. > > This adds devicetree support for the

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

Hello Paul, [snip] > + > +_pmx_core { > + pinctrl-names = "default"; > + > + uart3_pins: pinmux_uart3_pins { > + pinctrl-single,pins = < > + 0x16e (PIN_INPUT | MUX_MODE0) /* > uart3_rx_irrx */ > + 0x170 (PIN_OUTPUT

Re: [PATCH 5/5] arm: boot: store ATAGs structure into DT "/chosen/linux,atags" entry

Hi, On 15.12.2015 14:20, Russell King - ARM Linux wrote: You could also just save_atags() in there, with a comment saying that this is a work-around for N900 which needs the ATAGs saved, and this is allowed in ->reserve as a special exception. What about this (just to confirm I got the idea

Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support

* Uri Mashiach [151223 06:38]: > On 12/23/2015 12:25 PM, Grygorii Strashko wrote: > > >>+that services interrupts for this device > >>+- vwlan-supply :Point the node of the regulator that controls the > >>wl1271 chip WLAN_EN pin > > >

Re: [PATCH 2/3] ARM: dts: am335x-evm: add shared transport device tree bindings

* Reizer, Eyal [151223 03:40]: > The shared Shared Transport (ST) software enables BT and GPS protocols > or software components to interact with their respective cores over > single physical port. > Add the uart and enable pin device tree bindings ... > ---

Re: [PATCH 2/3] ARM: dts: am335x-evm: add shared transport device tree bindings

* Tony Lindgren [151223 10:19]: > * Reizer, Eyal [151223 03:40]: > > The shared Shared Transport (ST) software enables BT and GPS protocols > > or software components to interact with their respective cores over > > single physical port. > > Add the uart and

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

From: "David Rivshin (Allworx)" Date: Tue, 22 Dec 2015 19:36:31 -0500 > Testing by anyone who has real hardware using phy-handle or dual_emac > with fixed-link would be appreciated. I'm going to wait for such testing before applying this series. Thanks. -- To

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

On Wednesday 23 December 2015 12:04:25 David Miller wrote: > From: "David Rivshin (Allworx)" > Date: Tue, 22 Dec 2015 19:36:31 -0500 > > > Testing by anyone who has real hardware using phy-handle or dual_emac > > with fixed-link would be appreciated. > > I'm going to

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

On Thu, 24 Dec 2015 00:34:49 +0100 Nicolas Chauvet wrote: > 2015-12-23 22:54 GMT+01:00 David Rivshin (Allworx) < > drivshin.allw...@gmail.com>: > > > On Wed, 23 Dec 2015 22:20:58 +0100 > > Nicolas Chauvet wrote: > > > > > 2015-12-23 1:36 GMT+01:00 David

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

On Wed, 23 Dec 2015 19:35:37 +0100 Markus Brunner wrote: > On Wednesday 23 December 2015 12:04:25 David Miller wrote: > > From: "David Rivshin (Allworx)" > > Date: Tue, 22 Dec 2015 19:36:31 -0500 > > > > > Testing by anyone

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

On Wed, 23 Dec 2015 22:20:58 +0100 Nicolas Chauvet wrote: > 2015-12-23 1:36 GMT+01:00 David Rivshin (Allworx) < > drivshin.allw...@gmail.com>: > > > From: David Rivshin > > > > This series is based on the tip of the net tree. > > > > The first patch

Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support

Hi Grygorii, On 12/23/2015 12:25 PM, Grygorii Strashko wrote: On 12/23/2015 10:35 AM, Uri Mashiach wrote: Add DT support for the wl1271 SPI WiFi. Add documentation file for the wl1271 SPI WiFi. Signed-off-by: Uri Mashiach Acked-by: Igor Grinberg

Re: [PATCH v3 00/23] Unrestricted media entity ID range support

Em Wed, 16 Dec 2015 16:03:01 +0200 Sakari Ailus escreveu: > Hi Javier, > > On Wed, Dec 16, 2015 at 03:32:15PM +0200, Sakari Ailus wrote: > > This is the third version of the unrestricted media entity ID range > > support set. I've taken Mauro's comments into account and

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* Always set enable GPIO high. */ > > + ret =

[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements

This series introduces support for the LG Optimus Black, as described in the patch adding devicetree support for the device. In order to power the external mmc (mmc1), the lp872x regulator is used. Its code had to be improved a bit to work on the device. Note that the patch adding devicetree

[PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

The LG Optimus Black (P970) codename sniper is a smartphone that was designed and manufactured by LG Electronics (LGE) and released back in 2011. It is using an OMAP3630 SoC, GP version. This adds devicetree support for the device, with only a few basic features supported, such as debug uart,

[PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

The lp872x structure holds a reference to the DVS GPIO, but it is never actually used anywhere, since a first reference exists from the lp872x_dvs structure. Signed-off-by: Paul Kocialkowski --- drivers/regulator/lp872x.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski --- .../devicetree/bindings/regulator/lp872x.txt | 1 + drivers/regulator/lp872x.c

[PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

Some devices don't hook the DVS pin to a GPIO but to ground or VCC. In those cases, it is not a problem to have no DVS GPIO. Signed-off-by: Paul Kocialkowski --- drivers/regulator/lp872x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions

In order to select the regulators via of_find_regulator_by_node (and thus use them in devicetree), defining of_match for each regulator is required. Signed-off-by: Paul Kocialkowski --- drivers/regulator/lp872x.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support

The LP872x regulator is used in the LG Optimus Black (P970) codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig

Re: [PATCH 5/5] fbdev: omap2: panel-dpi: allow specification of a vcc regulator

Hi, On 19/12/15 22:41, Adam Ford wrote: > Tomi, > > Do you have any thought on how to approach adding sleep/delay > functions? I have a display that requires a small delay before and > after the enable gpio toggle. I assume that some may require a delay > after the regulator starts for it to

[PATCH 3/3] wlcore/wl12xx: spi: add wifi support to cm-t335

Device tree modifications: - Pinmux for SPI0 and WiFi GPIOs. - SPI0 node with wlcore as a child node. Cc: Tony Lindgren Signed-off-by: Uri Mashiach Acked-by: Igor Grinberg --- Prerequisites: This patch applies on Tony's

[PATCH 0/3] wlcore/wl12xx: spi: add wifi support to cm-t335

Add DT support for WLS1271 SPI driver. Fix oops by adding a power callback. Uri Mashiach (3): wlcore/wl12xx: spi: fix NULL pointer dereference (Oops) wlcore/wl12xx: spi: add device tree support wlcore/wl12xx: spi: add wifi support to cm-t335 .../bindings/net/wireless/ti,wlcore,spi.txt

[PATCH 1/3] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

The power function uses a consumer regulator access to update the WiFi enable GPIO value. Fix the below Oops when trying to modprobe wlcore_spi. The oops occurs because the wl1271_power_{off,on}() function doesn't check the power() function pointer. [ 23.401447] Unable to handle kernel NULL

[PATCH 2/3] wlcore/wl12xx: spi: add device tree support

Add DT support for the wl1271 SPI WiFi. Add documentation file for the wl1271 SPI WiFi. Signed-off-by: Uri Mashiach Acked-by: Igor Grinberg --- .../bindings/net/wireless/ti,wlcore,spi.txt| 35 +++