Re: [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token

2012-09-10 Thread Sebastian Andrzej Siewior
On 09/10/2012 03:54 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f commit: 721e2e91945bc2520d57d795dfe1b502ecec567c [58/62] usb: gadget: libcomposite: move composite.c into libcomposite config:

Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

2012-09-10 Thread Sebastian Andrzej Siewior
On 09/10/2012 06:40 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master head: d9c88901337158c9f253a7de58a10b5125d61d26 commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove usb_gadget_controller_number() All sparse

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Sebastian Andrzej Siewior
* Paul Walmsley | 2011-08-22 23:10:21 [-0600]: IRQ handler type mismatch for IRQ 74 It turns out that the omap-serial code used one threaded IRQ handler[1][2] and one non-threaded IRQ handler[3] that shared the same IRQ. During the 3.1-rc series, a patch was merged[4] that caused IRQF_ONESHOT

Re: 3.1-rc3 fails to boot on my pandaboard

2011-08-25 Thread Sebastian Andrzej Siewior
* Luciano Coelho | 2011-08-25 13:39:29 [+0300]: Hi, Hi, Any ideas what may be going wrong? I think my commit was identified as bogus and tglx is going to revert it. The problem is that I force ONESHOT mode for all threaded IRQs but there are also others without the flag which is not allowed.

Re: 3.1-rc3 fails to boot on my pandaboard

2011-08-25 Thread Sebastian Andrzej Siewior
* Luciano Coelho | 2011-08-25 14:24:34 [+0300]: These are the interrupts reported in /proc/interrupts on my board: Thank you, this is enough information. Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [patch] dwc3: add a kfree() on error to dwc3_testmode_open()

2011-08-26 Thread Sebastian Andrzej Siewior
* Dan Carpenter | 2011-08-26 12:21:13 [+0300]: Btw. This function returns -EBUSY on success. Was that really what you want? At that time yes. The idea was to enable the self-test mode of the core and let it do transfers forth and back and see if it works. There is also no off switch. I wasn't

Re: [balbi-usb:merge-result-for-greg 59/99] webcam.c:(.text+0x14afec): undefined reference to `config_ep_by_speed'

2012-10-15 Thread Sebastian Andrzej Siewior
On 10/12/2012 06:39 PM, Fengguang Wu wrote: Hi Sebastian, Hi Fengguang, FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git merge-result-for-greg head: 23953bde3e4d6aa8780dc054f6ad9882ac63f4f4 commit: 721e2e91945bc2520d57d795dfe1b502ecec567c

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Sebastian Andrzej Siewior
On 04/10/2012 05:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Why do you need this function at all? You should not need it. *I* introduced it because I need it early x86

Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

2013-04-26 Thread Sebastian Andrzej Siewior
On 04/26/2013 01:30 PM, Mugunthan V N wrote: diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 4e2d224..59c4391 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1633,7 +1633,6 @@ static int cpsw_probe_dual_emac(struct

Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence

2013-05-02 Thread Sebastian Andrzej Siewior
is invoked between packet processing and enable IRQ. Acked-by: Sebastian Andrzej Siewior bige...@linutronix.de Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] arm/omap: use const char properly

2013-06-06 Thread Sebastian Andrzej Siewior
The itention was probably to make both pointers const but as it is now, it is just const used twice. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/mach-omap2/id.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/id.c b/arch

[PATCH 4/4] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk

2013-06-06 Thread Sebastian Andrzej Siewior
...@avionic-design.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am335x-evmsk.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts index f67c360..c21fdaf 100644

[PATCH 3/4] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm

2013-06-06 Thread Sebastian Andrzej Siewior
-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am335x-evm.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 0423298..35b2f77 100644 --- a/arch/arm/boot/dts

[PATCH 2/4] ARM: dts: AM33XX: Add PWMSS device tree nodes

2013-06-06 Thread Sebastian Andrzej Siewior
avinashphi...@ti.com Reviewed-by: Thierry Reding thierry.red...@avionic-design.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am33xx.dtsi | 84 + 1 file changed, 84 insertions(+) diff --git a/arch/arm/boot/dts

Missing pieces for AM335x PWM / backlight support

2013-06-06 Thread Sebastian Andrzej Siewior
The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e: Linux 3.10-rc4 (2013-06-02 17:11:17 +0900) are available in the git repository at: git://git.breakpoint.cc/bigeasy/linux.git tags/am335x-pwm for you to fetch changes up to 6b319b16a27463c93ec36e59458448aae3ab94cd:

[PATCH 1/4] ARM: AM33XX: clk: Add clock node for EHRPWM TBCLK

2013-06-06 Thread Sebastian Andrzej Siewior
From: Philip Avinash avinashphi...@ti.com EHRPWM module requires explicit clock gating of TBCLK from control module. Hence add TBCLK clock node in clock tree for EHRPWM modules. Signed-off-by: Philip Avinash avinashphi...@ti.com [bigeasy: remove CK_AM33XX] Signed-off-by: Sebastian Andrzej

[PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-06-11 Thread Sebastian Andrzej Siewior
with no need to cache values like for I2C or SPI devices. Furthermore, most (if not all) of the access done by the touch ADC driver read volatile register. Therefore this patch removes regmap part of the driver. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd

[PATCH 06/22] input/ti_am33x_tsc: Add DT support

2013-06-11 Thread Sebastian Andrzej Siewior
our DT node without of_get_child_by_name(), rename steps_to_configure to coordinate_readouts because this is what it really does, don't overrire err after calling titsc_parse_dt() or titsc_parse_pdata()] Signed-off-by: Sebastian Andrzej Siewior bige

[PATCH 08/22] iio/ti_am335x_adc: Add DT support

2013-06-11 Thread Sebastian Andrzej Siewior
-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com [bigeasy: shift the code to the left, fix clean up on of_get_child_by_name() failer, provide OF binding in mfd, use own of node, get rid of of_get_child_by_name()] Signed-off-by: Sebastian Andrzej Siewior bige

[PATCH 07/22] input/ti_am33x_tsc: remove platform_data support

2013-06-11 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c | 25 + 1 file

[PATCH 09/22] iio/ti_am335x_adc: remove platform_data support

2013-06-11 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c | 21 +++-- 1 file changed, 7 insertions

[PATCH 05/22] input/ti_am33x_tsc: remove unwanted fifo flush

2013-06-11 Thread Sebastian Andrzej Siewior
From: Patil, Rachna rac...@ti.com When touchscreen and ADC are used together, this unwanted fifo flush leads to loss of ADC data. Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input

[PATCH 02/22] mfd input iio/ti_am335x_adc: use one structure for ti_tscadc_dev

2013-06-11 Thread Sebastian Andrzej Siewior
and the same structure is used. While doing the change I noticed that the suspend/resume code assumes the wrong pointer for ti_tscadc_dev and this has been fixed as well. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |5 +++-- drivers/input

[PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Sebastian Andrzej Siewior
of the patch, no config[4][4] array, smaller sized config_inp, no regbit_map(), shrinked titsc_config_wires(), no config redo on resume, config_inp and friends are now u32] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen

[PATCH 03/22] input/ti_am33x_tsc: Step enable bits made configurable

2013-06-11 Thread Sebastian Andrzej Siewior
should take care to set this parameter correctly. Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com [bigeasy: add lock, move to MFD, use in TSC ADC] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c | 20

am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
input/ti_am33x_tsc: remove unwanted fifo flush input/ti_am33x_tsc: Add DT support iio/ti_am335x_adc: Add DT support mfd/ti_am335x_tscadc: Add DT support arm/am33xx: add TSC/ADC mfd device support Sebastian Andrzej Siewior (13): mfd/ti_am335x_tscadc: remove

[PATCH 22/22] iio/ti_am335x_adc: check if we found the value

2013-06-11 Thread Sebastian Andrzej Siewior
Usually we get all the values we wanted but it is possible, that te ADC unit is busy performing the conversation for the HW events. In that case -EBUSY is returned and the user may re-call the function. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige

[PATCH 17/22] mfd iio/ti_am335x_adc: rename device from tiadc to TI-am335x-adc

2013-06-11 Thread Sebastian Andrzej Siewior
TI-adc reads a little better compared to tiadc. And if we add am335x to it then we have the same naming scheme as the tsc side. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |3 +-- drivers/mfd

[PATCH 14/22] arm/am33xx: add TSC/ADC mfd device support

2013-06-11 Thread Sebastian Andrzej Siewior
-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com [bigeasy: add 'status = okay'] Signed-off-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc --- arch/arm/boot/dts/am335x-evm.dts | 14 ++ arch/arm/boot/dts/am33xx.dtsi| 18 ++ 2 files

[PATCH 11/22] mfd/ti_am335x_tscadc: remove platform_data support

2013-06-11 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd/ti_am335x_tscadc.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCH 12/22] iio/ti_tscadc: provide datasheet_name and scan_type

2013-06-11 Thread Sebastian Andrzej Siewior
-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Signed-off-by: Felipe Balbi ba...@ti.com [bigeasy: use static AIN[0-8] names, use kcalloc(), removed iio_map, patch description] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c | 29

[PATCH 13/22] mfd/ti_tscadc: deal with partial activation

2013-06-11 Thread Sebastian Andrzej Siewior
for neither ADC nor TSC channels] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd/ti_am335x_tscadc.c | 38 ++ include/linux/mfd/ti_am335x_tscadc.h |8 +++ 2 files changed, 28 insertions(+), 18 deletions(-) diff

[PATCH 20/22] input/ti_am335x_tsc: return IRQ_NONE if there was no IRQ for us

2013-06-11 Thread Sebastian Andrzej Siewior
. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 84859da..6327169

[PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support

2013-06-11 Thread Sebastian Andrzej Siewior
Signed-off-by: Felipe Balbi ba...@ti.com [bigeasy: module alias, rename to ti,am3359-tscadc as it was tested on AM3359] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd/ti_am335x_tscadc.c | 32 ++-- 1 file changed, 26 insertions

[PATCH 21/22] iio/ti_am335x_adc: Allow to specify input line

2013-06-11 Thread Sebastian Andrzej Siewior
checks for correct step number during reading and does not rely on proper FIFO depth. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am335x-evm.dts |2 +- drivers/iio/adc/ti_am335x_adc.c | 57

[PATCH 18/22] input/ti_am335x_adc: use only FIFO0 and clean up a little

2013-06-11 Thread Sebastian Andrzej Siewior
coordinate set. On the second interrupt we will cleanup the remaining enties. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |2 +- drivers/input/touchscreen/ti_am335x_tsc.c

[PATCH 15/22] input mfd: ti_am335x_tsc remove remaining platform data pieces

2013-06-11 Thread Sebastian Andrzej Siewior
The two header files removed here are unused and have no users as this platform was never used with platform devices. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/input/ti_am335x_tsc.h | 35 --- include/linux/mfd

[PATCH 19/22] input/ti_am335x_tsc: ACK the HW_PEN irq in ISR

2013-06-11 Thread Sebastian Andrzej Siewior
Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 29febe9..84859da 100644 --- a/drivers/input/touchscreen

[PATCH 16/22] mfd input/ti_am335x_tsc: rename device from tsc to TI-am335x-tsc

2013-06-11 Thread Sebastian Andrzej Siewior
tsc is a very generic name. This patch adds a TI and HW prefix to it less generic. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c |2 +- drivers/mfd/ti_am335x_tscadc.c|2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, Therefore this patch removes regmap part of the driver. NAK. Using regmap is better than open coding your register accesses, and the children not using this API is not a reason for the MFD driver to do the same. There is

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, On Tue, Jun 11, 2013 at 01:30:50PM +0200, Sebastian Andrzej Siewior wrote: diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h index eeead15..2d78af8 100644 --- a/include/linux/mfd

Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior wrote: From: Patil, Rachna rac...@ti.com Make changes to add DT support in the MFD core driver. Which changes ? So rewrite the commit log… [ pa

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: I believe the whole thing should go via the MFD tree. It touches also input iio subsystem. I collected ACKs where I got some in the meantime

Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 05:05 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, On Tue, Jun 11, 2013 at 04:42:30PM +0200, Sebastian Andrzej Siewior wrote: In the end I would like not to post a patch with From: != me and don't make change which the original author did not do. Also dropping

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 06:10 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, On Tue, Jun 11, 2013 at 05:29:22PM +0200, Sebastian Andrzej Siewior wrote: Then, this is a pretty big patchset, with iio, input and mfd all mixed together and it is likely to create merge conflicts. They somehow depend

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/11/2013 07:55 PM, Samuel Ortiz wrote: Hi Jonathan, Hi Samuel, Sebastian, please address the commit log and cosmetic issues I pointed out, keep the regmap code and I'll pull this patchset in. By keep the regmap code you mean I am allowed to remove the regmap usage in mfd (keep patch #1)

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/12/2013 03:50 PM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, By keep the regmap code you mean I am allowed to remove the regmap usage in mfd (keep patch #1) or do you insist on adding its usage in iio and input? I insist on keeping it on the MFD driver, i.e. _not_ keeping patch #1.

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/12/2013 04:41 PM, Samuel Ortiz wrote: This forces me redo a few things and most likely adding it to the iio and input driver to be consistent here. I'm not asking for that. The current MFD code uses regmap fine without the iio and input using it, I don't see why you would have to add

Re: [PATCH 2/4] ARM: dts: AM33XX: Add PWMSS device tree nodes

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/06/2013 03:52 PM, Sebastian Andrzej Siewior wrote: From: Philip Avinash avinashphi...@ti.com Add PWMSS device tree nodes in relation with ECAP EHRPWM DT nodes to AM33XX SoC family. Also populates device tree nodes for ECAP EHRPWM by adding necessary properties like pwm-cells, base

am335x: TSC ADC reworking including DT pieces, take 5

2013-06-12 Thread Sebastian Andrzej Siewior
: add TSC/ADC mfd device support Sebastian Andrzej Siewior (12): mfd: input: iio: ti_am335x_adc: use one structure for ti_tscadc_dev input: ti_am33x_tsc: remove platform_data support iio: ti_am335x_adc: remove platform_data support mfd: ti_am335x_tscadc: remove platform_data

[PATCH 08/21] iio: ti_am335x_adc: remove platform_data support

2013-06-12 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c | 21 +++-- 1 file changed, 7 insertions

[PATCH 06/21] input: ti_am33x_tsc: remove platform_data support

2013-06-12 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c | 25 + 1 file

[PATCH 03/21] input: ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-12 Thread Sebastian Andrzej Siewior
, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c | 102 - include/linux/input/ti_am335x_tsc.h | 12 include/linux/mfd/ti_am335x_tscadc.h

[PATCH 09/21] mfd: ti_am335x_tscadc: Add DT support

2013-06-12 Thread Sebastian Andrzej Siewior
-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd/ti_am335x_tscadc.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 1d6c740..292d34e 100644 --- a/drivers

[PATCH 07/21] iio: ti_am335x_adc: Add DT support

2013-06-12 Thread Sebastian Andrzej Siewior
From: Patil, Rachna rac...@ti.com Add DT support for client ADC driver. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej

[PATCH 01/21] mfd: input: iio: ti_am335x_adc: use one structure for ti_tscadc_dev

2013-06-12 Thread Sebastian Andrzej Siewior
and the same structure is used. While doing the change I noticed that the suspend/resume code assumes the wrong pointer for ti_tscadc_dev and this has been fixed as well. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |5 +++-- drivers/input

[PATCH 02/21] input: ti_am33x_tsc: Step enable bits made configurable

2013-06-12 Thread Sebastian Andrzej Siewior
should take care to set this parameter correctly. Sebastian added the common lock and moved the code, that manipulates the steps, from into the mfd module. Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

[PATCH 04/21] input: ti_am33x_tsc: remove unwanted fifo flush

2013-06-12 Thread Sebastian Andrzej Siewior
From: Patil, Rachna rac...@ti.com When touchscreen and ADC are used together, this unwanted fifo flush leads to loss of ADC data. Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input

[PATCH 05/21] input: ti_am33x_tsc: Add DT support

2013-06-12 Thread Sebastian Andrzej Siewior
. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Signed-off-by: Patil, Rachna rac...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- .../bindings/input/touchscreen/ti-tsc-adc.txt | 44 drivers/input

[PATCH 13/21] arm: am33xx: add TSC/ADC mfd device support

2013-06-12 Thread Sebastian Andrzej Siewior
Andrzej Siewior sebast...@breakpoint.cc --- arch/arm/boot/dts/am335x-evm.dts | 14 ++ arch/arm/boot/dts/am33xx.dtsi| 18 ++ 2 files changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts index 0423298..26fea97

[PATCH 11/21] iio: ti_tscadc: provide datasheet_name and scan_type

2013-06-12 Thread Sebastian Andrzej Siewior
. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c | 29 - 1 file changed, 24

[PATCH 18/21] input: ti_am335x_tsc: ACK the HW_PEN irq in ISR

2013-06-12 Thread Sebastian Andrzej Siewior
Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 1bceb25..2ba7703 100644 --- a/drivers/input/touchscreen

[PATCH 12/21] mfd: ti_tscadc: deal with partial activation

2013-06-12 Thread Sebastian Andrzej Siewior
From: Pantelis Antoniou pa...@antoniou-consulting.com Fix the mfd device in the case where a subdevice might not be activated. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

[PATCH 17/21] input: ti_am335x_adc: use only FIFO0 and clean up a little

2013-06-12 Thread Sebastian Andrzej Siewior
coordinate set. On the second interrupt we will cleanup the remaining enties. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |2 +- drivers/input/touchscreen/ti_am335x_tsc.c

[PATCH 20/21] iio: ti_am335x_adc: Allow to specify input line

2013-06-12 Thread Sebastian Andrzej Siewior
checks for correct step number during reading and does not rely on proper FIFO depth. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am335x-evm.dts |2 +- drivers/iio/adc/ti_am335x_adc.c | 57

[PATCH 16/21] mfd: iio: ti_am335x_adc: rename device from tiadc to TI-am335x-adc

2013-06-12 Thread Sebastian Andrzej Siewior
TI-adc reads a little better compared to tiadc. And if we add am335x to it then we have the same naming scheme as the tsc side. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/iio/adc/ti_am335x_adc.c |3 +-- drivers/mfd

[PATCH 21/21] iio: ti_am335x_adc: check if we found the value

2013-06-12 Thread Sebastian Andrzej Siewior
Usually we get all the values we wanted but it is possible, that te ADC unit is busy performing the conversation for the HW events. In that case -EBUSY is returned and the user may re-call the function. Acked-by: Jonathan Cameron ji...@kernel.org Signed-off-by: Sebastian Andrzej Siewior bige

[PATCH 10/21] mfd: ti_am335x_tscadc: remove platform_data support

2013-06-12 Thread Sebastian Andrzej Siewior
This patch removes access to platform data mfd_tscadc_board because the platform is DT only. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/mfd/ti_am335x_tscadc.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCH 15/21] mfd: input: ti_am335x_tsc: rename device from tsc to TI-am335x-tsc

2013-06-12 Thread Sebastian Andrzej Siewior
tsc is a very generic name. This patch adds a TI and HW prefix to it less generic. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c |2 +- drivers/mfd/ti_am335x_tscadc.c|2 +- 2 files changed, 2 insertions(+), 2

[PATCH 19/21] input: ti_am335x_tsc: return IRQ_NONE if there was no IRQ for us

2013-06-12 Thread Sebastian Andrzej Siewior
. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/input/touchscreen/ti_am335x_tsc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 2ba7703..0e9f02a

[PATCH 14/21] input: mfd: ti_am335x_tsc remove remaining platform data pieces

2013-06-12 Thread Sebastian Andrzej Siewior
The two header files removed here are unused and have no users as this platform was never used with platform devices. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/input/ti_am335x_tsc.h | 35 --- include/linux/mfd

Re: am335x: TSC ADC reworking including DT pieces, take 5

2013-06-13 Thread Sebastian Andrzej Siewior
On 06/13/2013 11:07 AM, Samuel Ortiz wrote: Hi Sebastian, Hi Samuel, Pulled and pushed back to mfd-next, thanks. Thank you. I fixed a couple of unused variable warnings on top of it. I saw your patch at git.k.o and I am asking you not to taking it :) The code is:

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-06-17 Thread Sebastian Andrzej Siewior
On 06/14/2013 03:53 PM, Mark Brown wrote: On Tue, Jun 11, 2013 at 04:34:53PM +0200, Sebastian Andrzej Siewior wrote: It does give you tracepoints and debugfs. If it's making things at all complicated we need to look at why that is and figure out how to fix that since it's probably an issue

[PATCH] ARM: dts: omap3-beagle: fix the USB phy node

2013-06-17 Thread Sebastian Andrzej Siewior
I haven't tested this but it should not work the way it is now. The format for of_parse_phandle() is usuall phandle index not the other way around. Cc: Benoît Cousson b-cous...@ti.com Cc: Roger Quadros rog...@ti.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot

Re: [PATCH] ARM: dts: omap3-beagle: fix the USB phy node

2013-06-17 Thread Sebastian Andrzej Siewior
On 06/17/2013 03:27 PM, Sebastian Andrzej Siewior wrote: index 6eec699..a12e9b0 100644 --- a/arch/arm/boot/dts/omap3-beagle.dts +++ b/arch/arm/boot/dts/omap3-beagle.dts @@ -128,7 +128,7 @@ }; usbhsehci { - phys = 0 hsusb2_phy; + phys = hsusb2_phy 0; }; twl_gpio { Wait

[RFC] Add support for am33xx which has two musb ports

2013-06-17 Thread Sebastian Andrzej Siewior
Hi Felipe, so with these two I can use the second port on my am335x-evm in hostmode. After the second ports gets noticed by Linux I see over and over: |musb_bus_suspend 2457: trying to suspend as a_wait_bcon while active Which disappears once I plug in a device and does not come back after I

[PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-17 Thread Sebastian Andrzej Siewior
There is no need to hardcode the number of instances here. It is better to determine them at runtime. Even if the device provides two instances one might only want to use one of them. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/musb/musb_dsps.c | 33

[PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-17 Thread Sebastian Andrzej Siewior
boom. This patchs adds two dummy device node to the am33xx for the dummy phy which we have now. During probe time, we grab the phy based on the device node if we have one. If not, we use the same hack we used so far. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot

Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-18 Thread Sebastian Andrzej Siewior
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/18/2013 10:27 AM, Felipe Balbi wrote: diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index e1b661d..d9ff390 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -415,9 +415,14 @@ static

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Sebastian Andrzej Siewior
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/18/2013 10:31 AM, Felipe Balbi wrote: Hi, Hi Felipe, --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -110,8 +110,6 @@ struct dsps_musb_wrapper { @@ -646,6 +645,23 @@ static int dsps_probe(struct platform_device

Re: [PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-18 Thread Sebastian Andrzej Siewior
On 06/18/2013 10:54 AM, Felipe Balbi wrote: Hi, Hi Felipe, This isn't exactly a child node, is it? There is of_get_child_count() but this isn't a child, it is one property. is it because we haven't added DTS support for musb core ? Eventually we can/should add and convert this to

Re: [PATCH 2/4] ARM: dts: AM33XX: Add PWMSS device tree nodes

2013-06-18 Thread Sebastian Andrzej Siewior
On 06/12/2013 06:40 PM, Felipe Balbi wrote: On Wed, Jun 12, 2013 at 06:10:32PM +0200, Sebastian Andrzej Siewior wrote: On 06/06/2013 03:52 PM, Sebastian Andrzej Siewior wrote: From: Philip Avinash avinashphi...@ti.com Add PWMSS device tree nodes in relation with ECAP EHRPWM DT nodes

Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-19 Thread Sebastian Andrzej Siewior
On 06/18/2013 10:27 AM, Felipe Balbi wrote: --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -341,6 +341,14 @@ port1-mode = 3; power = 250; ti,hwmods = usb_otg_hs; + phys = nopphy0 nopphy1; + }; + + nopphy0: usbphy@0 { +

[RFC] am33xx: create child nodes for the two musb controllers

2013-06-26 Thread Sebastian Andrzej Siewior
I've been thinkig about creating two child nodes for the independent musb controllers on the am33. I've been thinking about the following: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8e1248f..6aa9506 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++

Re: [RFC] am33xx: create child nodes for the two musb controllers

2013-06-27 Thread Sebastian Andrzej Siewior
On 06/27/2013 08:51 AM, Felipe Balbi wrote: Hi, Hi Felipe, the patch is alright, but what about the giant amoutn of function pointers we have ? Are you planning to use of_dev_auxdata ?? I didn't plan to use of_dev_auxdata. What do you mean by giant amount of function pointers? Sebastian --

Re: [RFC] am33xx: create child nodes for the two musb controllers

2013-06-27 Thread Sebastian Andrzej Siewior
On 06/27/2013 01:23 PM, Benoit Cousson wrote: Hi Sebastian, Hi Benoit, BTW, why do have so many DMA compared to the previous version? I added them, the previous had none and is PIO only. I currently use three cells per dma channel (the posted example had two). In general I think I have to

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-07-04 Thread Sebastian Andrzej Siewior
Sorry for the long pause… On 06/17/2013 06:03 PM, Mark Brown wrote: This is a lot of for a simple mmio access. In terms of performance: If I add a trace point to my read and write I have still less code which is called and it can be disabled. This regmap overhead is always there chasing

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 12:45 PM, Mark Brown wrote: On Thu, Jul 04, 2013 at 11:02:41AM +0200, Sebastian Andrzej Siewior wrote: The driver here does not use atomic updates but read followed by write so your locking here is futile. So the API/regmap alone does not make Doesn't that sound like

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 01:14 PM, Sekhar Nori wrote: On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: From: Patil, Rachna rac...@ti.com The current driver expected touchscreen input wires(XP,XN,YP,YN) to be connected in a particular order. Making changes to accept this as platform data

Re: [PATCH 14/22] arm/am33xx: add TSC/ADC mfd device support

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 03:49 PM, Sekhar Nori wrote: diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 1460d9b..4ad7797 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -404,6 +404,24 @@ ti,hwmods = wkup_m3;

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 03:39 PM, Sekhar Nori wrote: Yes, I noticed that after sending the mail. To me it does not make sense to make changes to accept something as platform data only to remove platform data itself later. The patches were made earlier and it was easier that way to take everything and

[PATCH 1/5] usb: phy: phy-nop: add support for am335x PHY

2013-07-05 Thread Sebastian Andrzej Siewior
or just add the missing pieces to this one. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/phy/phy-nop.c | 113 +- 1 file changed, 101 insertions(+), 12 deletions(-) diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy

musb: dsps: make it work with two instances

2013-07-05 Thread Sebastian Andrzej Siewior
This enables the two musb instances on am335x to work. Could someone explain what ti,hwmods = usb_otg_hs; doing? I would want to have something like | musb { |/* glue /* | { | musb child node |} | } and this twice. This would put the glue layer

[PATCH 2/5] arm: dts: am33xx: add USB phy nodes

2013-07-05 Thread Sebastian Andrzej Siewior
register access. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am33xx.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 0d4df90..a24f1cb 100644 --- a/arch/arm/boot/dts

[PATCH 4/5] usb: musb: dsps: use proper child nodes

2013-07-05 Thread Sebastian Andrzej Siewior
This moves the two instances from the big node into two child nodes. The glue layer ontop does almost nothing. This could be two indepentant child nodes but I have no idea how 'ti,hwmods = usb_otg_hs;' affects the two musb controler. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

[PATCH 5/5] musb: musb: dsps: remove instances variable

2013-07-05 Thread Sebastian Andrzej Siewior
Remove the instances variable, there is no single use of it. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/musb/musb_dsps.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 0e01cc1..edeb2ad

[PATCH 3/5] usb: musb: dsps: remove the hardcoded phy pieces

2013-07-05 Thread Sebastian Andrzej Siewior
. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/boot/dts/am335x-bone.dts | 4 ++ arch/arm/boot/dts/am335x-evm.dts | 4 ++ arch/arm/boot/dts/am335x-evmsk.dts | 4 ++ arch/arm/boot/dts/am33xx.dtsi | 1 + drivers/usb/musb/musb_dsps.c | 97

Re: [PATCH 2/5] arm: dts: am33xx: add USB phy nodes

2013-07-05 Thread Sebastian Andrzej Siewior
On 07/05/2013 04:41 PM, Ruchika Kharwar wrote: On 07/05/2013 08:32 AM, Sebastian Andrzej Siewior wrote: The memory address contains three pieces that is the reset module which is currently the only one used and two other pices which seem interresting based on what the register. Please fix

Re: [PATCH 4/5] usb: musb: dsps: use proper child nodes

2013-07-05 Thread Sebastian Andrzej Siewior
On 07/05/2013 05:08 PM, Enric Balletbo Serra wrote: Hi Sebastian, Hi Enric, I'm trying to test these patches but I've problems, I've following error, [ 10.096492] musb-dsps 4740.usb: failed to get memory for instance 0 [ 10.103481] musb-dsps 4740.usb: failed to create child

Re: [PATCH 4/5] usb: musb: dsps: use proper child nodes

2013-07-05 Thread Sebastian Andrzej Siewior
On 07/05/2013 05:22 PM, Enric Balletbo Serra wrote: Fixed, I didn't update my DT for my custom board properly. Thanks. Good. I hate breaking the compatibility for DT but unfortunately it is beyond repair. Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the

  1   2   3   4   5   >