Re: [PATCH 20/20] OMAPDSS: Taal: remove rotate mirror support

2013-03-11 Thread Archit Taneja

Hi,

On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote:

Taal panel driver has support to set rotation and mirroring. However,
these features cannot be used without causing tearing, and are never
used. The code is just extra bloat, so let's remove it.

Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com


snip

  static ssize_t taal_num_errors_show(struct device *dev,
@@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device *dssdev)
if (r)
goto err;

-   r = taal_set_addr_mode(td, td-rotate, td-mirror);
-   if (r)
-   goto err;
-


I'm curious if we need to set the address mode(to the default value) at 
least once. It may not be a requirement for Taal, but if that's the 
case, why did we have a set_addr_mode() call in taal_power_on() in the 
first place? Is it because we can prepare rotation and mirroring before 
we enable the panel?


Archit

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 20/20] OMAPDSS: Taal: remove rotate mirror support

2013-03-11 Thread Tomi Valkeinen
On 2013-03-11 08:21, Archit Taneja wrote:
 Hi,
 
 On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote:
 Taal panel driver has support to set rotation and mirroring. However,
 these features cannot be used without causing tearing, and are never
 used. The code is just extra bloat, so let's remove it.

 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 
 snip
   static ssize_t taal_num_errors_show(struct device *dev,
 @@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device
 *dssdev)
   if (r)
   goto err;

 -r = taal_set_addr_mode(td, td-rotate, td-mirror);
 -if (r)
 -goto err;
 -
 
 I'm curious if we need to set the address mode(to the default value) at
 least once. It may not be a requirement for Taal, but if that's the
 case, why did we have a set_addr_mode() call in taal_power_on() in the
 first place? Is it because we can prepare rotation and mirroring before
 we enable the panel?

The panel resets its registers at HW reset, so in case we have changed
the rotation or mirroring, we need to set the addr more at power_on to
keep the user's rotation and mirroring after resuming from blanking. But
now that the rotation or mirroring is never changed, the default value
is always fine.

 Tomi




signature.asc
Description: OpenPGP digital signature


[PATCH 20/20] OMAPDSS: Taal: remove rotate mirror support

2013-03-08 Thread Tomi Valkeinen
Taal panel driver has support to set rotation and mirroring. However,
these features cannot be used without causing tearing, and are never
used. The code is just extra bloat, so let's remove it.

Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
 drivers/video/omap2/displays/panel-taal.c |  170 +
 1 file changed, 2 insertions(+), 168 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-taal.c 
b/drivers/video/omap2/displays/panel-taal.c
index 038a815..bc4c95e 100644
--- a/drivers/video/omap2/displays/panel-taal.c
+++ b/drivers/video/omap2/displays/panel-taal.c
@@ -76,8 +76,6 @@ struct taal_data {
 
/* runtime variables */
bool enabled;
-   u8 rotate;
-   bool mirror;
 
bool te_enabled;
 
@@ -202,49 +200,6 @@ static int taal_get_id(struct taal_data *td, u8 *id1, u8 
*id2, u8 *id3)
return 0;
 }
 
-static int taal_set_addr_mode(struct taal_data *td, u8 rotate, bool mirror)
-{
-   int r;
-   u8 mode;
-   int b5, b6, b7;
-
-   r = taal_dcs_read_1(td, MIPI_DCS_GET_ADDRESS_MODE, mode);
-   if (r)
-   return r;
-
-   switch (rotate) {
-   default:
-   case 0:
-   b7 = 0;
-   b6 = 0;
-   b5 = 0;
-   break;
-   case 1:
-   b7 = 0;
-   b6 = 1;
-   b5 = 1;
-   break;
-   case 2:
-   b7 = 1;
-   b6 = 1;
-   b5 = 0;
-   break;
-   case 3:
-   b7 = 1;
-   b6 = 0;
-   b5 = 1;
-   break;
-   }
-
-   if (mirror)
-   b6 = !b6;
-
-   mode = ~((17) | (16) | (15));
-   mode |= (b7  7) | (b6  6) | (b5  5);
-
-   return taal_dcs_write_1(td, MIPI_DCS_SET_ADDRESS_MODE, mode);
-}
-
 static int taal_set_update_window(struct taal_data *td,
u16 x, u16 y, u16 w, u16 h)
 {
@@ -455,15 +410,8 @@ static const struct backlight_ops taal_bl_ops = {
 static void taal_get_resolution(struct omap_dss_device *dssdev,
u16 *xres, u16 *yres)
 {
-   struct taal_data *td = dev_get_drvdata(dssdev-dev);
-
-   if (td-rotate == 0 || td-rotate == 2) {
-   *xres = dssdev-panel.timings.x_res;
-   *yres = dssdev-panel.timings.y_res;
-   } else {
-   *yres = dssdev-panel.timings.x_res;
-   *xres = dssdev-panel.timings.y_res;
-   }
+   *xres = dssdev-panel.timings.x_res;
+   *yres = dssdev-panel.timings.y_res;
 }
 
 static ssize_t taal_num_errors_show(struct device *dev,
@@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device *dssdev)
if (r)
goto err;
 
-   r = taal_set_addr_mode(td, td-rotate, td-mirror);
-   if (r)
-   goto err;
-
if (!td-cabc_broken) {
r = taal_dcs_write_1(td, DCS_WRITE_CABC, td-cabc_mode);
if (r)
@@ -1340,112 +1284,6 @@ static int taal_get_te(struct omap_dss_device *dssdev)
return r;
 }
 
-static int taal_rotate(struct omap_dss_device *dssdev, u8 rotate)
-{
-   struct taal_data *td = dev_get_drvdata(dssdev-dev);
-   u16 dw, dh;
-   int r;
-
-   dev_dbg(dssdev-dev, rotate %d\n, rotate);
-
-   mutex_lock(td-lock);
-
-   if (td-rotate == rotate)
-   goto end;
-
-   dsi_bus_lock(dssdev);
-
-   if (td-enabled) {
-   r = taal_wake_up(dssdev);
-   if (r)
-   goto err;
-
-   r = taal_set_addr_mode(td, rotate, td-mirror);
-   if (r)
-   goto err;
-   }
-
-   if (rotate == 0 || rotate == 2) {
-   dw = dssdev-panel.timings.x_res;
-   dh = dssdev-panel.timings.y_res;
-   } else {
-   dw = dssdev-panel.timings.y_res;
-   dh = dssdev-panel.timings.x_res;
-   }
-
-   omapdss_dsi_set_size(dssdev, dw, dh);
-
-   td-rotate = rotate;
-
-   dsi_bus_unlock(dssdev);
-end:
-   mutex_unlock(td-lock);
-   return 0;
-err:
-   dsi_bus_unlock(dssdev);
-   mutex_unlock(td-lock);
-   return r;
-}
-
-static u8 taal_get_rotate(struct omap_dss_device *dssdev)
-{
-   struct taal_data *td = dev_get_drvdata(dssdev-dev);
-   int r;
-
-   mutex_lock(td-lock);
-   r = td-rotate;
-   mutex_unlock(td-lock);
-
-   return r;
-}
-
-static int taal_mirror(struct omap_dss_device *dssdev, bool enable)
-{
-   struct taal_data *td = dev_get_drvdata(dssdev-dev);
-   int r;
-
-   dev_dbg(dssdev-dev, mirror %d\n, enable);
-
-   mutex_lock(td-lock);
-
-   if (td-mirror == enable)
-   goto end;
-
-   dsi_bus_lock(dssdev);
-   if (td-enabled) {
-   r = taal_wake_up(dssdev);
-   if (r)
-   goto err;
-
-   r = taal_set_addr_mode(td, td-rotate, enable);
-   if (r)
-