Re: [RFC][PATCH 0/4] TWL6030 patch series
On Mon, Aug 17, 2009 at 10:46:55AM +0530, Krishnamoorthy, Balaji T wrote: -Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] Sent: Monday, August 17, 2009 5:30 AM To: Krishnamoorthy, Balaji T Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; m...@felipebalbi.com Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series Hi Balaji, On Tue, Aug 11, 2009 at 06:30:24PM +0530, Krishnamoorthy, Balaji T wrote: Hi All, Can I have your comments on this so that I can rebase the patch for the upcoming merge window. I looked at the mfd related files, from patchwork.kernel.org. A few comments: * Besides making it look nicer, is there any other reason to change the twl4030-core.c name ? twl-core.c will have common code. twl4030-irq.c will have code specific for TWL4030 family and twl6030-irq.c will have specific code for TWL6030 family. Ok, I'm fine with renaming then. This is to make code easily readable and it wont be misleading. * You should also change drivers/mfd/Kconfig to reflect the more generic twl support. Added TWL6030 family to it, tps659x0 can be added if needed. It's up to you. Your Kconfig entry should be exhaustive as far as supported HW goes. * in drivers/mfd/twl-core.c: - status = twl_init_irq(client-irq, pdata-irq_base, pdata- irq_end); + status = twl_init_irq(client-irq, pdata-irq_base, +pdata-irq_end); Please remove it as it's unrelated to this patchset. Ok * Same for the - ( (devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ + ((devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ lines from include/linux/i2c/twl4030.h Ok * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? twl_init_irq and twl_exit_irq is defined in twl4030-irq.c and called from twl-core.c. Earlier twl4030-core.c had declaration too. You're now exporting those 2 routines from a include/linux/ header, and I still dont understand why. Cheers, Samuel. Cheers, Samuel. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, August 06, 2009 2:28 PM To: sa...@linux.intel.com Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; Krishnamoorthy, Balaji T Subject: RE: [RFC][PATCH 0/4] TWL6030 patch series Hi Samuel, Could you please add your comments on the following patch series. series 1 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*. [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg series 2 dependent on series 1 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators [RFC][PATCH v2 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH v2 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH v2 1/4] OMAP4: PMIC: Add support for twl6030 irq framework Thanks and Regards, Balaji T K -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Krishnamoorthy, Balaji T Sent: Monday, July 20, 2009 7:04 PM To: linux-ker...@vger.kernel.org Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk Subject: [RFC][PATCH 0/4] TWL6030 patch series The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and clear mechanism has changed from twl4030,5030. drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also twl6030 rtc drivers/regulator/twl-regulator.c will support twl regulators. include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets selected at compile time
RE: [RFC][PATCH 0/4] TWL6030 patch series
-Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] On Mon, Aug 17, 2009 at 10:46:55AM +0530, Krishnamoorthy, Balaji T wrote: From: Samuel Ortiz [mailto:sa...@linux.intel.com] * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? twl_init_irq and twl_exit_irq is defined in twl4030-irq.c and called from twl-core.c. Earlier twl4030-core.c had declaration too. You're now exporting those 2 routines from a include/linux/ header, and I still dont understand why. My assumption was that declaration has to be in .h file. But since these two functions are called only from twl-core.c files, I can keep it as before, without moving to twl.h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/4] TWL6030 patch series
Hi Balaji, On Tue, Aug 11, 2009 at 06:30:24PM +0530, Krishnamoorthy, Balaji T wrote: Hi All, Can I have your comments on this so that I can rebase the patch for the upcoming merge window. I looked at the mfd related files, from patchwork.kernel.org. A few comments: * Besides making it look nicer, is there any other reason to change the twl4030-core.c name ? * You should also change drivers/mfd/Kconfig to reflect the more generic twl support. * in drivers/mfd/twl-core.c: - status = twl_init_irq(client-irq, pdata-irq_base, pdata-irq_end); + status = twl_init_irq(client-irq, pdata-irq_base, +pdata-irq_end); Please remove it as it's unrelated to this patchset. * Same for the - ( (devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ + ((devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ lines from include/linux/i2c/twl4030.h * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? Cheers, Samuel. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, August 06, 2009 2:28 PM To: sa...@linux.intel.com Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; Krishnamoorthy, Balaji T Subject: RE: [RFC][PATCH 0/4] TWL6030 patch series Hi Samuel, Could you please add your comments on the following patch series. series 1 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*. [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg series 2 dependent on series 1 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators [RFC][PATCH v2 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH v2 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH v2 1/4] OMAP4: PMIC: Add support for twl6030 irq framework Thanks and Regards, Balaji T K -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Krishnamoorthy, Balaji T Sent: Monday, July 20, 2009 7:04 PM To: linux-ker...@vger.kernel.org Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk Subject: [RFC][PATCH 0/4] TWL6030 patch series The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and clear mechanism has changed from twl4030,5030. drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also twl6030 rtc drivers/regulator/twl-regulator.c will support twl regulators. include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets selected at compile time by CONFIG_TWL4030_CORE / CONFIG_TWL6030_CORE These patches are generated against mainline 2.6.31-rc1 and has dependancy on my 1st series[1]. Patch list: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators Needed board-* changes and defconfig changes will be done later.Please let me know your feedback/suggestion on this patch series. Thanks and Regards, Balaji T K [1] http://marc.info/?l=linux-omapm=124757921417187w=2 [PATCH 0/4] TWL patch series -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC][PATCH 0/4] TWL6030 patch series
-Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] Sent: Monday, August 17, 2009 5:30 AM To: Krishnamoorthy, Balaji T Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; m...@felipebalbi.com Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series Hi Balaji, On Tue, Aug 11, 2009 at 06:30:24PM +0530, Krishnamoorthy, Balaji T wrote: Hi All, Can I have your comments on this so that I can rebase the patch for the upcoming merge window. I looked at the mfd related files, from patchwork.kernel.org. A few comments: * Besides making it look nicer, is there any other reason to change the twl4030-core.c name ? twl-core.c will have common code. twl4030-irq.c will have code specific for TWL4030 family and twl6030-irq.c will have specific code for TWL6030 family. This is to make code easily readable and it wont be misleading. * You should also change drivers/mfd/Kconfig to reflect the more generic twl support. Added TWL6030 family to it, tps659x0 can be added if needed. * in drivers/mfd/twl-core.c: - status = twl_init_irq(client-irq, pdata-irq_base, pdata- irq_end); + status = twl_init_irq(client-irq, pdata-irq_base, + pdata-irq_end); Please remove it as it's unrelated to this patchset. Ok * Same for the - ( (devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ + ((devgrp) 13 | 1 12 | (grp) 9 | (type2) 7 \ lines from include/linux/i2c/twl4030.h Ok * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? twl_init_irq and twl_exit_irq is defined in twl4030-irq.c and called from twl-core.c. Earlier twl4030-core.c had declaration too. Cheers, Samuel. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, August 06, 2009 2:28 PM To: sa...@linux.intel.com Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; Krishnamoorthy, Balaji T Subject: RE: [RFC][PATCH 0/4] TWL6030 patch series Hi Samuel, Could you please add your comments on the following patch series. series 1 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*. [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg series 2 dependent on series 1 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators [RFC][PATCH v2 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH v2 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH v2 1/4] OMAP4: PMIC: Add support for twl6030 irq framework Thanks and Regards, Balaji T K -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Krishnamoorthy, Balaji T Sent: Monday, July 20, 2009 7:04 PM To: linux-ker...@vger.kernel.org Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk Subject: [RFC][PATCH 0/4] TWL6030 patch series The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and clear mechanism has changed from twl4030,5030. drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also twl6030 rtc drivers/regulator/twl-regulator.c will support twl regulators. include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets selected at compile time by CONFIG_TWL4030_CORE / CONFIG_TWL6030_CORE These patches are generated against mainline 2.6.31-rc1 and has dependancy on my 1st series[1]. Patch list: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH 4/4] OMAP4: PMIC
RE: [RFC][PATCH 0/4] TWL6030 patch series
Hi All, Can I have your comments on this so that I can rebase the patch for the upcoming merge window. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, August 06, 2009 2:28 PM To: sa...@linux.intel.com Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk; Krishnamoorthy, Balaji T Subject: RE: [RFC][PATCH 0/4] TWL6030 patch series Hi Samuel, Could you please add your comments on the following patch series. series 1 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use [PATCH 2/4] ARM: OMAP: Rename all twl4030_i2c*. [PATCH 3/4] ARM: OMAP: Rename twl4030_ in rtc-twl.c to make it generic rtc [PATCH 4/4] ARM: OMAP: Rename twl4030_ to twl_ in twl-regulator.c to make it generic reg series 2 dependent on series 1 [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators [RFC][PATCH v2 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH v2 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH v2 1/4] OMAP4: PMIC: Add support for twl6030 irq framework Thanks and Regards, Balaji T K -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Krishnamoorthy, Balaji T Sent: Monday, July 20, 2009 7:04 PM To: linux-ker...@vger.kernel.org Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa...@openedhand.com; w...@iguana.be; timo.t.kokko...@nokia.com; ben- li...@fluff.org; broo...@opensource.wolfsonmicro.com; l...@slimlogic.co.uk Subject: [RFC][PATCH 0/4] TWL6030 patch series The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and clear mechanism has changed from twl4030,5030. drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also twl6030 rtc drivers/regulator/twl-regulator.c will support twl regulators. include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets selected at compile time by CONFIG_TWL4030_CORE / CONFIG_TWL6030_CORE These patches are generated against mainline 2.6.31-rc1 and has dependancy on my 1st series[1]. Patch list: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators Needed board-* changes and defconfig changes will be done later.Please let me know your feedback/suggestion on this patch series. Thanks and Regards, Balaji T K [1] http://marc.info/?l=linux-omapm=124757921417187w=2 [PATCH 0/4] TWL patch series -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC][PATCH 0/4] TWL6030 patch series
Mark, Felipe, -Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Friday, July 24, 2009 2:51 PM To: Shilimkar, Santosh Cc: Felipe Balbi; Krishnamoorthy, Balaji T; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Nayak, Rajendra Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series On Fri, Jul 24, 2009 at 09:46:27AM +0530, Shilimkar, Santosh wrote: Mark, Liam, Can you please your comments of regulator patches. I'd really like to see the ifdefs go as someone else requested earlier in the thread. Allowing both twl4030 and twl6030 support to be built simultaneously is much nicer from a maintinance perspective and will scale better as further devices are added to the family. Can you please provide your comments on the v2 version of the patches in which Balaji has fixed the ifdef's Thanks!! Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/4] TWL6030 patch series
On Mon, Aug 03, 2009 at 11:45:58AM +0530, Shilimkar, Santosh wrote: Can you please provide your comments on the v2 version of the patches in which Balaji has fixed the ifdef's They're basically OK from a regulator API point of view but the series appears to depend on the renaming patch and possibly some others. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/4] TWL6030 patch series
On Fri, Jul 24, 2009 at 09:46:27AM +0530, Shilimkar, Santosh wrote: Mark, Liam, Can you please your comments of regulator patches. I'd really like to see the ifdefs go as someone else requested earlier in the thread. Allowing both twl4030 and twl6030 support to be built simultaneously is much nicer from a maintinance perspective and will scale better as further devices are added to the family. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC][PATCH 0/4] TWL6030 patch series
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Monday, July 20, 2009 5:45 PM To: Felipe Balbi Cc: Krishnamoorthy, Balaji T; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series On Mon, Jul 20, 2009 at 03:11:57PM +0300, Felipe Balbi wrote: send these to lkml and Cc linux-omap. Also add to Cc: Samuel Ortiz sa...@openedhand.com Wim Van Sebroeck w...@iguana.be Timo Kokkonen timo.t.kokko...@nokia.com Ben Dooks ben-li...@fluff.org linux-...@vger.kernel.org linux-ker...@vger.kernel.org Plus me and Liam Girdwood l...@slimlogic.co.uk for the regulator stuff. Mark, Liam, Can you please your comments of regulator patches. Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/4] TWL6030 patch series
Hi, On Mon, Jul 20, 2009 at 01:59:41PM +0200, ext Krishnamoorthy, Balaji T wrote: The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and clear mechanism has changed from twl4030,5030. drivers/rtc/rtc-twl.c will support twl4030,twl5030, and also twl6030 rtc drivers/regulator/twl-regulator.c will support twl regulators. include/linux/i2c/twl.h will have TWL4030 and TWL6030 offsets selected at compile time by CONFIG_TWL4030_CORE / CONFIG_TWL6030_CORE These patches are generated against mainline 2.6.31-rc1 and dependancy on my 1st series[1]. Patch list: [RFC][PATCH 1/4] OMAP4: PMIC: Add support for twl6030 irq framework [RFC][PATCH 2/4] OMAP4: PMIC: Add support for twl6030 RTC [RFC][PATCH 3/4] OMAP4: PMIC: Add support for twl6030 regulators [RFC][PATCH 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators Needed board-* changes and defconfig chages will be done later.Please let me know your feedback/suggestion on this patch series. send these to lkml and Cc linux-omap. Also add to Cc: Samuel Ortiz sa...@openedhand.com Wim Van Sebroeck w...@iguana.be Timo Kokkonen timo.t.kokko...@nokia.com Ben Dooks ben-li...@fluff.org linux-...@vger.kernel.org linux-ker...@vger.kernel.org -- balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/4] TWL6030 patch series
On Mon, Jul 20, 2009 at 03:11:57PM +0300, Felipe Balbi wrote: send these to lkml and Cc linux-omap. Also add to Cc: Samuel Ortiz sa...@openedhand.com Wim Van Sebroeck w...@iguana.be Timo Kokkonen timo.t.kokko...@nokia.com Ben Dooks ben-li...@fluff.org linux-...@vger.kernel.org linux-ker...@vger.kernel.org Plus me and Liam Girdwood l...@slimlogic.co.uk for the regulator stuff. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC][PATCH 0/4] TWL6030 patch series
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Monday, July 20, 2009 5:45 PM To: Felipe Balbi Cc: Krishnamoorthy, Balaji T; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra Subject: Re: [RFC][PATCH 0/4] TWL6030 patch series On Mon, Jul 20, 2009 at 03:11:57PM +0300, Felipe Balbi wrote: send these to lkml and Cc linux-omap. Also add to Cc: Samuel Ortiz sa...@openedhand.com Wim Van Sebroeck w...@iguana.be Timo Kokkonen timo.t.kokko...@nokia.com Ben Dooks ben-li...@fluff.org linux-...@vger.kernel.org linux-ker...@vger.kernel.org Plus me and Liam Girdwood l...@slimlogic.co.uk for the regulator stuff. Ok will resend both the patch series with above mentioned email-id's in CC. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
