[PATCH 0/2] PCMCIA: Deletion of a few unnecessary checks

2015-01-18 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 18 Jan 2015 19:49:16 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Deletion of checks before the function call "iounmap" Less function calls in bcm63xx_drv_pcmcia_probe()

[PATCH 1/2] PCMCIA: Deletion of checks before the function call "iounmap"

2015-01-18 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 18 Jan 2015 18:48:09 +0100 The iounmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pcmcia/bcm63xx_pcmcia.c

[PATCH 2/2] PCMCIA: Less function calls in bcm63xx_drv_pcmcia_probe() after error detection

2015-01-18 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 18 Jan 2015 19:45:45 +0100 The functions "iounmap", "kfree" and "release_mem_region" were called in some cases by the bcm63xx_drv_pcmcia_probe() function during error handling even if the passed variable contained a null pointer. * Corresponding details could be i

Re: samples: move auxdisplay example code from Documentation

2016-09-19 Thread SF Markus Elfring
> Documentation/auxdisplay/cfag12864b needs to be updated to reflect the new > home for the program (which probably does belong in samples/). > > I wonder if these programs need MAINTAINERS entries too? Do you find any more update suggestions interesting around this software module? https://patch

[PATCH 0/4] PCMCIA-PD6729: Adjustments for four function implementations

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 14:05:06 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use kcalloc() in pd6729_pci_probe() Delete an error message for a failed memory allocation in pd6729_pci_probe() Add the macro "

[PATCH 1/4] pcmcia: pd6729: Use kcalloc() in pd6729_pci_probe()

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 11:41:00 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by using the Coccinelle softw

[PATCH 2/4] pcmcia: pd6729: Delete an error message for a failed memory allocation in pd6729_pci_probe()

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 12:44:23 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Sign

[PATCH 3/4] pcmcia: pd6729: Add the macro "pr_fmt"

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 13:15:33 +0200 Add a definition for the macro "pr_fmt" so that its information can be used for consistent message output. Signed-off-by: Markus Elfring --- drivers/pcmcia/pd6729.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/p

[PATCH 4/4] pcmcia: pd6729: Combine substrings for six messages

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 13:50:52 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Prefer usage of the macros "pr_err" and "pr_info" over the interface "printk". S

[PATCH 2/2] pcmcia: Delete an error message for a failed memory allocation in two functions

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 15:23:42 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Si

[PATCH 0/2] PCMCIA-Resource management: Adjustments for three function implementations

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 15:46:54 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in three functions Delete an error message for a failed memory allocation in two functions drivers/pc

[PATCH 1/2] pcmcia: Improve a size determination in three functions

2017-05-15 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 May 2017 15:13:00 +0200 Replace the specification of three data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH] pcmcia/vrc4171: Use common error handling code in vrc4171_card_init()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 14:05:35 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pcmcia/vrc4171_card.c | 13 +++

[PATCH 0/2] PCMCIA-rsrc_nonstatic: Adjustments for two function implementations

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 21:26:54 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Improve a size determination in three functions drivers/pc

[PATCH 1/2] pcmcia/rsrc_nonstatic: Delete an error message for a failed memory allocation in two functions

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 21:00:13 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pcmcia/rsrc_nonstatic.c | 10 -- 1 file changed, 4 i

[PATCH 2/2] pcmcia/rsrc_nonstatic: Improve a size determination in three functions

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 21:07:39 +0100 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detect

[PATCH 0/3] PCMCIA-CIS: Adjustments for six function implementations

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 22:42:10 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): cistpl: Delete error messages for a failed memory allocation in three functions cis: Delete an error message for a failed memo

[PATCH 1/3] pcmcia/cistpl: Delete error messages for a failed memory allocation in three functions

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 22:12:00 +0100 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pcmcia/cistpl.c | 12 1 file changed, 4 insertion

[PATCH 2/3] pcmcia/cis: Delete an error message for a failed memory allocation in two functions

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 22:20:51 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pcmcia/pcmcia_cis.c | 9 +++-- 1 file changed, 3 inserti

[PATCH 3/3] pcmcia/cis: Improve a size determination in pcmcia_loop_config()

2017-12-28 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 28 Dec 2017 22:30:42 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det