Re: [PATCH] md: new bitmap sysfs interface

2006-08-03 Thread Mr. James W. Laferriere
Hello All , On Thu, 3 Aug 2006, David Greaves wrote: Neil Brown wrote: write-bits-here-to-dirty-them-in-the-bitmap is probably (no, definitely) too verbose. Any better suggestions? It's not actually a bitmap is it? It takes a number or range and *operates* on a bitmap. so:

Re: [PATCH] md: new bitmap sysfs interface

2006-08-02 Thread Paul Clements
Neil Brown wrote: Is 'bitmap' the best name for the sysfs file? It seems a bit generic to me. write-bits-here-to-dirty-them-in-the-bitmap is probably (no, definitely) too verbose. dirty-in-bitmap maybe? bitmap-set-bits Any better suggestions? I like bitmap-set-bits or bitmap-dirty

Re: [PATCH] md: new bitmap sysfs interface

2006-07-27 Thread Paul Clements
Mike Snitzer wrote: On 7/26/06, Paul Clements [EMAIL PROTECTED] wrote: Mike Snitzer wrote: Also, what is the interface one should use to collect dirty bits from the primary's bitmap? Whatever you'd like. scp the bitmap file over or collect the ranges into a file and scp that over, or

Re: [PATCH] md: new bitmap sysfs interface

2006-07-27 Thread Mike Snitzer
On 7/26/06, Paul Clements [EMAIL PROTECTED] wrote: Mike Snitzer wrote: I tracked down the thread you referenced and these posts (by you) seems to summarize things well: http://marc.theaimsgroup.com/?l=linux-raidm=16563016418w=2

Re: [PATCH] md: new bitmap sysfs interface

2006-07-27 Thread Paul Clements
Mike Snitzer wrote: On 7/26/06, Paul Clements [EMAIL PROTECTED] wrote: Right. At the time of the failover, there were (probably) blocks that were out of sync between the primary and secondary. OK, so now that I understand the need to merge the bitmaps... the various scenarios that create

Re: [PATCH] md: new bitmap sysfs interface

2006-07-26 Thread Mike Snitzer
On 7/25/06, Paul Clements [EMAIL PROTECTED] wrote: This patch (tested against 2.6.18-rc1-mm1) adds a new sysfs interface that allows the bitmap of an array to be dirtied. The interface is write-only, and is used as follows: echo 1000 /sys/block/md2/md/bitmap (dirty the bit for chunk 1000

Re: [PATCH] md: new bitmap sysfs interface

2006-07-26 Thread Paul Clements
Mike Snitzer wrote: I tracked down the thread you referenced and these posts (by you) seems to summarize things well: http://marc.theaimsgroup.com/?l=linux-raidm=16563016418w=2 http://marc.theaimsgroup.com/?l=linux-raidm=17515400864w=2 But for clarity's sake, could you elaborate on the

Re: [PATCH] md: new bitmap sysfs interface

2006-07-26 Thread Mike Snitzer
On 7/26/06, Paul Clements [EMAIL PROTECTED] wrote: Mike Snitzer wrote: I tracked down the thread you referenced and these posts (by you) seems to summarize things well: http://marc.theaimsgroup.com/?l=linux-raidm=16563016418w=2

[PATCH] md: new bitmap sysfs interface

2006-07-25 Thread Paul Clements
This patch (tested against 2.6.18-rc1-mm1) adds a new sysfs interface that allows the bitmap of an array to be dirtied. The interface is write-only, and is used as follows: echo 1000 /sys/block/md2/md/bitmap (dirty the bit for chunk 1000 [offset 0] in the in-memory and on-disk bitmaps of

Re: [PATCH] md: new bitmap sysfs interface

2006-07-25 Thread dave rientjes
On Tue, 25 Jul 2006, Paul Clements wrote: @@ -1322,6 +1324,18 @@ static void bitmap_set_memory_bits(struc } +/* dirty the memory and file bits for bitmap chunks s to e */ +void bitmap_dirty_bits(struct bitmap *bitmap, unsigned long s, unsigned long e) +{ + unsigned long chunk; + +