[PATCH 2/2]: Powerpc: Fix EHCA driver on relocatable kernel

2010-08-19 Thread Sonny Rao
the eHCA driver registers a MR for all of kernel memory, but makes the assumption that valid memory exists at KERNELBASE. This assumption may not be true in the case of a relocatable kernel, so use KERNELBASE + PHYSICAL_START to get the true beginning of usable kernel memory. This patch depends o

[PATCH 1/2]: Powerpc: Fix EHCA driver on relocatable kernel

2010-08-19 Thread Sonny Rao
Some modules (like eHCA) want to map all of kernel memory, for this to work with a relocated kernel, we need to export kernstart_addr so modules can use PHYSICAL_START and memstart_addr so they could use MEMORY_START. Note that the 32bit code already exports these symbols. Signed-off-By: Sonny Ra

ipoib neighbour free race?

2010-08-19 Thread Zach Brown
Hi gang, We're chasing a bug that we can hit when we pull IB cables with CONFIG_DEBUG_PAGE_ALLOC enabled. It appears as though the to_ipoib_neigh() in ipoib_neigh_free() under ipoib_mcast_free() is referencing a freed neighbour struct. The invariant here, as far as I can tell, is that cleanup_n

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread Bart Van Assche
On Thu, Aug 19, 2010 at 7:29 PM, Roland Dreier wrote: >  > > Putting the rsv assignment on the same line as its declaration would >  > > make that line exceed 80 columns and hence would trigger a checkpatch >  > > complaint, so it's better to keep it as it is now. > >  > I didn't check it with che

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread Roland Dreier
> > Putting the rsv assignment on the same line as its declaration would > > make that line exceed 80 columns and hence would trigger a checkpatch > > complaint, so it's better to keep it as it is now. > I didn't check it with checkpatch, but vi tells me it is 78 characters. In any case I thi

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread Bart Van Assche
On Thu, Aug 19, 2010 at 7:25 PM, David Dillow wrote: > On Thu, 2010-08-19 at 18:53 +0200, Bart Van Assche wrote: >> On Thu, Aug 19, 2010 at 12:44 PM, David Dillow wrote: >> > Put the assignment on the same line as the declaration and I'll deal >> > with the name. >> >> Putting the rsv assignment

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread David Dillow
On Thu, 2010-08-19 at 18:53 +0200, Bart Van Assche wrote: > On Thu, Aug 19, 2010 at 12:44 PM, David Dillow wrote: > > Put the assignment on the same line as the declaration and I'll deal > > with the name. > > Putting the rsv assignment on the same line as its declaration would > make that line e

Re: Userspace MMU Notification

2010-08-19 Thread Roland Dreier
> During the .35 merge window I attempted to merge the ummunotify driver and > was told by Linus that he didn't like the approach. At that point several > members of the RDMA community were hashing out a way to do the same thing > that would get Linus' blessing. I haven't seen anything about

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread Bart Van Assche
On Thu, Aug 19, 2010 at 12:44 PM, David Dillow wrote: > On Thu, 2010-08-19 at 08:04 +0200, Bart Van Assche wrote: >> On Thu, Aug 19, 2010 at 1:44 AM, David Dillow wrote: >> > >> > On Mon, 2010-08-16 at 20:54 +0200, Bart Van Assche wrote: >> > > @@ -989,19 +989,21 @@ static void srp_send_completio

Userspace MMU Notification

2010-08-19 Thread Eric B Munson
During the .35 merge window I attempted to merge the ummunotify driver and was told by Linus that he didn't like the approach. At that point several members of the RDMA community were hashing out a way to do the same thing that would get Linus' blessing. I haven't seen anything about it since and

Re: [PATCH 2/3 v5] IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQ

2010-08-19 Thread Bart Van Assche
On Thu, Aug 19, 2010 at 12:52 PM, David Dillow wrote: > > On Thu, 2010-08-19 at 12:10 +0200, Bart Van Assche wrote: > > On Thu, Aug 19, 2010 at 2:48 AM, David Dillow wrote: > > [ ... ] > > If I do not receive any further feedback, > > I will modify srp_handle_req() such that it accepts a third ar

Re: [PATCH 2/3 v5] IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQ

2010-08-19 Thread David Dillow
On Thu, 2010-08-19 at 12:10 +0200, Bart Van Assche wrote: > On Thu, Aug 19, 2010 at 2:48 AM, David Dillow wrote: > > On Mon, 2010-08-16 at 20:55 +0200, Bart Van Assche wrote: > >> Implements SRP_CRED_REQ and SRP_AER_REQ, which are information units > >> defined > >> in the SRP (draft) standard.

Re: [PATCH 1/3 v5] IB/srp: Preparation for transmit ring response allocation

2010-08-19 Thread David Dillow
On Thu, 2010-08-19 at 08:04 +0200, Bart Van Assche wrote: > On Thu, Aug 19, 2010 at 1:44 AM, David Dillow wrote: > > > > On Mon, 2010-08-16 at 20:54 +0200, Bart Van Assche wrote: > > > @@ -989,19 +989,21 @@ static void srp_send_completion(struct ib_cq *cq, > > > void *target_ptr) > > > static st

Re: IBoE and congestion management

2010-08-19 Thread Or Gerlitz
Fredy Neeser wrote: Not sure what you mean by "IB CM is fully functional for IBoE" with ConnectX. The IB CM (Connection Manager) is used for the connection establishment, it has nothing do to with Congestion Management. I mentioned it in the context of IB MAD (Management Datagrams) support b

Re: [PATCH 2/3 v5] IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQ

2010-08-19 Thread Bart Van Assche
On Thu, Aug 19, 2010 at 2:48 AM, David Dillow wrote: > On Mon, 2010-08-16 at 20:55 +0200, Bart Van Assche wrote: >> Implements SRP_CRED_REQ and SRP_AER_REQ, which are information units defined >> in the SRP (draft) standard.  Adds declarations for the SRP_CRED_REQ, >> SRP_CRED_RSP, SRP_AER_REQ and

Re: [PATCH v2] rdma/ib_pack.h: add new bth opcodes

2010-08-19 Thread Eli Cohen
On Thu, Aug 19, 2010 at 11:54:17AM +0300, Or Gerlitz wrote: > Bob Pearson wrote: > > I was curious to see if I could force a ConnectX device to slow down from a > > remote application. > > But since the MADs have been crippled for IBOE there is no way to configure > > it. > > QP1 MADs are workin

Re: [PATCH v2] rdma/ib_pack.h: add new bth opcodes

2010-08-19 Thread Or Gerlitz
Bob Pearson wrote: > I was curious to see if I could force a ConnectX device to slow down from a > remote application. > But since the MADs have been crippled for IBOE there is no way to configure > it. QP1 MADs are working for ConnectX, e.g the IB CM is fully functional for IBoE, and I don't t

Re: opensm/osm_opensm.c: no report when SM is exiting

2010-08-19 Thread Yevgeny Kliteynik
On 19-Aug-10 3:59 AM, Ira Weiny wrote: > On Wed, 18 Aug 2010 14:58:44 -0700 > Yevgeny Kliteynik wrote: > >> On 18-Aug-10 7:06 PM, Ira Weiny wrote: >>> On Wed, 18 Aug 2010 06:38:14 -0700 >>> Yevgeny Kliteynik wrote: >>> Don't bother reporting events to plug-ins while SM is exiting. >>> >>>