Re: [PATCH 2/2] Ad IB_MTU_1500|9000 enums.

2013-04-19 Thread Jeff Squyres (jsquyres)
On Apr 12, 2013, at 11:40 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: As an aside I like the use of RDMA_MTU_* for these values. Again to distinguish them from the IBTA values. But I know that is poor form. So what's the right way to move forward on this? Is it this: enum

Re: [PATCH 1/2] Use autoreconf in autogen.sh

2013-04-19 Thread Jeff Squyres (jsquyres)
Bump. Any thoughts on these two patches? They're pretty trivial, enable use with modern versions of Autotools, and now feature the proper Signed-off-by line. On Apr 13, 2013, at 8:15 AM, Jeff Squyres jsquy...@cisco.com wrote: The old sequence of Autotools commands listed in autogen.sh is no

[PATCH] infiniband-diags: updates for new autoconf tools

2013-04-19 Thread Ira Weiny
Signed-off-by: Ira Weiny ira.we...@intel.com --- NEWS |2 + autogen.sh |6 +- configure.ac | 255 ++ configure.in | 255 -- 4 files changed, 258 insertions(+), 260

[PATCH] infiniband-diags: add .gitignore

2013-04-19 Thread Ira Weiny
Signed-off-by: Ira Weiny ira.we...@intel.com --- .gitignore | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..390c6d7 --- /dev/null +++

[PATCH] infiniband-diags: remove doc/man/ibclearcounters.8.in

2013-04-19 Thread Ira Weiny
ibclearcounters is part of the compatibility package and the man page remains in the man directory. Signed-off-by: Ira Weiny ira.we...@intel.com --- doc/man/ibclearcounters.8.in | 101 -- 1 files changed, 0 insertions(+), 101 deletions(-) delete mode

Re: IPoIB header prefetch for fragmented SKB

2013-04-19 Thread Eric Dumazet
I dont think so : a total of 52 bytes are pulled. (20 bytes for IPv4 header, 32 bytes for TCP header (TS)) On Fri, Apr 19, 2013 at 11:07 AM, Markus Stockhausen markus.stockhau...@gmx.de wrote: Am 17.04.13 21:10 schrieb Eric Dumazet unter eduma...@google.com: Please try : diff --git

Re: IPoIB header prefetch for fragmented SKB

2013-04-19 Thread Eric Dumazet
This pulls cannot explain a major performance problem. Its a memcpy( ... 20 bytes). No more no less. I have NICs here, reaching 20Gbp on a single TCP flow, were the pull is done. Something else is going on. On Fri, Apr 19, 2013 at 11:09 AM, Eric Dumazet eduma...@google.com wrote: I dont think

Re: IPoIB header prefetch for fragmented SKB

2013-04-19 Thread Roland Dreier
On Wed, Apr 17, 2013 at 12:10 PM, Eric Dumazet eduma...@google.com wrote: + prefetch(page_address(frag-page.p)); Would it also make sense to do a prefetchw(skb-data); here? (That's where we'll copy the header, right?) -- To unsubscribe from this list: send the line

RE: [PATCH 1/2] Use autoreconf in autogen.sh

2013-04-19 Thread Hefty, Sean
Any thoughts on these two patches? They're pretty trivial, enable use with modern versions of Autotools, and now feature the proper Signed-off-by line. It may help if you identify the library this patch is against. :) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in

Re: IPoIB header prefetch for fragmented SKB

2013-04-19 Thread Eric Dumazet
Almost no driver care to do that, but you could try anyway ;) On Fri, Apr 19, 2013 at 5:18 PM, Roland Dreier rol...@kernel.org wrote: On Wed, Apr 17, 2013 at 12:10 PM, Eric Dumazet eduma...@google.com wrote: + prefetch(page_address(frag-page.p)); Would it also make sense to do

Re: [PATCH 2/2] Ad IB_MTU_1500|9000 enums.

2013-04-19 Thread Doug Ledford
On 04/19/2013 11:24 AM, Jeff Squyres (jsquyres) wrote: On Apr 12, 2013, at 11:40 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: As an aside I like the use of RDMA_MTU_* for these values. Again to distinguish them from the IBTA values. But I know that is poor form. So what's the