Re: [PATCH v2 2/2] IB/mlx5: Free resources during PCI error

2014-03-17 Thread Eli Cohen
On Fri, Mar 14, 2014 at 12:14:58PM -0500, cls...@linux.vnet.ibm.com wrote: Hi Carol, see my comments below. Also, can please share with us if you've been making any testing to these patches, how you tested and what were the results? @@ -471,9 +471,12 @@ static void clean_keys(struct mlx5_ib_de

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Mike Christie
On 03/17/2014 02:25 AM, Or Gerlitz wrote: On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg sa...@mellanox.com wrote: iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the

RE: Why is Infiniband a Lossless medium?

2014-03-17 Thread Christoph Lameter
On Sun, 16 Mar 2014, Shachar Raindel wrote: Infiniband is a lossless medium in the aspect of the switches and L2 buffering. This means that if the switch or HCA does not have buffer space to receive a packet, the remote side will not send it. If the receiving QP does not have buffers

[PATCH] Fix memory leak of recv context array during failed init

2014-03-17 Thread Dennis Dalessandro
Hi Roland, The following patch fixes a small memory leak during a failed init. It is based on change 2dea9094. --- Dennis Dalessandro (1): IB/qib: Fix memory leak of recv context when driver fails to initialize. drivers/infiniband/hw/qib/qib_init.c | 13 + 1 files

[PATCH] IB/qib: Fix memory leak of recv context when driver fails to initialize.

2014-03-17 Thread Dennis Dalessandro
In qib_create_ctxts() we allocate an array to hold recv contexts. Then attempt to create data for those recv contexts. If that call to qib_create_ctxtdata() fails then an error is returned but the previously allocated memory is not freed. Reviewed-by: Mike Marciniszyn mike.marcinis...@intel.com

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Sagi Grimberg
On 3/17/2014 6:59 PM, Mike Christie wrote: SNIP This patch is ok, but happened to the patch for the xmit task path? Hey Mike, Thanks for your Ack on this. The xmit_task fix was posted as a separate patch since it is not specific to this set (relevant also for existing data dma_mapping in

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-17 Thread Or Gerlitz
On Mon, Mar 17, 2014, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/17/2014 6:59 PM, Mike Christie wrote: This patch is ok, but happened to the patch for the xmit task path? Hey Mike, Thanks for your Ack on this. The xmit_task fix was posted as a separate patch since it is not specific