> > > > >
> > > > > If Doug accepts the library changes, let me know that public git
> > > > > commit
> > > > > and I can pull it into the staging-next branch and you can continue to
> > > > > send me staging patches that way.
> > > >
> > > > Won't this cause a conflict during the merge window?
On Tue, Jan 05, 2016 at 01:52:55PM -0500, Hal Rosenstock wrote:
> In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr
>
> Signed-off-by: Hal Rosenstock
First off I have to say; this comment is wrong and should be fixed.
Reviewed-by: Ira Weiny
That said.
I agree with Sean that
On Mon, Jan 04, 2016 at 03:44:15PM -0500, Hal Rosenstock wrote:
> ib_mad_snoop_handler uses send_buf rather than send_wr
>
> Signed-off-by: Hal Rosenstock
Reviewed-by: Ira Weiny
> ---
> Change since v1:
> Fixed typo in patch description
>
> diff --git a/include/rdma/ib_mad.h b/include/rdma/ib
On Mon, Jan 04, 2016 at 02:15:59PM +0100, Christoph Hellwig wrote:
> Remove the local workqueue to process mad completions and use the CQ API
> instead.
>
> Signed-off-by: Christoph Hellwig
One minor nit below...
> ---
> drivers/infiniband/core/mad.c | 159
> +---
On Mon, Jan 04, 2016 at 02:15:58PM +0100, Christoph Hellwig wrote:
> Stop abusing wr_id and just pass the parameter explicitly.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Ira Weiny
> ---
> drivers/infiniband/core/cm.c | 1 +
> drivers/infiniband/core/mad.c | 18 ++
On Wed, Dec 30, 2015 at 03:01:33AM -0800, Christoph Hellwig wrote:
> Hi Ira,
>
> please take a look at the patches I've attached - they are just WIP
> that hasn't been tested as I'm on a vacation without access to my
> IB setup until New Year's Eve.
>
> Patch 1 is I think a genuine bug fix caused
On Thu, Dec 31, 2015 at 08:58:31AM +0100, Bart Van Assche wrote:
> On 12/17/2015 08:52 PM, Christoph Lameter wrote:
> >-in_mad->mad_hdr.attr_id = cpu_to_be16(0x12); /* PortCounters */
> >+in_mad->mad_hdr.attr_id = attr;
>
> Hello Christoph,
>
> sparse reports an endianness mis
On Wed, Dec 30, 2015 at 03:01:33AM -0800, Christoph Hellwig wrote:
> Hi Ira,
>
> please take a look at the patches I've attached - they are just WIP
> that hasn't been tested as I'm on a vacation without access to my
> IB setup until New Year's Eve.
>
> Patch 1 is I think a genuine bug fix caused
On Sat, Jan 02, 2016 at 09:03:31AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 30, 2015 at 09:00:07PM -0500, ira.weiny wrote:
> > On Wed, Dec 30, 2015 at 03:01:33AM -0800, Christoph Hellwig wrote:
> > > Hi Ira,
> > >
> > > please take a look at the patch
On Wed, Dec 30, 2015 at 03:01:33AM -0800, Christoph Hellwig wrote:
> Hi Ira,
>
> please take a look at the patches I've attached - they are just WIP
> that hasn't been tested as I'm on a vacation without access to my
> IB setup until New Year's Eve.
I have them on a branch.
I'll try and do some
On Tue, Dec 29, 2015 at 11:51:19AM +0200, Sagi Grimberg wrote:
>
> >Please just convert the mad handler to the new CQ API in
> >drivers/infiniband/core/cq.c. If you have any question about it I'd be
> >glad to help you.
>
> +1 on this suggestion.
>
> We had these sorts of questions in our ULPs
On Tue, Dec 29, 2015 at 01:25:33AM +0200, Eli Cohen wrote:
> On Mon, Dec 28, 2015 at 06:05:46PM -0500, ira.weiny wrote:
> >
> > Will it hurt to rearm? The way the code stands I think the worse that will
> > happen is an extra work item scheduled and an ib_poll_cq cal
On Mon, Dec 28, 2015 at 04:53:18PM -0500, Hal Rosenstock wrote:
>
> Port number is not part of ClassPortInfo attribute but is
> still needed as a parameter when invoking process_mad.
>
> To properly handle this attribute, port_num is added as a
> parameter to get_counter_table and get_perf_mad wa
On Mon, Dec 28, 2015 at 06:51:30PM +0200, Eli Cohen wrote:
> On Thu, Dec 10, 2015 at 04:52:30PM -0500, ira.we...@intel.com wrote:
> > From: Dean Luick
> >
> >
> > @@ -2555,6 +2567,7 @@ static void ib_mad_completion_handler(struct
> > work_struct *work)
> > {
> > struct ib_mad_port_private
On Thu, Dec 24, 2015 at 06:22:14PM +0200, eran ben elisha wrote:
> On Mon, Dec 21, 2015 at 4:20 PM, Christoph Lameter wrote:
[snip]
> >
> > +/*
> > + * Figure out which counter table to use depending on
> > + * the device capabilities.
> > + */
> > +static struct attribute_group *get_counter_tab
On Tue, Dec 22, 2015 at 06:27:57PM -0800, gre...@linuxfoundation.org wrote:
> On Tue, Dec 22, 2015 at 02:15:08PM -0500, ira.weiny wrote:
> > On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote:
[snip]
> > >
> > > No, git is good :)
> > &g
On Tue, Dec 22, 2015 at 02:38:10PM +0200, Moni Shoua wrote:
> Hi,
>
> In the past months the need for a kernel module that implements the InfiniBand
> transport in software and unify all the InfiniBand software drivers has
> been raised. Since then, nobody has submitted any design proposal that sa
On Wed, Dec 23, 2015 at 01:11:11PM -0500, Doug Ledford wrote:
> On 12/21/2015 09:42 AM, Christoph Lameter wrote:
> > V1->V2
> > - Add Reviewed by's for first patch from Ira Weiny
> > - Change name of ipoib_check_mcast_sendonly() to
> > ipoib_check_and_add_mcast_sendonly() as requested by Ira
Doug,
With your email troubles I just wanted to make sure you did not lose track of
this patch.
https://patchwork.kernel.org/patch/7822511/
Thanks,
Ira
On Thu, Dec 10, 2015 at 04:52:30PM -0500, ira.we...@intel.com wrote:
> From: Dean Luick
>
> It was found that when a process was rapidly send
On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote:
> > On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote:
> > > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny w
On Mon, Dec 21, 2015 at 04:13:49PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote:
> > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote:
> > > From: Ira Weiny
> > >
> > > Various
On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote:
> > Greg, Doug,
> >
> > As mentioned below, these patches depend on the new rdmavt library
> > submitted to
> > Doug on li
On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Various improvements to the SDMA engine code.
Greg,
Thanks for reviewing and accepting our patches to staging-testing. I apologize
for the conflicts we had between the 3 of us submitting. However, in
at
On Mon, Dec 21, 2015 at 01:31:31PM -0600, Christoph Lameter wrote:
> On Mon, 21 Dec 2015, Hal Rosenstock wrote:
>
> > > Don't we need to change all the sysfs_remove_groups to use
> > > get_counter_table as
> > > well?
> >
> > Looks like it to me too. Good catch.
>
> Fix follows:
>
> From: Chris
On Mon, Dec 21, 2015 at 08:20:29AM -0600, Christoph Lameter wrote:
> V2->V3: Add check for NOIETF mode and create special table
> for that case.
>
> Check if the extended counters are available and if so
> create the proper extended and additional counters.
>
> Reviewed-by: Hal Rosenstock
> Si
On Mon, Dec 21, 2015 at 08:20:28AM -0600, Christoph Lameter wrote:
> Add the attr_id on port_table_attribute since we will have to add
> a different port_table_attribute for the extended attribute soon.
>
> Reviewed-by: Hal Rosenstock
Reviewed-by: Ira Weiny
> Signed-off-by: Christoph Lameter
On Mon, Dec 21, 2015 at 08:20:27AM -0600, Christoph Lameter wrote:
> Create a new function to retrieve performance management
> data from the existing code in get_pma_counter().
>
> Reviewed-by: Hal Rosenstock
Reviewed-by: Ira Weiny
> Signed-off-by: Christoph Lameter
> ---
> drivers/infiniba
On Mon, Dec 21, 2015 at 12:03:46AM -0800, Christoph Hellwig wrote:
> On Mon, Dec 21, 2015 at 08:37:26AM +0200, Leon Romanovsky wrote:
> > You are right and it is a preferred way for me too, however the
> > downside of such change will be one of two:
> > 1. Change this structure only => we will have
On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Modify enum ib_device_cap_flags such that other patches which add new
> enum values pass strict checkpatch.pl checks.
>
> Reviewed-by: Sagi Grimberg
> Signed-off-by: Leon Romanovsky
> ---
> include/rd
Greg, Doug,
As mentioned below, these patches depend on the new rdmavt library submitted to
Doug on linux-rdma.
We continue to identify (and rework) patches by our other developers which can
be submitted without conflicts with this series. Furthermore, We have, as much
as possible, placed fixes
On Fri, Dec 18, 2015 at 11:01:24AM +0200, Or Gerlitz wrote:
> On Fri, Dec 18, 2015 at 7:16 AM, ira.weiny wrote:
>
> > More than anything what I hate is all the places that allocate struct
> > ib_device_attr just to free it after the query call.
>
> did you care to look
On Thu, Dec 17, 2015 at 07:31:20PM +0100, Bart Van Assche wrote:
> On 12/17/2015 06:41 PM, Jason Gunthorpe wrote:
> >On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote:
> >>
> >>>+ ret = ib_query_device(device, &device->attrs);
> >>>+ if (ret) {
> >>>+ printk(KERN_WARNING "Cou
On Thu, Dec 17, 2015 at 02:23:39PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> > +static int unprogram_rcvarray(struct file *fp, u32 tidinfo,
> > + struct tid_group **grp)
> > +{
> > + stru
On Thu, Dec 17, 2015 at 03:06:45PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:23AM -0500, ira.we...@intel.com wrote:
> > + mutex_lock(&uctxt->exp_lock);
> > + /*
> > +* The first step is to program the RcvArray entries which are complete
> > +* groups.
> > +*/
> > +
On Thu, Dec 17, 2015 at 02:59:52PM +0300, Dan Carpenter wrote:
> On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote:
> > +}
> > +
> > +static int program_rcvarray(struct file *fp, unsigned long vaddr,
> > + struct tid_group *grp,
> > + st
On Tue, Dec 15, 2015 at 10:30:22AM -0700, Jason Gunthorpe wrote:
> On Tue, Dec 15, 2015 at 05:38:34PM +0100, Michael Wang wrote:
> > The hop_limit is only suggest that the package allowed to be
> > routed, not have to, correct?
>
> If the hop limit is >= 2 (?) then the GRH is mandatory.
Yes >= 2.
Any further feedback on this series?
Ira
On Tue, Dec 01, 2015 at 02:47:55PM -0500, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> This was a single patch before. The change to dev_dbg required a precursor
> patch to add the dd_dev_dbg which is consistent with the other dev_* macros
> which a
On Tue, Nov 10, 2015 at 01:22:51PM +0200, Hal Rosenstock wrote:
>
> src/ibdiag_common.c: In function ?dump_portinfo?:
> src/ibdiag_common.c:856: warning: unused parameter ?pisize?
>
> Signed-off-by: Hal Rosenstock
Thanks applied,
Ira
> ---
> diff --git a/include/ibdiag_common.h b/include/ibdia
On Tue, Nov 10, 2015 at 01:23:39PM +0200, Hal Rosenstock wrote:
>
> src/ibsendtrap.c: In function ?send_trap?:
> src/ibsendtrap.c:124: warning: unused parameter ?name?
>
> Signed-off-by: Hal Rosenstock
Thanks applied,
Ira
> ---
> diff --git a/src/ibsendtrap.c b/src/ibsendtrap.c
> index 46fd6e7
On Tue, Nov 10, 2015 at 01:23:01PM +0200, Hal Rosenstock wrote:
>
> src/ibportstate.c:450: warning: comparison of unsigned expression < 0 is
> always false
> src/ibportstate.c:454: warning: comparison of unsigned expression < 0 is
> always false
> src/ibportstate.c:458: warning: comparison of un
On Fri, Dec 11, 2015 at 05:47:15PM -0700, Jason Gunthorpe wrote:
> On Fri, Dec 11, 2015 at 07:23:13PM -0500, ira.weiny wrote:
> > On Fri, Dec 11, 2015 at 05:00:47PM -0700, Jason Gunthorpe wrote:
> > >
> > > FWIW, I also hate the sysfs counters that reflect the PMA
On Fri, Dec 11, 2015 at 05:00:47PM -0700, Jason Gunthorpe wrote:
>
> FWIW, I also hate the sysfs counters that reflect the PMA, these would
> be much better are free running, wrapping, non-resetting counters
> unrelated to the PMA. Something that doesn't zero after the SM samples
> it. Sounds like
On Fri, Dec 11, 2015 at 12:25:35PM -0600, Christoph Lameter wrote:
> Display the additional 64 bit counters available through the extended
> set and replace the existing 32 bit counters if there is a 64 bit
> alternative available.
>
> Note: This requires universal support of extended counters in
On Fri, Dec 11, 2015 at 12:25:34PM -0600, Christoph Lameter wrote:
> Add a branch to display 64 bit values
>
> Signed-off-by: Christoph Lameter
Reviewed-by: Ira Weiny
> ---
> drivers/infiniband/core/sysfs.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/infiniband/core
On Fri, Dec 11, 2015 at 12:25:33PM -0600, Christoph Lameter wrote:
> This is necessary to support the extended attributes which involves
> a different attribute id.
>
> Signed-off-by: Christoph Lameter
Reviewed-by: Ira Weiny
> ---
> drivers/infiniband/core/sysfs.c | 41
>
On Fri, Dec 11, 2015 at 06:21:43PM -0500, ira. weiny wrote:
> On Fri, Dec 11, 2015 at 12:16:54PM -0600, Christoph Lameter wrote:
> > Code cleanup to move multicast specific code that checks for
> > a sendonly join to ipoib_multicast.c. This allows the removal
> > of the export of __ipoib_mcast_find
On Fri, Dec 11, 2015 at 12:16:54PM -0600, Christoph Lameter wrote:
> Code cleanup to move multicast specific code that checks for
> a sendonly join to ipoib_multicast.c. This allows the removal
> of the export of __ipoib_mcast_find().
>
> Signed-off-by: Christoph Lameter
> ---
> drivers/infiniba
On Fri, Dec 11, 2015 at 12:16:53PM -0600, Christoph Lameter wrote:
> Code cleanup to remove multicast specific code from ipoib_main.c
>
> The removal of a list of multicast groups occurs in three places.
> Create a new function ipoib_mcast_remove_list(). Use this new
> function in ipoib_main.c too
On Thu, Dec 10, 2015 at 11:49:40AM -0500, Dalessandro, Dennis wrote:
> On Tue, Dec 08, 2015 at 02:52:36PM -0500, ira. weiny wrote:
> >On Tue, Dec 08, 2015 at 01:17:48PM -0600, Sean Hefty wrote:
> >>> > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev,
> >>> > > +struct
On Wed, Dec 09, 2015 at 10:42:35AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 08, 2015 at 07:52:03PM -0500, ira.weiny wrote:
> > Searching patchworks...
> >
> > I'm a bit worried about the size of the patch and I would like to see it
> > split
> > up for
On Tue, Dec 08, 2015 at 03:02:44PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 08, 2015 at 03:59:40PM -0700, Jason Gunthorpe wrote:
> > Or, can we please stop this bikeshedding. Christoph's patch is done,
> > well tested and does a lot more clean up that this hacky three liner.
> >
> > It is a g
On Tue, Dec 08, 2015 at 01:17:48PM -0600, Sean Hefty wrote:
> > > > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev,
> > > > + struct ib_ucontext *context,
> > > > + struct ib_udata *udata)
> > > > +{
> > > > + struct rvt_dev_info *dev = i
On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote:
> On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote:
> > /* A multicast address requires a GRH (see ch. 8.4.1). */
> > - if (ah_attr->dlid >= QIB_MULTICAST_LID_BASE &&
> > - ah_attr->dlid != QIB_PERMISSIVE
On Mon, Dec 07, 2015 at 03:13:16PM -0600, Sean Hefty wrote:
> > +struct ib_pd *rvt_alloc_pd(struct ib_device *ibdev,
> > + struct ib_ucontext *context,
> > + struct ib_udata *udata)
> > +{
> > + struct rvt_dev_info *dev = ib_to_rvt(ibdev);
> > + struct
On Mon, Nov 30, 2015 at 09:34:15AM -0500, Mike Marciniszyn wrote:
> This two patch series fixes regressions for qib and hfi1
> introduced in the 4.4 merge window.
>
> These are critical for 4.4 and for rebasing the qib/hfi1
> refactoring.
Doug, Greg,
It should also be noted that without this cha
On Tue, Nov 17, 2015 at 02:27:46PM -0800, gre...@linuxfoundation.org wrote:
> On Tue, Nov 17, 2015 at 03:30:24PM -0500, ira.weiny wrote:
> > On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote:
> > > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com w
On Thu, Nov 19, 2015 at 04:54:44PM -0800, Greg KH wrote:
> On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote:
> > From: Vennila Megavannan
> >
> > Add a module paramter to toggle prescan/Fast ECN Detection and remove the
> > Kconfig option which used to control this.
>
> Ick, n
On Sat, Nov 21, 2015 at 01:25:23AM +0300, Dan Carpenter wrote:
> On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote:
> > So, as to the hfi1/qib/rxe transport library. The qib driver is in the
> > rdma tree, and we aren't going to move it to staging just because it
> > depends on somethin
On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote:
> On 11/19/2015 05:23 PM, Dennis Dalessandro wrote:
> > On Thu, Nov 12, 2015 at 04:13:18PM -0500, Dennis Dalessandro wrote:
> >> The major todo for the hfi1 driver in staging is getting rid of the
> >> verbs code duplication between ipat
On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote:
> On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote:
> > From: Jubin John
> >
> > Correct the checks on diag.c with the latest checkpatch
> >
> > Reviewed-by: Dennis Dalessandro
> > Reviewed-by: Mike Marciniszyn
On Thu, Nov 12, 2015 at 01:48:50PM +0200, Hal Rosenstock wrote:
>
> Receipt of CM MAD with response method for other than ClassPortInfo
> attribute is invalid.
>
> CM attributes other than ClassPortInfo use send method only
> and GetResp is valid for ClassPortInfo attribute.
> Note also that the
On Wed, Nov 11, 2015 at 12:01:08PM +0300, Dan Carpenter wrote:
> On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > This goto done is followed by an if (ret) break in the outer switch clause.
> > It
> > is unnecessary.
> >
> > Signed-off-by: Dennis
> >
> > Ok, patch 7-9 of this series do not depend on this patch nor number 6. I
> > will
> > resend those 3 while I figure out what to do about these 2:
> >
> > staging/rdma/hfi1: Add function stubs for TID caching
> > staging/rdma/hfi1: Implement Expected Receive TID caching
> >
> > Frankly
On Fri, Oct 30, 2015 at 07:58:18PM -0400, ira. weiny wrote:
> On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote:
> > Hello,
> >
> > hfi1_ioctl() contains many calls to might sleep functions with
> > dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
> > copy_from_use
On Tue, Nov 10, 2015 at 12:59:29PM +0300, Dan Carpenter wrote:
> Gar... No. Please please get rid of the PC() macro. It makes the code
> impossible to understand because instead of hitting CTRL-[ you have
> decode it and then manually type out
>
> :cs find g CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_O
On Fri, Nov 06, 2015 at 05:03:28PM -0800, Greg KH wrote:
> On Fri, Oct 30, 2015 at 06:58:45PM -0400, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> >
> > Expected receives work by user-space libraries (PSM) calling into the driver
> > with information about the user's receive buffer and h
On Fri, Nov 06, 2015 at 05:02:35PM -0800, Greg KH wrote:
> On Fri, Oct 30, 2015 at 06:58:44PM -0400, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> >
> > Add mmu notify helper functions and TID caching function stubs in
> > preparation
> > for the TID caching implementation.
> >
> > TID
On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro
>
> Signed-off-by: Sunny Kumar
Also, NAK as has been covered in other responses.
However, I wanted to add, similar to the hfi1_ioctl fix, we have follow on
checkpatch patch
On Thu, Nov 05, 2015 at 10:56:27AM +0300, Dan Carpenter wrote:
> On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.we...@intel.com wrote:
> > From: Vennila Megavannan
> >
> > Add a module paramter to toggle prescan/Fast ECN Detection.
> >
> > In addition change the PRESCAN_RXQ Kconfig default to "ye
On Thu, Nov 05, 2015 at 10:34:48AM +0300, Dan Carpenter wrote:
> On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.we...@intel.com wrote:
>
> > +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull
>
> There is absolutely no point to having a variable name which is nine
> bajillion
On Fri, Oct 30, 2015 at 08:23:45AM -0400, kaike@intel.com wrote:
> From: Kaike Wan
>
> It was found by Saurabh Sengar that the netlink code tried to allocate
> memory with GFP_KERNEL while holding a spinlock. While it is possible
> to fix the issue by replacing GFP_KERNEL with GFP_ATOMIC, it
On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote:
> Hello,
>
> hfi1_ioctl() contains many calls to might sleep functions with
> dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
> copy_from_user, kzalloc(GFP_KERNEL), etc.).
>
> Should dd->hfi1_snoop.snoop_lock be
> > Can I add the removal of these macros to the TODO list and get this patch
> > accepted in the interm?
>
> Nope, sorry, why would I accept a known-problem patch? Would you do
> such a thing?
>
> > Many of the patches I am queueing up to submit as well as one in this
> > series do
> > not app
On Wed, Oct 28, 2015 at 09:44:27AM -0400, kaike@intel.com wrote:
> From: Kaike Wan
>
> It was found by Saurabh Sengar that the netlink code tried to allocate
> memory with GFP_KERNEL while holding a spinlock. While it is possible
> to fix the issue by replacing GFP_KERNEL with GFP_ATOMIC, it
On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote:
> On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote:
> > From: Jubin John
> >
> > Signed-off-by: Jubin John
> > Signed-off-by: Ira Weiny
> > ---
> > drivers/staging/rdma/hfi1/common.h | 2 +-
> > 1 file changed, 1 inser
On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote:
> On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote:
> > From: Mitko Haralanov
> >
> > Clean up the context and sdma macros and move them to a more logical place
> > in
> > hfi.h
> >
> > Signed-off-by: Mitko Haralanov
>
On Tue, Oct 27, 2015 at 12:16:52PM -0600, Jason Gunthorpe wrote:
> On Tue, Oct 27, 2015 at 02:12:36PM -0400, ira.weiny wrote:
> > On Tue, Oct 27, 2015 at 09:17:40PM +0530, Saurabh Sengar wrote:
> > > replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock
>
On Tue, Oct 27, 2015 at 09:17:40PM +0530, Saurabh Sengar wrote:
> replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock
> should be atomic
> GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may
> fail but certainly avoids deadlock
Great catch. Thanks!
However, gfp_
On Wed, Oct 21, 2015 at 04:18:06PM +0300, Dan Carpenter wrote:
> On Mon, Oct 19, 2015 at 10:11:16PM -0400, ira.we...@intel.com wrote:
> > From: Mike Marciniszyn
> >
> > This additional call is a regression from qib. For small messages the
> > progress
> > routine always builds one and clears ou
On Thu, Oct 22, 2015 at 01:41:58PM +0300, Dan Carpenter wrote:
> On Mon, Oct 19, 2015 at 10:11:29PM -0400, ira.we...@intel.com wrote:
> > + case HFI1_CMD_TID_INVAL_READ:
> > + ret = hfi1_user_exp_rcv_invalid(fp, &tinfo);
> > + if (!ret) {
> > + addr = (unsign
On Thu, Oct 22, 2015 at 01:54:21PM +0300, Dan Carpenter wrote:
> What values work well for this parameter?
64.
For v3, I've squashed a change which was farther down my list of changes
which set this after some testing.
Thanks,
Ira
>
> regards,
> dan carpenter
>
--
To unsubscribe from this lis
On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote:
> >
> > Perhaps I did not chose my words carefully enough.
> >
> > The largest issue on the TODO list is the refactoring of the code to be
> > shared between the hfi1 and qib driver. While the hardware between hfi1
> > and qib is similar
On Tue, Oct 13, 2015 at 08:38:20AM -0400, Hal Rosenstock wrote:
>
> src/ibqueryerrors.c: In function ?print_port_config?:
> src/ibqueryerrors.c:176: warning: unused parameter ?node_name?
> src/ibqueryerrors.c: In function ?query_and_dump?:
> src/ibqueryerrors.c:367: warning: unused parameter ?node
On Tue, Oct 13, 2015 at 08:38:02AM -0400, Hal Rosenstock wrote:
>
> src/ibcacheedit.c: In function ?update_switchportguids?:
> src/ibcacheedit.c:168: warning: unused parameter ?guid?
>
> Signed-off-by: Hal Rosenstock
Thanks applied,
Ira
> ---
> diff --git a/src/ibcacheedit.c b/src/ibcacheedit.
There is a new release of infiniband-diags at:
https://www.openfabrics.org/downloads/management/infiniband-diags-1.6.6.tar.gz
md5sum:
b855ca3b98afefc2ad6a2de378ab71dd infiniband-diags-1.6.6.tar.gz
Dependencies:
1) libibmad >= 1.3.12
2) libibumad >= 1.3.7
3) opensm-lib
On Wed, Sep 30, 2015 at 08:53:51AM -0400, Hal Rosenstock wrote:
> From: Dan Ben Yosef
>
> This patch avoids pushing the same pointer to the hash table that causes
> endless loop during dumping.
>
> Signed-off-by: Dan Ben Yosef
> Signed-off-by: Hal Rosenstock
>
I'm not sure what would cause th
On Mon, Oct 12, 2015 at 08:30:31AM -0400, Hal Rosenstock wrote:
>
> smp_query_via returns pointer so < 0 comparison is wrong:
> src/perfquery.c: In function ?is_rsfec_mode_active?:
> src/perfquery.c:481: warning: ordered comparison of pointer with integer zero
> src/perfquery.c: In function ?main?
On Mon, Oct 12, 2015 at 08:31:23AM -0400, Hal Rosenstock wrote:
>
> Eliminate compiler warning:
> src/ibdiag_common.c:85: warning: ?static? is not at beginning of declaration
>
> Signed-off-by: Hal Rosenstock
Thanks applied,
Ira
> ---
> diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c
>
On Tue, Sep 01, 2015 at 08:28:38AM -0400, Hal Rosenstock wrote:
> From 0e8341980ca7133fe0a472fddc1c622f766b8f8e Mon Sep 17 00:00:00 2001
> From: Dan Ben Yosef
> Date: Mon, 31 Aug 2015 10:49:04 +0300
>
> perfquery -T (print Extended Speed Counters) times out on nodes
> supporting RS_FEC capability
On Thu, Sep 10, 2015 at 09:09:57AM -0400, Hal Rosenstock wrote:
> From: Vladimir Koushnir
> Date: Wed, 9 Sep 2015 14:29:38 +0300
>
> -D and -list saquery options are operational only
> when -N option is explicitly invoked (default option)
>
> This patch allows using -D or --list options when no
Hal,
I'm working on a couple of patches to address these comments. I will be
submitting them in the next day or so.
On Wed, Jun 17, 2015 at 10:12:41AM -0400, Hal Rosenstock wrote:
> On 6/17/2015 8:28 AM, Mike Marciniszyn wrote:
> > From: Ira Weiny
> >
> > Add common OPA header definitions for
On Tue, Aug 18, 2015 at 12:23:17PM +0300, Dan Carpenter wrote:
> This is a zero offset array. The current code could try to free random
> memory and crash. Also it leaks the first element.
>
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter
I don't
On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
> Smatch says that, based on the indenting, we should probably add curly
> braces here.
>
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter
>
Reviewed-by: Ira Weiny
>
> diff --git a/dr
Doug,
Please Pull:
git://github.com/weiny2/linux-firmware.git master-hfi1-firmware-v2
This is the first release of the Intel OPA hfi1 firmware required by the hfi1
driver.
Changes from V2:
Simplified license text.
Thank you,
Ira Weiny
--
To unsubscribe from this list: send the line "
On Tue, Aug 11, 2015 at 05:35:53PM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 11, 2015 at 10:47:03PM +, Vogel, Steve wrote:
> > The license terms allow anyone to distribute (but not sell) the firmware but
> > only for use on Intel products.
>
> Redistribution alone may be enough to be includ
On Tue, Aug 11, 2015 at 05:35:53PM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 11, 2015 at 10:47:03PM +, Vogel, Steve wrote:
> > The license terms allow anyone to distribute (but not sell) the firmware but
> > only for use on Intel products.
>
> Redistribution alone may be enough to be includ
On Mon, Aug 10, 2015 at 10:46:55PM -0400, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The recently added SA Netlink service requires admin privileges to receive
> kernel requests. This is only partially sufficient to protect the kernel from
> malicious users. This patch fixes two issues.
>
Doug,
Please Pull:
git://github.com/weiny2/linux-firmware.git master-hfi1-firmware
This is the first release of the Intel OPA hfi1 firmware required by the hfi1
driver.
Thank you,
Ira Weiny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to ma
ledf...@redhat.com; linux-rdma@vger.kernel.org
> > Subject: Re: [PATCH] IB/sa: Restrict SA Netlink to admin users
> >
> > On Mon, Aug 10, 2015 at 05:58:30PM -0400, ira.weiny wrote:
> >
> > > Furthermore, the check in netlink_bind also uses the socket namespace
>
On Mon, Aug 10, 2015 at 11:38:10PM -0600, Jason Gunthorpe wrote:
> On Mon, Aug 10, 2015 at 05:58:30PM -0400, ira.weiny wrote:
>
> > Furthermore, the check in netlink_bind also uses the socket namespace to
> > restrict the use of multicast. This plus my checks should allow an
1 - 100 of 228 matches
Mail list logo
