Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-08 Thread Jason Gunthorpe
On Tue, Dec 08, 2015 at 06:19:41PM -0500, Dennis Dalessandro wrote: > So what is the consensus here? Should we leave it alone for now and > potentially go back and deal with this separately? Just define the new one > as LE and use it, even though it doesn't match the rest? Something else > entir

Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-08 Thread Dennis Dalessandro
On Tue, Dec 08, 2015 at 01:55:11PM -0700, Jason Gunthorpe wrote: On Tue, Dec 08, 2015 at 02:24:55PM -0500, ira.weiny wrote: On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote: > > /* A multicast address requ

Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-08 Thread Jason Gunthorpe
On Tue, Dec 08, 2015 at 02:24:55PM -0500, ira.weiny wrote: > On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote: > > On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote: > > > /* A multicast address requires a GRH (see ch. 8.4.1). */ > > > - if (ah_attr->dlid >= QIB_MU

Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-08 Thread ira.weiny
On Mon, Dec 07, 2015 at 01:54:39PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote: > > /* A multicast address requires a GRH (see ch. 8.4.1). */ > > - if (ah_attr->dlid >= QIB_MULTICAST_LID_BASE && > > - ah_attr->dlid != QIB_PERMISSIVE

Re: [PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-07 Thread Jason Gunthorpe
On Mon, Dec 07, 2015 at 03:49:12PM -0500, Dennis Dalessandro wrote: > /* A multicast address requires a GRH (see ch. 8.4.1). */ > - if (ah_attr->dlid >= QIB_MULTICAST_LID_BASE && > - ah_attr->dlid != QIB_PERMISSIVE_LID && > + if (ah_attr->dlid >= be16_to_cpu(IB_MULTICAST_LID_B

[PATCH 05/10] IB/qib: Use rdmavt lid defines in qib

2015-12-07 Thread Dennis Dalessandro
Original patch for AH changes from Kamal Heib , split apart from original. This patch also removes the qib specific multicast lid base and permissive lid defines since they are no longer needed. Use common LID defines in qib driver. Reviewed-by: Ira Weiny Signed-off-by: Kamal Heib Signed-off-by