RE: [PATCH V2 1/1] [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

Thanks - applied -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH V2 1/1] [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

From: Kaike Wan In an insecure IB fabric, the default pkey in a port is 0x, where each node is allowed to talk to any other node in the fabric, including the SA node. However, in a secure fabric, to limit member access, not all nodes can have the full-member default pkey

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 12:33 PM, kaike@intel.com wrote: > From: Kaike Wan > > In an insecure IB fabric, the default pkey in a port is 0x, where each > node is allowed to talk to any other node in the fabric, including the SA > node. However, in a secure fabric, to limit member

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Tuesday, December 08, 2015 4:22 PM > To: Wan, Kaike > Cc: Hefty, Sean; linux-rdma@vger.kernel.org > Subject: Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics > > On Tue, Dec 08, 2015 at 12

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 7:26 PM, Hefty, Sean wrote: >>> +* Determine the default pkey for parsing address file as well. >>> +* order of preference: first full-member non-management pkey, >>> +* 0x, first pkey. >>> +*/ >> >> This really should just be the 0 index pkey, which exactly

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 4:21 PM, Jason Gunthorpe wrote: > On Tue, Dec 08, 2015 at 12:33:02PM -0500, kaike@intel.com wrote: >> From: Kaike Wan >> >> In an insecure IB fabric, the default pkey in a port is 0x, where each >> node is allowed to talk to any other node in the fabric,

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 10:04 AM, Wan, Kaike wrote: > I mean that the user needs to investigate why the fabric is not working out > of box. My point is that an educated admin should _know_ to configure in these cases and that debug is only when things are broken not by default in these more complex cases.

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, December 09, 2015 9:06 AM > > This is the best effort and it should work for most common > > configurations, but may not work for more complicated cases. > > Right, there are various

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Wednesday, December 09, 2015 9:36 AM > >> Unfortunately not. It comes down to whether the out of box cases > >> outweigh the debug when it's an

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Wednesday, December 09, 2015 8:46 AM > >>> To solve the problem, this patch introduces the following priority > >>> to interpret default pkey: > >>> 1. Find the first non-management full-member pkey; 2.

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 8:24 AM, Wan, Kaike wrote: >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Sent: Wednesday, December 09, 2015 7:50 AM >> To: Wan, Kaike; Hefty, Sean >> Cc: linux-rdma@vger.kernel.org >> Subject: Re: [PATCH 1/1] Ibacm: default pkey for partitio

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 8:55 AM, Wan, Kaike wrote: > This is the best effort and it should work for most common configurations, > but may not work for more complicated cases. Right, there are various scenarios where it will not work. This was one of them but there are others I can think of. > Any other

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

>> Unfortunately not. It comes down to whether the out of box cases outweigh >> the debug when it's an exception case. The premise of this patch is that >> that's the case. > > I would argue that it does. Without this patch, ibacm will not work on secure > fabric out of box > (where "default"

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> > I mean that the user needs to investigate why the fabric is not working > out of box. > > My point is that an educated admin should _know_ to configure in these > cases and that debug is only when things are broken not by default in > these more complex cases. This means the limitations of

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Wednesday, December 09, 2015 11:49 AM > > When IP addresses are used, the corresponding pkey is used. The issue this > patch is addressing is

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On Wed, Dec 09, 2015 at 07:51:46AM -0500, Hal Rosenstock wrote: > > ipoib always uses the 0 pkey index to create the default ipoib > > interface. (see eg, update_parent_pkey) > > This is beyond IBA spec and is currently a linux convention for IPoIB. > IMO it should be changed to search for this

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On Wed, Dec 09, 2015 at 01:07:14PM +, Wan, Kaike wrote: > > > + /* Determine the default pkey index for SA access first. > > > + * Order of preference: 0x, 0x7fff, first pkey. > > > > No, IBA says that only the default pkey should be used to talk to the SA, > > every port needs 0x7FFF

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 11:26 AM, Hefty, Sean wrote: >>> I mean that the user needs to investigate why the fabric is not working >> out of box. >> >> My point is that an educated admin should _know_ to configure in these >> cases and that debug is only when things are broken not by default in >> these more

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> pkey[0] at least has the logic that the admin will configure things so > that the default ipoib device reaches the broadest audiance makes the > most sense to me. That is what most sites I've seen want to do. Kaike, will pkey[0] work in the configurations that you're targeting with this

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> -Original Message- > From: Hefty, Sean > Sent: Wednesday, December 09, 2015 1:37 PM > To: Jason Gunthorpe > Cc: Hal Rosenstock; Wan, Kaike; linux-rdma@vger.kernel.org > Subject: RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics > > > pke

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/09/2015 01:22 PM, Jason Gunthorpe wrote: > On Wed, Dec 09, 2015 at 05:13:49PM +, Hefty, Sean wrote: > >> Example: Compute nodes are assigned pkeys 0x8000 and 0x7fff. A node >> running the job scheduler has pkeys 0x and 0x8000 (maybe it's >> also the backup SA). Ibacm would need

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> >> Example: Compute nodes are assigned pkeys 0x8000 and 0x7fff. A node > >> running the job scheduler has pkeys 0x and 0x8000 (maybe it's > >> also the backup SA). Ibacm would need to select pkey 0x8000 for > >> communication. > > > > I've also seen the reverse, eg 0x is used for

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> > 1. Find the first non-management full-member pkey; I.e. a pkey with the high-order bit set that is not 0x > > 2. If it fails, find pkey 0x; > > Order of 1 and 2 depends on use models for full default partition and > other partitions. Reversing 1 and 2 (full default partition first)

[PATCH 1/1] Ibacm: default pkey for partitioned fabrics

From: Kaike Wan In an insecure IB fabric, the default pkey in a port is 0x, where each node is allowed to talk to any other node in the fabric, including the SA node. However, in a secure fabric, to limit member access, not all nodes can have the full-member default pkey

RE: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

> > +* Determine the default pkey for parsing address file as well. > > +* order of preference: first full-member non-management pkey, > > +* 0x, first pkey. > > +*/ > > This really should just be the 0 index pkey, which exactly matches how > IPoIB determines the default

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On Tue, Dec 08, 2015 at 12:33:02PM -0500, kaike@intel.com wrote: > From: Kaike Wan > > In an insecure IB fabric, the default pkey in a port is 0x, where each > node is allowed to talk to any other node in the fabric, including the SA > node. However, in a secure