RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-07-02 Thread Steve Wise
ox.com; linux-rdma@vger.kernel.org; > jguntho...@obsidianresearch.com; infinipath; > e...@mellanox.com; ogerl...@mellanox.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On 7/2/2015 4:17 PM, Steve Wise wrote: > > On 7/2/2015 1:22 AM, Sagi Grimberg

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-07-02 Thread Sagi Grimberg
On 7/2/2015 4:17 PM, Steve Wise wrote: On 7/2/2015 1:22 AM, Sagi Grimberg wrote: On 6/30/2015 8:10 PM, Hefty, Sean wrote: I suggest to start consolidating to ib_create_mr() that receives an extensible ib_mr_init_attr and additional attributes can be mr_roles and mr_attrs. I think this makes s

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-07-02 Thread Steve Wise
On 7/2/2015 1:22 AM, Sagi Grimberg wrote: On 6/30/2015 8:10 PM, Hefty, Sean wrote: I suggest to start consolidating to ib_create_mr() that receives an extensible ib_mr_init_attr and additional attributes can be mr_roles and mr_attrs. I think this makes sense, but does it really help? If the en

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-07-01 Thread Sagi Grimberg
On 6/30/2015 8:10 PM, Hefty, Sean wrote: I suggest to start consolidating to ib_create_mr() that receives an extensible ib_mr_init_attr and additional attributes can be mr_roles and mr_attrs. I think this makes sense, but does it really help? If the end result is that the app and providers basi

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-07-01 Thread Or Gerlitz
On 6/30/2015 7:42 PM, Jason Gunthorpe wrote: NFSRDMA currently checks the transport type to decide how to set the >access flags for memory registration. With the new services >exported in this series, we can change/simplify NFSRDMA to not have >to know the transport type. It would be excellent

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Steve Wise
.@mellanox.com; ogerl...@mellanox.com; sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On Mon, Jun 29, 2015 at 04:36:18PM -0500, Steve Wise wrote: > > +int rdma_device_access_flags(struct ib_pd *pd, int roles, int attrs) >

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Hefty, Sean
> I suggest to start consolidating to ib_create_mr() that receives an > extensible ib_mr_init_attr and additional attributes can be mr_roles > and mr_attrs. I think this makes sense, but does it really help? If the end result is that the app and providers basically end up switching on mr_attr::t

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Jason Gunthorpe
> NFSRDMA currently checks the transport type to decide how to set the > access flags for memory registration. With the new services > exported in this series, we can change/simplify NFSRDMA to not have > to know the transport type. It would be excellent if this series actually went through and g

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Jason Gunthorpe
On Mon, Jun 29, 2015 at 04:36:18PM -0500, Steve Wise wrote: > +int rdma_device_access_flags(struct ib_pd *pd, int roles, int attrs) > +{ > + int access_flags = attrs; No RDMA_MRR_SEND ? > + if (roles & RDMA_MRR_RECV) > + access_flags |= IB_ACCESS_LOCAL_WRITE; > + > + if (r

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Steve Wise
com; > linux-rdma@vger.kernel.org; > jguntho...@obsidianresearch.com; infinip...@intel.com; e...@mellanox.com; > sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > > On Jun 30, 2015, at 10:29 AM, Steve Wise wrote: > > > &

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Chuck Lever
; sa...@mellanox.com; >> linux-rdma@vger.kernel.org; jguntho...@obsidianresearch.com; >> infinip...@intel.com; e...@mellanox.com; sean.he...@intel.com >> Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags >> >> On 6/30/2015 12:36 AM, Steve Wise wrot

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Steve Wise
...@intel.com; > e...@mellanox.com; ogerl...@mellanox.com; sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On 6/30/2015 12:36 AM, Steve Wise wrote: > > The semantics for MR access flags are not consistent across RDMA

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Steve Wise
rch.com; > infinip...@intel.com; e...@mellanox.com; sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On 6/30/2015 12:36 AM, Steve Wise wrote: > > The semantics for MR access flags are not consistent across RDMA > > protocols. So r

RE: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Steve Wise
...@intel.com; > e...@mellanox.com; ogerl...@mellanox.com; sean.he...@intel.com > Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags > > On 30/06/2015 00:36, Steve Wise wrote: > > /** > > + * rdma_mr_roles - possible roles an RDMA MR will be used f

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Sagi Grimberg
On 6/30/2015 12:36 AM, Steve Wise wrote: The semantics for MR access flags are not consistent across RDMA protocols. So rather than have applications try and glean what they need, have them pass in the intended roles and attributes for the MR to be allocated and let the RDMA core select the appr

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Or Gerlitz
On 6/30/2015 12:36 AM, Steve Wise wrote: The semantics for MR access flags are not consistent across RDMA protocols. So rather than have applications try and glean what they need, have them pass in the intended roles and attributes for the MR to be allocated and let the RDMA core select the appr

Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

2015-06-30 Thread Haggai Eran
On 30/06/2015 00:36, Steve Wise wrote: > /** > + * rdma_mr_roles - possible roles an RDMA MR will be used for > + * > + * This allows a transport independent RDMA application to > + * create MRs that are usable for all the desired roles w/o > + * having to understand which access rights are needed