Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

2015-12-24 Thread Faisal Latif
On Thu, Dec 24, 2015 at 10:25:08AM +0200, Or Gerlitz wrote: > On 12/24/2015 9:31 AM, Faisal Latif wrote: > >On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote: > >>On 12/22/2015 1:13 AM, Faisal Latif wrote: > >>>+ > >>>+enum i40iw_memreg_type { > >>>+ IW_MEMREG_TYPE_MEM = 0x, > >>>+

Re: [PATCH 3/3] Display extended counter set if available

2015-12-24 Thread Hal Rosenstock
On 12/24/2015 11:22 AM, eran ben elisha wrote: > On Mon, Dec 21, 2015 at 4:20 PM, Christoph Lameter wrote: >> V2->V3: Add check for NOIETF mode and create special table >> for that case. >> >> Check if the extended counters are available and if so >> create the proper extended

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-24 Thread ira.weiny
On Tue, Dec 22, 2015 at 06:27:57PM -0800, gre...@linuxfoundation.org wrote: > On Tue, Dec 22, 2015 at 02:15:08PM -0500, ira.weiny wrote: > > On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote: [snip] > > > > > > No, git is good :) > > > > > > > How do we handle changes

[PATCH 2/4] RDMA/ocrdma: Dispatch only port event when port state changes

2015-12-24 Thread Devesh Sharma
Dispatch only port event to IB stack when port state changes. Don't explicitly modify qps to error. Let application listen to port events on async event queue or let QP fail with retry-exceeded completion error. Signed-off-by: Padmanabh Ratnakar Signed-off-by:

[PATCH 3/4] RDMA/ocrdma: Depend on async link events from CNA

2015-12-24 Thread Devesh Sharma
Recently Dough Ledford reported a deadlock happening between ocrdma-load sequence and NetworkManager service issuing "open" on be2net interface. The deadlock happens when any be2net hook (e.g. open/close) is called in parallel to insmod ocrdma.ko. A. be2net is sending administrative open/close

[PATCH 0/4] ocrdma bug fix for linux-4.4-rc

2015-12-24 Thread Devesh Sharma
This patch series fixes for critical bugs introduced due to recent changes in linux Infiniband stack. Patch 0001 fixes a vlan-id assignment issues in presence of PFC. This bug was introduced recently got introduced and it fixes dbf727de7440 ('IB/core: Use GID table in AH creation and dmac

[PATCH 4/4] RDMA/be2net: Remove open and close entry points

2015-12-24 Thread Devesh Sharma
Recently Dough Ledford reported a deadlock happening between ocrdma-load sequence and NetworkManager service issueing "open" on be2net interface. The deadlock happens when any be2net hook (e.g. open/close) is called in parallel to insmod ocrdma.ko. A. be2net is sending administrative open/close

[PATCH 1/4] RDMA/ocrdma: Fix vlan-id assignment in qp parameters

2015-12-24 Thread Devesh Sharma
vlan-id is wrongly getting as 0 when PFC is enabled. Set vlan-id configured by user in QP parameters. In case vlan interface is not used, flash a warning to user to configure vlan and assign vlan-id as 0 in qp params. Fixes: dbf727de7440 ('IB/core: Use GID table in AH creation and dmac

Re: [PATCH V1 0/3] Add cross-channel support

2015-12-24 Thread Doug Ledford
On 12/24/2015 05:41 AM, Or Gerlitz wrote: > On 12/24/2015 12:00 PM, Christoph Hellwig wrote: >> On Thu, Dec 24, 2015 at 10:02:29AM +0200, Or Gerlitz wrote: >>> We had consensus among the reviewers that the 1st patch ("IB/core: Align >>> coding style of ib_device_cap_flags structure") is wrong

Re: [PATCH 3/3] Display extended counter set if available

2015-12-24 Thread ira.weiny
On Thu, Dec 24, 2015 at 06:22:14PM +0200, eran ben elisha wrote: > On Mon, Dec 21, 2015 at 4:20 PM, Christoph Lameter wrote: [snip] > > > > +/* > > + * Figure out which counter table to use depending on > > + * the device capabilities. > > + */ > > +static struct attribute_group

Re: [PATCH V1 15/16] i40iw: add entry in rdma_netlink

2015-12-24 Thread Or Gerlitz
On 12/24/2015 9:05 AM, Faisal Latif wrote: >Why the iwarp port mapper implementationhas to be repeated in each >driver? can you join your code in a common place and avoid the duplication? > >root@r-dcs58 hw]# git grep RDMA_NL_ nes >nes/nes.c: [RDMA_NL_IWPM_REG_PID] = {.dump =

Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

2015-12-24 Thread Or Gerlitz
On 12/24/2015 9:31 AM, Faisal Latif wrote: On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote: On 12/22/2015 1:13 AM, Faisal Latif wrote: + +enum i40iw_memreg_type { + IW_MEMREG_TYPE_MEM = 0x, + IW_MEMREG_TYPE_QP = 0x0001, + IW_MEMREG_TYPE_CQ = 0x0002, +

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-24 Thread Or Gerlitz
On 12/24/2015 9:57 AM, Matan Barak wrote: I totally agree that it's better to use the local IP address and not just get a random device by using 127.0.0.1. You could get a specific device by binding it, but then - use its local IP instead of 127.0.0.1. Yes guys, it might be better but the user

Re: [PATCH V1 0/3] Add cross-channel support

2015-12-24 Thread Or Gerlitz
On 12/24/2015 5:31 AM, Doug Ledford wrote: On 12/20/2015 12:16 PM, Leon Romanovsky wrote: Leon Romanovsky (3): IB/core: Align coding style of ib_device_cap_flags structure IB/core: Add cross-channel support IB/mlx5: Add driver cross-channel support

[PATCH V2 0/2] Add cross-channel support

2015-12-24 Thread Leon Romanovsky
From: Leon Romanovsky The following set of patches implements cross-channel (CC) support in the RDMA core and in the mlx5 infiniband driver. The cross-channel feature allows to execute WQEs that involve cross-channel synchronization of IO operations’ on different QPs.

[PATCH V2 2/2] IB/mlx5: Add driver cross-channel support

2015-12-24 Thread Leon Romanovsky
From: Leon Romanovsky Add support of cross-channel functionality to mlx5 driver. This includes ability to ignore overrun for CQ which intended for cross-channel, export device capability and configure the QP to be sync master/slave queues. The cross-channel enabled QP

[PATCH V2 1/2] IB/core: Add cross-channel support

2015-12-24 Thread Leon Romanovsky
From: Leon Romanovsky The cross-channel feature allows to execute WQEs that involve synchronization of IO operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby significantly reducing overhead associated with IO

[PATCH rdma-next V2 10/32] IB/rxe: User/kernel shared queues infrastructure

2015-12-24 Thread Kamal Heib
mmap routines Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_mmap.c | 173 1 file changed, 173 insertions(+) create mode 100644

[PATCH rdma-next V2 05/32] IB/rxe: Default rxe device and port parameters

2015-12-24 Thread Kamal Heib
Default/initial rxe device parameter settings. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_param.h | 177 +++ 1 file changed, 177

[PATCH rdma-next V2 03/32] IB/rxe: IBA header types and methods

2015-12-24 Thread Kamal Heib
Add declarations for data structures used to hold per opcode and per work request opcode tables. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_hdr.h | 950

[PATCH rdma-next V2 32/32] IB/rxe: TODO file while in staging

2015-12-24 Thread Kamal Heib
From: Amir Vadai Things todo in order to get out of staging subtree. Signed-off-by: Amir Vadai Signed-off-by: Kamal Heib --- drivers/staging/rdma/rxe/TODO | 18 ++ 1 file changed, 18 insertions(+) create mode

[PATCH rdma-next V2 18/32] IB/rxe: Queue Pair (QP) handling

2015-12-24 Thread Kamal Heib
Functions to manipulate QP objects. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_qp.c | 835 ++ 1 file changed, 835 insertions(+) create mode 100644

[PATCH rdma-next V2 01/32] IB/core: Macro for RoCEv2 UDP port

2015-12-24 Thread Kamal Heib
From: Amir Vadai Adding a macro for RoCEv2 UDP destination port. Signed-off-by: Amir Vadai Signed-off-by: Kamal Heib --- include/rdma/ib_verbs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/rdma/ib_verbs.h

[PATCH rdma-next V2 13/32] IB/rxe: Allocation pool for RDMA objects

2015-12-24 Thread Kamal Heib
Manage and allocate pool of objects with given limit on number of elements. Gets parameters from rxe_type_info. Pool elements are allocated out of a slab cache. Objects that are using this facility are: PD, QP, SRQ, CQ, MR, FMR, MW, etc. Signed-off-by: Kamal Heib

[PATCH rdma-next V2 23/32] IB/rxe: QP request handling

2015-12-24 Thread Kamal Heib
QP request logic. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_req.c | 679 + 1 file changed, 679 insertions(+) create mode 100644 drivers/staging/rdma/rxe/rxe_req.c diff

[PATCH rdma-next V2 22/32] IB/rxe: Completion handling

2015-12-24 Thread Kamal Heib
Handling of Work Completions. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_comp.c | 728 1 file changed, 728 insertions(+) create mode 100644

[PATCH rdma-next V2 15/32] IB/rxe: Address vector manipulation functions

2015-12-24 Thread Kamal Heib
Functions to manipulate Address Vector. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_av.c | 87 +++ 1 file changed, 87

[PATCH rdma-next V2 09/32] IB/rxe: Work request's opcode information table

2015-12-24 Thread Kamal Heib
Useful information about work request opcodes and pkt opcodes in table form. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_opcode.c | 961

[PATCH rdma-next V2 00/32] Soft-RoCE driver

2015-12-24 Thread Kamal Heib
Doug and list Hi, This patchset introduces Soft RoCE driver. Some background on the driver: The original Soft-RoCE driver was implemented by Bob Pearson from SFW. Bob started the submission process [1], but his work was abandoned after v2. Mellanox decided to pick it up and continue the

[PATCH rdma-next V2 04/32] IB/rxe: Bit mask and lengths declaration for different opcodes

2015-12-24 Thread Kamal Heib
header bit mask definitions and header lengths declaration of the rxe_opcode_info struct and rxe_wr_opcode_info struct. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran ---

[PATCH rdma-next V2 02/32] IB/core: Add SEND_LAST_INV and SEND_ONLY_INV opcodes

2015-12-24 Thread Kamal Heib
Intorduce Add SEND_LAST_INV and SEND_ONLY_INV opcodes in ib_pack.h to be used by RXE for RC. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- include/rdma/ib_pack.h | 4 1 file changed, 4

[PATCH rdma-next V2 26/32] IB/rxe: ICRC calculations

2015-12-24 Thread Kamal Heib
Compute ICRC for UDP/IP/BTH headers Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_icrc.c | 96 + 1 file changed, 96 insertions(+) create mode 100644

[PATCH rdma-next V2 06/32] IB/rxe: External interface to lower level modules

2015-12-24 Thread Kamal Heib
Functions to be called by the networking layer. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe.h | 70 ++ 1 file changed, 70

[PATCH rdma-next V2 07/32] IB/rxe: Misc local interfaces between files in ib_rxe

2015-12-24 Thread Kamal Heib
Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_loc.h | 291 + 1 file changed, 291 insertions(+) create mode 100644

[PATCH rdma-next V2 14/32] IB/rxe: RXE tasks handling

2015-12-24 Thread Kamal Heib
A 'task' is a short function that returns 0 as long as it needs to be called again. rxe tasks are based on the kernel's tasklet infrastructure. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran ---

[PATCH rdma-next V2 31/32] IB/rxe: Add Soft-RoCE to kbuild and makefiles

2015-12-24 Thread Kamal Heib
Kconfig and Makefiles for RXE driver Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/Kconfig | 2 ++ drivers/staging/rdma/Makefile | 1 +

[PATCH rdma-next V2 24/32] IB/rxe: QP response handling

2015-12-24 Thread Kamal Heib
QP response logic. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_resp.c | 1368 +++ 1 file changed, 1368 insertions(+) create mode 100644 drivers/staging/rdma/rxe/rxe_resp.c diff

[PATCH rdma-next V2 25/32] IB/rxe: Dummy DMA callbacks for RXE device

2015-12-24 Thread Kamal Heib
Dummy DMA processing for RXE device. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_dma.c | 166 + 1 file changed, 166

[PATCH rdma-next V2 17/32] IB/rxe: Completion Queue (CQ) manipulation functions

2015-12-24 Thread Kamal Heib
Functions to manipulate CQ. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_cq.c | 165 ++ 1 file changed, 165 insertions(+) create

[PATCH rdma-next V2 29/32] IB/rxe: sysfs interface to RXE

2015-12-24 Thread Kamal Heib
sysfs interface for ib_rxe Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_sysfs.c | 168 +++ 1 file changed, 168 insertions(+) create

[PATCH rdma-next V2 28/32] IB/rxe: Interface to netdev stack

2015-12-24 Thread Kamal Heib
Linux netdev related code Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_net.c | 729 + drivers/staging/rdma/rxe/rxe_net.h | 78 2 files changed, 807 insertions(+) create

[PATCH rdma-next V2 30/32] IB/rxe: Shared objects between user and kernel

2015-12-24 Thread Kamal Heib
From: Amir Vadai Objects used by the userspace to post work requests. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- include/uapi/rdma/Kbuild | 1 +

[PATCH rdma-next V2 20/32] IB/rxe: Multicast implementation

2015-12-24 Thread Kamal Heib
Multicast groups handling. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_mcast.c | 190 +++ 1 file changed, 190 insertions(+) create

[PATCH rdma-next V2 08/32] IB/rxe: Add maintainer for rxe driver

2015-12-24 Thread Kamal Heib
Add maintainer for rxe driver Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH rdma-next V2 21/32] IB/rxe: Received packets handling

2015-12-24 Thread Kamal Heib
Handles receiving new packets which are sent to either request or response processing. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_recv.c | 371

[PATCH rdma-next V2 11/32] IB/rxe: Common user/kernel queue implementation

2015-12-24 Thread Kamal Heib
A simple circular buffer that can optionally be shared between user space and the kernel and can be resized. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_queue.c |

[PATCH rdma-next V2 16/32] IB/rxe: Shared Receive Queue (SRQ) manipulation functions

2015-12-24 Thread Kamal Heib
Functions to manipulate SRQ. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe_srq.c | 195 + 1 file changed, 195 insertions(+)

[PATCH rdma-next V2 27/32] IB/rxe: Module init hooks

2015-12-24 Thread Kamal Heib
Module main for ib_rxe Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran --- drivers/staging/rdma/rxe/rxe.c | 436 + drivers/staging/rdma/rxe/rxe.h | 2 + 2

[PATCH rdma-next V2 12/32] IB/rxe: Interface to ib_core

2015-12-24 Thread Kamal Heib
rxe interface to rdma/core Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai Reviewed-by: Haggai Eran Signed-off-by: Kamal Heib --- drivers/staging/rdma/rxe/rxe_verbs.c | 1423

[PATCH rdma-next V2 19/32] IB/rxe: Memory Region (MR) handling

2015-12-24 Thread Kamal Heib
MR objects handling. Signed-off-by: Kamal Heib Signed-off-by: Amir Vadai --- drivers/staging/rdma/rxe/rxe_mr.c | 764 ++ 1 file changed, 764 insertions(+) create mode 100644 drivers/staging/rdma/rxe/rxe_mr.c diff

Re: [RFC] Generic InfiniBand transport done in software

2015-12-24 Thread Moni Shoua
> > > There were discussions, and Mellanox even contributed code to the effort. > See Kamal's patches in the patch set I provided. > As far as I see it discussions were shallow and never produced an agreement. Kamal's patches should not be considered as as such. >>

Re: [RFC] Generic InfiniBand transport done in software

2015-12-24 Thread Moni Shoua
> I'm not sure I understand what you mean. Denny has posted several high level > emails similar to this one and has asked for public feedback. We have been > addressing all the feedback as it has come in and we continue to work toward > this common layer. > > To that end we have been asking for

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Matan Barak
On Thu, Dec 24, 2015 at 4:07 PM, Matan Barak wrote: > On Thu, Dec 24, 2015 at 2:38 PM, Or Gerlitz wrote: >> On 12/24/2015 12:42 PM, Sagi Grimberg wrote: >>> >>> > This patch seems to generate a list corruption [1] when I test > with

Re: [RFC] Generic InfiniBand transport done in software

2015-12-24 Thread Dennis Dalessandro
On Thu, Dec 24, 2015 at 05:43:11PM +0200, Moni Shoua wrote: There were discussions, and Mellanox even contributed code to the effort. See Kamal's patches in the patch set I provided. As far as I see it discussions were shallow and never produced an agreement. Kamal's patches should not be

[PATCH] IB/qib: Improve ipoib UD performance

2015-12-24 Thread Mike Marciniszyn
Based on profiling, UD performance drops in case of processes in a single client due to excess context switches when the progress workqueue is scheduled. This is solved by modifying the heuristic to select the direct progress instead of the scheduling progress via the workqueue when UD-like

Re: [PATCH V1 0/3] Add cross-channel support

2015-12-24 Thread Christoph Hellwig
On Thu, Dec 24, 2015 at 10:02:29AM +0200, Or Gerlitz wrote: > We had consensus among the reviewers that the 1st patch ("IB/core: Align > coding style of ib_device_cap_flags structure") is wrong cleanup which > basically is (1) unneeded (2) creates more damage (git blame and such, > non-applicable

Re: [PATCH v2 00/10] iSER support for remote invalidate

2015-12-24 Thread Christoph Hellwig
> Applied to target-pending/for-next as v4.5-rc1 material, along with > Reviewed-by tags from HCH. So this is both in your and Dougs now it seems. Given the non-trivial merge with the other RDMA updates I'd suggest to drop it from the target tree as Doug already sorted out the merge. -- To

Re: [PATCH v2 00/10] iSER support for remote invalidate

2015-12-24 Thread Sagi Grimberg
Applied to target-pending/for-next as v4.5-rc1 material, along with Reviewed-by tags from HCH. So this is both in your and Dougs now it seems. Given the non-trivial merge with the other RDMA updates I'd suggest to drop it from the target tree as Doug already sorted out the merge. Yea, this

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Or Gerlitz
On 12/24/2015 12:12 PM, Sagi Grimberg wrote: This patch seems to generate a list corruption [1] when I test with Doug's for-4.5 tree. Eran, care to take a look at this? This patch is part from a series that was introduced in 4.3-rc1 [1], did 4.4-rc5/6 worked for you before you uploaded there

libmlx5 : Maintainer/Git change

2015-12-24 Thread Yishai Hadas
I’m taking the responsibility from Mellanox side on libmlx5, the formal tree to be used: git://openfabrics.org/~yishaih/libmlx5.git Thanks Eli for creating and maintaining it from day one. Yishai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Sagi Grimberg
This patch seems to generate a list corruption [1] when I test with Doug's for-4.5 tree. Eran, care to take a look at this? [1]: mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) mlx4_core: Initializing :04:00.0 mlx4_core :04:00.0: PCIe link speed is 8.0GT/s, device

Re: [PATCH v4 00/11] NFS/RDMA server patches for v4.5

2015-12-24 Thread Chuck Lever
My functional test suite includes Cthon, iozone, dbench, fio, multi-threaded builds of git and the Linux kernel, and xfstests. This patch series passes with NFSv3, NFSv4.0, and now NFSv4.1. -- Chuck Lever > On Dec 23, 2015, at 21:00, J. Bruce Fields wrote: > >> On Wed,

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

2015-12-24 Thread Christoph Hellwig
On Thu, Dec 24, 2015 at 11:17:46AM +0200, Kamal Heib wrote: > We've located the driver in the staging subtree. This follows a requirement > to implement an IB transport library - Soft RoCE is in the same boat like the > hfi1 > driver. We need to define and implement a lib to prevent those code >

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Sagi Grimberg
Doug, I'm also can't load mlx5 drivers in your tree [1] but I don't know where it's from, it can come from pretty much everything... Now I'm left with no useable HW to test with :( [1]: mlx5_core :06:00.0: firmware version: 12.14.74 mlx5_core :06:00.1: firmware version: 12.14.74

Re: [PATCH V1 0/3] Add cross-channel support

2015-12-24 Thread Or Gerlitz
On 12/24/2015 12:00 PM, Christoph Hellwig wrote: On Thu, Dec 24, 2015 at 10:02:29AM +0200, Or Gerlitz wrote: We had consensus among the reviewers that the 1st patch ("IB/core: Align coding style of ib_device_cap_flags structure") is wrong cleanup which basically is (1) unneeded (2) creates more

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Sagi Grimberg
This patch seems to generate a list corruption [1] when I test with Doug's for-4.5 tree. Eran, care to take a look at this? This patch is part from a series that was introduced in 4.3-rc1 [1], Then something else broke it. Can people check their patches on doug's tree? At the moment it's

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

2015-12-24 Thread Christoph Hellwig
On Thu, Dec 24, 2015 at 02:58:10PM +0200, Or Gerlitz wrote: > On Thu, Dec 24, 2015 at 12:02 PM, Christoph Hellwig > wrote: > > On Thu, Dec 24, 2015 at 11:17:46AM +0200, Kamal Heib wrote: > >> We've located the driver in the staging subtree. This follows a requirement > >> to

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Or Gerlitz
On 12/24/2015 12:42 PM, Sagi Grimberg wrote: This patch seems to generate a list corruption [1] when I test with Doug's for-4.5 tree. Eran, care to take a look at this? This patch is part from a series that was introduced in 4.3-rc1 [1], Then something else broke it. Can people check their

Re: [PATCH rdma-next V2 00/32] Soft-RoCE driver

2015-12-24 Thread Or Gerlitz
On Thu, Dec 24, 2015 at 12:02 PM, Christoph Hellwig wrote: > On Thu, Dec 24, 2015 at 11:17:46AM +0200, Kamal Heib wrote: >> We've located the driver in the staging subtree. This follows a requirement >> to implement an IB transport library - Soft RoCE is in the same boat like

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

2015-12-24 Thread Matan Barak
On Thu, Dec 24, 2015 at 2:38 PM, Or Gerlitz wrote: > On 12/24/2015 12:42 PM, Sagi Grimberg wrote: >> >> This patch seems to generate a list corruption [1] when I test with Doug's for-4.5 tree. Eran, care to take a look at this? >>> >>> >>> This patch is part from

[PATCH 6/6] IB/uapi: expose device capability flags

2015-12-24 Thread Christoph Hellwig
Expose the device capability flags which can be queried through uverbs in the uapi headers. Signed-off-by: Christoph Hellwig --- include/rdma/ib_verbs.h | 94 +++- include/uapi/rdma/ib_verbs.h | 66 +++ 2

[PATCH 3/6] IB/uapi: expose uverbs WC opcodes

2015-12-24 Thread Christoph Hellwig
This exposes the WC opcodes supported by uverbs as part of the uapi headers. It follows the same scheme as the WR opcodes. Signed-off-by: Christoph Hellwig --- include/rdma/ib_verbs.h | 29 + include/uapi/rdma/ib_verbs.h | 16 2

[PATCH 4/6] IB/uapi: expose uverbs WC flags

2015-12-24 Thread Christoph Hellwig
This exposes the WC flags supported by uverbs as part of the uapi headers. It follows the same scheme as the WR opcodes. Signed-off-by: Christoph Hellwig --- include/rdma/ib_verbs.h | 14 +++--- include/uapi/rdma/ib_verbs.h | 10 ++ 2 files changed, 17

[PATCH 2/6] IB/uapi: expose uverbs send WR flags

2015-12-24 Thread Christoph Hellwig
This exposes the send WR flags supported by uverbs as part of the uapi headers. It follows the same scheme as the WR opcodes. Signed-off-by: Christoph Hellwig --- drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 +++--- include/rdma/ib_verbs.h | 14 ++

start moving user space visible constants to uapi headers

2015-12-24 Thread Christoph Hellwig
Currently very little of the uverbs user interface is actually exposed in uapi headers, and it's a constant struggle to figure out what's kernel internal and what is actually exposed in public. This series starts sorting this out by creating the infrastructure for a uapi header shared between