Re: Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram

Geert Uytterhoeven wrote: > 8 locks held by s2ram/1899: > #0: (sb_writers#7){.+.+.+}, at: [] vfs_write+0xa8/0x15c > #1: (>mutex){+.+.+.}, at: [] > kernfs_fop_write+0xf0/0x194 > #2: (s_active#48){.+.+.+}, at: [] > kernfs_fop_write+0xf8/0x194 > #3: (pm_mutex){+.+.+.}, at: []

[PATCH v2] ASoC: rsnd: control kctrl items acceptance anytime/runtime

From: Kuninori Morimoto Current SRC/DVC/CTU adds kctrl for each device, and SRC can adjust its sampling rate during playback, thus, this feature should be enabled only *during* playback. This patch controls it more clearly Signed-off-by: Kuninori Morimoto

[PATCH] ASoC: rsnd: enable clock-frequency for both 44.1kHz/48kHz

From: Kuninori Morimoto Current clock-frequency allows only 1 clock, but ADG can handle both 44.1kHz/48kHz base clocks. This patch enables these. On Salvator-X board, AUDIO_CLKOUT which is generated by ADG is connected to ak4613 MCKI, and it should be

[PATCH] ASoC: rsnd: rsnd_mod_make_sure() is not under DEBUG

From: Kuninori Morimoto rsnd_mod_make_sure() will be used any situation, thus, under DEBUG is not realistic. This patch move it to non DEBUG area Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/core.c | 2 --

[PATCH] ASoC: ak4613: use snd_soc_update_bits() to avoid Reserve bit on I/O CTRL

From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/ak4613.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index

Re: [PATCH] i2c: rcar: fix resume by always initializing registers before transfer

Hi Wolfram > Resume failed because of uninitialized registers. Instead of adding a > resume callback, we simply initialize registers before every transfer. > This lightweight change is more robust and will keep us safe if we ever > need support for power domains or dynamic frequency changes. >

Re: [PATCH] PCI: Freeze PME scan before suspending devices

Hi Lukas, Thank you for the patch. On Tuesday 18 Apr 2017 20:44:30 Lukas Wunner wrote: > Laurent Pinchart reported that the Renesas R-Car H2 Lager board > (r8a7790) crashes during suspend tests. Geert Uytterhoeven managed to > reproduce the issue on an M2-W Koelsch board (r8a7791): > > It

Re: "mm: move pcp and lru-pcp draining into single wq" broke resume from s2ram

On Tue 18-04-17 21:56:56, Geert Uytterhoeven wrote: > Hi all, > > On Sat, Apr 8, 2017 at 10:48 AM, Linux Kernel Mailing List > wrote: > > Web: > > https://git.kernel.org/torvalds/c/ce612879ddc78ea7e4de4be80cba4ebf9caa07ee > > Commit:

Re: [PATCH] PCI: Freeze PME scan before suspending devices

On Tue, Apr 18, 2017 at 08:44:30PM +0200, Lukas Wunner wrote: > Laurent Pinchart reported that the Renesas R-Car H2 Lager board > (r8a7790) crashes during suspend tests. Geert Uytterhoeven managed to > reproduce the issue on an M2-W Koelsch board (r8a7791): > > It occurs when the PME scan runs,

Re: [PATCH 2/2] ARM: dts: r8a7791: Add GyroADC bindings

Hi Marek, On Tue, Apr 18, 2017 at 9:05 PM, Marek Vasut wrote: > On 04/18/2017 03:59 PM, Geert Uytterhoeven wrote: >> On Sun, Apr 16, 2017 at 6:57 PM, Marek Vasut wrote: >>> --- a/arch/arm/boot/dts/r8a7791.dtsi >>> +++

Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

On 04/18/2017 07:57 PM, Mark Brown wrote: > On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote: > > This looks good, a couple of minor things though: > >> +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg) >> +{ >> +/* Always enabled. */ >> +return 1; >> +} >

Re: [PATCH 2/2] ARM: dts: r8a7791: Add GyroADC bindings

On 04/17/2017 11:19 AM, Sergei Shtylyov wrote: > Hello! Hi! > On 4/16/2017 7:57 PM, Marek Vasut wrote: > >> Add bindings for the GyroADC block and it's associated clock. > >Well, I already spoke to you about the bindings on IRC... That's fixed. >> Signed-off-by: Marek Vasut

Re: [PATCH 2/2] ARM: dts: r8a7791: Add GyroADC bindings

On 04/18/2017 03:59 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi Geert, > On Sun, Apr 16, 2017 at 6:57 PM, Marek Vasut wrote: >> Add bindings for the GyroADC block and it's associated clock. > > bindings?? That's fixed... >> --- a/arch/arm/boot/dts/r8a7791.dtsi >> +++

Re: [PATCHv3 08/14] drivers/perf: arm_pmu: split cpu-local irq request/free

Hi Mark, On Tue, Apr 18, 2017 at 8:33 PM, Mark Rutland wrote: >> On Tue, Apr 11, 2017 at 10:39 AM, Mark Rutland wrote: >> > Currently we have functions to request/free all IRQs for a given PMU. >> > While this works today, this won't work for ACPI,

[PATCH] PCI: Freeze PME scan before suspending devices

Laurent Pinchart reported that the Renesas R-Car H2 Lager board (r8a7790) crashes during suspend tests. Geert Uytterhoeven managed to reproduce the issue on an M2-W Koelsch board (r8a7791): It occurs when the PME scan runs, once per second. During PME scan, the PCI host bridge (rcar-pci)

Re: PCI / PM: Crashes in PME scan during system suspend

On Tue, Apr 18, 2017 at 04:06:27PM +0200, Rafael J. Wysocki wrote: > On Tuesday, April 18, 2017 08:49:39 AM Geert Uytterhoeven wrote: > > On Sun, Apr 16, 2017 at 9:55 AM, Lukas Wunner wrote: > > > Subject: [PATCH] PCI: Freeze PME scan before suspending devices > > > > > > Laurent

[PATCH] i2c: rcar: fix resume by always initializing registers before transfer

Resume failed because of uninitialized registers. Instead of adding a resume callback, we simply initialize registers before every transfer. This lightweight change is more robust and will keep us safe if we ever need support for power domains or dynamic frequency changes. Signed-off-by: Wolfram

Re: [PATCHv3 08/14] drivers/perf: arm_pmu: split cpu-local irq request/free

On Tue, Apr 18, 2017 at 07:25:28PM +0200, Geert Uytterhoeven wrote: > Hi Mark, Hi Geert, > On Tue, Apr 11, 2017 at 10:39 AM, Mark Rutland wrote: > > Currently we have functions to request/free all IRQs for a given PMU. > > While this works today, this won't work for ACPI,

renesas-drivers-2017-04-18-v4.11-rc7

I have pushed renesas-drivers-2017-04-18-v4.11-rc7 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees

Re: [PATCHv3 08/14] drivers/perf: arm_pmu: split cpu-local irq request/free

On Tue, Apr 18, 2017 at 7:25 PM, Geert Uytterhoeven wrote: > On Tue, Apr 11, 2017 at 10:39 AM, Mark Rutland wrote: >> Currently we have functions to request/free all IRQs for a given PMU. >> While this works today, this won't work for ACPI, where we

Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote: This looks good, a couple of minor things though: > +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg) > +{ > + /* Always enabled. */ > + return 1; > +} This should be the default implementation, no need to

Re: [PATCH] drm: rcar-du: Document the vsps property in the DT bindings

Hi Laurent, On Fri, Mar 31, 2017 at 11:19 AM, Laurent Pinchart wrote: > On Monday 27 Mar 2017 13:05:48 Geert Uytterhoeven wrote: >> On Mon, Mar 27, 2017 at 11:56 AM, Laurent Pinchart wrote: >> > The property is used by the driver but is missing from the DT

Re: [PATCHv3 08/14] drivers/perf: arm_pmu: split cpu-local irq request/free

Hi Mark, On Tue, Apr 11, 2017 at 10:39 AM, Mark Rutland wrote: > Currently we have functions to request/free all IRQs for a given PMU. > While this works today, this won't work for ACPI, where we don't know > the full set of IRQs up front, and need to request them

RE: [PATCH v3 5/7] doc_rst: media: New SDR formats PC16, PC18 & PC20

Hi Laurent, Thanks for the review comments. > On Tuesday 07 Feb 2017 15:02:35 Ramesh Shanmugasundaram wrote: > > This patch adds documentation for the three new SDR formats > > > > V4L2_SDR_FMT_PCU16BE > > V4L2_SDR_FMT_PCU18BE > > V4L2_SDR_FMT_PCU20BE > > > > Signed-off-by: Ramesh

RE: [PATCH v3 7/7] media: platform: rcar_drif: Add DRIF support

Hi Laurent, Many thanks for your time & the review comments. I have agreed to most of the comments and a few need further discussion. Could you please take a look at those? > On Tuesday 07 Feb 2017 15:02:37 Ramesh Shanmugasundaram wrote: > > This patch adds Digital Radio Interface (DRIF)

Re: [PATCH 2/2] arm64: Fix power-of-ten vs. power-of-two prefixes in comments etc.

On Mon, Apr 17, 2017 at 01:54:49PM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 17, 2017 at 1:12 AM, Simon Horman wrote: > > On Thu, Apr 13, 2017 at 01:18:58PM +0100, David Woodhouse wrote: > >> Less important than in user-visible messages, but still good practice as > >>

Re: PCI / PM: Crashes in PME scan during system suspend

On Tuesday, April 18, 2017 08:49:39 AM Geert Uytterhoeven wrote: > Hi Lukas, > > On Sun, Apr 16, 2017 at 9:55 AM, Lukas Wunner wrote: > > On Sat, Apr 15, 2017 at 12:27:31AM +0200, Rafael J. Wysocki wrote: > >> On Friday, April 14, 2017 10:22:49 AM Lukas Wunner wrote: > >> >

Re: [PATCH 2/2] ARM: dts: r8a7791: Add GyroADC bindings

Hi Marek, On Sun, Apr 16, 2017 at 6:57 PM, Marek Vasut wrote: > Add bindings for the GyroADC block and it's associated clock. bindings?? > --- a/arch/arm/boot/dts/r8a7791.dtsi > +++ b/arch/arm/boot/dts/r8a7791.dtsi > @@ -776,6 +776,15 @@ > status =

Re: [PATCH 1/2] ARM: shmobile: r8a7791: add GyroADC clock

On Sun, Apr 16, 2017 at 6:57 PM, Marek Vasut wrote: > Add the GyroADC clock to the R8A7791 device tree. > > Signed-off-by: Marek Vasut Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH] of: Add vendor prefix for ROHM Semiconductor

On Sun, Apr 16, 2017 at 8:01 PM, Marek Vasut wrote: > ROHM Semiconductor Co., Ltd. offer PMICs, touchscreen controllers etc. > http://www.rohm.com/web/global/ > > Signed-off-by: Marek Vasut Acked-by: Geert Uytterhoeven

Re: [PATCH net-next] ravb: Fix ravb_ptp_interrupt clear interrupt all status

Hello! On 04/18/2017 03:55 AM, Simon Horman wrote: From: Tsutomu Izawa This patch fixes ravb_ptp_interrupt clears GIS register of all interrupts Clearing, maybe? status. It corrects to clear PTCF bit or PTMF bit. Well, it's safer to clear all of

Re: [PATCH 3/3] usb: host: xhci-plat: set resume_quirk() for R-Car controllers

On 17.03.2017 12:02, Yoshihiro Shimoda wrote: This patch sets resume_quirk() for R-Car controllers to re-download the firmware in resume timing. Otherwise, if the controller's power is down in suspend timing, the firmware in the controller goes away, and then the controller doesn't work after

Re: [GIT PULL FOR renesas-drivers] VSP1 rotation and histogram

it://linuxtv.org/pinchartl/media.git vsp1/histogram > >> > >> Dropped, too many conflicts. > > > > And the code is in the linuxtv master branch anyway, scheduled for merge > > in v4.12-rc1. > > Not the HGO and HGT support, cfr. > > git cherry -v next-2017041

Re: [GIT PULL FOR renesas-drivers] VSP1 rotation and histogram

nflicts. > > And the code is in the linuxtv master branch anyway, scheduled for merge in > v4.12-rc1. Not the HGO and HGT support, cfr. git cherry -v next-20170418 8bcdadfb22f218a4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux bey

Re: [GIT PULL FOR renesas-drivers] VSP1 rotation and histogram

Hi Geert, On Tuesday 18 Apr 2017 11:01:59 Geert Uytterhoeven wrote: > On Mon, Mar 6, 2017 at 1:47 AM, Laurent Pinchart wrote: > > The following changes since commit 130f8756b9b83c0137ee0d587152a7ef3e10f74b: > > v4l: vsp1: Register pipe with output WPF (2017-03-05 01:53:46 +0200) > > > > are

Re: [PATCH] arm64: dts: m3ulcb: Fix EthernetAVB PHY timing

Hello. On 4/18/2017 4:06 AM, Simon Horman wrote: Set PHY rxc-skew-ps to 1500 and all other values to their default values. This is intended to to address failures in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been The by? :-)

Re: [PATCH/RFT] sata: rcar_sata: Reset SATA PHY on resume

Hello. On 4/18/2017 10:02 AM, Simon Horman wrote: In the case where power is cut on suspend the SATA PHY state needs to be suspended on resume. This is the case on the Salvator-X board with the r8a7795 or r8a7796 SoC. In that environment it has been observed that SATA partitions cannot not be

Re: [GIT PULL FOR renesas-drivers] VSP1 rotation and histogram

On Mon, Mar 6, 2017 at 1:47 AM, Laurent Pinchart wrote: > The following changes since commit 130f8756b9b83c0137ee0d587152a7ef3e10f74b: > > v4l: vsp1: Register pipe with output WPF (2017-03-05 01:53:46 +0200) > > are available in the git repository at: > >

Re: [GIT PULL FOR renesas-drivers] R-Car Gen3 HDMI output support

Hi Laurent, On Mon, Mar 6, 2017 at 1:32 AM, Laurent Pinchart wrote: > Please find two pull requests below for renesas-drivers (in a single e-mail, > lucky you :-)). > > The first tag contains driver changes only and is based on a merge of drm-next > and

Re: [GIT PULL FOR renesas-drivers] R-Car Gen3 HDMI output support

Hi Geert, On Tuesday 18 Apr 2017 10:54:43 Geert Uytterhoeven wrote: > On Mon, Mar 6, 2017 at 1:32 AM, Laurent Pinchart wrote: > > Please find two pull requests below for renesas-drivers (in a single > > e-mail, lucky you :-)). > > > > The first tag contains driver changes only and is based on a

[PATCH/RFT v2] ARM: dts: silk: Enable UHS-I SDR-50

Add the "1v8" pinctrl state and sd-uhs-sdr50 property to SDHI1. Signed-off-by: Simon Horman --- * Compile tested only; no access to silk board --- arch/arm/boot/dts/r8a7794-silk.dts | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH/RFT] ARM: dts: silk: Enable UHS-I SDR-50

On Tue, Apr 18, 2017 at 09:22:24AM +0200, Geert Uytterhoeven wrote: > On Tue, Apr 18, 2017 at 7:27 AM, Simon Horman > wrote: > > Add the "1v8" pinctrl state and sd-uhs-sdr50 property to SDHI1. > > > > Signed-off-by: Simon Horman > > --- > >

Re: [PATCH/RFT] sata: rcar_sata: Reset SATA PHY on resume

On Tue, Apr 18, 2017 at 04:17:38PM +0900, Tejun Heo wrote: > On Tue, Apr 18, 2017 at 04:02:53PM +0900, Simon Horman wrote: > > In the case where power is cut on suspend the SATA PHY state needs to be > > suspended on resume. > ^ > re-initialized? Yes, sorry for the think-o. > > This is the

Re: [PATCH/RFT] ARM: dts: silk: Enable UHS-I SDR-50

On Tue, Apr 18, 2017 at 7:27 AM, Simon Horman wrote: > Add the "1v8" pinctrl state and sd-uhs-sdr50 property to SDHI1. > > Signed-off-by: Simon Horman > --- > * Compile tested only; no access to silk board > --- >

Re: [PATCH/RFT] sata: rcar_sata: Reset SATA PHY on resume

On Tue, Apr 18, 2017 at 04:02:53PM +0900, Simon Horman wrote: > In the case where power is cut on suspend the SATA PHY state needs to be > suspended on resume. ^ re-initialized? > > This is the case on the Salvator-X board with the r8a7795 or r8a7796 SoC. > In that environment it has been

Re: [RFC] i2c: rcar: reinit hardware on resume

> Thus, just calling rcar_i2c_init() is not enough ? Yes, where is my brown paper bag... I noticed this yesterday as well before falling asleep... ;) > But in my opinion, all register settings should be merged in one please > (= transfer function) and call pm_runtime_get/put there only. >

[PATCH/RFT] sata: rcar_sata: Reset SATA PHY on resume

In the case where power is cut on suspend the SATA PHY state needs to be suspended on resume. This is the case on the Salvator-X board with the r8a7795 or r8a7796 SoC. In that environment it has been observed that SATA partitions cannot not be accessed on resume. Based on work by Khiem Nguyen.

Re: PCI / PM: Crashes in PME scan during system suspend

Hi Lukas, On Sun, Apr 16, 2017 at 9:55 AM, Lukas Wunner wrote: > On Sat, Apr 15, 2017 at 12:27:31AM +0200, Rafael J. Wysocki wrote: >> On Friday, April 14, 2017 10:22:49 AM Lukas Wunner wrote: >> > Below is a tentative patch which moves PME polling to a freezable >> > workqueue,

[PATCH/RFT] ARM: dts: porter: Enable UHS-I SDR-50 and SDR-104

Add the "1v8" pinctrl state and sd-uhs-sdr50 property to SDHI{0,2}. And the sd-uhs-sdr104 property to SDHI0. Signed-off-by: Simon Horman -- Testing failed: - SDHI0: mmc0: error -110 whilst initialising SD card - It is unclear if this is something to do with my