Re: [PATCH v2 8/8] dt-bindings: pwm: Add R-Car M3-W device tree bindings

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 04:50:37PM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 27, 2017 at 4:37 PM, Ulrich Hecht > wrote: > > Add device tree bindings for the PWM controller found on R-Car M3-W SoCs. > > > > Signed-off-by: Ulrich Hecht

Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 05:43:35PM +0300, Laurent Pinchart wrote: > On Thursday 27 Apr 2017 17:42:53 Laurent Pinchart wrote: > > On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote: > > > From: Laurent Pinchart > > > > > > The panel backlight is

Re: [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 10:42:02AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi > wrote: > >this is 5th round of gpio/pincontroller for RZ/A1 devices. > > > > I have updated the pin controller driver to use the

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 10:48:45AM +, Chris Brandt wrote: > Hi Geert, > > On Thursday, April 27, 2017, Geert Uytterhoeven wrote: > > > + { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <_pins>; > > > + > > > + status = "okay"; > > > + > > > +

Re: [PATCH v5 07/10] arm: dts: genmai: Add SCIF2 pin group

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 10:19:51AM +0200, Jacopo Mondi wrote: > Add pin configuration subnode for SCIF2 serial debug interface. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven As the dt-bindings (documentation) has been

Re: [PATCH v5 05/10] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 10:38:39AM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi > wrote: > > Add dt-bindings for Renesas r7s72100 pin controller header file. > > > > Signed-off-by: Jacopo Mondi > >

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2017-04-27 Thread Simon Horman
On Wed, Apr 26, 2017 at 06:56:06PM +0300, Laurent Pinchart wrote: > Hi Ulrich, > > On Tuesday 21 Feb 2017 01:42:15 Laurent Pinchart wrote: > > On Thursday 20 Oct 2016 10:49:11 Simon Horman wrote: > > > On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > > >> Hi! > > >> > > >> This is

Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing

2017-04-27 Thread Simon Horman
On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman wrote: > > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote: > >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:

Re: [PATCH 0/9] ARM: dts: renesas: update PFC node name to pin-controller

2017-04-27 Thread Simon Horman
On Wed, Apr 26, 2017 at 01:20:52PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Apr 26, 2017 at 12:05 PM, Simon Horman > wrote: > > The device trees for Renesas SoCs use either pfc or pin-controller as the > > node name for the PFC device. This patch is

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
On 27/04/17 23:49, Sakari Ailus wrote: > Hi Kieran, > > On Thu, Apr 27, 2017 at 11:13:50PM +0100, Kieran Bingham wrote: >> Hi Sakari, >> >> Thanks for taking a look > > Sure! :-) > >> >> On 27/04/17 22:43, Sakari Ailus wrote: >>> Hi Kieran, >>> >>> Could I ask you to rebase your patches on top

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Sakari Ailus
Hi Kieran, On Thu, Apr 27, 2017 at 11:13:50PM +0100, Kieran Bingham wrote: > Hi Sakari, > > Thanks for taking a look Sure! :-) > > On 27/04/17 22:43, Sakari Ailus wrote: > > Hi Kieran, > > > > Could I ask you to rebase your patches on top of my V4L2 fwnode patches > > here? > > > >

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-27 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. I took it for a spin on my Koelsch and it worked nicely. Acked-by: Niklas Söderlund On 2017-04-25 15:55:00 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The

[PATCH v4 16/27] rcar-vin: add functions to manipulate Gen3 CHSEL value

2017-04-27 Thread Niklas Söderlund
On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from

[PATCH v4 24/27] rcar-vin: add link notify for Gen3

2017-04-27 Thread Niklas Söderlund
Add the ability to process media device link change request. Link enablement are a bit complicated on Gen3, if it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VIN are split into two subgroups (VIN0-3 and VIN4-7) and from a routing perspective these two

[PATCH v4 23/27] rcar-vin: parse Gen3 OF and setup media graph

2017-04-27 Thread Niklas Söderlund
Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN group common media device. Once a CSI-2 subdevice is added to the common media device list as many links as possible are added. The parsing and registering CSI-2 subdevices is a collaborative effort shared between all rcar-vin

[PATCH v4 22/27] rcar-vin: add chsel information to rvin_info

2017-04-27 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and virtual channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund ---

[PATCH v4 19/27] rcar-vin: use different v4l2 operations in media controller mode

2017-04-27 Thread Niklas Söderlund
When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the

[PATCH v4 27/27] rcar-vin: enable support for r8a7796

2017-04-27 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund --- .../devicetree/bindings/media/rcar_vin.txt | 1 + drivers/media/platform/rcar-vin/rcar-core.c| 64 ++ 2 files changed, 65

[PATCH v4 25/27] rcar-vin: extend {start,stop}_streaming to work with media controller

2017-04-27 Thread Niklas Söderlund
The procedure to start or stop streaming using the none MC single subdevice and the MC graph and multiple subdevices are quiet different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v4 26/27] rcar-vin: enable support for r8a7795

2017-04-27 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/rcar-vin/rcar-core.c | 72 + 2 files changed, 73

[PATCH v4 17/27] rcar-vin: prepare digital notifier for group notifier

2017-04-27 Thread Niklas Söderlund
The media bus parsing functions used by the digital subdevice V4L2 notifier can be shared with the upcoming CSI-2 notifier. To prepare for this move and rename the function to reflect it's generic. Signed-off-by: Niklas Söderlund ---

[PATCH v4 20/27] rcar-vin: register a media pad if running in media controller mode

2017-04-27 Thread Niklas Söderlund
When running in media controller mode a media pad is needed, register one. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 9 + drivers/media/platform/rcar-vin/rcar-vin.h | 4 2 files changed, 13

[PATCH v4 21/27] rcar-vin: add group allocator functions

2017-04-27 Thread Niklas Söderlund
In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add a allocator framework where the first VIN instance to be probed creates a shared data

[PATCH v4 18/27] rcar-vin: add flag to switch to media controller mode

2017-04-27 Thread Niklas Söderlund
On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v4 13/27] rcar-vin: do not cut height in two for top, bottom or alternate fields

2017-04-27 Thread Niklas Söderlund
The height should not be cut in half for the format for top, bottom or alternate fields settings. This was a mistake and it was made visible by the scaling refactoring. Correct behavior is that the user should request a frame size that fits the half height frame reflected in the field setting. If

[PATCH v4 05/27] rcar-vin: move chip information to own struct

2017-04-27 Thread Niklas Söderlund
When Gen3 support is added to the driver more then chip id will be different for the different Soc. To avoid a lot of if statements in the code create a struct chip_info to contain this information. Signed-off-by: Niklas Söderlund ---

[PATCH v4 10/27] rcar-vin: do not reset crop and compose when setting format

2017-04-27 Thread Niklas Söderlund
It was a bad idea to reset the crop and compose settings when a new format is set. This would overwrite any crop/compose set by s_select and cause unexpected behaviors, remove it. Also fold the reset helper in to the only remaining caller. Signed-off-by: Niklas Söderlund

[PATCH v4 03/27] media: entity: Add media_entity_has_route() function

2017-04-27 Thread Niklas Söderlund
From: Laurent Pinchart This is a wrapper around the media entity has_route operation. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by: Sakari Ailus

[PATCH v4 06/27] rcar-vin: move max width and height information to chip information

2017-04-27 Thread Niklas Söderlund
On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 6 ++

[PATCH v4 14/27] rcar-vin: move media bus configuration to struct rvin_info

2017-04-27 Thread Niklas Söderlund
Bus configuration will once the driver is extended to to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_info to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH v4 09/27] rcar-vin: all Gen2 boards can scale simplify logic

2017-04-27 Thread Niklas Söderlund
The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and hight when interacting with the subdevice much like

[PATCH v4 15/27] rcar-vin: enable Gen3 hardware configuration

2017-04-27 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund ---

[PATCH v4 08/27] rcar-vin: move functions regarding scaling

2017-04-27 Thread Niklas Söderlund
In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund

[PATCH v4 07/27] rcar-vin: change name of video device

2017-04-27 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++- 1 file

[PATCH v4 11/27] rcar-vin: do not allow changing scaling and composing while streaming

2017-04-27 Thread Niklas Söderlund
It is possible on Gen2 to change the registers controlling composing and scaling while the stream is running. Is however not a good idea to do so and could result in trouble. There are also no good reason to allow this, remove immediate reflection in hardware registers from vidioc_s_selection and

[PATCH v4 01/27] rcar-vin: add Gen3 devicetree bindings documentation

2017-04-27 Thread Niklas Söderlund
Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

[PATCH v4 04/27] media: entity: Swap pads if route is checked from source to sink

2017-04-27 Thread Niklas Söderlund
From: Sakari Ailus This way the pads are always passed to the has_route() op sink pad first. Makes sense. Signed-off-by: Sakari Ailus Signed-off-by: Niklas Söderlund ---

[PATCH v4 02/27] media: entity: Add has_route entity operation

2017-04-27 Thread Niklas Söderlund
From: Laurent Pinchart The optional operation can be used by entities to report whether two pads are internally connected. Signed-off-by: Laurent Pinchart Signed-off-by: Michal Simek Signed-off-by:

[PATCH v6 2/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2017-04-27 Thread Niklas Söderlund
A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver supports the rcar-vin driver on R-Car Gen3 SoCs where separate CSI-2 hardware blocks are connected between the video sources and the video grabbers (VIN). Driver is based on a prototype by Koji Matsuoka in the Renesas BSP.

[PATCH v6 1/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

2017-04-27 Thread Niklas Söderlund
Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers are located between the video sources (CSI-2 transmitters) and the video grabbers (VIN) on Gen3 of Renesas R-Car SoC. Each CSI-2 device is connected to more then one VIN device which simultaneously can receive video from the

[PATCH v6 0/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 support

2017-04-27 Thread Niklas Söderlund
Hi, This is the latest incarnation of R-Car MIPI CSI-2 receiver driver. It's based on top of v4.11-rc1 and are tested on Renesas Salvator-X together with the out of tree patches for rcar-vin to add support for Gen3 VIN and a prototype driver for ADV7482. If anyone is interested to test video

[PATCH 1/2] media: entity: Add pad_from_dt_regs entity operation

2017-04-27 Thread Niklas Söderlund
The optional operation can be used by entities to report how it maps its DT node ports and endpoints to media pad numbers. This is useful for devices which require more advanced mappings of pads then DT port number is equivalent with media port number. Signed-off-by: Niklas Söderlund

[PATCH 2/2] media: entity: Add media_entity_pad_from_dt_regs() function

2017-04-27 Thread Niklas Söderlund
This is a wrapper around the media entity pad_from_dt_regs operation. Signed-off-by: Niklas Söderlund --- drivers/media/media-entity.c | 21 + include/media/media-entity.h | 22 ++ 2 files changed, 43 insertions(+)

[PATCH 0/2] media: entity: add operation to help map DT node to media pad

2017-04-27 Thread Niklas Söderlund
Hi, This small series add a new entity operation which will aid capture drivers to map a port/endpoint in DT to a media graph pad. I looked around and in my experience most drivers assume the DT port number is the same as the media pad number. This might be true for most devices but there are

[PATCH] v4l2-async: add subnotifier registration for subdevices

2017-04-27 Thread Niklas Söderlund
When registered() of v4l2_subdev_internal_ops is called the subdevice have access to the master devices v4l2_dev and it's called with the async frameworks list_lock held. In this context the subdevice can register its own notifiers to allow for incremental discovery of subdevices. The master

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
Hi Sakari, Thanks for taking a look On 27/04/17 22:43, Sakari Ailus wrote: > Hi Kieran, > > Could I ask you to rebase your patches on top of my V4L2 fwnode patches > here? > > > > It depends on the fwnode graph patches,

Re: [PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Sakari Ailus
Hi Kieran, Could I ask you to rebase your patches on top of my V4L2 fwnode patches here? It depends on the fwnode graph patches, merged here: I

[PATCH] pinctrl: sh-pfc: r8a7794: rename some I2C signals

2017-04-27 Thread Sergei Shtylyov
The R8A7794 PFC driver was apparently based on the preliminary revisions of the user's manual which called I2C5 device IIC0 and IIC0 device IIC1. Luckily, these signals haven't been used for any functions/groups so far, so the renaming should be painless... Signed-off-by: Sergei Shtylyov

[PATCH] usb: r8a66597-hcd: decrease timeout

2017-04-27 Thread Chris Brandt
The timeout for BULK packets was 300ms which is a long time if other endpoints or devices are waiting for their turn. Changing it to 50ms greatly increased the overall performance for multi-endpoint devices. Fixes: 5d3043586db4 ("usb: r8a66597-hcd: host controller driver for R8A6659")

[PATCH] usb: r8a66597-hcd: select a different endpoint on timeout

2017-04-27 Thread Chris Brandt
If multiple endpoints on a single device have pending IN URBs and one endpoint times out due to NAKs (perfectly legal), select a different endpoint URB to try. The existing code only checked to see another device address has pending URBs and ignores other IN endpoints on the current device

[PATCH] ARM: dts: r7s72100: add usb clocks to device tree

2017-04-27 Thread Chris Brandt
This adds the USB0 and USB1 clocks to the device tree. Signed-off-by: Chris Brandt --- arch/arm/boot/dts/r7s72100.dtsi| 6 +++--- include/dt-bindings/clock/r7s72100-clock.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH V2 3/4] gpio: Add ROHM BD9571MWV-M PMIC GPIO driver

2017-04-27 Thread Marek Vasut
On 04/25/2017 11:32 AM, Linus Walleij wrote: > On Mon, Apr 24, 2017 at 5:21 PM, Marek Vasut wrote: > >> Add driver for the GPIO block in the ROHM BD9571MWV-W MFD PMIC. >> This block is pretty trivial and supports setting GPIO direction >> as Input/Output and in case of

[PATCH 2/5] rcar-vin: Match sources against ports if specified.

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham If an endpoint source specifies a port number, then it may have multiple entities provided by one DT node. In this event, match against both the DT node and it's relevant port. Signed-off-by: Kieran Bingham

[PATCH 4/5] arm64: dts: r8a7795: salvator-x: enable VIN, CSI and ADV7482

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 129 + 1 file

[PATCH 1/5] v4l2-subdev: Provide a port mapping for asynchronous subdevs

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham Devices such as the the ADV748x support multiple parallel stream routes through a single chip. This leads towards needing to provide multiple distinct entities and subdevs from a single device-tree node. To distinguish these separate

[PATCH 3/5] media: i2c: adv748x: add adv748x driver

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham Provide basic support for the ADV7481 and ADV7482. The driver is modelled with 2 subdevices to allow simultaneous streaming from the AFE (Analog front end) and HDMI inputs. Presently the HDMI is hardcoded to link to the TXA CSI bus,

[PATCH 0/5] RFC: ADV748x HDMI/Analog video receiver

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham This is an RFC for the Analog Devices ADV748x driver, and follows on from a previous posting by Niklas Söderlund [0] of an earlier incarnation of this driver. This is an early posting of the driver following the release early,

[PATCH 5/5] arm64: dts: r8a7796: salvator-x: enable VIN, CSI and ADV7482

2017-04-27 Thread Kieran Bingham
From: Kieran Bingham Provide bindings between the VIN, CSI and the ADV7482 on the r8a7796. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 129 + 1 file

RE: [RFC v2 0/2] SH CEU camera driver

2017-04-27 Thread Chris Brandt
Hi Jacopo, On Thursday, April 27, 2017, jmondi wrote: > We planned to use the following setup to test the CEU driver with an > actual HW platform > > GR-Peach + GR-Peach Audio Camera Shield + OV7670 evaluation module > https://www.digikey.com/product-detail/en/renesas-electronics- >

Re: [RFC v2 0/2] SH CEU camera driver

2017-04-27 Thread jmondi
Hi Chris, On Thu, Apr 27, 2017 at 01:10:15PM +, Chris Brandt wrote: > Hi Jacopo, > > > The driver is -not tested- for lack of available platforms, just > > compiled in. > > For HW, it would be good if you use a OV7670 camera module for testing. > > Like this: >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

2017-04-27 Thread Andy Shevchenko
On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi wrote: > Add bi-directional and output-enable pin configuration properties. > > bi-directional allows to specify when a pin shall operate in input and > output mode at the same time. This is particularly useful in platforms

Re: [PATCH v2 8/8] dt-bindings: pwm: Add R-Car M3-W device tree bindings

2017-04-27 Thread Geert Uytterhoeven
On Thu, Apr 27, 2017 at 4:37 PM, Ulrich Hecht wrote: > Add device tree bindings for the PWM controller found on R-Car M3-W SoCs. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven

Re: [PATCH v2 4/8] arm64: dts: r8a7796: salvator-x: Add panel backlight support

2017-04-27 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Thursday 27 Apr 2017 16:37:39 Ulrich Hecht wrote: > The panel backlight is controlled through a GPIO and a PWM channel. > > Signed-off-by: Ulrich Hecht Reviewed-by: Laurent Pinchart >

Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

2017-04-27 Thread Laurent Pinchart
On Thursday 27 Apr 2017 17:42:53 Laurent Pinchart wrote: > On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote: > > From: Laurent Pinchart > > > > The panel backlight is controlled through a GPIO and a PWM channel. > > > > Signed-off-by: Laurent

Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

2017-04-27 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote: > From: Laurent Pinchart > > The panel backlight is controlled through a GPIO and a PWM channel. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 7/8] arm64: dts: r8a7795-salvator-x: Enable PWM2

2017-04-27 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Thursday 27 Apr 2017 16:37:42 Ulrich Hecht wrote: > From: Takeshi Kihara > > This patch enables PWM2 for Salvator-X board on R8A7795 SoC. > > Signed-off-by: Takeshi Kihara > Signed-off-by:

[PATCH v2 8/8] dt-bindings: pwm: Add R-Car M3-W device tree bindings

2017-04-27 Thread Ulrich Hecht
Add device tree bindings for the PWM controller found on R-Car M3-W SoCs. Signed-off-by: Ulrich Hecht --- Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

2017-04-27 Thread Ulrich Hecht
From: Laurent Pinchart The panel backlight is controlled through a GPIO and a PWM channel. Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 ++

[PATCH v2 4/8] arm64: dts: r8a7796: salvator-x: Add panel backlight support

2017-04-27 Thread Ulrich Hecht
The panel backlight is controlled through a GPIO and a PWM channel. Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH v2 1/8] pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions

2017-04-27 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds PWM{0,1,2,3,4,5,6} pins, groups and functions to R8A7796 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7796.c

[PATCH v2 7/8] arm64: dts: r8a7795-salvator-x: Enable PWM2

2017-04-27 Thread Ulrich Hecht
From: Takeshi Kihara This patch enables PWM2 for Salvator-X board on R8A7795 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |

[PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

2017-04-27 Thread Ulrich Hecht
Hi! Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X boards. This revision addresses the issues found by Geert and adds Laurent's backlight support patch, including a version for r8a7796. CU Uli Changes since v1: - PWM clock is S0D12, not S3D4 - dts: fix register

[PATCH v2 2/8] clk: renesas: r8a7796: add PWM clock

2017-04-27 Thread Ulrich Hecht
From: Ryo Kodama This patch adds PWM clock for PWM. Signed-off-by: Ryo Kodama Signed-off-by: Takeshi Kihara [uli: changed from S3D4 to S0D12 in accordance with datasheet] Signed-off-by: Ulrich Hecht

Re: [PATCH/RFC 0/5] arm64: dts: renesas: Break out common board support

2017-04-27 Thread Geert Uytterhoeven
Hi Simon, On Wed, Apr 26, 2017 at 10:11 AM, Geert Uytterhoeven wrote: > CC Vladimir (which I forgot to CC initially, sorry for that) > > On Wed, Apr 26, 2017 at 10:06 AM, Simon Horman wrote: >> On Fri, Apr 21, 2017 at 02:55:16PM +0200, Geert

RE: [RFC v2 0/2] SH CEU camera driver

2017-04-27 Thread Chris Brandt
Hi Jacopo, > The driver is -not tested- for lack of available platforms, just > compiled in. For HW, it would be good if you use a OV7670 camera module for testing. Like this: https://www.amazon.com/OV7670-Compatible-Arduino-Atomic-Market/dp/B00TKXAGZM/ref=sr_1_2?ie=UTF8 That's what we use

Re: [renesas-drivers:topic/rcar2-cpg-mssr 5/32] arch/mips//lantiq/clk.c:163:13: error: redefinition of 'of_clk_get_from_provider'

2017-04-27 Thread Geert Uytterhoeven
On Wed, Apr 26, 2017 at 11:50 AM, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git > topic/rcar2-cpg-mssr > head: bd948f4b8c455dfdbc8175b5c2bc29c91b048971 > commit: 647a9d3c4f83250fd1f4e6519cf785319c9afe4c

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

2017-04-27 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. This is a partial review, as some of the comments will result in large changes that would make review of some of the current code pointless. There is however enough comments to keep you busy for a bit :-) By the way, you might want to keep your development

RE: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Chris Brandt
Hi Geert, On Thursday, April 27, 2017, Geert Uytterhoeven wrote: > > + { > > + pinctrl-names = "default"; > > + pinctrl-0 = <_pins>; > > + > > + status = "okay"; > > + > > + renesas,no-ether-link; > > + phy-handle = <>; > > + phy0: ethernet-phy@0 { > > +

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Geert Uytterhoeven
Hi Jacopo, On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven > ---

[RFC v2 1/2] media: platform: Add SH CEU camera interface driver

2017-04-27 Thread Jacopo Mondi
Add driver for SH Mobile CEU driver, based on drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c The original driver was based on soc-camera framework. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile

[RFC v2 0/2] SH CEU camera driver

2017-04-27 Thread Jacopo Mondi
Edit: re-sending as new driver to ease review. Remove the existing soc-camera one in patch [2/2]. Hello Renesas list, this is a first attempt to move SH Mobile CEU driver away from soc_camera framework. The driver is -not tested- for lack of available platforms, just compiled in. Sending it

[RFC v2 2/2] media: platform: soc-camera: Remove SH CEU driver

2017-04-27 Thread Jacopo Mondi
Remove SH Mobile CEU driver from soc-camera framework Signed-off-by: Jacopo Mondi --- drivers/media/platform/soc_camera/Kconfig | 10 - drivers/media/platform/soc_camera/Makefile |1 - .../platform/soc_camera/sh_mobile_ceu_camera.c | 1821

Re: [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller

2017-04-27 Thread Geert Uytterhoeven
Hi Jacopo, On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: >this is 5th round of gpio/pincontroller for RZ/A1 devices. > > I have updated the pin controller driver to use the newly introduced > "pinctrl_enable()" function. > This is required since v4.11-rc7

Re: [PATCH v5 05/10] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header

2017-04-27 Thread Geert Uytterhoeven
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add dt-bindings for Renesas r7s72100 pin controller header file. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven > --- /dev/null > +++

Re: [PATCH v5 04/10] dt-bindings: pinctrl: Add RZ/A1 bindings doc

2017-04-27 Thread Geert Uytterhoeven
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin > controller. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

Re: [PATCH v5 03/10] pinctrl: Renesas RZ/A1 pin and gpio controller

2017-04-27 Thread Geert Uytterhoeven
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add combined gpio and pin controller driver for Renesas RZ/A1 > r7s72100 SoC. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

Re: [PATCH v5 02/10] pinctrl: generic: Add macros to unpack properties

2017-04-27 Thread Geert Uytterhoeven
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to > unpack generic properties and their arguments > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

[PATCH v5 06/10] arm: dts: r7s72100: Add pin controller node

2017-04-27 Thread Jacopo Mondi
Add pin controller node with 12 gpio controller sub-nodes to r7s72100 dtsi. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven --- arch/arm/boot/dts/r7s72100.dtsi | 78 + 1 file changed, 78

[PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Jacopo Mondi
Add pin configuration subnode for ETHER ethernet controller. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100-genmai.dts | 41 +++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts

[PATCH v5 09/10] arm: dts: genmai: Add user led device nodes

2017-04-27 Thread Jacopo Mondi
Add device nodes for user leds on Genmai board. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven --- arch/arm/boot/dts/r7s72100-genmai.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v5 08/10] arm: dts: genmai: Add RIIC2 pin group

2017-04-27 Thread Jacopo Mondi
Add pin configuration subnode for RIIC2 interface. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven --- arch/arm/boot/dts/r7s72100-genmai.dts | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v5 05/10] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header

2017-04-27 Thread Jacopo Mondi
Add dt-bindings for Renesas r7s72100 pin controller header file. Signed-off-by: Jacopo Mondi --- include/dt-bindings/pinctrl/r7s72100-pinctrl.h | 16 1 file changed, 16 insertions(+) create mode 100644 include/dt-bindings/pinctrl/r7s72100-pinctrl.h

[PATCH v5 07/10] arm: dts: genmai: Add SCIF2 pin group

2017-04-27 Thread Jacopo Mondi
Add pin configuration subnode for SCIF2 serial debug interface. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven --- arch/arm/boot/dts/r7s72100-genmai.dts | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller

2017-04-27 Thread Jacopo Mondi
Hi Geert, this is 5th round of gpio/pincontroller for RZ/A1 devices. I have updated the pin controller driver to use the newly introduced "pinctrl_enable()" function. This is required since v4.11-rc7 as otherwise, as reported by Chris Brandt, the pin controller does not start. I have

[PATCH v5 02/10] pinctrl: generic: Add macros to unpack properties

2017-04-27 Thread Jacopo Mondi
Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to unpack generic properties and their arguments Signed-off-by: Jacopo Mondi --- include/linux/pinctrl/pinconf-generic.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

2017-04-27 Thread Jacopo Mondi
Add bi-directional and output-enable pin configuration properties. bi-directional allows to specify when a pin shall operate in input and output mode at the same time. This is particularly useful in platforms where input and output buffers have to be manually enabled. output-enable is just