Re: [PATCH] dt-bindings: serial: sh-sci: Add support for r8a77995 (H)SCIF

2017-08-21 Thread Rob Herring
On Thu, Aug 17, 2017 at 01:16:28PM +0200, Geert Uytterhoeven wrote: > Document support for the (H)SCIF serial ports in the Renesas R-Car D3 > (r8a77995) SoC. > > No driver update is needed. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH] dt-bindings: watchdog: renesas-wdt: Add support for the r8a77995 wdt

2017-08-21 Thread Rob Herring
On Thu, Aug 17, 2017 at 01:14:25PM +0200, Geert Uytterhoeven wrote: > Document support for the Watchdog Timer (WDT) Controller in the Renesas > R-Car D3 (r8a77995) SoC. > > No driver update is needed. > > Signed-off-by: Geert Uytterhoeven > --- >

[PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount by using of_get_parent() instead of of_get_next_parent() which don't decrement the usecount of the node passed to it. Fixes: 3b27d00e7b6d7c88

Re: [PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Rob Herring
On Mon, Aug 21, 2017 at 11:38:17AM +0100, Biju Das wrote: > Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI > is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das > --- > v1->v2 > -Modified the listing SoC's description related to SoC

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hejssan Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 22:03:02 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Hi Sakari, On 2017-08-21 22:03:02 +0300, Sakari Ailus wrote: > Hi Niklas, > > Niklas Söderlund wrote: > > Hi Sakari, > > > > On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: > > > Hi Niklas, > > > > > > Niklas Söderlund wrote: > > > > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hi Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Geert Uytterhoeven
Hi Niklas, On Mon, Aug 21, 2017 at 2:51 PM, Niklas Söderlund wrote: > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > node being passed to of_fwnode_graph_get_port_parent(). Preserve the > usecount just like it is done in

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: > Hi Niklas, > > Niklas Söderlund wrote: > > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > > node being passed to of_fwnode_graph_get_port_parent(). Preserve the > > usecount just like it is done in

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Wolfram Sang
> It works, now :) Great! > tmio_mmc_init_ocr() > > fails (silently!). And with this the whole RCar3 SDHI, without any error > message. I'll check next week about an error message there. > Many thanks for your help! You're welcome. If you want, you can even test SDR104 by applying this

[GIT PULL FOR renesas-drivers] cpufreq: dt-platdev: Automatically create cpufreq device with OPP v2

2017-08-21 Thread Simon Horman
Hi Geert, please consider pulling driver cpufreq driver changes to allow it to automatically create a cpufreq device. This patch is proposed by Viresh Kumar. The other patches remove the r8a7795 and r8a7796 from the creation whitelist so that Viresh's code may be exercised on those platforms.

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like it is done in of_graph_get_port_parent(). The of_fwnode_graph_get_port_parent() is called by

[GIT PULL FOR renesas-drivers] arm64: dts: r8a779[56]: Add OPPs table for cpu devices

2017-08-21 Thread Simon Horman
Hi Geert, please consider pulling OPPs table for cpufreq support on the r8a7796 and r8a7795. This pull request is based on renesas-arm64-dt-for-v4.14. These are dependencies for supporting CPUFreq. The remainder of that work is being posted separately and can be found at:

[GIT PULL FOR renesas-drivers] clk: renesas: r8a779[56]: Add Z and Z2 clock support

2017-08-21 Thread Simon Horman
Hi Geert, please consider pulling the Z and Z2 clock support for r8a779[56] (v2). This pull request is based on clk-renesas-for-v4.14-tag1. These are dependencies for supporting CPUFreq. The remainder of that work is being posted separately and can be found at:

[PATCH v2 6/6] clk: renesas: r8a7796: Add Z2 clock

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock for R8A7796 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 2/6] clk: renesas: rcar-gen3: Add Z2 clock divider support

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock divider support for R-Car Gen3 SoC. Signed-off-by: Takeshi Kihara [simon: add recalc_rate() helper; use bitops macros] Signed-off-by: Simon Horman --- v1

[PATCH v2 3/6] clk: renesas: r8a7795: Add Z clock

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock for R8A7795 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 5/6] clk: renesas: r8a7796: Add Z clock

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock for R8A7796 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Simon Horman --- drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 0/6] clk: renesas: r8a779[56]: Add Z and Z2 clock support

2017-08-21 Thread Simon Horman
Hi, this patch-set adds Z and Z2 clock support. These are dependencies for supporting CPUFreq. The remainder of that work is being posted separately and can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/rcar-gen3-cpufreq A description of steps taken to

[PATCH v2 4/6] clk: renesas: r8a7795: Add Z2 clock

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z2 clock for r8a7795 SoC. Signed-off-by: Takeshi Kihara --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c

[PATCH v2 1/6] clk: renesas: rcar-gen3: Add Z clock divider support

2017-08-21 Thread Simon Horman
From: Takeshi Kihara This patch adds Z clock divider support for R-Car Gen3 SoC. Signed-off-by: Takeshi Kihara [simon: divide parent by 2; use bitops macros] Signed-off-by: Simon Horman --- v1 [Simon

[PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like it is done in of_graph_get_port_parent(). Fixes: 3b27d00e7b6d7c88 ("device property: Move fwnode graph ops to firmware specific

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Dirk Behme
On 21.08.2017 10:24, Dirk Behme wrote: On 21.08.2017 10:18, Wolfram Sang wrote: Hi Dirk, Ah, ES2.0. That's the missing information. Yup, is on the todo-list. I will try to test your patch on my Salvator-XS board today. Ok, thanks :) Your patch on top of v4.13-rc5 makes SDHI work on my

Re: [PATCH v3] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Wolfram Sang
On Mon, Aug 21, 2017 at 01:25:11PM +0100, Biju Das wrote: > Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI > is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das Reviewed-by: Wolfram Sang

[PATCH v3] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Biju Das
Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family. Signed-off-by: Biju Das --- v1->v2 - Modified the listing SoC's description related to SoC with 1 Clock and 2 Clocks v2->v3 - Fixed the trailing double

Re: [PATCH v2] mmc: sdhi: use maximum width for the sdbuf register

2017-08-21 Thread Ulf Hansson
On 9 August 2017 at 20:29, Wolfram Sang wrote: > Make use of the 64 bit sdbuf width on Renesas R-Car Gen3. If the > registers are 8 byte apart, the width is also 64 bit. For all others, > the width is 32 bit, even if the registers are only 16 bit apart. > >

Re: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1

2017-08-21 Thread Ulf Hansson
On 9 August 2017 at 21:14, Wolfram Sang wrote: > Here is a small series to improve RZ support for SDHI. I don't have that > platform currently, so I hope Chris has some time to check these simple > patches. It is based on top of the patch just sent out: >

RE: [PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Biju Das
> -Original Message- > From: devicetree-ow...@vger.kernel.org [mailto:devicetree- > ow...@vger.kernel.org] On Behalf Of Geert Uytterhoeven > Sent: 21 August 2017 12:30 > To: Biju Das > Cc: Ulf Hansson ; Rob Herring ; >

Re: [PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Wolfram Sang
> - Below is the number clocks for each supported SoC: > -1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790 > - R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796 > -2: R7S72100 > + Most supported SoCs only have 1 clock. Devices which have more > +

Re: [PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Geert Uytterhoeven
Hi Biju, On Mon, Aug 21, 2017 at 12:38 PM, Biju Das wrote: > Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI > is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das > --- > v1->v2 > -Modified the listing SoC's

[PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Biju Das
Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family. Signed-off-by: Biju Das --- v1->v2 -Modified the listing SoC's description related to SoC with 1 Clock and 2 Clocks This patch is compiled and tested

RE: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Biju Das
> -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: 21 August 2017 09:25 > To: Biju Das > Cc: Ulf Hansson ; Rob Herring ; > Mark Rutland ; Simon Horman >

Re: [PATCH v2] arm64: dts: renesas: r8a7796: Add FDP1 instance

2017-08-21 Thread Laurent Pinchart
Hi Simon, On Thursday, 13 July 2017 14:21:10 EEST Laurent Pinchart wrote: > The r8a7796 has a single FDP1 instance. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Kieran Bingham > Reviewed-by: Geert Uytterhoeven

Re: [PATCH repost2] pwm: renesas-tpu: remove support for sh7372

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 05:28:01PM +0200, Thierry Reding wrote: > On Fri, Aug 18, 2017 at 12:09:01PM +0200, Simon Horman wrote: > > Remove support for the SH7372 (SH-Mobile AP4) from the renesas-tpu driver. > > > > Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy file") > >

Re: [PATCH v2 0/4] ARM: dts: rcar-gen2: Stop grouping clocks under a "clocks" subnode

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 11:16:53AM +0200, Geert Uytterhoeven wrote: > Hi Simon, Magnus, > > The current practice is to not group clocks under a "clocks" subnode, > but just put them together with the other on-SoC devices. > > Hence this patch series implements this for the various R-Car

Re: [PATCH v2 0/5] ARM: dts: rcar-gen2: Convert to new CPG/MSSR bindings

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 11:11:33AM +0200, Geert Uytterhoeven wrote: > Hi Simon, Magnus, > > Currently Renesas R-Car Gen2 SoCs use the common clk-rcar-gen2, > clk-mstp, and clk-div6 drivers, which depend on most clocks being > described in DT. Especially the module (MSTP) clocks are

Re: [PATCH v2] ARM: multi_v7_defconfig: Enable BQ32000 RTC driver

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 12:12:38PM +0100, Biju Das wrote: > The iWave RZ/G1M Q7 SOM supports RTC (TI BQ32000). > To increase hardware support enable the driver in the > multi_v7_defconfig multiplatform configuration. > > Signed-off-by: Biju Das Thanks, applied for

Re: [PATCH] arm64: dts: r8a7795-es1: Drop extra zero from usb unit address

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 10:07:26AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Aug 18, 2017 at 10:02 AM, Simon Horman wrote: > > On Thu, Aug 17, 2017 at 01:29:14PM +0200, Geert Uytterhoeven wrote: > >> With W=1: > >> > >>

Re: [PATCH 5/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer

2017-08-21 Thread Simon Horman
On Wed, Aug 16, 2017 at 03:22:27PM +0200, Ulrich Hecht wrote: > Adds serial port SCIF1 and the MAX9260 deserializers connected to it. > > Signed-off-by: Ulrich Hecht Hi Ulrich, I am marking this patch as deferred pending progress on the rest of the series.

Re: [PATCH 3/3] ARM: dts: iwg20d-q7: Add SDHI1 support

2017-08-21 Thread Wolfram Sang
On Mon, Aug 14, 2017 at 12:49:49PM +0100, Biju Das wrote: > Define the iWave RainboW-G20D-Qseven board dependent part of the > SDHI1 device node. > > Signed-off-by: Biju Das Acked-by: Wolfram Sang signature.asc Description: PGP

Re: [PATCH 2/3] ARM: dts: iwg20m: Enable SDHI0 controller

2017-08-21 Thread Wolfram Sang
> > > +vmmc-supply = <_3p3v>; > > > +vqmmc-supply = <_3p3v>; > > > > Just to make sure: No 1.8V and UHS support (SDR50/104)? Or is this to be > > tested and added later? > > Thanks. The current hardware doesn't support 1.8V switching for SDHI0. There > is a plan to > add this in future board

RE: [PATCH 2/3] ARM: dts: iwg20m: Enable SDHI0 controller

2017-08-21 Thread Biju Das
> -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: 21 August 2017 09:29 > To: Biju Das > Cc: Rob Herring ; Mark Rutland > ; Simon Horman ; Magnus > Damm

Re: [PATCH 2/3] ARM: dts: iwg20m: Enable SDHI0 controller

2017-08-21 Thread Wolfram Sang
> + > + { > + pinctrl-0 = <_pins>; > + pinctrl-names = "default"; > + > + vmmc-supply = <_3p3v>; > + vqmmc-supply = <_3p3v>; > + cd-gpios = < 11 GPIO_ACTIVE_LOW>; > + status = "okay"; > +}; Just to make sure: No 1.8V and UHS support (SDR50/104)? Or is this to be tested and

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Dirk Behme
On 21.08.2017 10:18, Wolfram Sang wrote: Hi Dirk, Ah, ES2.0. That's the missing information. Yup, is on the todo-list. I will try to test your patch on my Salvator-XS board today. Ok, thanks :) Your patch on top of v4.13-rc5 makes SDHI work on my Salvator-XS with a Please feel free to

Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-21 Thread Wolfram Sang
> Below is the number clocks for each supported SoC: > -1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790 > - R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796 > +1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779, > + R8A7790,

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Wolfram Sang
Hi Dirk, > > Ah, ES2.0. That's the missing information. Yup, is on the todo-list. I > > will try to test your patch on my Salvator-XS board today. > > Ok, thanks :) Your patch on top of v4.13-rc5 makes SDHI work on my Salvator-XS with a H3 ES2.0. It detects the eMMC and I can mount SD cards on

[PATCH v2] rcar-dmac: initialize all data before registering IRQ handler

2017-08-21 Thread Kuninori Morimoto
From: Kuninori Morimoto Anton Volkov noticed that engine->dev is NULL before of_dma_controller_register() in probe. Thus there might be a NULL pointer dereference in rcar_dmac_chan_start_xfer while accessing chan->chan.device->dev which is equal to

Re: Possible null pointer dereference in rcar-dmac.ko

2017-08-21 Thread Kuninori Morimoto
Hi Laurent > I don't think this fully fixes the problem, as the rcar_dmac_isr_error() IRQ > handler is still registered before all this. Furthermore, at least some of > the > initialization at the end of rcar_dmac_chan_probe() has to be moved before > the > rcar_dmac_isr_channel() IRQ