Re: [PATCH v7 0/8] vsp1: TLB optimisation and DL caching

Hi Kieran, I've finished reviewing the series. For your convenience, I've rebased it on top of the BRU/BRS dynamic allocation patches, and pushed the result to git://linuxtv.org/pinchartl/media.git v4l2/vsp1/tlb-optimise (Please note it has been compile-tested only) I have also taken

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:31 EEST Kieran Bingham wrote: > We are now able to configure a pipeline directly into a local display > list body. Take advantage of this fact, and create a cacheable body to > store the configuration of the pipeline in the

Re: [PATCH v7 7/8] media: vsp1: Adapt entities to configure into a body

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:30 EEST Kieran Bingham wrote: > Currently the entities store their configurations into a display list. > Adapt this such that the code can be configured into a body directly, > allowing greater flexibility and control of the

Re: [PATCH v7 6/8] media: vsp1: Refactor display list configure operations

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:29 EEST Kieran Bingham wrote: > The entities provide a single .configure operation which configures the > object into the target display list, based on the vsp1_entity_params > selection. > > This restricts us to a single

Re: [PATCH v7 5/8] media: vsp1: Use reference counting for bodies

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:28 EEST Kieran Bingham wrote: > Extend the display list body with a reference count, allowing bodies to > be kept as long as a reference is maintained. This provides the ability > to keep a cached copy of bodies which will not

Re: [PATCH v7 4/8] media: vsp1: Convert display lists to use new body pool

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:27 EEST Kieran Bingham wrote: > Adapt the dl->body0 object to use an object from the body pool. This > greatly reduces the pressure on the TLB for IPMMU use cases, as all of > the lists use a single allocation for the main body.

Re: [PATCH v7 3/8] media: vsp1: Provide a body pool

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:26 EEST Kieran Bingham wrote: > Each display list allocates a body to store register values in a dma > accessible buffer from a dma_alloc_wc() allocation. Each of these > results in an entry in the TLB, and a large number of

Re: [PATCH v7 1/8] media: vsp1: Reword uses of 'fragment' as 'body'

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:24 EEST Kieran Bingham wrote: > Throughout the codebase, the term 'fragment' is used to represent a > display list body. This term duplicates the 'body' which is already in > use. > > The datasheet references these objects as a

[PATCH 3/3] arm64: dts: renesas: condor: add PCIe support

Enable PCIe PHY and PCIEC and specify the PCIe bus clock for the Condor board. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 12 1 file changed, 12 insertions(+) Index:

[PATCH 2/3] arm64: dts: renesas: r8a77980: add PCIEC support

Describe PCIEC and PCIe bus clock in the R8A77980 device tree. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 39 ++ 1 file changed, 39 insertions(+) Index:

[PATCH 1/3] arm64: dts: renesas: r8a77980: add PCIe PHY support

Describe the PCIe PHY in the R8A77980 device tree; it will be used by PCIEC in the next patch... Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 50 ++ 1 file changed, 50 insertions(+) Index:

[PATCH 0/3] Add R8A77980/Condor PCIe support

Hello! Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180330-v4.16-rc7' tag. We're adding the R8A77980 PCIe related device nodes and then enable PCIe on the Condor board. These patches depend on the R8A77980 PCIe PHY and PCIEC driver support in order to

[PATCH v2.1 09/15] v4l: vsp1: Move DRM pipeline output setup code to a function

In order to make the vsp1_du_setup_lif() easier to read, and for symmetry with the DRM pipeline input setup, move the pipeline output setup code to a separate function. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

[PATCH v2.1 06/15] v4l: vsp1: Move DRM atomic commit pipeline setup to separate function

The DRM pipeline setup code used at atomic commit time is similar to the setup code used when enabling the pipeline. Move it to a separate function in order to share it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

[PATCH v5 1/3] ARM: dts: r8a7790: Convert to new LVDS DT bindings

The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") Fixes: 4bdb7aa7dcd0 ("ARM: dts: r8a7790: add soc node") Signed-off-by: Laurent Pinchart

[PATCH v5 3/3] ARM: dts: r8a7793: Convert to new LVDS DT bindings

The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") Fixes: bff8f8c2feb7 ("ARM: dts: r8a7793: add soc node") Signed-off-by: Laurent Pinchart

[PATCH v5 2/3] ARM: dts: r8a7791: Convert to new LVDS DT bindings

The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") Fixes: bb21803ea440 ("ARM: dts: r8a7791: add soc node") Signed-off-by: Laurent Pinchart

[PATCH v5 0/3] R-Car DU: Fix LVDS output on Gen2 boards

Hello, This patch series fixes LVDS output support on the Lager, Koelsh, Porter and Gose boards that broke in v4.17-rc1 due to the combination of the R-Car DU LVDS driver rework and the DT move of all on-SoC peripherals to a /soc node. We could handle the problem in the R-Car DU LVDS DT backward

Re: [PATCH v2 11/15] v4l: vsp1: Add per-display list internal completion notification support

Hi Laurent, On 05/04/18 10:18, Laurent Pinchart wrote: > Display list completion is already reported to the frame end handler, > but that mechanism is global to all display lists. In order to implement > BRU and BRS reassignment in DRM pipelines we will need to commit a > display list and wait

Re: [PATCH v2 09/15] v4l: vsp1: Move DRM pipeline output setup code to a function

Hi Laurent, Thanks for the updates On 05/04/18 10:18, Laurent Pinchart wrote: > In order to make the vsp1_du_setup_lif() easier to read, and for > symmetry with the DRM pipeline input setup, move the pipeline output > setup code to a separate function. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 10/15] v4l: vsp1: Turn frame end completion status into a bitfield

Hi Laurent, Thanks for this enhancement. On 05/04/18 10:18, Laurent Pinchart wrote: > We will soon need to return more than a boolean completion status from > the vsp1_dlm_irq_frame_end() IRQ handler. Turn the return value into a > bitfield to prepare for that. No functional change is introduced

Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

Hi Jacopo, (CC'ing Mark Brown) On Friday, 6 April 2018 17:25:58 EEST jacopo mondi wrote: > On Fri, Apr 06, 2018 at 04:15:35PM +0300, Laurent Pinchart wrote: > > On Friday, 6 April 2018 15:41:56 EEST Jacopo Mondi wrote: > >> Document Thine THC63LVD1024 LVDS decoder device tree bindings. > >> >

Re: [PATCH 1/7] arm64: dts: renesas: r8a77970: add FCPVD support

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:06 EEST Jacopo Mondi wrote: > From: Sergei Shtylyov > > Describe FCPVD0 in the R8A77970 device tree; it will be used by VSPD0 in > the next patch... > > Based on the original (and large)

Re: [PATCH 3/7] arm64: dts: renesas: r8a77970: add DU support

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:08 EEST Jacopo Mondi wrote: > From: Sergei Shtylyov > > Define the generic R8A77970 part of the DU device node. > > Based on the original (and large) patch by Daisuke Matsushita >

Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

Hi Laurent, On Fri, Apr 06, 2018 at 04:15:35PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Friday, 6 April 2018 15:41:56 EEST Jacopo Mondi wrote: > > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > > > Signed-off-by: Jacopo Mondi

Re: [PATCH 4/7] arm64: dts: renesas: r8a77970: add the LVDS instance

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:09 EEST Jacopo Mondi wrote: > From: Niklas Söderlund > > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > the it to the LVDS output of the DU. While at it align the

Re: [PATCH 7/7] arm64: dts: renesas: eagle: Add ADV7511W and HDMI output

Hi Laurent, On Fri, Apr 06, 2018 at 04:51:11PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Friday, 6 April 2018 16:08:12 EEST Jacopo Mondi wrote: > > From: Niklas Söderlund > > > > Enable HDMI output adding the HDMI

Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge

Hi Laurent, On Fri, Apr 06, 2018 at 04:53:43PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > > Hello, > >this series enables HDMI display on V3M Eagle board. > > > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16"

RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs

Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Thursday, April 5, 2018 1:45 AM > > From: Wolfram Sang > > Early revisions of certain SoCs cannot do multiple DMA RX streams in > parallel. To avoid data corruption, only allow one DMA RX

RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: use more generic whitelisting

Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Friday, April 6, 2018 1:42 AM > > From: Wolfram Sang > > Whitelisting every ES version does not scale. So, we whitelist whole > SoCs independent of ES version. If we need specific handling

RE: [PATCH] pwm: rcar: simplify getting .drvdata

Hi Wolfram-san, > From: Wolfram Sang, Sent: Friday, April 6, 2018 2:26 AM > > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Only build tested. Fixed

RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Thursday, April 5, 2018 2:01 AM > > From: Wolfram Sang > > If we detect an incompatible scatterlist, we should fall back to PIO, > too. > > Signed-off-by: Wolfram Sang

Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge

Hi Jacopo, On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > THC63LVD1024 driver on top (cfr. my in review series: > "[PATCH v7 0/2] drm: Add

Re: [PATCH 7/7] arm64: dts: renesas: eagle: Add ADV7511W and HDMI output

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:12 EEST Jacopo Mondi wrote: > From: Niklas Söderlund > > Enable HDMI output adding the HDMI connector and the ADV7511W, connected > to THC63LVD1024 LVDS decoder output. > > Signed-off-by:

Re: [PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:11 EEST Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > decoder, connected to the on-chip LVDS encoder output on one side > and to the not-yet-described HDMI encoder ADV7511W on the other

Re: [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:10 EEST Jacopo Mondi wrote: > Enable DU for Renesas R-Car V3M Eagle board. > > Signed-off-by: Jacopo Mondi > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 11 +++ > 1 file changed, 11

Re: [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU

Hi again, On Friday, 6 April 2018 16:45:16 EEST Laurent Pinchart wrote: > On Friday, 6 April 2018 16:08:10 EEST Jacopo Mondi wrote: > > Enable DU for Renesas R-Car V3M Eagle board. > > > > Signed-off-by: Jacopo Mondi > > --- > > > >

Re: [PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support

On Friday, 6 April 2018 16:08:07 EEST Jacopo Mondi wrote: > From: Sergei Shtylyov > > Describe VSPD0 in the R8A77970 device tree; it will be used by DU in > the next patch... > > Based on the original (and large) patch by Daisuke Matsushita >

Re: [PATCH v7 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 15:41:57 EEST Jacopo Mondi wrote: > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > output converter. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Andrzej Hajda

Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge

Sorry for the mess subject should have been Subject: [PATCH 0/7] V3M-Eagle display enablement I copied the wrong one from another cover letter... On Fri, Apr 06, 2018 at 03:08:05PM +0200, Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series

Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 15:41:56 EEST Jacopo Mondi wrote: > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Andrzej Hajda > Reviewed-by: Niklas

[PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support

From: Sergei Shtylyov Describe VSPD0 in the R8A77970 device tree; it will be used by DU in the next patch... Based on the original (and large) patch by Daisuke Matsushita . Signed-off-by: Vladimir Barinov

[PATCH 1/7] arm64: dts: renesas: r8a77970: add FCPVD support

From: Sergei Shtylyov Describe FCPVD0 in the R8A77970 device tree; it will be used by VSPD0 in the next patch... Based on the original (and large) patch by Daisuke Matsushita . Signed-off-by: Vladimir Barinov

[PATCH 4/7] arm64: dts: renesas: r8a77970: add the LVDS instance

From: Niklas Söderlund Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect the it to the LVDS output of the DU. While at it align the endpoint name of the du to du_out_lvds0 which is used in other Renesas DTS files to describe this link.

[PATCH 3/7] arm64: dts: renesas: r8a77970: add DU support

From: Sergei Shtylyov Define the generic R8A77970 part of the DU device node. Based on the original (and large) patch by Daisuke Matsushita . Signed-off-by: Vladimir Barinov

[PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder

The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS decoder, connected to the on-chip LVDS encoder output on one side and to the not-yet-described HDMI encoder ADV7511W on the other one. As the decoder does not need any configuration it has been so-far omitted from DTS. Now that a

[PATCH 7/7] arm64: dts: renesas: eagle: Add ADV7511W and HDMI output

From: Niklas Söderlund Enable HDMI output adding the HDMI connector and the ADV7511W, connected to THC63LVD1024 LVDS decoder output. Signed-off-by: Niklas Söderlund Signed-off-by: Jacopo Mondi

[PATCH 5/7] arm64: dts: renesas: eagle: Enable DU

Enable DU for Renesas R-Car V3M Eagle board. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts

[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge

Hello, this series enables HDMI display on V3M Eagle board. The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with THC63LVD1024 driver on top (cfr. my in review series: "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") This series includes some preliminary

[PATCH v7 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver

Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel output converter. Signed-off-by: Jacopo Mondi Reviewed-by: Andrzej Hajda Reviewed-by: Niklas Söderlund ---

[PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

Document Thine THC63LVD1024 LVDS decoder device tree bindings. Signed-off-by: Jacopo Mondi Reviewed-by: Andrzej Hajda Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge

Hello, this new version moves the driver and its bindings to use semi-standard names for powerdown and output enable GPIOs, as result of the discussion with Laurent, Vladimir and Rob. I kept the actual pin names in the bindings description for reference, even if there are no huge ambiguities

Re: [PATCH 0/4] Add R8A77980 PCIe support & some driver cleanups

On 04/06/2018 01:58 PM, Sergei Shtylyov wrote: > Hello! > > Here's a set of 4 patches against the 'pci.rcar' branch of Lorenzo Pieralisi's I meant to type 'pci/rcar'. :-) [...] MBR, Sergei

[PATCH 4/4] pcie-rcar: factor out rcar_pcie_hw_init() call

We now have rcar_pcie_hw_init_{h1|gen2|gen3}() differing only in the PCIe PHY init code and all ending with a call to rcar_pcie_hw_init(), thus it makes sense to move that call into the driver's probe() method and then rename those functions to rcar_pcie_phy_init_{h1|gen2|gen3}() -- doing this

[PATCH 3/4] pcie-rcar: add R-Car gen3 PHY support

On R-Car gen3 SoCs the PCIe PHY has its own register region -- and I have written a generic PHY driver for it, thus we need to add the corresponding code in rcar_pcie_hw_init_gen3() and call devm_phy_optional_get() at the driver's probing time, so that the existing R-Car gen3 device trees (not

[PATCH 2/4] pcie-rcar: remove PHYRDY polling from rcar_pcie_hw_init_h1()

Now that we've added PCIEPHYSR.PHYRDY polling to rcar_pcie_hw_init(), there is no need anymore for polling the PHY specific register in rcar_pcie_hw_init_h1() -- remove it. Signed-off-by: Sergei Shtylyov --- drivers/pci/host/pcie-rcar.c | 12 +---

[PATCH 1/4] pcie-rcar: poll PHYRDY in rcar_pcie_hw_init()

In all the R-Car gen1/2/3 manuals, we are instructed to poll PCIEPHYSR for PHYRDY=1 at an early stage of the PCIEC initialization -- while the driver only does this on R-Car H1 (polling a PHY specific register). Add the PHYRDY polling to rcar_pcie_hw_init(). Note that without the special PHY

[PATCH 0/4] Add R8A77980 PCIe support & some driver cleanups

Hello! Here's a set of 4 patches against the 'pci.rcar' branch of Lorenzo Pieralisi's 'pci.git' repo. These are the changes needed for better R-Car gen3 support (namely for R8A77980 support) plus some PCIe driver re-factoring done in the process... [1/4] pcie-rcar: poll PHYRDY in

RE: [PATCH] gpio: dwapb: Add support for 32 interrupts

Hi Geert, On 06 April 2018 10:57 Geert Uytterhoeven wrote: > On Thu, Apr 5, 2018 at 11:42 AM, Phil Edworthy wrote: > > On 30 March 2018 22:26 Andy Shevchenko wrote: > >> On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote: > >> > The DesignWare GPIO IP can be configured for either 1 or 32 > >> >

Re: [PATCH] gpio: dwapb: Add support for 32 interrupts

Hi Phil, On Thu, Apr 5, 2018 at 11:42 AM, Phil Edworthy wrote: > On 30 March 2018 22:26 Andy Shevchenko wrote: >> On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote: >> > The DesignWare GPIO IP can be configured for either 1 or 32 >> > interrupts, >> >> 1 to 32, or