[PATCH v3 2/2] dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status

2019-04-11 Thread Dirk Behme
increase of the residue. Fix this by introducing a 'safe read' logic. Fixes: 73a47bd0da66 ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue") Signed-off-by: Achim Dahlhoff Signed-off-by: Dirk Behme Cc: # v4.16+ --- Note: Patch done against mainline v5.0 Changes in v

[PATCH v3 1/2] dmaengine: sh: rcar-dmac: With cyclic DMA residue 0 is valid

2019-04-11 Thread Dirk Behme
tatus") Signed-off-by: Dirk Behme Signed-off-by: Achim Dahlhoff Signed-off-by: Hiroyuki Yokoyama Signed-off-by: Yao Lihua Cc: # v4.8+ --- Note: Patch done against mainline v5.0 Changes in v2: None Changes in v3: Move reading rchan into the spin lock protection. drivers/dma/sh/rcar-

Re: [PATCH v2 2/2] dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status

2019-04-01 Thread Dirk Behme
Hi Renesas SoC team, On 05.03.2019 06:56, Dirk Behme wrote: From: Achim Dahlhoff The tx_status poll in the rcar_dmac driver reads the status register which indicates which chunk is busy (DMACHCRB). Afterwards the point inside the chunk is read from DMATCRB. It is possible that the chunk has

Re: [PATCH] serial: sh-sci: Fix HSCIF RX sampling point adjustment

2019-03-31 Thread Dirk Behme
tterhoeven Acked-by: Dirk Behme --- drivers/tty/serial/sh-sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 060fcd42b6d56010..2bdaeba5d527a6ce 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/seria

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-31 Thread Dirk Behme
Hi Geert, On 29.03.2019 14:00, Geert Uytterhoeven wrote: Hi Dirk, On Fri, Mar 29, 2019 at 1:13 PM Dirk Behme wrote: On 29.03.2019 10:46, Geert Uytterhoeven wrote: On Fri, Mar 29, 2019 at 8:05 AM Dirk Behme wrote: On 28.03.2019 12:30, Dirk Behme wrote: On 28.03.2019 11:16, Dirk Behme

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-29 Thread Dirk Behme
On 29.03.2019 10:46, Geert Uytterhoeven wrote: Hi Dirk, On Fri, Mar 29, 2019 at 8:05 AM Dirk Behme wrote: On 28.03.2019 12:30, Dirk Behme wrote: On 28.03.2019 11:16, Dirk Behme wrote: On 28.03.2019 10:24, Geert Uytterhoeven wrote: On Wed, Mar 27, 2019 at 7:36 PM Eugeniu Rosca wrote

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-29 Thread Dirk Behme
On 29.03.2019 10:46, Ulrich Hecht wrote: On March 29, 2019 at 8:05 AM Dirk Behme wrote: Hi Geert, On 28.03.2019 12:30, Dirk Behme wrote: On 28.03.2019 11:16, Dirk Behme wrote: * Testing the patch [5] - int shift = min(-8, max(7, deviation / 2)); + int shift = clamp(deviation / 2, -8, 7

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-29 Thread Dirk Behme
Hi Geert, On 28.03.2019 12:30, Dirk Behme wrote: On 28.03.2019 11:16, Dirk Behme wrote: Hi Geert, On 28.03.2019 10:24, Geert Uytterhoeven wrote: Hi Eugeniu, On Wed, Mar 27, 2019 at 7:36 PM Eugeniu Rosca wrote: We've recently switched from rcar-3.7.x to rcar-3.9.x [1] kernel and

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-28 Thread Dirk Behme
On 28.03.2019 11:16, Dirk Behme wrote: Hi Geert, On 28.03.2019 10:24, Geert Uytterhoeven wrote: Hi Eugeniu, On Wed, Mar 27, 2019 at 7:36 PM Eugeniu Rosca wrote: We've recently switched from rcar-3.7.x to rcar-3.9.x [1] kernel and the latter contains this patch [2] by virtue of rcar-

Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2019-03-28 Thread Dirk Behme
Hi Geert, On 28.03.2019 10:24, Geert Uytterhoeven wrote: Hi Eugeniu, On Wed, Mar 27, 2019 at 7:36 PM Eugeniu Rosca wrote: We've recently switched from rcar-3.7.x to rcar-3.9.x [1] kernel and the latter contains this patch [2] by virtue of rcar-3.9.0 commit [3], which mirrors v4.18-rc1 commit

[PATCH v2 1/2] dmaengine: sh: rcar-dmac: With cyclic DMA residue 0 is valid

2019-03-04 Thread Dirk Behme
tatus") Signed-off-by: Dirk Behme Signed-off-by: Achim Dahlhoff Signed-off-by: Hiroyuki Yokoyama Cc: # v4.8+ --- Note: Patch done against mainline v5.0 Changes in v2: None drivers/dma/sh/rcar-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sh/rca

[PATCH 2/2] dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status

2019-03-04 Thread Dirk Behme
increase of the residue. Fix this by introducing a 'safe read' logic. Fixes: 73a47bd0da66 ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue") Signed-off-by: Achim Dahlhoff Signed-off-by: Dirk Behme Cc: # v4.16+ --- Note: Patch done against mainline v5.0 Changes in v

[PATCH 1/2] dmaengine: sh: rcar-dmac: With cyclic DMA residue 0 is valid

2019-03-04 Thread Dirk Behme
tatus") Signed-off-by: Dirk Behme Signed-off-by: Achim Dahlhoff Signed-off-by: Hiroyuki Yokoyama Cc: # v4.8+ --- Note: Patch done against mainline v5.0 drivers/dma/sh/rcar-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/d

[PATCH 2/2] dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status

2019-03-04 Thread Dirk Behme
increase of the residue. Fix this by introducing a 'safe read' logic. Fixes: 73a47bd0da66 ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue") Signed-off-by: Achim Dahlhoff Signed-off-by: Dirk Behme Cc: # v4.16+ --- Note: Patch done against mainline v5.0 drivers/dma

Re: [PATCHv2 1/4] dmaengine: rcar-dmac: use result of updated get_residue in tx_status

2019-01-15 Thread Dirk Behme
On 30.06.2016 17:15, Niklas Söderlund wrote: From: Muhammad Hamza Farooq The hardware might have complete the transfer but the interrupt handler might not have had a chance to run. If rcar_dmac_chan_get_residue() which reads HW registers finds that there is no residue return DMA_COMPLETE. Sign

Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2018-01-03 Thread Dirk Behme
On 03.01.2018 18:25, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Sep 7, 2017 at 11:12 AM, Geert Uytterhoeven wrote: On Thu, Sep 7, 2017 at 11:05 AM, Dirk Behme wrote: On 07.09.2017 10:59, Geert Uytterhoeven wrote: On Thu, Sep 7, 2017 at 10:42 AM, Dirk Behme wrote: On 07.09.2017 10:39

Re: Applied "spi: sh-msiof: Fix timeout failures for TX-only DMA transfers" to the spi tree

2018-01-03 Thread Dirk Behme
On 03.01.2018 18:44, Mark Brown wrote: The patch spi: sh-msiof: Fix timeout failures for TX-only DMA transfers has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git Would it make sense to forward this to -stable, too? Best regards Dir

Re: [PATCH] spi: sh-msiof: Fix DMA transfer size check

2017-11-02 Thread Dirk Behme
tterhoeven Acked-by: Dirk Behme --- v2 * Added Geert's Ack Sorry for letting this slip through the cracks, it appears to have been on my todo list for 1 year less 5 days. Thanks for picking it :) Best regards Dirk P.S.: The remaining msiof (DMA) patches are not forgotten, we are s

clk: r8a7795: Why to read EXTAL* from DT? (was: Re: [PATCH v6 5/5] clk: shmobile: r8a7795: Add new CPG/MSSR driver)

2017-10-24 Thread Dirk Behme
Hi Geert, today, I want to learn some history ;) On 12.11.2015 16:54, Geert Uytterhoeven wrote: Add a new R-Car H3 Clock Pulse Generator / Module Standby and Software Reset driver, using the new CPG/MSSR driver core. Signed-off-by: Geert Uytterhoeven --- ... diff --git a/drivers/clk/shmobil

Re: mainline 4.14-rc4: renesas_sdhi_internal_dmac ee100000.sd: swiotlb buffer is full?

2017-10-16 Thread Dirk Behme
Limiting the thread to Renesas only, again, to discuss the other issue: On 17.10.2017 06:51, Yoshihiro Shimoda wrote: Hi Linus-san, From: Linus Walleij, Sent: Monday, October 16, 2017 9:22 PM On Mon, Oct 16, 2017 at 2:07 PM, Geert Uytterhoeven wrote: On Mon, Oct 16, 2017 at 1:41 PM, Linus

Re: mainline 4.14-rc4: renesas_sdhi_internal_dmac ee100000.sd: swiotlb buffer is full?

2017-10-12 Thread Dirk Behme
On 12.10.2017 10:20, Dirk Behme wrote: On 11.10.2017 15:20, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Oct 11, 2017 at 2:57 PM, Dirk Behme wrote: On 11.10.2017 14:42, Geert Uytterhoeven wrote: On Wed, Oct 11, 2017 at 2:23 PM, Dirk Behme wrote: trying to boot recent mainline v4.14-rc4 on a

Re: mainline 4.14-rc4: renesas_sdhi_internal_dmac ee100000.sd: swiotlb buffer is full?

2017-10-11 Thread Dirk Behme
Hi Geert, On 11.10.2017 14:42, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Oct 11, 2017 at 2:23 PM, Dirk Behme wrote: trying to boot recent mainline v4.14-rc4 on a custom H3 ES2.0 board with rootfs on SD card I'm getting [1]. Last time I think I used v4.13 in the same environment and I

mainline 4.14-rc4: renesas_sdhi_internal_dmac ee100000.sd: swiotlb buffer is full?

2017-10-11 Thread Dirk Behme
Hi, trying to boot recent mainline v4.14-rc4 on a custom H3 ES2.0 board with rootfs on SD card I'm getting [1]. Last time I think I used v4.13 in the same environment and I think it worked fine, most probably because renesas_sdhi_internal_dmac wasn't there, yet ;) I checked renesas-drivers

Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2017-09-07 Thread Dirk Behme
On 07.09.2017 10:59, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Sep 7, 2017 at 10:42 AM, Dirk Behme wrote: On 07.09.2017 10:39, Geert Uytterhoeven wrote: On Thu, Sep 7, 2017 at 10:33 AM, Dirk Behme wrote: On 07.09.2017 10:31, Geert Uytterhoeven wrote: On Wed, Sep 6, 2017 at 9:05 AM, Dirk

Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2017-09-07 Thread Dirk Behme
On 07.09.2017 10:39, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Sep 7, 2017 at 10:33 AM, Dirk Behme wrote: On 07.09.2017 10:31, Geert Uytterhoeven wrote: On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Hiromitsu Yamasaki DMA supports 32-bit words only, even if BITLEN1 of SITMDR2

Re: [PATCH 4/8] spi: sh-msiof: Fix DMA completion

2017-09-07 Thread Dirk Behme
On 07.09.2017 10:33, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Ryo Kataoka When reception DMA completes before transmission DMA, next transmission DMA may not be able to start. This patch adds wait_for_completion_timeout() to both of

Re: [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2017-09-07 Thread Dirk Behme
On 07.09.2017 10:31, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Hiromitsu Yamasaki DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi

Re: [PATCH 1/8] spi: sh-msiof: Add sleep before master transfer for test

2017-09-07 Thread Dirk Behme
On 07.09.2017 10:11, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Hiromitsu Yamasaki This patch is for debug of transfer between master and slave. Since the slave needs to complete a preparation in data transfer before the master working, the

Re: [PATCH 1/8] spi: sh-msiof: Add sleep before master transfer for test

2017-09-07 Thread Dirk Behme
On 07.09.2017 09:04, Vladimir Zapolskiy wrote: Hi Dirk, On 09/06/2017 10:05 AM, Dirk Behme wrote: From: Hiromitsu Yamasaki This patch is for debug of transfer between master and slave. Since the slave needs to complete a preparation in data transfer before the master working, the sleep wait

Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC

2017-09-06 Thread Dirk Behme
On 06.09.2017 12:42, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme wrote: On 06.09.2017 11:22, Geert Uytterhoeven wrote: On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Ryo Kataoka MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.

Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC

2017-09-06 Thread Dirk Behme
On 06.09.2017 11:22, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme wrote: From: Ryo Kataoka MSIOF Base Address H'E6xx can be accessed by CPU and DMAC. MSIOF Base Address H'E7xx for DMAC was removed from H/W manual. Signed-off-by: Ryo Kataoka Sig

[PATCH 1/8] spi: sh-msiof: Add sleep before master transfer for test

2017-09-06 Thread Dirk Behme
From: Hiromitsu Yamasaki This patch is for debug of transfer between master and slave. Since the slave needs to complete a preparation in data transfer before the master working, the sleep wait is put before the data transfer of the master. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk

[PATCH 5/8] spi: sh-msiof: Wait for Tx FIFO empty after DMA

2017-09-06 Thread Dirk Behme
From: Hiromitsu Yamasaki When Tx DMA is only used, Tx FIFO is still not empty after DMA callback. This patch waits for sweeping data out of the Tx FIFO. Signed-off-by: Hiromitsu Yamasaki [adjust context] Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 13 - 1 file

[PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC

2017-09-06 Thread Dirk Behme
From: Ryo Kataoka MSIOF Base Address H'E6xx can be accessed by CPU and DMAC. MSIOF Base Address H'E7xx for DMAC was removed from H/W manual. Signed-off-by: Ryo Kataoka Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 5 + 1 file

[PATCH 8/8] spi: sh-msiof: Add registers reset

2017-09-06 Thread Dirk Behme
From: Hiromitsu Yamasaki Reset register before starting transfer. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c

[PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check

2017-09-06 Thread Dirk Behme
From: Hiromitsu Yamasaki DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sh-msiof.c b

[PATCH 6/8] spi: sh-msiof: Add MSIOF parent clock changing function for R-Car Gen3

2017-09-06 Thread Dirk Behme
From: Hiromitsu Yamasaki Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index a960e8da123d..2c53fc3f73af 100644 --- a

[PATCH 4/8] spi: sh-msiof: Fix DMA completion

2017-09-06 Thread Dirk Behme
of DMA Engine may be still processing. Signed-off-by: Ryo Kataoka [reword commit message] Signed-off-by: Hiromitsu Yamasaki [adjust context] Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 53 +++--- 1 file changed, 36 insertions(+), 17

[PATCH 0/8] spi: sh-msiof: Import some BSP patches

2017-09-06 Thread Dirk Behme
Pick some patches and fixes from Renesas v4.9/rcar-3.5.8 BSP to make spi on RCar3 more reliably. Patches are done against renesas-drivers-2017-09-05-v4.13. Should we consider spi: sh-msiof: Fix DMA transfer size check spi: sh-msiof: Fix MSIOF address for DMAC for -stable? Both have been introd

[PATCH 7/8] spi: sh-msiof: Fix gpio function

2017-09-06 Thread Dirk Behme
0 { ... reg = <0>; ... }; spidev@1 { ... reg = <1>; ... }; }; Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Dirk Behme --- drivers/spi/spi-sh-msiof.c | 9 +++-- 1 file

[PATCH] pinctrl: sh-pfc: r8a7795: Re-add DRIF support

2017-08-30 Thread Dirk Behme
rt for R-Car H3 ES2.0"). As the DRIF doesn't differ, re-add it here. Signed-off-by: Dirk Behme --- Patch based on sh-pfc-for-v4.14-tag1 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 291 +++ 1 file changed, 291 insertions(+) diff --git a/drivers/pinctr

Re: clk: renesas: rcar-gen3: Status of Z* clocks?

2017-08-29 Thread Dirk Behme
On 30.08.2017 08:48, Simon Horman wrote: On Tue, Aug 29, 2017 at 12:36:50PM +0200, Dirk Behme wrote: On 29.08.2017 11:44, Geert Uytterhoeven wrote: Hi Dirk, On Tue, Aug 29, 2017 at 11:15 AM, Dirk Behme wrote: But ZG and with this module clock #112 is still missing, no? https

Re: clk: renesas: rcar-gen3: Status of Z* clocks?

2017-08-29 Thread Dirk Behme
On 29.08.2017 11:44, Geert Uytterhoeven wrote: Hi Dirk, On Tue, Aug 29, 2017 at 11:15 AM, Dirk Behme wrote: But ZG and with this module clock #112 is still missing, no? https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?h=v4.9/rcar-3.5.8&id=aa7b99b06d280e4

Re: clk: renesas: rcar-gen3: Status of Z* clocks?

2017-08-29 Thread Dirk Behme
On 29.08.2017 10:01, Geert Uytterhoeven wrote: Hi Dirk, On Tue, Aug 29, 2017 at 9:51 AM, Dirk Behme wrote: as mentioned previously since ages I'm back looking at the RCar3 status in recent mainline (4.13-rc7). While doing so, it looks to me that some Z* clock patches from recent BSP

spi: sh-msiof: Status of fixes from BSP?

2017-08-29 Thread Dirk Behme
Hi, as mentioned previously since ages I'm back looking at the RCar3 status in recent mainline (4.13-rc7). While doing so, it looks to me that some msiof fixes from recent BSP https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.9/rcar-3.5.8 are not in mainline, ye

clk: renesas: rcar-gen3: Status of Z* clocks?

2017-08-29 Thread Dirk Behme
Hi, as mentioned previously since ages I'm back looking at the RCar3 status in recent mainline (4.13-rc7). While doing so, it looks to me that some Z* clock patches from recent BSP https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.9/rcar-3.5.8 are not in mainlin

Re: Status of r8a7795 SDHI support?

2017-08-22 Thread Dirk Behme
On 22.08.2017 08:56, Wolfram Sang wrote: I'm not an expert on this, does SDR104 need 1.8V? To my understanding, sd-uhs-sdr50 is the max speed for 3.3V? Nope, everything with SDR* needs 1.8V. So, classic "highspeed" is the maximum for your slot. I ask because on my custom board the hardware

[PATCH v2] pinctrl: sh-pfc: r8a7795: Add SDHIx support

2017-08-22 Thread Dirk Behme
Add SDHIx support for ES2.0. Taken from the Renesas BSP https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/tree/drivers/pinctrl/sh-pfc/pfc-r8a7795.c Signed-off-by: Dirk Behme --- Note: Patch is generated against renesas-drivers-2017-08-16-v4.13-rc5 Changes in v2: Fix a typo

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Dirk Behme
On 21.08.2017 15:47, Wolfram Sang wrote: It works, now :) Great! tmio_mmc_init_ocr() fails (silently!). And with this the whole RCar3 SDHI, without any error message. I'll check next week about an error message there. Many thanks for your help! You're welcome. If you want, you can ev

[PATCH] pinctrl: sh-pfc: r8a7795: Add SDHIx support

2017-08-21 Thread Dirk Behme
Add SDHIx support for ES2.0. Taken from the Renesas BSP https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/tree/drivers/pinctrl/sh-pfc/pfc-r8a7795.c Signed-off-by: Dirk Behme --- Note: Patch is generated against renesas-drivers-2017-08-16-v4.13-rc5 drivers/pinctrl/sh-pfc

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Dirk Behme
On 21.08.2017 10:24, Dirk Behme wrote: On 21.08.2017 10:18, Wolfram Sang wrote: Hi Dirk, Ah, ES2.0. That's the missing information. Yup, is on the todo-list. I will try to test your patch on my Salvator-XS board today. Ok, thanks :) Your patch on top of v4.13-rc5 makes SDHI work

Re: Status of r8a7795 SDHI support?

2017-08-21 Thread Dirk Behme
On 21.08.2017 10:18, Wolfram Sang wrote: Hi Dirk, Ah, ES2.0. That's the missing information. Yup, is on the todo-list. I will try to test your patch on my Salvator-XS board today. Ok, thanks :) Your patch on top of v4.13-rc5 makes SDHI work on my Salvator-XS with a Please feel free to fo

Re: Status of r8a7795 SDHI support?

2017-08-18 Thread Dirk Behme
On 18.08.2017 11:00, Wolfram Sang wrote: What's the status of SDHI support in mainline and/or renesas-drivers (renesas-drivers-2017-08-16-v4.13-rc5)? I use it daily here, even with SDR104 enabled. On ES2.0? I wonder how if not even the pinmux is there ;) Ah, ES2.0. That's the missing info

Re: Status of r8a7795 SDHI support?

2017-08-17 Thread Dirk Behme
On 17.08.2017 09:29, Wolfram Sang wrote: What's the status of SDHI support in mainline and/or renesas-drivers (renesas-drivers-2017-08-16-v4.13-rc5)? I use it daily here, even with SDR104 enabled. On ES2.0? I wonder how if not even the pinmux is there ;) sdhci-pltfm: SDHCI platform and

Re: Status of r8a7795 SDHI support?

2017-08-17 Thread Dirk Behme
On 17.08.2017 09:48, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Aug 17, 2017 at 9:44 AM, Dirk Behme wrote: On 17.08.2017 09:33, Geert Uytterhoeven wrote: On Thu, Aug 17, 2017 at 9:23 AM, Dirk Behme wrote: since ages I tried recent mainline (v4.13-rc5) on a custom r8a7795 board. R-Car H3

Re: Status of r8a7795 SDHI support?

2017-08-17 Thread Dirk Behme
On 17.08.2017 09:33, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Aug 17, 2017 at 9:23 AM, Dirk Behme wrote: since ages I tried recent mainline (v4.13-rc5) on a custom r8a7795 board. R-Car H3 ES1.x or ES2.0? ES2.0 I tried with the attachment and picked some patches from renesas-drivers

Status of r8a7795 SDHI support?

2017-08-17 Thread Dirk Behme
F driver helper hidraw: raw HID events driver (C) Jiri Kosina NET: Registered protocol family 17 ... From ae0ba44723548f835824ad8f2f96dd971cfedb0f Mon Sep 17 00:00:00 2001 From: Dirk Behme Date: Thu, 17 Aug 2017 08:02:14 +0200 Subject: [PATCH] pinctrl: sh-pfc: r8a7795: Add SDHIx support Taken from

Re: Clocks used by another OS/CPU (was: Re: [RFC PATCH] clk: renesas: cpg-mssr: Add interface for critical core clocks)

2017-07-01 Thread Dirk Behme
On 01.07.2017 20:14, Uwe Kleine-König wrote: Hello, On Sat, Jul 01, 2017 at 07:02:48AM +0200, Dirk Behme wrote: On 30.06.2017 22:24, Uwe Kleine-König wrote: Hello, On Fri, Jun 30, 2017 at 10:58:26AM -0500, Rob Herring wrote: TL;DR: Clocks may be in use by another CPU not running Linux

Re: Clocks used by another OS/CPU (was: Re: [RFC PATCH] clk: renesas: cpg-mssr: Add interface for critical core clocks)

2017-06-30 Thread Dirk Behme
to start a Linux kernel on a Cortex-M companion to a Cortex-A. On Mon, Jun 26, 2017 at 1:30 PM, Dirk Behme wrote: With commit 72f5df2c2bbb6 ("clk: renesas: cpg-mssr: Migrate to CLK_IS_CRITICAL") we are able to handle critical module clocks. Introduce the same logic for critical c

Re: Clocks used by another OS/CPU

2017-06-29 Thread Dirk Behme
On 29.06.2017 13:18, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 29, 2017 at 12:28 PM, Dirk Behme wrote: On 29.06.2017 11:27, Geert Uytterhoeven wrote: CC clock, ARM, DT, PM people TL;DR: Clocks may be in use by another CPU not running Linux, while Linux disables them as being unused

Re: Clocks used by another OS/CPU

2017-06-29 Thread Dirk Behme
On 29.06.2017 14:45, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 29, 2017 at 2:07 PM, Dirk Behme wrote: On 29.06.2017 13:56, Geert Uytterhoeven wrote: On Thu, Jun 29, 2017 at 11:27 AM, Geert Uytterhoeven wrote: CC clock, ARM, DT, PM people TL;DR: Clocks may be in use by another CPU not

Re: Clocks used by another OS/CPU

2017-06-29 Thread Dirk Behme
On 29.06.2017 13:56, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 29, 2017 at 11:27 AM, Geert Uytterhoeven wrote: CC clock, ARM, DT, PM people TL;DR: Clocks may be in use by another CPU not running Linux, while Linux disables them as being unused. Of course this is not limited to clocks,

Re: Clocks used by another OS/CPU (was: Re: [RFC PATCH] clk: renesas: cpg-mssr: Add interface for critical core clocks)

2017-06-29 Thread Dirk Behme
On 29.06.2017 11:27, Geert Uytterhoeven wrote: Hi Dirk, CC clock, ARM, DT, PM people TL;DR: Clocks may be in use by another CPU not running Linux, while Linux disables them as being unused. On Mon, Jun 26, 2017 at 1:30 PM, Dirk Behme wrote: With commit 72f5df2c2bbb6 ("clk: renesas: cpg

[RFC PATCH] clk: renesas: cpg-mssr: Add interface for critical core clocks

2017-06-26 Thread Dirk Behme
With commit 72f5df2c2bbb6 ("clk: renesas: cpg-mssr: Migrate to CLK_IS_CRITICAL") we are able to handle critical module clocks. Introduce the same logic for critical core clocks. Signed-off-by: Dirk Behme --- Commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.

Re: [RFC 0/2] mmc: sdhi: make use of CBSY

2017-04-29 Thread Dirk Behme
On 29.04.2017 11:55, Wolfram Sang wrote: Hi Dirk, Checking the recent kernel [1] it seems to me that this changes never made it into mainline. Does anybody remember why and/or the history? As for Ulf, it was RFC, so no urge to pick it up. As for me, I was waiting for more feedback and then i

Re: [RFC 0/2] mmc: sdhi: make use of CBSY

2017-04-28 Thread Dirk Behme
Hi, On 26.01.2016 12:46, Wolfram Sang wrote: Honestly, I still think this is a micro-optimization: Assuming SCLKDIVEN is basically CBSY plus 8 SD clock cycles, then we'd save in the best case (SD clock is slowest, 24 MHz) around 333ns while we are polling with 1 us granularity... However, in ca

Re: [PATCH/RFC 4/4] soc: renesas: Identify SoC and register with the SoC bus

2016-10-05 Thread Dirk Behme
Hi Geert, I've been offline some weeks, so sorry if I'm not completely up to date, yet, or miss anything. Overall, having a quick look, the proposal in this patch series and your second series "arm64: renesas: r8a7795: R-Car H3 ES2.0 Prototype" looks nice to me. At least much better than enc

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-07-20 Thread Dirk Behme
Hi Simon, On 21.07.2016 01:51, Simon Horman wrote: On Wed, Jun 29, 2016 at 10:15:27AM +0200, Dirk Behme wrote: Hi Simon, ... Hmm, could you kindly help me to remember what's the recent status of your discussion above regarding a hierarchical structure of the RCar3 device trees? Hi

Re: [PATCH] clk: renesas: r8a7795: Fix SD clocks

2016-07-19 Thread Dirk Behme
0 0 Note that I still have a Salvator-X with a 16.67 MHz i.s.o. 33.33 Mhz crystal. Wolfram, Dirk: any comments? I think this has changed (corrected?) in the manual since 90c073e53909da85 ("clk: shmobile: r8a7795: Add SD divider support") Acked-by: Dirk Behme Best regards Dirk -

Re: [PATCH 3/3] arm64: dts: r8a7795: salvator: enable UHS for SDHI 0 & 3

2016-06-29 Thread Dirk Behme
Hi Wolfram, On 06.06.2016 18:08, Wolfram Sang wrote: From: Wolfram Sang Reviewed-by: Geert Uytterhoeven Signed-off-by: Wolfram Sang --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm64/b

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-06-29 Thread Dirk Behme
Hi Simon, On 27.05.2016 09:32, Dirk Behme wrote: Hi Simon, On 27.05.2016 02:42, Simon Horman wrote: On Thu, May 26, 2016 at 09:14:16AM +0200, Dirk Behme wrote: Hi Simon, On 26.05.2016 04:28, Simon Horman wrote: Hi Dirk, On Wed, May 25, 2016 at 07:10:26AM +0200, Dirk Behme wrote: Hi Simon

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-06-29 Thread Dirk Behme
Hi Geert, On 10.06.2016 08:34, Dirk Behme wrote: Hi Geert, On 09.06.2016 10:54, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 9, 2016 at 10:31 AM, Dirk Behme wrote: On 07.06.2016 10:17, Geert Uytterhoeven wrote: On Tue, Jun 7, 2016 at 9:53 AM, Dirk Behme wrote: I think I just want to

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-06-29 Thread Dirk Behme
Hi Magnus, On 01.06.2016 07:19, Magnus Damm wrote: Hi Dirk, On Fri, May 27, 2016 at 4:56 PM, Dirk Behme wrote: On 27.05.2016 05:13, Magnus Damm wrote: I don't think anyone disagrees that it makes sense to be able to determine ES version during runtime. The questions in my mind are how

Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver

2016-06-10 Thread Dirk Behme
On 10.06.2016 09:58, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 2, 2016 at 7:42 AM, Dirk Behme wrote: +int __init rcar_rst_read_mode_pins(u32 *mode) Just a style issue: Is the string 'pins' in the function name still relevant? I.e. what's about just 'rcar_rst_re

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-06-09 Thread Dirk Behme
Hi Geert, On 09.06.2016 10:54, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 9, 2016 at 10:31 AM, Dirk Behme wrote: On 07.06.2016 10:17, Geert Uytterhoeven wrote: On Tue, Jun 7, 2016 at 9:53 AM, Dirk Behme wrote: I think I just want to discuss if we have a clever idea to further improve

Re: R-Car3: PFC: Where to do the pinmux/drvctrl?

2016-06-09 Thread Dirk Behme
Hi Geert, On 09.06.2016 11:20, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 9, 2016 at 10:58 AM, Dirk Behme wrote: On 09.06.2016 10:22, Geert Uytterhoeven wrote: On Thu, Jun 9, 2016 at 8:56 AM, Dirk Behme wrote: with the R-Car3, the pinmux/drvctrl is done at 3 places: 1. ARM trusted

Re: R-Car3: PFC: Where to do the pinmux/drvctrl?

2016-06-09 Thread Dirk Behme
Hi Geert, On 09.06.2016 10:22, Geert Uytterhoeven wrote: Hi Dirk, On Thu, Jun 9, 2016 at 8:56 AM, Dirk Behme wrote: with the R-Car3, the pinmux/drvctrl is done at 3 places: 1. ARM trusted firmware / IPL: https://github.com/renesas-rcar/meta-renesas/blob/jethro/meta-rcar-gen3/recipes-bsp

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-06-09 Thread Dirk Behme
Hi Geert, On 07.06.2016 10:17, Geert Uytterhoeven wrote: Hi Dirk, On Tue, Jun 7, 2016 at 9:53 AM, Dirk Behme wrote: I think I just want to discuss if we have a clever idea to further improve one detail. That is, if we have a clever idea to avoid the copy & paste between the family mem

R-Car3: PFC: Where to do the pinmux/drvctrl?

2016-06-08 Thread Dirk Behme
Hi, with the R-Car3, the pinmux/drvctrl is done at 3 places: 1. ARM trusted firmware / IPL: https://github.com/renesas-rcar/meta-renesas/blob/jethro/meta-rcar-gen3/recipes-bsp/arm-trusted-firmware/arm-trusted-firmware/0001-add-bl2-bl31-R-Car-support.patch#L8428 2. U-Boot: https://github.com/

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-06-07 Thread Dirk Behme
Hi Geert, On 06.06.2016 14:59, Geert Uytterhoeven wrote: Hi Dirk, On Mon, Jun 6, 2016 at 2:03 PM, Dirk Behme wrote: On 30.05.2016 18:36, Dirk Behme wrote: On 30.05.2016 18:28, Geert Uytterhoeven wrote: Add all R-Car M3-W Clock Pulse Generator Core Clock Outputs, as listed in Table 8.2b

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-06-06 Thread Dirk Behme
Hi Geert, On 30.05.2016 18:36, Dirk Behme wrote: Hi Geert, On 30.05.2016 18:28, Geert Uytterhoeven wrote: Add all R-Car M3-W Clock Pulse Generator Core Clock Outputs, as listed in Table 8.2b ("List of Clocks [R-Car M3-W]") of the R-Car Gen3 datasheet (rev. 0.51 + Errata for Rev051 M

Re: [PATCH/RFC v3 00/22] soc: renesas: Add R-Car RST driver for obtaining mode pin state

2016-06-01 Thread Dirk Behme
car-rst.c create mode 100644 include/linux/soc/renesas/rcar-rst.h Whole series: Acked-by: Dirk Behme Thanks! Dirk

Re: [PATCH/RFC v3 20/22] clk: renesas: r8a7778: Remove obsolete r8a7778_clocks_init()

2016-06-01 Thread Dirk Behme
On 01.06.2016 21:21, Geert Uytterhoeven wrote: The R-Car M1A board code no longer calls r8a7778_clocks_init(). Signed-off-by: Geert Uytterhoeven --- v3: - New. --- drivers/clk/renesas/clk-r8a7778.c | 13 - include/linux/clk/renesas.h | 1 - 2 files changed, 14 deletions(-)

Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver

2016-06-01 Thread Dirk Behme
On 01.06.2016 21:21, Geert Uytterhoeven wrote: Add a driver for the Renesas R-Car Gen1 RESET/WDT and R-Car Gen2/Gen3 RST module. For now this driver just provides an API to obtain the state of the mode pins, as latched at reset time. As this is typically called from the probe function of a cloc

Re: [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings

2016-06-01 Thread Dirk Behme
On 01.06.2016 21:20, Geert Uytterhoeven wrote: Add DT bindings for the Renesas R-Car Reset Controller (R-Car Gen1 RESET/WDT and R-Car Gen2/Gen3 RST). As the features provided by the hardware module differ a lot across the various SoC families and members, only SoC-specific compatible values are

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-06-01 Thread Dirk Behme
Hi Geert, On 01.06.2016 10:26, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Jun 1, 2016 at 9:38 AM, Dirk Behme wrote: Sorry, if that was unclear. I took the example and transferred it to R-Car3 where we have ES1 - ES3. So, taking this example, on R-Car3 we might end up with

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-06-01 Thread Dirk Behme
On 01.06.2016 10:40, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Jun 1, 2016 at 10:36 AM, Dirk Behme wrote: On 01.06.2016 10:26, Geert Uytterhoeven wrote: On Wed, Jun 1, 2016 at 9:38 AM, Dirk Behme wrote: Sorry, if that was unclear. I took the example and transferred it to R-Car3 where we

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-06-01 Thread Dirk Behme
Hi Geert, On 01.06.2016 09:27, Geert Uytterhoeven wrote: Hi Dirk, On Wed, Jun 1, 2016 at 9:19 AM, Dirk Behme wrote: On 01.06.2016 07:19, Magnus Damm wrote: On Fri, May 27, 2016 at 4:56 PM, Dirk Behme wrote: On 27.05.2016 05:13, Magnus Damm wrote: I don't think anyone disagrees th

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-06-01 Thread Dirk Behme
Hi Magnus, On 01.06.2016 07:19, Magnus Damm wrote: Hi Dirk, On Fri, May 27, 2016 at 4:56 PM, Dirk Behme wrote: On 27.05.2016 05:13, Magnus Damm wrote: I don't think anyone disagrees that it makes sense to be able to determine ES version during runtime. The questions in my mind are how

Re: [PATCH v2 2/4] clk: renesas: Add r8a7796 CPG Core Clock Definitions

2016-05-30 Thread Dirk Behme
Hi Geert, On 30.05.2016 18:28, Geert Uytterhoeven wrote: Add all R-Car M3-W Clock Pulse Generator Core Clock Outputs, as listed in Table 8.2b ("List of Clocks [R-Car M3-W]") of the R-Car Gen3 datasheet (rev. 0.51 + Errata for Rev051 Mar 31 2016). Note that internal CPG clocks (S0, S1, S2, S3, S

Re: [RFC 08/21] drm: rcar-du: Add DPLL support

2016-05-30 Thread Dirk Behme
On 30.05.2016 18:00, Ulrich Hecht wrote: From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 97 - drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 8 +++ drivers/gpu/drm/rcar-du/rcar_du

Re: [PATCH 4/4] drm: rcar-du: Use product register framework

2016-05-27 Thread Dirk Behme
Hi Magnus, On 27.05.2016 11:56, Magnus Damm wrote: Hi Dirk, On Fri, May 27, 2016 at 5:16 PM, Dirk Behme wrote: Hi Magnus, On 27.05.2016 05:40, Magnus Damm wrote: Hi Dirk, On Wed, May 25, 2016 at 5:58 PM, Dirk Behme wrote: Instead of hard coding the product register in the rcar-du

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-05-27 Thread Dirk Behme
On 27.05.2016 10:39, Geert Uytterhoeven wrote: On Fri, May 27, 2016 at 9:56 AM, Dirk Behme wrote: Given the use of PRR you saw is in a patch that's definitely not ready for upstream, I think adding a full-fledged PRR driver is a bit premature. I don't think anyone disagrees tha

Re: [PATCH 4/4] drm: rcar-du: Use product register framework

2016-05-27 Thread Dirk Behme
Hi Magnus, On 27.05.2016 05:40, Magnus Damm wrote: Hi Dirk, On Wed, May 25, 2016 at 5:58 PM, Dirk Behme wrote: Instead of hard coding the product register in the rcar-du, use the framework for it to get the SoC version and the revision needed for the enabling the workaround. Signed-off-by

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-05-27 Thread Dirk Behme
Hi Magnus, On 27.05.2016 05:13, Magnus Damm wrote: Hi Dirk, On Thu, May 26, 2016 at 4:48 PM, Dirk Behme wrote: Hi Geert, On 26.05.2016 09:14, Geert Uytterhoeven wrote: Hi Dirk, On Wed, May 25, 2016 at 10:58 AM, Dirk Behme wrote: Instead of hard coding the product register in

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-05-27 Thread Dirk Behme
Hi Simon, On 27.05.2016 02:42, Simon Horman wrote: On Thu, May 26, 2016 at 09:14:16AM +0200, Dirk Behme wrote: Hi Simon, On 26.05.2016 04:28, Simon Horman wrote: Hi Dirk, On Wed, May 25, 2016 at 07:10:26AM +0200, Dirk Behme wrote: Hi Simon, On 25.05.2016 02:48, Simon Horman wrote: Hi

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-05-26 Thread Dirk Behme
Hi Geert, On 26.05.2016 10:05, Geert Uytterhoeven wrote: Hi Dirk, On Thu, May 26, 2016 at 9:32 AM, Dirk Behme wrote: On 26.05.2016 09:03, Geert Uytterhoeven wrote: On Wed, May 25, 2016 at 9:32 AM, Dirk Behme wrote: P.S.: This also results in the question why we need similar r8a7795-cpg

Re: [PATCH 0/4] ARM: Renesas: R-Car3: Add product register support

2016-05-26 Thread Dirk Behme
Hi Geert, On 26.05.2016 09:14, Geert Uytterhoeven wrote: Hi Dirk, On Wed, May 25, 2016 at 10:58 AM, Dirk Behme wrote: Instead of hard coding the product register in rcar_du_crtc.c, read it based on the device tree. This patch series is based on https://git.kernel.org/cgit/linux/kernel/git

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-05-26 Thread Dirk Behme
On 26.05.2016 09:03, Geert Uytterhoeven wrote: Hi Dirk, On Wed, May 25, 2016 at 9:32 AM, Dirk Behme wrote: P.S.: This also results in the question why we need similar r8a7795-cpg-mssr.h and r8a7796-cpg-mssr.h with just different "numbers" for the same clocks. Can't we use the

Re: [PATCH v3 1/3] arm64: dts: r8a7796: Add Renesas R8A7796 SoC support

2016-05-26 Thread Dirk Behme
Hi Simon, On 26.05.2016 04:28, Simon Horman wrote: Hi Dirk, On Wed, May 25, 2016 at 07:10:26AM +0200, Dirk Behme wrote: Hi Simon, On 25.05.2016 02:48, Simon Horman wrote: Hi Dirk, On Tue, May 24, 2016 at 07:30:17AM +0200, Dirk Behme wrote: Hi Simon, [...] With Renesas R-Car3 we will

  1   2   >