Re: [PATCH 1/3] dt-bindings: mmc: sh_mmcif: Document r8a7743 DT bindings

On 12 July 2017 at 12:03, Chris Paterson wrote: > Signed-off-by: Chris Paterson > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > index c32dc5a..703e18c

Re: [PATCH v3] mmc: tmio-mmc: fix bad pointer math

On 12 July 2017 at 17:40, Chris Brandt wrote: > The existing code gives an incorrect pointer value. > The buffer pointer 'buf' was of type unsigned short *, and 'count' was a > number in bytes. A cast of buf should have been used. > > However, instead of casting, just

Re: Rebasing mmc/next

On 20 June 2017 at 11:06, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, > > On Tue, Jun 20, 2017 at 10:07 AM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> On 20 June 2017 at 09:17, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: >>> It l

Re: [PATCH mmc/next v3 0/4] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC

On 21 June 2017 at 16:00, Simon Horman wrote: > Hi, > > this series adds support for the internal DMAC used by r8a779[56] SoCs. > This is achieved by adding a new variant of the SDHI driver for this > DMA controller with compat strings for the r8a779[56] SoCs. > Compat

Re: [PATCH] mmc: tmio: don't wait on R-Car2+ when handling the clock

On 28 June 2017 at 17:23, Wolfram Sang wrote: > Our hardware engineers confirmed that it is unnecessary to wait when > turning the clock on/off. The documentation was a tad vague, so we > used to play safe. > > Signed-off-by: Wolfram Sang

Re: [PATCH V2] mmc: renesas_sdhi_core: on R-Car 2+, make use of CBSY bit

On 28 June 2017 at 17:21, Wolfram Sang wrote: > Most registers need to wait until the command is completed, not > necessarily until the bus is free. At least, R-Car 2+ SoCs can signal > that via the CBSY bit, so let's use it there instead of SCLKDIVEN to > save a

Re: [RFT] mmc: tmio: fix CMD12 (STOP) handling

On 3 July 2017 at 21:28, Wolfram Sang wrote: > I always anticipated this code to be not correct, but now I had a test > case to prove it. According to all documentation I have, setting the > TMIO_STOP_STP bit ever only worked during block transfers. This bit is >

Re: [PATCH 0/4] tmio/sdhi: use max sd_buf size & clean header file before

On 30 June 2017 at 12:56, Wolfram Sang wrote: > From: Wolfram Sang > > The main patch is patch 4 which uses the maximum sd_buf size, i.e. 32 bit on > Gen2 and 64 bit on Gen3. Instead of a new flag, we use the bus_shift > information we

Re: Rebasing mmc/next

On 20 June 2017 at 09:17, Geert Uytterhoeven wrote: > Hi Ulf, > > It looks like you rebase mmc/next almost daily. Is there any specific reason > for that? I don't do it daily, but often, yes. :-) > > I'm asking because I create a "renesas-drivers" tree on a regular basis >

Re: [PATCH mmc/next v3 1/2] mmc: tmio: improve checkpatch cleanness

+Lee On 16 June 2017 at 18:11, Simon Horman wrote: > Trivial updates to improve checkpatch cleanness. > > Signed-off-by: Simon Horman > --- > v3 > * Really don't add bogus ',' after KERN_DEBUG > * Adjustments as per Wolfram's preferences >

Re: [PATCH mmc/next v3 2/2] mmc: renesas-sdhi: improve checkpatch cleanness

On 16 June 2017 at 18:11, Simon Horman wrote: > Trivial updates to improve checkpatch cleanness. > > Signed-off-by: Simon Horman > Reviewed-by: Wolfram Sang > Tested-by: Wolfram Sang

Re: [PATCH 1/2] soc: renesas: rcar-sysc: Use GENPD_FLAG_ALWAYS_ON

ns"). > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Ulf Hansson <ulf.hans...@linaro.org> Kind regards Uffe > --- > drivers/soc/renesas/rcar-sysc.c | 28 > drivers/soc/renesas/rcar-sysc.h | 2 -- > 2 files c

Re: [PATCH 2/2] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ALWAYS_ON

t;). > > Note that the PM domain containing the serial console is still handled > locally. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Ulf Hansson <ulf.hans...@linaro.org> Kind regards Uffe > --- > arch/arm/mach-shmobile/pm-rmobile.

Re: [RFC PATCH v2 0/2] mmc: core: process ECC errors raised in stop cmds

On 8 April 2017 at 22:20, Wolfram Sang wrote: > Here is the second RFC for handling ECC errors flagged in the stop command > after a multiblock transfer. It is still RFC because I could only test it by > inducing ECC errors in software (see patch for TMIO below).

Re: SDHI clock imbalance

On 2 June 2017 at 10:47, Geert Uytterhoeven wrote: > Hi Wolfram, Ulf, Simon, > > While investigating suspend/resume for the R-Car Gen3 clock driver, I > noticed a clock imbalance for SDHI on Salvator-X. > > After boot: > > # head -2 /sys/kernel/debug/clk/clk_summary >

Re: [PATCH] mmc: tmio: make sure SDIO gets reinitialized after resume

On 23 May 2017 at 15:34, Wolfram Sang wrote: > To achieve that, we set the registers in the generic HW reset routine > which gets called at both, init and resume. We also make sure to move > SDIO initialization before reset gets called in probe(). > >

Re: [PATCH 4/7] mmc: use proper name for the R-Car SoC

On 30 May 2017 at 09:16, Lee Jones <lee.jo...@linaro.org> wrote: > On Mon, 29 May 2017, Ulf Hansson wrote: > >> On 28 May 2017 at 11:30, Wolfram Sang <wsa+rene...@sang-engineering.com> >> wrote: >> > It is 'R-Car', not 'RCar'. No code or bindi

Re: [PATCH 4/7] mmc: use proper name for the R-Car SoC

On 28 May 2017 at 11:30, Wolfram Sang wrote: > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text. > > Signed-off-by: Wolfram Sang Thanks, applied for next! For mfd, Lee, please tell if you have any

Re: [PATCH v2 0/6] tmio/sdhi: add cmd23 support

On 19 May 2017 at 15:31, Wolfram Sang wrote: > This series adds CMD23 support to SDHI. It was tested on H2 (Gen2, Lager) and > M3W (Gen3, Salvator-X). The test procedure can be found here: > > http://elinux.org/Tests:SDHI-CMD23 > > Patches are based on mmc/next

Re: [PATCH v2 0/6] mmc: renesas-sdhi: refactor DMA support

On 18 May 2017 at 22:14, Wolfram Sang wrote: > On Wed, May 10, 2017 at 11:25:24AM +0200, Simon Horman wrote: >> Hi Wolfram, Hi Ulf, Hi Arnd, Hi all, >> >> the intention of this patch-set is to refactor the DMA support in >> the Renesas SDHI driver in order to make it easier to

Re: [PATCH v4] mmc: sh_mmcif: Document r7s72100 DT bindings

On 22 March 2017 at 15:42, Chris Brandt wrote: > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Simon Horman > Acked-by: Rob Herring Thanks,

Re: [PATCH v3] mmc: sh_mmcif: Document r7s72100 DT bindings

On 22 March 2017 at 14:17, Chris Brandt wrote: > This one seems to have been forgotten. > > Should I resend with all the acks and reviews? Seems like you didn't send it to linux-mmc, so it wasn't picked up by the patchtracker. Please re-send so I can pick it up. Kind

Re: [PATCH] mmc: tmio: always get number of taps

On 17 March 2017 at 10:04, Wolfram Sang wrote: > From: Masaharu Hayakawa > > Current code gets number of taps only once and keeps the value. This is > not correct, we need to obtain it every time before executing tuning, > so

Re: [RFC] mmc: tmio: always unmap DMA before waiting for interrupt

On 16 March 2017 at 11:56, Wolfram Sang wrote: > In the (maybe academical) case, we don't get a DATAEND interrupt after > DMA completed, we will wait endlessly for the completion to complete. > This is not bad per se, since we have a more generic completion

Re: [PATCH v3 0/4] mmc: tmio: properly report status from autocmd12

On 14 March 2017 at 11:09, Wolfram Sang wrote: > New in V3: > > * rebased to v4.11-rc2 and retested > * added one more tag from Simon > > New in V2: > * Fix some more comments in patch 2. > * Add Simon's tags > > SDHI automatically sends CMD12 when the desired

Re: [PATCH v2] mmc: host: tmio: ensure end of DMA and SD access are in sync

On 17 February 2017 at 19:22, Wolfram Sang wrote: > The current code assumes that DMA is finished before SD access end is > flagged. Thus, it schedules the 'dma_complete' tasklet in the SD card > interrupt routine when DATAEND is set. The assumption is not safe,

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

On 16 February 2017 at 09:37, Wolfram Sang <w...@the-dreams.de> wrote: > Hi Ulf, > > On Thu, Feb 16, 2017 at 08:57:36AM +0100, Ulf Hansson wrote: >> On 15 February 2017 at 16:02, Wolfram Sang <w...@the-dreams.de> wrote: >> > >> >> > I see. Ulf,

Re: [RFC] mmc: host: tmio: ensure end of DMA and SD access are in sync

On 15 February 2017 at 19:05, Wolfram Sang wrote: > The current code assumes that DMA is finished before SD access end is > flagged. Thus, it schedules the 'dma_complete' tasklet in the SD card > interrupt routine when DATAEND is set. The assumption is not safe,

Re: [PATCH v2 4/4] mmc: host: tmio: fill in response from auto cmd12

On 15 February 2017 at 16:02, Wolfram Sang wrote: > >> > I see. Ulf, do you think it makes sense to extend the condition when to >> > call mmc_blk_cmd_recovery() with checking if stop.resp[0] has one of the >> > R1_* bits set which are marked with 'ex' (and probably 'erx',

Re: [PULL REQUEST] renesas/topic/sdhi-autocmd12-resp for renesas drivers

On 13 February 2017 at 11:04, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Sun, Feb 12, 2017 at 12:27 PM, Wolfram Sang wrote: >> here is a topic branch for renesas-drivers to report back autocmd12 >> responses for SDHI. It is based on mmc/next. Please

Re: [RESEND PATCH 2/2] PM / Domains: Fix asynchronous execution of *noirq() callbacks

On 7 February 2017 at 14:23, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, Rafael, > > On Thu, Jan 12, 2017 at 6:17 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> As the PM core may invoke the *noirq() callbacks asynchronously, the >> current lo

Re: [PATCH v6 0/3] mmc: sh_mobile_sdhi: fix missing r7s72100 clocks

On 26 January 2017 at 11:12, Wolfram Sang wrote: > >> Thanks, applied patch1 and patch2 for next. Patch3 is for Simon, I >> guess!? (And I can add Rob's ack afterwards). > > Can you add my tags as well. They got dropped somehow: > > Reviewed-by: Wolfram Sang

Re: [PATCH v5 2/3] mmc: sh_mobile_sdhi: explain clock bindings

On 26 January 2017 at 15:39, Rob Herring wrote: > On Mon, Jan 23, 2017 at 11:56 AM, Chris Brandt > wrote: >> Hello Rob, >> >> >> On Monday, January 23, 2017, Rob Herring wrote: >>> > --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt >>> > +++

Re: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

On 20 January 2017 at 17:05, Chris Brandt <chris.bra...@renesas.com> wrote: > Hello Ulf, > > Friday, January 20, 2017, Ulf Hansson wrote: >> > +- clocks: Most controllers only have 1 clock source per channel. >> However, some >> > + have a second

Re: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

On 18 January 2017 at 18:25, Chris Brandt wrote: > In the case of a single clock source, you don't need names. However, > if the controller has 2 clock sources, you need to name them correctly > so the driver can find the 2nd one. > > Signed-off-by: Chris Brandt

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

On 18 January 2017 at 18:25, Chris Brandt wrote: > Some controllers have 2 clock sources instead of 1, so they both need > to be turned on/off. This doesn't tell me enough. Please elaborate. For example, tell how you treat the clocks, which of them that is optional and

Re: [PATCH] mmc: host: tmio: drop superfluous exit path

On 6 January 2017 at 09:38, Wolfram Sang wrote: > The probe exit path on error does nothing since commit 94b110aff8679b > ("mmc: tmio: add tmio_mmc_host_alloc/free()"), so we can bail out > immediately. > > Signed-off-by: Wolfram Sang

Re: [PATCH] mmc: tmio: use SDIO master interrupt bit only when allowed

On 9 December 2016 at 17:51, Wolfram Sang wrote: > The master bit to enable SDIO interrupts can only be accessed if > SCLKDIVEN bit allows that. However, the core uses the SDIO enable > callback at times when SCLKDIVEN forbids the change. This leads to > "timeout

Re: [PATCH 0/9] mmc: sh_mobile_sdhi: add HS200 support

On 12 December 2016 at 20:51, Wolfram Sang wrote: > Here is a series adding HS200 support to the SDHI driver. Building the actual > functionality on top of SDR104 support was rather easy. However, I figured the > checks for enabling tuning were rather scattered

Re: [PATCH mmc/next] mmc: sh_mobile_sdhi: remove support for sh7372

On 24 November 2016 at 11:48, Simon Horman wrote: > Remove documentation of support for the SH7372 (SH-Mobile AP4) from the MMC > driver. The driver itself appears to have no SH7372 specific code. > > Commit edf4100906044225 ("ARM: shmobile: sh7372 dtsi: Remove Legacy

Re: [PATCH mmc/next] mmc: sh_mmcif: Document r8a73a4, r8a7778 and sh73a0 DT bindings

On 25 November 2016 at 08:56, Simon Horman wrote: > Simply document new compatibility strings as the driver is already > activated using a fallback compatibility string. > > These compat strings are in keeping with those for all other > Renesas ARM based SoCs with

Re: [PATCH 1/2] mmc: tmio: fix wrong bitmask for SDIO irqs

On 13 November 2016 at 15:29, Wolfram Sang wrote: > Commit 7729c7a232a953 ("mmc: tmio: Provide separate interrupt handlers") > refactored the sdio irq handler and wrongly used the mask for SD irqs, > not for SDIO irqs. This doesn't really matter in practice

Re: [PATCH v8 0/6] UHS-I SDR-104 support for sh_mobile_sdhi

On 10 November 2016 at 12:45, Wolfram Sang wrote: > On Thu, Nov 03, 2016 at 03:15:58PM +0100, Simon Horman wrote: >> Hi, >> >> this series is based on work by Ai Kyuse to add UHS-I SDR-104 support for >> sh_mobile_sdhi. It builds on work by Shinobu Uehara, Rob Taylor, William

Re: [PATCH v3 0/3] mmc: sh_mobile_sdhi: Add r7s72100 support

On 12 September 2016 at 16:15, Chris Brandt wrote: > For the most part, the SDHI controller in the RZ/A1 (r7s72100) > is the same as other Renesas SoC...except for the fact that the > data port register was widened to 32-bits and the 16-bit accesses > in the current tmio

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

On 14 October 2016 at 15:18, Chris Brandt <chris.bra...@renesas.com> wrote: > On 9/22/2016, Ulf Hansson wrote: >> To: Chris Brandt <chris.bra...@renesas.com> >> Cc: Wolfram Sang <wsa+rene...@sang-engineering.com>; Sergei Shtylyov >> <sergei.shtyl...@coge

Re: [PATCH v3 0/6] tmio: add support for eMMC with 8 bit bus width

On 19 September 2016 at 22:57, Wolfram Sang wrote: > This series enables SDHI instances on R-Car Gen3 to access eMMC with 8 bit bus > width. I think the patch descriptions speak for themselves. > > I decided to not protect this new feature with a flag because it

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

+ Lee On 12 September 2016 at 16:15, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

On 13 September 2016 at 17:59, Chris Brandt <chris.bra...@renesas.com> wrote: > Hello Uffe > > Thank you for your reply. > > On 9/13/2016, Ulf Hansson wrote: >> Because, if you have an external regulator feeding the mmc with power you >> should set it up and use

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

On 13 September 2016 at 15:50, Chris Brandt wrote: > Here's a question: > > The DT regulator method is good if you want to be able to control the > regulator at run-time by the system. > > But for MMC and SDHI, why isn't there a way to just set the OCR voltage in > the

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

On 12 September 2016 at 16:15, Chris Brandt wrote: > In moving platforms from board files to DT, there still needs to be a way > to set the ocr_mask setting for the tmio driver during probe. Without this > setting, the probe will fail because the supported voltages are

Re: [PATCH v7 0/6] UHS-I SDR-104 support for sh_mobile_sdhi

On 13 September 2016 at 12:56, Simon Horman wrote: > > Hi, > > this series is based on work by Ai Kyuse to add UHS-I SDR-104 support for > sh_mobile_sdhi. It builds on work by Shinobu Uehara, Rob Taylor, William > Towle and Ian Molton, Ben Hutchings, Wolfram Sang and

Re: [PATCH] mmc: sh_mobile_sdhi: Add r8a7796 support

On 6 September 2016 at 12:38, Simon Horman wrote: > From: Ai Kyuse > > Add support for r8a7796 SoC. > > Signed-off-by: Ai Kyuse > Signed-off-by: Simon Horman > Reviewed-by: Geert

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

On 5 September 2016 at 10:18, Wolfram Sang wrote: > >> > It can be argued that this tag could be added: >> > >> > Fixes: 452e5eef6d311e ("mmc: tmio: Add UHS-I mode support") >> > >> > I don't know how well it applies, though, because the code has been >> > modified a lot

Re: [PATCH v6 5/9] mmc: tmio: Add tuning support

;horms+rene...@verge.net.au> > --- > v6 [Simon Horman] > * As suggested by Ulf Hansson: > - Restore saved tuning parameters on resume > > v5 [Simon Horman] > * As suggested by Ulf Hansson: > - Move hw reset support into a separate patch > - Use more descriptive

Re: [PATCH 2/2] mmc: host: sh_mobile_sdhi: don't populate unneeded functions

On 2 September 2016 at 07:23, Wolfram Sang wrote: > Magnus, > >> To my eye it looks like this patch might be adding a fix for a bug >> introduced by another patch. R-Car Gen2 and later are quite recent >> SoCs but I believe support for other mobile chips and earlier R-Car >>

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

On 1 September 2016 at 10:37, Simon Horman <ho...@verge.net.au> wrote: > On Thu, Sep 01, 2016 at 08:46:44AM +0200, Simon Horman wrote: >> On Wed, Aug 31, 2016 at 09:38:40AM +0200, Ulf Hansson wrote: >> > On 30 August 2016 at 22:51, Simon Horman <ho...@verge.net.au>

Re: [PATCH v5 03/11] mmc: tmio: Add hw reset support

.au> > --- > This is required by tuning support which will > be introduced by follow-up patches. > > v5 [Simon Horman] > * As suggested by Ulf Hansson > - Broke out of a larger patch > --- > drivers/mmc/host/tmio_mmc.h | 1 + > drivers/mmc/host/tmio_mmc_pio

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

On 30 August 2016 at 22:51, Simon Horman <ho...@verge.net.au> wrote: > On Mon, Aug 29, 2016 at 04:05:55PM +0200, Ulf Hansson wrote: >> On 29 August 2016 at 14:05, Simon Horman <ho...@verge.net.au> wrote: >> > On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

On 29 August 2016 at 14:05, Simon Horman <ho...@verge.net.au> wrote: > On Fri, Aug 26, 2016 at 10:01:35AM +0200, Ulf Hansson wrote: >> On 25 August 2016 at 14:04, Simon Horman <ho...@verge.net.au> wrote: >> > On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

On 25 August 2016 at 14:04, Simon Horman <ho...@verge.net.au> wrote: > On Tue, Aug 23, 2016 at 05:02:56PM +0200, Ulf Hansson wrote: >> [...] >> >> >> > +static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) >> >> > +{ >&g

Re: [PATCH 0/2] mmc: sh_mobile_sdhi: use SDR & card_busy only on Gen2+

On 24 August 2016 at 11:34, Wolfram Sang wrote: > This series hopefully fixes a performance regression for r8a73a4 (pre Gen2) > caused by a not working card_busy. Because we don't have documentation for its > SDHI (and I don't have the hardware), just enable

Re: [PATCH v4 2/4] mmc: tmio: Add tuning support

On 27 July 2016 at 06:13, Simon Horman wrote: > From: Ai Kyuse > > Add tuning support for use with SDR104 mode > > Signed-off-by: Ai Kyuse > Signed-off-by: Simon Horman > --- > v4 [Simon

Re: [PATCH 4/4] PM / Runtime: Defer resuming of the device in pm_runtime_force_resume()

On 28 June 2016 at 18:26, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, Rafael, > > On Tue, May 17, 2016 at 1:41 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> When the pm_runtime_force_suspend|resume() helpers were invented, we still >> had CONF

Re: [PATCH] mmc: tmio: make a cast explicit

On 27 May 2016 at 14:10, Wolfram Sang wrote: > From: Wolfram Sang > > Sparse complains about the implicit cast. Making it explicit is indeed > better coding style. > > Signed-off-by: Wolfram Sang Thanks,

Re: [PATCH] mmc: sh_mobile_sdhi: properly document R-Car versions

On 11 May 2016 at 14:46, Wolfram Sang wrote: > From: Wolfram Sang > > Replace hardcoded values with meaningful names and document what we > know. > > Signed-off-by: Wolfram Sang Thanks, applied for next!

Re: [PATCH] mmc: sh_mobile_sdhi: enable SDIO IRQs for RCar Gen3

On 9 May 2016 at 17:01, Wolfram Sang wrote: > From: Wolfram Sang > > Tested on a Salvator-X board with a Spectec SDW-823 WLAN card. > > Signed-off-by: Wolfram Sang Just to let you know, this one was queued

Re: [PATCH] MAINTAINERS: update entry for TMIO MMC driver

On 9 May 2016 at 10:26, Wolfram Sang wrote: > From: Wolfram Sang > > I have some more additions planned for this driver, so I'd like to get > notified of other changes and coordinate them. Drop Ian as maintainer > because he hasn't been

Re: [PATCH] mmc: sdio: fall back to SDIO 1.0 for broken 1.1 cards

On 9 May 2016 at 09:59, Wolfram Sang wrote: > From: Wolfram Sang > > I have two SDIO WLAN cards which specify being SDIO Rev. 1.1 cards but > their FUNCE tuple reports the smaller size of a Rev 1.0 card. So, > enforce 1.0 on these cards to

Re: [PATCH] ARM: shmobile: pm-rmobile: Postpone call to pm_genpd_init()

On 4 May 2016 at 10:27, Geert Uytterhoeven <geert+rene...@glider.be> wrote: > All local setup of the generic_pm_domain structure should have been > completed before calling pm_genpd_init(). > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-b

Re: [PATCH] mmc: sh_mobile_sdhi: remove obsolete include file

On 28 April 2016 at 08:18, Wolfram Sang wrote: > From: Wolfram Sang > > A few SH boards include the file but don't make use of it (no named > interrupts). The SDHI code removed support for this feature as well. > So, drop the references and

Re: [PATCH v3 0/5] mmc: tmio: make CTL_STATUS handling consistent

On 27 April 2016 at 18:51, Wolfram Sang wrote: > It took me a little to discover that CTL_STATUS has a different handling than > the other registers. CTL_STATUS and CTL_STATUS2, both u16, are merged into a > virtual u32. However, CTL_STATUS2 was also directly accessed. > >

Re: [PATCH 0/4] clk: renesas: Clock Domain fixes

main > clk: renesas: cpg-mssr: Postpone call to pm_genpd_init() > clk: renesas: cpg-mssr: Use always-on governor for Clock Domain > > drivers/clk/renesas/clk-mstp.c | 3 +-- > drivers/clk/renesas/renesas-cpg-mssr.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) For the series: Reviewed-by: Ulf Hansson <ulf.hans...@linaro.org> Kind regards Uffe

Re: [PATCH 2/4] clk: renesas: mstp: Use always-on governor for Clock Domain

On 27 April 2016 at 16:04, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, > > On Wed, Apr 27, 2016 at 3:59 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> On 26 April 2016 at 09:09, Geert Uytterhoeven <geert+rene...@glider.be> >> wrote: &

Re: [PATCH v2 0/5] mmc: tmio: make CTL_STATUS handling consistent

On 26 April 2016 at 18:53, Wolfram Sang wrote: > It took me a little to discover that CTL_STATUS has a different handling than > the other registers. CTL_STATUS and CTL_STATUS2, both u16, are merged into a > virtual u32. However, CTL_STATUS2 was also directly accessed. > >

Re: [PATCH] mmc: mmcif: remove obsolete support for sh7372

On 26 April 2016 at 22:34, Wolfram Sang wrote: > From: Wolfram Sang > > There is no support for this platform in the kernel anymore. Make the > Kconfig text more generic, so it won't get stale anymore. > > Reported-by: Geert Uytterhoeven

Re: [PATCH] mmc: sdhi: remove obsolete support for sh7372

On 26 April 2016 at 22:29, Wolfram Sang wrote: > From: Wolfram Sang > > There is no support for this platform in the kernel anymore. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang

Re: [PATCH V2 0/6] mmc: tmio/sdhi: clean up cruft

On 26 April 2016 at 17:55, Wolfram Sang wrote: > Largely due to DT unification, some parts of the code became obsolete. Let's > remove that, the code is complex enough still: > > * There are no boards anymore with named interrupt support. Drop support for > that (patches

Re: [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices

On 22 April 2016 at 09:59, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, > > On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >>> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct >>> gener

Re: [PATCH v6 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

ins are initialized before secondary CPU bringup. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Ulf Hansson <ulf.hans...@linaro.org> Kind regards Uffe > --- > v6: > - Drop unneeded genpd->dev_ops.active_wakeup callback, >

Re: [PATCH v2] PM / Runtime: Only force-resume device if it has been force-suspended

On 21 April 2016 at 23:07, Laurent Pinchart wrote: > Hi Rafael, > > On Thursday 21 Apr 2016 23:02:06 Rafael J. Wysocki wrote: >> On Thu, Apr 21, 2016 at 10:57 PM, Laurent Pinchart wrote: >> > On Thursday 21 Apr 2016 21:52:56 Rafael J. Wysocki wrote: >> >> On

Re: [PATCH] PM / Runtime: Only force-resume device if it has been force-suspended

On 21 April 2016 at 14:41, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Ulf, > > On Thursday 21 Apr 2016 11:10:19 Ulf Hansson wrote: >> On 21 April 2016 at 01:30, Laurent Pinchart wrote: >> > On Monday 07 Mar 2016 11:10:08 Ulf Hansson wrote: >

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

On 20 April 2016 at 10:24, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, > > On Mon, Apr 18, 2016 at 4:02 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: >> On 18 April 2016 at 15:39, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: >>&

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

On 18 April 2016 at 15:39, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Ulf, > > On Mon, Apr 18, 2016 at 2:59 PM, Geert Uytterhoeven > <ge...@linux-m68k.org> wrote: >> On Mon, Apr 18, 2016 at 2:21 PM, Ulf Hansson <ulf.hans...@linaro.org> wrote: &g

Re: [PATCH v5 03/11] soc: renesas: rcar-sysc: Add DT support for SYSC PM domains

[...] > + > +static bool rcar_sysc_active_wakeup(struct device *dev) > +{ > + return true; I am interested to know why this is always returning true. Perhaps you can elaborate a bit on that? > +} > + > +static int rcar_sysc_pd_power_off(struct generic_pm_domain *genpd) > +{ > +

Re: [PATCH 2/6] mmc: sh_mobile_sdhi: remove obsolete irq_by_name registration

On 6 April 2016 at 11:25, Wolfram Sang wrote: > From: Wolfram Sang > > There is no user left in the kernel, so this code can be removed. > (Legacy, non-DT sh_mobile boards have been removed a while ago.) The > diff looks more complicated than

Re: [PATCH v2 0/9] r8a7790: add UHS-I (SDR50) support to Lager

On 4 April 2016 at 17:21, Wolfram Sang wrote: > >> The documentation of mmc is quite poor. There are both code and >> specification that needs to be understand, so some more help from >> kernel doc could clearly help. > > I agree. > >> Anyway, I noticed that patch 6 helps to

Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

On 4 April 2016 at 17:17, Wolfram Sang wrote: > >> > + usleep_range(5000, 5500); >> >> Why do you need this delay/sleep? > > My datasheet says to wait at least 5ms before re-enabling the clock > after a voltage switch... > > Ah, found it in the core. It is doing it for

Re: [PATCH v2 7/9] mmc: sh_mobile_sdhi: Add UHS-I mode support

On 1 April 2016 at 17:44, Wolfram Sang wrote: > From: Wolfram Sang > > Implement voltage switch, supporting modes up to SDR-50. > > Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. > > Signed-off-by: Ben Hutchings

Re: [PATCH] PM / Runtime: Only force-resume device if it has been force-suspended

[...] >> I agree, that's a better idea. Drivers shouldn't call >> pm_runtime_force_resume() if they haven't called pm_runtime_force_suspend(), >> so checking the PM use count should be fine. I'll modify the patch, test it >> and resubmit. > > I gave it an unfortunately unsuccessful try. The

Re: [PATCH] PM / Runtime: Only force-resume device if it has been force-suspended

+ Alan On 3 March 2016 at 21:16, Laurent Pinchart wrote: > The pm_runtime_force_suspend() and pm_runtime_force_resume() helpers are > designed to help driver being RPM-centric by offering an easy way to > manager runtime PM state during system suspend

Re: [RFC 5/7] mmc: sh_mobile_sdhi: Add UHS-I mode support

On 19 February 2016 at 21:16, Wolfram Sang wrote: > From: Ben Hutchings > > Implement voltage switch, supporting modes up to SDR-50. > > Based on work by Shinobu Uehara, Rob Taylor, William Towle and Ian Molton. > > Signed-off-by: Ben Hutchings

Re: [PATCH RESEND 1/3] mmc: sdhi: Add r8a7795 support

On 15 February 2016 at 16:01, Wolfram Sang wrote: > From: Wolfram Sang > > Registers are 64bit apart, so we refactor bus_shift handling a little and set > it based on the DT compatible. Also, EXT_ACC is different. It has been tested > on a

Re: [PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support

On 2 February 2016 at 15:06, Wolfram Sang wrote: > >> Although, I couldn't apply patch1, could you please send a new version >> rebased onto my next branch. > > I rebased to your tree (especially patch 1, rest stayed the same) and > pushed patches 1-8 here: > >

Re: [PATCH] mmc: sanitize 'bus width' in debug output

On 29 January 2016 at 09:27, Wolfram Sang wrote: > From: Wolfram Sang > > The bus width is sometimes the actual bus width, and sometimes indices > to different arrays encoding the bus width. In my debugging case "2" > could mean 8-bit as well

Re: [PATCH] mmc: make MAN_BKOPS_EN message a debug

On 25 January 2016 at 20:18, Wolfram Sang wrote: > From: Wolfram Sang > > IMO this info is only useful for developers. Most users won't need this > information, since there is not much they can do about it. > > Signed-off-by: Wolfram Sang

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

On 25 January 2016 at 20:15, Wolfram Sang wrote: > From: Wolfram Sang > > Registers are 64bit apart, so we refactor bus_shift handling a little > and set it based on the DT compatible. Also, EXT_ACC is different. > > Signed-off-by: Ai Kyuse

Re: [PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support

On 25 January 2016 at 20:15, Wolfram Sang wrote: > So, here is the series to enable basic SD support on r8a7795; no DMA and UHS-I > for now. Will be added incrementally. It turns out that the driver needs a > little love, so some refactoring is also in place before adding the

<    1   2   3