[PATCH v5 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-12 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v5 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-12 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v5 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-12 Thread Jacopo Mondi
soc_camera based driver as long as other platforms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- drivers/media/i2c/Kconfig | 9 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/tw9910.c | 162

[PATCH v5 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-12 Thread Jacopo Mondi
chitecture specific part from CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- arch/sh/boards/mach-migor/setup.c | 225 +++-- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 2 files changed, 101 insertions(+), 126 deletions(-) diff --git a/arch

[PATCH v5 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-12 Thread Jacopo Mondi
ent: --- Removed platform callbacks and handle clocks and gpios from sensor drivers --- Remove g/s_mbus_config operations Jacopo Mondi (9): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CEU driver ARM: dts: r7s72

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-12 Thread jacopo mondi
Hi Philippe, Laurent, Geert, On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote: > On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi > wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > > > > --- /dev/null > > +++ b/drivers/media/p

[PATCH v4 2/9] include: media: Add Renesas CEU driver interface

2018-01-09 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- include/media/drv-intf/renesas-ceu.h | 26 ++ 1 file changed, 26 insertions

[PATCH v4 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-09 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi --- .../devicetree/bindings/media/renesas,ceu.txt | 81 ++ 1 file changed, 81 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt diff

[PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-09 Thread Jacopo Mondi
RZ platform GR-Peach. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |1 + drivers/media/platform/renesas-ceu.c | 1648 ++ 3 files chan

[PATCH v4 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-09 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- arch/arm/boot/dts/r7s72100.dtsi | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi

[PATCH v4 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-09 Thread Jacopo Mondi
forms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- drivers/media/i2c/Kconfig | 11 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov772x.c | 177 ++--- include/media/i2c/ov772x.h | 6

[PATCH v4 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-09 Thread Jacopo Mondi
soc_camera based driver as long as other platforms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- drivers/media/i2c/Kconfig | 9 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/tw9910.c | 162

[PATCH v4 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-09 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v4 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-09 Thread Jacopo Mondi
chitecture specific part from CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- arch/sh/boards/mach-migor/setup.c | 225 +++-- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 2 files changed, 101 insertions(+), 126 deletions(-) diff --git a/arch

[PATCH v4 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-09 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v4 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-09 Thread Jacopo Mondi
remarks from Hans and Laurent: --- Removed platform callbacks and handle clocks and gpios from sensor drivers --- Remove g/s_mbus_config operations Jacopo Mondi (9): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CE

Re: [PATCH v3 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-05 Thread jacopo mondi
Hi Laurent, On Fri, Jan 05, 2018 at 12:28:03AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 4 January 2018 18:03:09 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > >

[PATCH v3 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-04 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi --- .../devicetree/bindings/media/renesas,ceu.txt | 85 ++ 1 file changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt diff

[PATCH v3 3/9] v4l: platform: Add Renesas CEU driver

2018-01-04 Thread Jacopo Mondi
RZ platform GR-Peach. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |1 + drivers/media/platform/renesas-ceu.c | 1649 ++ 3 files chan

[PATCH v3 2/9] include: media: Add Renesas CEU driver interface

2018-01-04 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- include/media/drv-intf/renesas-ceu.h | 26 ++ 1 file changed, 26 insertions

[PATCH v3 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-04 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- arch/arm/boot/dts/r7s72100.dtsi | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi

[PATCH v3 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-04 Thread Jacopo Mondi
soc_camera based driver as long as other platforms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- drivers/media/i2c/Kconfig | 9 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/tw9910.c | 162

[PATCH v3 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-04 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v3 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-04 Thread Jacopo Mondi
forms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/Kconfig | 11 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov772x.c | 177 ++--- include/media/i2c/ov772x.h | 6 +- 4 files changed, 133 inser

[PATCH v3 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-04 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v3 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-04 Thread Jacopo Mondi
chitecture specific part from CEU driver. Signed-off-by: Jacopo Mondi --- arch/sh/boards/mach-migor/setup.c | 225 +++-- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 2 files changed, 101 insertions(+), 126 deletions(-) diff --git a/arch/sh/boards/mach-migor/setup.c

[PATCH v3 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-04 Thread Jacopo Mondi
sensors (tw9910 and ov772x) drivers headers and drivers to close remarks from Hans and Laurent: --- Removed platform callbacks and handle clocks and gpios from sensor drivers --- Remove g/s_mbus_config operations Jacopo Mondi (9): dt-bindings: media: Add Renesas CEU bindings include: media: A

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 04:14:35PM -0200, Fabio Estevam wrote: > On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: > > >> Initially the rest GPIO was doing: > >> > >> - gpio_set_value(GPIO_PTT3, 0); > >> - mdelay(10)

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 03:27:53PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > > > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > > See patch [5/9] in this series and search for

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 02:41:20PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi > wrote: > > > + if (priv->rstb_gpio) { > > + gpiod_set_value(priv->rstb_gpio, 0); > >

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:50:38PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:21 EET Jacopo Mondi wrote: > > - priv->clk = v4l2_clk_get(&client->dev, "mclk"); > &g

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Wed, Jan 03, 2018 at 05:49:55PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > > > > DT based platforms won't have any info->xlkc_rate, so they should be > > fine. I wonder how could I set rate in board code, as I'm just > > registering an alias for the clock there... > > Exactly a

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:44:03PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:19 EET Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > &g

Re: [PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 03:46:27PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > > +/* > > + * ceu_device - CEU device instance > > + */ > > +struct ceu_device { > > + struct device *dev; > > + struct video_device vdev; > > + struct v4

Re: [PATCH v2 2/9] include: media: Add Renesas CEU driver interface

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:50:07PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:14 EET Jacopo Mondi wrote: > > Add renesas-ceu header file. > > > > Do not remove the existing s

Re: [PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:45:30PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:13 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > >

Re: [PATCH v2 6/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-02 Thread jacopo mondi
Hi Philippe, thanks for the comment, On Fri, Dec 29, 2017 at 01:47:30PM +0100, Philippe Ombredanne wrote: > Jacopo, > > On Thu, Dec 28, 2017 at 3:01 PM, Jacopo Mondi > wrote: > > Copy the soc_camera based driver in v4l2 sensor driver directory. > > This commit just

[PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2017-12-28 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi --- .../devicetree/bindings/media/renesas,ceu.txt | 85 ++ 1 file changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt diff

[PATCH v2 2/9] include: media: Add Renesas CEU driver interface

2017-12-28 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi --- include/media/drv-intf/renesas-ceu.h | 20 1 file changed, 20 insertions(+) create mode 100644 include/media/drv

[PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2017-12-28 Thread Jacopo Mondi
RZ platform GR-Peach. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |1 + drivers/media/platform/renesas-ceu.c | 1652 ++ 3 files chan

[PATCH v2 5/9] arch: sh: migor: Use new renesas-ceu camera driver

2017-12-28 Thread Jacopo Mondi
chitecture specific part from CEU driver. Signed-off-by: Jacopo Mondi --- arch/sh/boards/mach-migor/setup.c | 213 ++--- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 2 files changed, 89 insertions(+), 126 deletions(-) diff --git a/arch/sh/boards/mach-migor/setup.c

[PATCH v2 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2017-12-28 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100.dtsi | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index ab9645a..b09b032 100644

[PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2017-12-28 Thread Jacopo Mondi
oc to driver interface header file - Adjust build system This commit does not remove the original soc_camera based driver as long as other platforms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/Kconfig | 11 +++ drivers/media/i2c/Makefile | 1 + dr

[PATCH v2 6/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-28 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v2 8/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2017-12-28 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi Acked-by: Laurent

[PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2017-12-28 Thread Jacopo Mondi
soc_camera based driver as long as other platforms depends on soc_camera-based CEU driver. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/Kconfig | 9 +++ drivers/media/i2c/Makefile | 1 + drivers/media/i2c/tw9910.c | 158 - include/media/i2c/tw9910.h

[PATCH v2 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2017-12-28 Thread Jacopo Mondi
mal operations to reset the interface properly. Jacopo Mondi (9): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CEU driver ARM: dts: r7s72100: Add Capture Engine Unit (CEU) arch: sh: migor: Use new renesas-ceu ca

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-22 Thread jacopo mondi
Hi Laurent, On Fri, Dec 22, 2017 at 02:03:41PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Thursday, 21 December 2017 18:27:02 EET jacopo mondi wrote: > > On Mon, Dec 18, 2017 at 05:28:43PM +0200, Laurent Pinchart wrote: > > > On Monday, 18 December 2017 14:25:1

Re: [PATCH v1 05/10] arch: sh: migor: Use new renesas-ceu camera driver

2017-12-21 Thread jacopo mondi
Hi Laurent, On Tue, Dec 12, 2017 at 12:00:43PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wednesday, 15 November 2017 12:55:58 EET Jacopo Mondi wrote: > > Migo-R platform uses sh_mobile_ceu camera driver, which is now being > > repla

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-21 Thread jacopo mondi
Hi Laurent, On Mon, Dec 18, 2017 at 05:28:43PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Monday, 18 December 2017 14:25:12 EET jacopo mondi wrote: > > On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: [snip] > > >> +/** > > >> + * ce

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-19 Thread jacopo mondi
Hi Laurent, a few more details on subdevice management On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > [snip] > > > +static int ceu_sensor_bound(struct v4l2_async_notifier *notifier, > > + struct v4l2_subdev *

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-18 Thread jacopo mondi
Hi Hans, thanks for review comments On Wed, Dec 13, 2017 at 01:03:03PM +0100, Hans Verkuil wrote: > On 15/11/17 11:55, Jacopo Mondi wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > + > > + /* Register the video device */ > > + strncpy(vdev

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-18 Thread jacopo mondi
Hi Laurent, thanks for review comments... On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > [snip] > > + > > +/** > > + * ceu_buffer - Link vb2 buffer to the list of available buffers > > If you use kerneldoc comments please make the

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-17 Thread jacopo mondi
Hi Sakari, On Fri, Dec 15, 2017 at 06:17:04PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Dec 13, 2017 at 07:26:20PM +0100, Jacopo Mondi wrote: > > The v4l2-async module operations are quite complex to follow, due to the > > asynchronous nature of subdevices and notif

Re: [PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

2017-12-17 Thread jacopo mondi
Hi Sakari, On Fri, Dec 15, 2017 at 05:20:40PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Dec 13, 2017 at 07:26:19PM +0100, Jacopo Mondi wrote: > > Currently, subdevice notifiers are tested against all available > > subdevices as soon as they get registered. It

Re: [PATCH/RFC v2 10/15] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

2017-12-15 Thread jacopo mondi
Hi Kieran, On Thu, Dec 14, 2017 at 10:25:36PM +, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: > > This will be needed to fill out the frame descriptor information > > correctly. > > > > Signed-off-by: Niklas Söderlund > > --- > > drivers/media/i2c/adv748x

Re: [PATCH/RFC v2 07/15] rcar-csi2: use frame description information to configure CSI-2 bus

2017-12-15 Thread jacopo mondi
Hi Niklas, thanks for the patch! On Thu, Dec 14, 2017 at 08:08:27PM +0100, Niklas Söderlund wrote: > The driver now have access to frame descriptor information, use it. Only > enable the virtual channels which are described in the frame descriptor > and calculate the link based on all enabled s

[PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-13 Thread Jacopo Mondi
t that useful). Signed-off-by: Jacopo Mondi --- For fwnodes backed by OF, I may have used the "%pOF" format modifier to get the full node name instead of parsing the fwnode graph by myself with "v4l2_async_fwnode_full_name()". Unfortunately I'm not aware of anything like &

[PATCH 3/5] include: v4l2_async: Add 'owner' field to notifier

2017-12-13 Thread Jacopo Mondi
e can be printed out for debug purposes. Signed-off-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-async.c | 2 ++ include/media/v4l2-async.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index

[PATCH 1/5] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-13 Thread Jacopo Mondi
From: Sakari Ailus V4L2 async framework can use both device's fwnode and endpoints's fwnode for matching the async sub-device with the sub-device. In order to proceed moving towards endpoint matching assign the endpoint to the async sub-device. As most async sub-device drivers (and the related h

[PATCH 2/5] device property: Add fwnode_get_name() operation

2017-12-13 Thread Jacopo Mondi
Add operation to retrieve the device name from a fwnode handle. Signed-off-by: Jacopo Mondi --- drivers/acpi/property.c | 6 ++ drivers/base/property.c | 12 drivers/of/property.c| 6 ++ include/linux/fwnode.h | 2 ++ include/linux/property.h | 1 + 5 files

[PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

2017-12-13 Thread Jacopo Mondi
gistered, the complete() call chain cannot be upscaled as long as the subdevice the notifiers belongs to is not registered. Also, it is now safe to access a notifier 'struct device *' as we're now sure it is properly initialized when the notifier is actually registered. Signed-off-b

[PATCH 0/5] Add debug output to v4l2-async

2017-12-13 Thread Jacopo Mondi
linux-media anyhow for feedbacks. Thanks j Jacopo Mondi (4): device property: Add fwnode_get_name() operation include: v4l2_async: Add 'owner' field to notifier v4l2: async: Postpone subdev_notifier registration v4l2: async: Add debug output to v4l2-async module Sakar

Re: [PATCH v5] v4l2-async: Match parent devices

2017-12-06 Thread jacopo mondi
> node. > > Signed-off-by: Kieran Bingham > Signed-off-by: Sakari Ailus please append: Reported-by: Jacopo Mondi Thanks j > > --- > > Hi Sakari, > > Since you signed-off on this patch - it has had to be reworked due to the > changes on the of_node_full_name

[PATCH] v4l: rcar-csi2: Don't bail out from probe on no ep

2017-12-05 Thread Jacopo Mondi
When rcar-csi interface is not connected to any endpoint, it fails and bails out from probe before registering its own video subdevice. This prevents rcar-vin registered notifier from completing and no subdevice is ever registered, also for other properly connected csi interfaces. Fix this not ret

Re: [RFC] v4l: i2c: ov7670: Implement mbus configuration

2017-11-29 Thread jacopo mondi
Hi Sakari, thanks for the reply On Wed, Nov 29, 2017 at 01:06:49PM +0200, Sakari Ailus wrote: > On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote: > > > ov7670 current

[RFC] v4l: i2c: ov7670: Implement mbus configuration

2017-11-27 Thread Jacopo Mondi
ov7670 currently supports configuration of a few parameters only through platform data. Implement media bus configuration by parsing DT properties at probe() time and opportunely configure REG_COM10 during s_format(). Signed-off-by: Jacopo Mondi --- Hi linux-media, I'm using this sens

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-25 Thread jacopo mondi
Hi Sakari! On Sat, Nov 25, 2017 at 05:56:14PM +0200, Sakari Ailus wrote: > On Fri, Nov 17, 2017 at 10:33:55AM +0100, jacopo mondi wrote: > > Hi Sakari! > > [snip] > > I would like to make sure we're all on the same page with this. My > > preference would be: >

Re: [PATCH RFT] i2c: sh_mobile: make sure to not accidently trigger STOP

2017-11-17 Thread jacopo mondi
fine, > a cleared one may trigger STOP on the bus. > > Signed-off-by: Wolfram Sang > --- > > Jacopo: another to test, please. On top of all the other patches. Thank you! and for this one as well, on Migo-R no visible regressions. I2c sensor probes properly, and I can capture

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-17 Thread jacopo mondi
Hi Sakari! On Fri, Nov 17, 2017 at 02:36:51AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote: > > Hi Sakari, > >thanks for review! > > You're welcome! > > > On Wed, Nov 15, 2017 at 02:45:51PM +

Re: [PATCH v1 06/10] sh: sh7722: Rename CEU clock

2017-11-17 Thread jacopo mondi
Hi Geert, On Wed, Nov 15, 2017 at 02:13:43PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > wrote: > > Rename CEU clock to match the new platform driver name used in Migo-R. > > > > There are no other sh7722 bas

Re: [PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

2017-11-17 Thread jacopo mondi
Hi Sakari! On Fri, Nov 17, 2017 at 02:43:15AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote: > > [snip] > > +#include > > #include > > #include > > #include > > @@ -25,8 +26,8 @@ &g

[RFC] arm: dts: gr-peach: Add audiocamerashield DTSi

2017-11-16 Thread Jacopo Mondi
Add device tree header for GR-Peach's audiocamerashield with OV7670 image sensor. Signed-off-by: Jacopo Mondi --- Hello, this patch adds device tree header file for GR-Peach's audiocamerashield. More details on the shield can be found at [1]. Sending as RFC and to a limited au

Re: [PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

2017-11-15 Thread jacopo mondi
Hi Geert, On Wed, Nov 15, 2017 at 02:07:31PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > CC devicetree folks Yeah, sorry I forgot them. Sorry about this and thanks for adding the address back! > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > wrote: > > Add bi

[PATCH] v4l: sh_mobile_ceu: Return buffers on streamoff()

2017-11-15 Thread Jacopo Mondi
videobuf2 core reports an error when not all buffers have been returned to the framework: drivers/media/v4l2-core/videobuf2-core.c:1651 WARN_ON(atomic_read(&q->owned_by_drv_count)) Fix this returning all buffers currently in capture queue. Signed-off-by: Jacopo Mondi --- I know I&#x

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-15 Thread jacopo mondi
uple of other routines apart, there's not that much code shared between the two... > > The same goes for the two V4L2 SoC camera sensor / video decoder drivers at > the end of the set. > Also in this case I prefer not to remove existing code, as long as there are platforms using it..

[PATCH v1 10/10] media: i2c: tw9910: Remove soc_camera dependencies

2017-11-15 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi

[PATCH v1 00/10] Renesas Capture Engine Unit (CEU) V4L2 driver

2017-11-15 Thread Jacopo Mondi
submission. Thanks j Jacopo Mondi (10): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CEU driver ARM: dts: r7s72100: Add Capture Engine Unit (CEU) arch: sh: migor: Use new renesas-ceu camera driver sh: sh7722:

[PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

2017-11-15 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi --- .../devicetree/bindings/media/renesas,ceu.txt | 87 ++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/renesas,ceu.txt diff

[PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-11-15 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 1124 1 file changed, 1124 insertions(+) create mode

[PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

2017-11-15 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi

[PATCH v1 09/10] v4l: i2c: Copy tw9910 soc_camera sensor driver

2017-11-15 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 999 + 1 file changed, 999 insertions(+) create mode 100644

[PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-11-15 Thread Jacopo Mondi
RZ platform GR-Peach. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |2 + drivers/media/platform/renesas-ceu.c | 1768 ++ 3 files chan

[PATCH v1 02/10] include: media: Add Renesas CEU driver interface

2017-11-15 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi --- include/media/drv-intf/renesas-ceu.h | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 include/media/drv

[PATCH v1 05/10] arch: sh: migor: Use new renesas-ceu camera driver

2017-11-15 Thread Jacopo Mondi
so, memory for CEU video buffers is now reserved with membocks APIs, and need to be declared as dma_coherent during machine initialization to remove that architecture specific part from CEU driver. Signed-off-by: Jacopo Mondi --- arch/sh/boards/mach-migor/set

[PATCH v1 06/10] sh: sh7722: Rename CEU clock

2017-11-15 Thread Jacopo Mondi
Rename CEU clock to match the new platform driver name used in Migo-R. There are no other sh7722 based devices Migo-R apart, so we can safely rename this. Signed-off-by: Jacopo Mondi --- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v1 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2017-11-15 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index 4ed12a4..683d459 100644

[RFC v2 2/2] base: dma-mapping: Postpone page_to_pfn() on mmap()

2017-11-14 Thread Jacopo Mondi
mit a proper fix mainline. Not sending for inclusion at the moment. Suggested-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/base/dma-mapping.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c index e5

[PATCH v2 1/2] sh: migor: Reserve memory block for CEU

2017-11-14 Thread Jacopo Mondi
. This is similar to what happens on ARM architecture with 'arm_memblock_steal()' function. Suggested-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- arch/sh/boards/mach-migor/setup.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/sh

[PATCH v2 0/2] Migo-R: reserve memory block with memblock APIs

2017-11-14 Thread Jacopo Mondi
H4 architecture, but please do not consider that patch for inclusion for now. Thanks j Jacopo Mondi (2): sh: migor: Reserve memory block for CEU base: dma-mapping: Postpone page_to_pfn() on mmap() arch/sh/boards/mach-migor/setup.c | 29 +++-- drivers/base/dma-mappin

Re: [PATCH] sh: migor: Reserve memory block for CEU

2017-11-14 Thread jacopo mondi
7;m basing my patches to move Migo-R to use the new CEU driver on top of them. Thanks j > > On Wednesday, 8 November 2017 20:05:46 EET Jacopo Mondi wrote: > > A memory region for CEU video buffer has to be reserved during machine > > initialization. > > > > Or

Re: [PATCH] i2c: sh_mobile: send STOP according to datasheet

2017-11-14 Thread jacopo mondi
e > quite a lot, so let's do it. > > Signed-off-by: Wolfram Sang > --- > > Jacopo: another one to test, pretty please. No regressions on Migo-R during image capture. Tested-by: Jacopo Mondi Thanks j > > drivers/i2c/busses/i2c-sh_mobile.c | 29 ++--

Re: [RFT] i2c: sh_mobile: avoid unnecessary register read

2017-11-14 Thread jacopo mondi
I didn't find a > better solution yet. The compiler will make this cheap anyhow, I guess. > > Jacopo: can you please test this on top of all other patches? No regressions on Migo-R during image capture. Tested-by: Jacopo Mondi Thanks j > > drivers/i2c/busses/i2c-sh_mobile.c |

Re: [RFT] i2c: sh_mobile: let RuntimePM do the clock handling

2017-11-08 Thread jacopo mondi
preciable differences with this patch applied, the image sensor is properly detected and I can grab an image. For this one as well: Tested-by: Jacopo Mondi Thanks j > > I tested it on a Lager and it worked there. Will try Gen3 later, too. > > drivers/i2c/busses/i2c-sh_mobile.c | 2

[PATCH] sh: migor: Reserve memory block for CEU

2017-11-08 Thread Jacopo Mondi
system RAM. This is similar to what happens on ARM architecture with 'arm_memblock_steal()' function. Suggested-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- arch/sh/boards/mach-migor/setup.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/arch/

Re: [PATCH RFT 0/5] i2c: sh_mobile: refactor HW init/deinit

2017-11-03 Thread jacopo mondi
nnot try capture, as I currently have issues with mmap on SH4 :( If you want me to run some specific tests, let me know. Otherwise you can add my Tested-by: Jacopo Mondi Cheers! j > > Looking forward to other comments, as well... > > > Wolfram Sang (5): > i2c: sh_mobile: r

[PATCH v2] clocksource/drivers/ostm: Use unique device name instead of ostm

2017-10-11 Thread Jacopo Mondi
-ostm: used for clocksource -ostm: used for clock events +ostm /timer@fcfec000: used for clocksource +ostm /timer@fcfec400: used for clock events Signed-off-by: Geert Uytterhoeven Signed-off-by: Jacopo Mondi Tested-by: Jacopo Mondi --- Hi Geert, with your original patch boot log

[PATCH 1/2] ARM: dts: gr-peach: Add ETHER pin group

2017-10-09 Thread Jacopo Mondi
Add pin configuration subnode for ETHER pin group. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100-gr-peach.dts | 39 + 1 file changed, 39 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-gr-peach.dts b/arch/arm/boot/dts/r7s72100-gr-peach.dts

[PATCH 2/2] ARM: dts: gr-peach: Enable ostm0 and ostm1 timers

2017-10-09 Thread Jacopo Mondi
, resolution 30ns, wraps every 64440619504ns ostm: used for clocksource ostm: used for clock events Signed-off-by: Jacopo Mondi Suggested-by: Chris Brandt --- arch/arm/boot/dts/r7s72100-gr-peach.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-gr-peach.dts b

[PATCH 0/2] ARM: dts: gr-peach: ETHER and OS Timers enable

2017-10-09 Thread Jacopo Mondi
k and clock event source. This patch has been suggested by Chris, as that's how the BSP initializes timers by default. Thanks j Jacopo Mondi (2): ARM: dts: gr-peach: Add ETHER pin group ARM: dts: gr-peach: Enable ostm0 and ostm1 timers arch/arm/boot/dts/r7s72100-gr-peach.dts | 47 +++

<    3   4   5   6   7   8   9   10   11   >