On Mon, Jul 04, 2016 at 08:59:53AM +, Kuninori Morimoto wrote:
> > If we try to dereference card->dai_link without checking to see if it's
> > set then we'll crash.
> Ahh, do you mean we need like this ?
> if (!card->name && card->dai_link)
> card->name = card->dai_link->name;
Yes,
Hi Mark
Thank you for your feedback
> > This function tries to get card name from snd_soc_of_parse_card_name().
> > and it tries to set card->name from dai_link if card still doesn't have
> > name.
> > So, above is optional 2nd try.
> > Or, do you mean this if (!card->name) can goes to
On Mon, Jul 04, 2016 at 12:20:29AM +, Kuninori Morimoto wrote:
> > > > > > + if (!card->name)
> > > > > > + card->name = card->dai_link->name;
> > > > > This will unconditionally defererence dai_link but it's optional - we
> > > > > can have analogue only cards.
> > > > This is
Hi Mark, again
sorry previous was not good question
> > > > > + if (!card->name)
> > > > > + card->name = card->dai_link->name;
> >
> > > > This will unconditionally defererence dai_link but it's optional - we
> > > > can have analogue only cards.
> >
> > > This is not new
Hi Mark
> > > > + if (!card->name)
> > > > + card->name = card->dai_link->name;
>
> > > This will unconditionally defererence dai_link but it's optional - we
> > > can have analogue only cards.
>
> > This is not new feature. Current simple-card already has it.
>
> Right,
On Thu, Jun 30, 2016 at 02:55:06AM +, Kuninori Morimoto wrote:
> > > + if (!card->name)
> > > + card->name = card->dai_link->name;
> > This will unconditionally defererence dai_link but it's optional - we
> > can have analogue only cards.
> This is not new feature. Current
Hi Mark
> > + if (!card->name)
> > + card->name = card->dai_link->name;
>
> This will unconditionally defererence dai_link but it's optional - we
> can have analogue only cards.
This is not new feature. Current simple-card already has it.
commit
On Tue, May 31, 2016 at 09:01:34AM +, Kuninori Morimoto wrote:
> + if (!card->name)
> + card->name = card->dai_link->name;
This will unconditionally defererence dai_link but it's optional - we
can have analogue only cards.
signature.asc
Description: PGP signature
