Re: [PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-07-26 Thread Wolfram Sang
> I agree but I could not find a neat way of doing it. How about? > > bool use_4tap = host->pdata->flags & TMIO_MMC_HAVE_4TAP_HS400; > > if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) && > !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) && > !(host->mmc->ios.timing

Re: [PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-07-25 Thread Niklas Söderlund
Hi Wolfram, On 2018-07-25 14:21:07 +0200, Wolfram Sang wrote: > Hi Niklas, > > > * Changes since v3 > > - Add check for 4TAP for HS400. > > Is it the same in the BSP or where does this info come from? It comes from the BSP but I had to modify it to fit with the upstream implementation of 4 vs

Re: [PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-07-25 Thread Wolfram Sang
Hi Niklas, > * Changes since v3 > - Add check for 4TAP for HS400. Is it the same in the BSP or where does this info come from? > + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) && > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) && > + !(host->mmc->ios.timing ==

[PATCH 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-07-25 Thread Niklas Söderlund
From: Masaharu Hayakawa Checking for SCC error during retuning is unnecessary. Signed-off-by: Masaharu Hayakawa [Niklas: fix small style issue] Signed-off-by: Niklas Söderlund --- * Changes since v3 - Add check for 4TAP for HS400. * Changes since v2 - Added check for HS400 as it's now