Re: [PATCH RFT] i2c: sh_mobile: make sure to not accidently trigger STOP

2017-11-27 Thread Wolfram Sang
On Wed, Nov 15, 2017 at 03:32:21PM +0100, Wolfram Sang wrote: > The datasheet was a bit vague, but after consultation with HW designers, > we came to the conclusion that we should set the SCP bit always when > dealing only with the ICE bit. A set SCP bit is ignored, and thus fine, > a cleared one m

Re: [PATCH RFT] i2c: sh_mobile: make sure to not accidently trigger STOP

2017-11-17 Thread jacopo mondi
Hi Wolfram, On Wed, Nov 15, 2017 at 03:32:21PM +0100, Wolfram Sang wrote: > The datasheet was a bit vague, but after consultation with HW designers, > we came to the conclusion that we should set the SCP bit always when > dealing only with the ICE bit. A set SCP bit is ignored, and thus fine, > a

[PATCH RFT] i2c: sh_mobile: make sure to not accidently trigger STOP

2017-11-15 Thread Wolfram Sang
The datasheet was a bit vague, but after consultation with HW designers, we came to the conclusion that we should set the SCP bit always when dealing only with the ICE bit. A set SCP bit is ignored, and thus fine, a cleared one may trigger STOP on the bus. Signed-off-by: Wolfram Sang --- Jacopo: