Re: [PATCH 24/24] drm/bridge: establish a link between the bridge supplier and consumer

On 2018-04-30 17:32, Daniel Vetter wrote: > On Fri, Apr 27, 2018 at 12:31:39AM +0200, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (the

Re: [PATCH 23/24] drm/bridge: require the .owner to be filled in on drm_bridge_attach

On 2018-04-30 17:24, Daniel Vetter wrote: > On Fri, Apr 27, 2018 at 12:31:38AM +0200, Peter Rosin wrote: >> The .owner will be handy to have around. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/gpu/drm/drm_bridge.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff

Re: [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

On Mon, Apr 30, 2018 at 02:25:33PM +0300, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote: > > Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances") > > introduced the FDP1 for the r8a7790, but

Re: [PATCH V3] PCI: rcar: Clean up the macros

On Sun, Apr 08, 2018 at 08:04:31PM +0200, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, > no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy

Re: [PATCH v2 0/5] Add R8A77980 PCIe support & some driver cleanups

On Sun, Apr 08, 2018 at 08:57:13PM +0300, Sergei Shtylyov wrote: > Hello! > > Here's a set of 5 patches against the 'pci/rcar' branch of Lorenzo Pieralisi's > 'pci.git' repo. These are the changes needed for better R-Car gen3 support > (namely for R8A77980 support) plus some PCIe driver

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

On Thu, Apr 26, 2018 at 12:29:47PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote: > > On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote: > > > The r8a7790 has three FDP1 instances. > > > > > > Signed-off-by: Laurent

Re: [PATCH] i2c: busses: remove superfluous ignoring of children for RPM

On Sun, Apr 29, 2018 at 8:41 PM, Wolfram Sang wrote: > These days, the I2C core ensures that the embedded adapter device > ignores the PM states of its children already. Because the adapter > device is an opaque logical device, there is no need for drivers to >

Re: [PATCH v7 4/8] media: vsp1: Convert display lists to use new body pool

Hi Laurent, On 06/04/18 23:55, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 8 March 2018 02:05:27 EEST Kieran Bingham wrote: >> Adapt the dl->body0 object to use an object from the body pool. This >> greatly reduces the pressure on the TLB for IPMMU use

Re: igt trouble with planes shared between multiple CRTCs (Re: [PATCH v2 0/8] R-Car DU: Support CRC calculation)

On Sat, Apr 28, 2018 at 12:07:04AM +0300, Laurent Pinchart wrote: > Hi Daniel, > > (Removing the linux-media mailing list from CC as it is out of scope) > > You enquired on IRC whether this patch series passes the igt CRC tests. > > # ./kms_pipe_crc_basic --run-subtest read-crc-pipe-A >

Re: [PATCH 23/24] drm/bridge: require the .owner to be filled in on drm_bridge_attach

On Fri, Apr 27, 2018 at 12:31:38AM +0200, Peter Rosin wrote: > The .owner will be handy to have around. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/drm_bridge.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_bridge.c

Re: [PATCH 24/24] drm/bridge: establish a link between the bridge supplier and consumer

On Fri, Apr 27, 2018 at 12:31:39AM +0200, Peter Rosin wrote: > If the bridge supplier is unbound, this will bring the bridge consumer > down along with the bridge. Thus, there will no longer linger any > dangling pointers from the bridge consumer (the drm_device) to some > non-existent bridge

Re: [PATCH v7 3/8] media: vsp1: Provide a body pool

Hi Laurent, On 06/04/18 23:33, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 8 March 2018 02:05:26 EEST Kieran Bingham wrote: >> Each display list allocates a body to store register values in a dma >> accessible buffer from a dma_alloc_wc() allocation. Each

Re: igt trouble with planes shared between multiple CRTCs (Re: [PATCH v2 0/8] R-Car DU: Support CRC calculation)

On Mon, Apr 30, 2018 at 04:55:24PM +0200, Daniel Vetter wrote: > On Sat, Apr 28, 2018 at 12:07:04AM +0300, Laurent Pinchart wrote: > > Hi Daniel, > > > > (Removing the linux-media mailing list from CC as it is out of scope) > > > > You enquired on IRC whether this patch series passes the igt CRC

Re: [PATCH 00/24] device link, bridge supplier <-> drm device

On Fri, Apr 27, 2018 at 01:40:21AM +0300, Laurent Pinchart wrote: > Hi Peter, > > Thank you for the patches. > > On Friday, 27 April 2018 01:31:15 EEST Peter Rosin wrote: > > Hi! > > > > It was noted by Russel King [1] that bridges (not using components) > > might disappear unexpectedly if the

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

Hi Laurent, On 07/04/18 01:23, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 8 March 2018 02:05:31 EEST Kieran Bingham wrote: >> We are now able to configure a pipeline directly into a local display >> list body. Take advantage of this fact, and create a

Re: [PATCH 07/10] ARM: dts: kzm9d: Drop unnecessary address properties from gpio_keys node

On Thu, Apr 26, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your work. > > On 2018-04-26 12:29:48 +0200, Simon Horman wrote: > > The gpio_keys node does not have an address and thus does not need > > address-cells or address size-properties. > > > > This is

Re: [PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

On Fri, Apr 27, 2018 at 01:21:42PM +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patchset removes unused MERAM support (last user was removed > 3 years ago) from shmobile fbdev & drm drivers and then removes > MERAM driver itself. > > If it is okay to merge this patches I would like

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

On Thu, Apr 26, 2018 at 10:41:14PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman > > --- > The patch is

Re: [PATCH v2 07/11] arm64: dts: r8a77965: Add VSP instances

On Fri, Apr 27, 2018 at 05:57:18PM +0100, Kieran Bingham wrote: > The r8a77965 has 4 VSP instances. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart . > > Signed-off-by: Takeshi Kihara >

Re: [PATCH v2 09/11] arm64: dts: r8a77965: Add HDMI encoder instance

On Fri, Apr 27, 2018 at 05:57:20PM +0100, Kieran Bingham wrote: > Add the HDMI encoder to the R8A77965 DT in disabled state. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart . > > Signed-off-by: Takeshi Kihara

Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote: > Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU > unit. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman > --- >

Re: [PATCH 2/2] ARM: dts: iwg23s-sbc: Add EtherAVB support

On Tue, Apr 24, 2018 at 04:37:33PM +0100, Biju Das wrote: > Define the iW-RainboW-G23S board dependent part of the > EtherAVB device node. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson Thanks, applied. > --- > * currently

Re: [PATCH 1/2] ARM: dts: r8a77470: Add EtherAVB support

On Tue, Apr 24, 2018 at 04:37:32PM +0100, Biju Das wrote: > Define the generic R8A77470 part of the EtherAVB device node. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson Thanks, applied.

Re: [PATCH 10/61] gpio: simplify getting .drvdata

On Thu, Apr 19, 2018 at 5:14 PM, Grygorii Strashko wrote: > On 04/19/2018 09:05 AM, Wolfram Sang wrote: >> >> We should get drvdata from struct device directly. Going via >> platform_device is an unneeded step back and forth. >> >> Signed-off-by: Wolfram Sang

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

On Thu, Apr 26, 2018 at 05:20:05PM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2018-04-25 09:18:51 +0200, Simon Horman wrote: > > On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > > > Store the group pointer before disassociating the VIN from

Re: [PATCH v2 06/11] arm64: dts: r8a77965: Add FCPF and FCPV instances

On Fri, Apr 27, 2018 at 05:57:17PM +0100, Kieran Bingham wrote: > The FCPs handle the interface between various IP cores and memory. Add > the instances related to the FDPs and VSP2s. > > Based on a similar patch of the R8A7796 device tree > by Laurent Pinchart

Re: [PATCH v2 08/11] arm64: dts: r8a77965: Populate the DU instance placeholder

On Fri, Apr 27, 2018 at 05:57:19PM +0100, Kieran Bingham wrote: > The DU entity node has been previously added but only as a placeholder. > Populate the node with the properties to use the device. > > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent

Re: [PATCH v3 0/6] arm: dts: r8a77965 DU enablement

On Sat, Apr 28, 2018 at 01:06:20AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Saturday, 28 April 2018 01:02:14 EEST Kieran Bingham wrote: > > Provide the required DT updates to enable the DU and, VGA and HDMI > > outputs on the M3-N Salvator-X(S) platforms. > > > > Driver updates and

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

On 04/27/2018 08:53 PM, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov Applied to linux-can. tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH 10/61] gpio: simplify getting .drvdata

> Wolfram: if I don't find it, poke me with something sharp so I get to apply > it. I just bounced it again. Otherwise, it is here, too, downloadable as mbox: https://patchwork.kernel.org/patch/10350759/ signature.asc Description: PGP signature

Re: [PATCH] i2c: rcar: enhance comment to avoid regressions

On Sat, Apr 28, 2018 at 10:01:02PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > Give a clear testcase for people wishing to change this code. It is also > a reminder for me if people ask about it. > > Signed-off-by: Wolfram Sang

Re: [PATCH 10/61] gpio: simplify getting .drvdata

On Mon, Apr 30, 2018 at 11:03:25AM +0200, Linus Walleij wrote: > On Thu, Apr 19, 2018 at 5:14 PM, Grygorii Strashko > wrote: > > On 04/19/2018 09:05 AM, Wolfram Sang wrote: > >> > >> We should get drvdata from struct device directly. Going via > >> platform_device is an

Re: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI

On Sat, Apr 28, 2018 at 12:34:26AM +0300, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 27 April 2018 19:57:21 EEST Kieran Bingham wrote: > > The DU1 external dot clock is provided by the fixed frequency clock > > generator X21, while the DU0 and DU3 clocks are

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

On Fri, Apr 27, 2018 at 09:53:33PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against the 'linux-can-next.git' repo plus the R8A77970

Re: [PATCH v2] arm64: dts: renesas: condor: add eMMC support

On Tue, Apr 24, 2018 at 10:25:24PM +0300, Sergei Shtylyov wrote: > Define the Condor board dependent part of the MMC0 (connected to eMMC chip) > device node along with the necessary voltage regulators... > > Signed-off-by: Sergei Shtylyov > > --- > This patch

RE: [PATCH 2/2] ARM: dts: iwg23s-sbc: Add EtherAVB support

Hi Simon, > -Original Message- > From: Simon Horman [mailto:ho...@verge.net.au] > Sent: 30 April 2018 09:00 > To: Biju Das > Cc: Rob Herring ; Mark Rutland > ; Magnus Damm ; > Geert Uytterhoeven

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

On 04/27/2018 01:33 PM, Ramesh Shanmugasundaram wrote: > Hello Sergei, > > Thanks for your patch. > >> Subject: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings >> >> Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD >> bindings. >> >> Signed-off-by: Sergei Shtylyov

Re: [PATCH 43/61] pwm: simplify getting .drvdata

On Thu, Apr 19, 2018 at 04:06:13PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy.

Re: [PATCH v7 6/8] media: vsp1: Refactor display list configure operations

Hi Laurent, On 07/04/18 00:38, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 8 March 2018 02:05:29 EEST Kieran Bingham wrote: >> The entities provide a single .configure operation which configures the >> object into the target display list, based on the

[PATCH] i2c: mux: demux-pinctrl: disable PM user interface

The demux device is only a logical device with no children. So, no RuntimePM is needed, let's disable the sysfs interface for it. Signed-off-by: Wolfram Sang --- I think it is proper to just disable the interface without enabling RPM at all. USB and PCIE core

Re: [PATCH 22/24] drm/bridge: remove the .of_node member

On 2018-04-28 10:09, kbuild test robot wrote: > Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on v4.17-rc2] > [also build test ERROR on next-20180426] > [cannot apply to drm/drm-next robclark/msm-next > drm-exynos/exynos-drm/for-next] > [if your patch is

Re: [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

Hi Kieran, Thank you for the patch. On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote: > Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances") > introduced the FDP1 for the r8a7790, but broke the sort ordering of the > device tree nodes. > > Move the last VSP up to

[PATCH 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter

Due to a typo, the wrong parent device was assigned to the newly created demuxing adapter device. It got connected to the demuxing platform device but not to the selected parent I2C adapter device. Fix it to get a proper parent-child relationship of the demuxed busses, needed also for proper PM.

[PATCH 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs

Similar to mux devices, create special symlinks to connect the demuxed bus with the demux device. Signed-off-by: Wolfram Sang --- drivers/i2c/muxes/i2c-demux-pinctrl.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 0/2] i2c: mux: demux-pinctrl: improve device relationships

While researching some PM behaviour within I2C, I found out that the i2c-demux driver does not play well with that due to broken relationship with other devices. Patch 1 ensures the right parent-child relationship. Patch 2 makes the connection between the demux device and the demuxed bus similar

[PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances") introduced the FDP1 for the r8a7790, but broke the sort ordering of the device tree nodes. Move the last VSP up to it's peers to correct the ordering. Signed-off-by: Kieran Bingham