Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 15:46, Frank Rowand wrote: > On 01/15/18 12:29, Laurent Pinchart wrote: >> Hi Frank, >> >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >>> On 01/15/18 11:22, Laurent Pinchart wrote: On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: > On 01/15/18

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 12:29, Laurent Pinchart wrote: > Hi Frank, > > On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >> On 01/15/18 11:22, Laurent Pinchart wrote: >>> On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: On 01/15/18 09:09, Rob Herring wrote: > +Frank > >

Re: [PATCH v2 0/6] i2c: send STOP after recovery; use it for i2c-rcar

2018-01-15 Thread Wolfram Sang
On Tue, Jan 09, 2018 at 02:58:53PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > When implementing bus recovery for the i2c-rcar driver, two problems were > encountered: 1) When reading the SDA bit, not the SDA status was returned but > the internal state

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Sergei Shtylyov
On 01/15/2018 11:32 PM, Laurent Pinchart wrote: The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. Backward

Re: [PATCH v2] vsp1: fix video output on R8A77970

2018-01-15 Thread Laurent Pinchart
Hi Sergei, On Monday, 15 January 2018 18:06:48 EET Sergei Shtylyov wrote: > On 01/15/2018 03:51 PM, Laurent Pinchart wrote: > > On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: > >> Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) > >> but > > > > I'm not

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Laurent Pinchart
Hi Sergei, On Monday, 15 January 2018 22:25:16 EET Sergei Shtylyov wrote: > On 01/13/2018 02:14 AM, Laurent Pinchart wrote: > > The LVDS encoders used to be described in DT as part of the DU. They now > > have their own DT node, linked to the DU using the OF graph bindings. > > This allows moving

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Laurent Pinchart
Hi Frank, On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: > On 01/15/18 11:22, Laurent Pinchart wrote: > > On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: > >> On 01/15/18 09:09, Rob Herring wrote: > >>> +Frank > >>> > >>> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge.

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 11:22, Laurent Pinchart wrote: > Hi Frank, > > On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: >> On 01/15/18 09:09, Rob Herring wrote: >>> +Frank >>> >>> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: The internal LVDS encoders now have their own DT

Re: [PATCH 0/2] sh_eth: simplify TSU initialization

2018-01-15 Thread David Miller
From: Sergei Shtylyov Date: Sun, 14 Jan 2018 20:47:42 +0300 > Here's a set of 2 patches against DaveM's 'net-next.git' repo. With those, > I'm somewhat simplifying the TSU init code in the driver probe() method... > > [1/2] sh_eth: gather all TSU init code in

Re: [PATCH] sh_eth: dix dumping ARSTR

2018-01-15 Thread David Miller
From: Sergei Shtylyov Date: Sat, 13 Jan 2018 20:22:01 +0300 > ARSTR is always located at the start of the TSU register region, thus > using add_reg() instead of add_tsu_reg() in __sh_eth_get_regs() to dump it > causes EDMR or EDSR (depending on the register

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Laurent Pinchart
Hi Frank, On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: > On 01/15/18 09:09, Rob Herring wrote: > > +Frank > > > > On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: > >> The internal LVDS encoders now have their own DT bindings. Before > >> switching the driver

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 09:09, Rob Herring wrote: > +Frank > > On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart > wrote: >> The internal LVDS encoders now have their own DT bindings. Before >> switching the driver infrastructure to those new bindings, implement >>

[PATCH/RFT v3] gpio: gpio-rcar: Support S2RAM

2018-01-15 Thread Yoshihiro Kaneko
From: Hien Dang This patch adds an implementation that saves and restores the state of GPIO configuration on suspend and resume. Signed-off-by: Hien Dang Signed-off-by: Takeshi Kihara [Modify structure of the

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Laurent Pinchart
Hi Rob, (CC'ing Geert) On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: > +Frank > > On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Rob Herring
+Frank On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: > The internal LVDS encoders now have their own DT bindings. Before > switching the driver infrastructure to those new bindings, implement > backward-compatibility through live DT patching.

Re: [RFC PATCH 0/7] i2c: sh_mobile: support per-SoC frequency calculation

2018-01-15 Thread Wolfram Sang
On Mon, Dec 18, 2017 at 10:57:55PM +0100, Wolfram Sang wrote: > The current calculation for I2C bus speeds does not match the datasheet and > is, > in deed, a little too fast for 100kHz settings (~107kHz have been measured). > > This series implements a second calculation according to the

Re: [PATCH] [VSP-Tests] tests: add pseudo platform test

2018-01-15 Thread Kieran Bingham
Ahem, ... Not that it really matters but perhaps that should read 'add platform pseudo test' instead.? -- Kieran On 15/01/18 16:47, Kieran Bingham wrote: > From: Kieran Bingham > > Provide an initial test which can run as part of the test suite. > This test

[PATCH] [VSP-Tests] tests: add pseudo platform test

2018-01-15 Thread Kieran Bingham
From: Kieran Bingham Provide an initial test which can run as part of the test suite. This test will report the platform and kernel version, along with the identified paths of required utilities. This will aid in ensuring that required tools are available on a

[PATCH v5 7/9] v4l: vsp1: Adapt entities to configure into a body

2018-01-15 Thread Kieran Bingham
Currently the entities store their configurations into a display list. Adapt this such that the code can be configured into a body directly, allowing greater flexibility and control of the content. All users of vsp1_dl_list_write() are removed in this process, thus it too is removed. A helper,

[PATCH v5 4/9] v4l: vsp1: Convert display lists to use new body pool

2018-01-15 Thread Kieran Bingham
Adapt the dl->body0 object to use an object from the body pool. This greatly reduces the pressure on the TLB for IPMMU use cases, as all of the lists use a single allocation for the main body. The CLU and LUT objects pre-allocate a pool containing three bodies, allowing a userspace update before

[PATCH v5 2/9] v4l: vsp1: Protect bodies against overflow

2018-01-15 Thread Kieran Bingham
The body write function relies on the code never asking it to write more than the entries available in the list. Currently with each list body containing 256 entries, this is fine, but we can reduce this number greatly saving memory. In preparation of this add a level of protection to catch any

[PATCH v5 5/9] v4l: vsp1: Use reference counting for bodies

2018-01-15 Thread Kieran Bingham
Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v5 8/9] v4l: vsp1: Move video configuration to a cached dlb

2018-01-15 Thread Kieran Bingham
We are now able to configure a pipeline directly into a local display list body. Take advantage of this fact, and create a cacheable body to store the configuration of the pipeline in the video object. vsp1_video_pipeline_run() is now the last user of the pipe->dl object. Convert this function to

[PATCH v5 9/9] v4l: vsp1: Reduce display list body size

2018-01-15 Thread Kieran Bingham
The display list originally allocated a body of 256 entries to store all of the register lists required for each frame. This has now been separated into fragments for constant stream setup, and runtime updates. Empirical testing shows that the body0 now uses a maximum of 41 registers for each

[PATCH v5 6/9] v4l: vsp1: Refactor display list configure operations

2018-01-15 Thread Kieran Bingham
The entities provide a single .configure operation which configures the object into the target display list, based on the vsp1_entity_params selection. This restricts us to a single function prototype for both static configuration (the pre-stream INIT stage) and the dynamic runtime stages for

[PATCH v5 0/9] vsp1: TLB optimisation and DL caching

2018-01-15 Thread Kieran Bingham
Each display list currently allocates an area of DMA memory to store register settings for the VSP1 to process. Each of these allocations adds pressure to the IPMMU TLB entries. We can reduce the pressure by pre-allocating larger areas and dividing the area across multiple bodies represented as a

[PATCH v5 3/9] v4l: vsp1: Provide a body pool

2018-01-15 Thread Kieran Bingham
Each display list allocates a body to store register values in a dma accessible buffer from a dma_alloc_wc() allocation. Each of these results in an entry in the TLB, and a large number of display list allocations adds pressure to this resource. Reduce TLB pressure on the IPMMUs by allocating

[PATCH v5 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body'

2018-01-15 Thread Kieran Bingham
Throughout the codebase, the term 'fragment' is used to represent a display list body. This term duplicates the 'body' which is already in use. The datasheet references these objects as a body, therefore replace all mentions of a fragment with a body, along with the corresponding pluralised

Re: [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework

2018-01-15 Thread Rafael J. Wysocki
On Mon, Jan 15, 2018 at 3:26 PM, Ulf Hansson wrote: > On 15 January 2018 at 14:22, Geert Uytterhoeven wrote: [cut] >> >> I did miss a small difference in topology: in pm/linux-next, H3 has DMA >> enabled for SCIF2, while M3 hasn't (yet). >> With

Re: [PATCH v2] vsp1: fix video output on R8A77970

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/15/2018 03:51 PM, Laurent Pinchart wrote: On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but I'm not sure there's a need to state my name in the commit message. You were the author of

Re: [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework

2018-01-15 Thread Ulf Hansson
On 15 January 2018 at 14:22, Geert Uytterhoeven wrote: > Hi Rafael, > > On Mon, Jan 15, 2018 at 9:16 AM, Geert Uytterhoeven > wrote: >> On Mon, Jan 15, 2018 at 1:04 AM, Rafael J. Wysocki wrote: >>> On Sun, Jan 14, 2018 at 10:48 AM,

Re: [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework

2018-01-15 Thread Geert Uytterhoeven
Hi Rafael, On Mon, Jan 15, 2018 at 9:16 AM, Geert Uytterhoeven wrote: > On Mon, Jan 15, 2018 at 1:04 AM, Rafael J. Wysocki wrote: >> On Sun, Jan 14, 2018 at 10:48 AM, Geert Uytterhoeven >> wrote: >>> On Sat, Jan 13, 2018 at 1:38

Re: [PATCH v2] vsp1: fix video output on R8A77970

2018-01-15 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: > Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but I'm not sure there's a need to state my name in the commit message. > the video output that VSP2-D sends to DU has

[PATCH] [LOCAL] arm64: renesas_defconfig: Use a default 128MB of CMA

2018-01-15 Thread Kieran Bingham
Our media tests frequently need large areas of CMA. Define the default allocation to be 128 MBytes to support larger use-cases. Signed-off-by: Kieran Bingham Acked-by: Laurent Pinchart --- v1.1 - Collected Laurent's Acked-by

Re: [PATCH v2 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git

Re: [PATCH v2 07/12] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/13/2018 02:14 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git

Re: [PATCH 3/3] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-01-15 Thread Daniel Thompson
On 14/01/18 21:07, Wolfram Sang wrote: The documentation was wrong, gpiod_get_direction() returns 0/1 instead of the GPIOF_* flags. The docs were fixed with commit 94fc73094abe47 ("gpio: correct docs about return value of gpiod_get_direction"). Now, fix this user (until a better, system-wide

Re: [PATCH 2/3] arm64: dts: renesas: eagle: Remove renesas, no-ether-link property

2018-01-15 Thread Sergei Shtylyov
Hello! On 1/15/2018 11:41 AM, Simon Horman wrote: Regarding Salvator-X and ULCB boards, Bogdan Mirea says: Intended to reply to the original patches but due to high load haven't ever finished that email... The present change is a bug fix for AVB link iteratively up/down.

[PATCH 0/3] arm64: dts: v3msk, eagle, draak: Remove renesas,no-ether-link property

2018-01-15 Thread Simon Horman
tion and not on software heuristic. Bogdan Mirea also highlighted that this change may be relevant to the DTS files for V3M Starter Kit, Draak and Eagle boards. Examination of the relevant documentation has confirmed this. Based on renesas-devel-20180115-v4.15-rc8 Simon Horman (3): arm6

[PATCH 3/3] arm64: dts: renesas: draak: Remove renesas, no-ether-link property

2018-01-15 Thread Simon Horman
Regarding Salvator-X and ULCB boards, Bogdan Mirea says: The present change is a bug fix for AVB link iteratively up/down. Steps to reproduce: - start AVB TX stream (Using aplay via MSE), - disconnect+reconnect the eth cable, - after a reconnection the eth connection goes

[PATCH 1/3] arm64: dts: renesas: v3msk: Remove renesas, no-ether-link property

2018-01-15 Thread Simon Horman
Regarding Salvator-X and ULCB boards, Bogdan Mirea says: The present change is a bug fix for AVB link iteratively up/down. Steps to reproduce: - start AVB TX stream (Using aplay via MSE), - disconnect+reconnect the eth cable, - after a reconnection the eth connection goes

[PATCH 2/3] arm64: dts: renesas: eagle: Remove renesas, no-ether-link property

2018-01-15 Thread Simon Horman
Regarding Salvator-X and ULCB boards, Bogdan Mirea says: The present change is a bug fix for AVB link iteratively up/down. Steps to reproduce: - start AVB TX stream (Using aplay via MSE), - disconnect+reconnect the eth cable, - after a reconnection the eth connection goes

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Laurent Pinchart
Hi Geert, On Monday, 15 January 2018 10:30:23 EET Geert Uytterhoeven wrote: > On Sat, Jan 13, 2018 at 12:14 AM, Laurent Pinchart wrote: > > The LVDS encoders used to be described in DT as part of the DU. They now > > have their own DT node, linked to the DU using the OF graph bindings. > > This

Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-01-15 Thread Geert Uytterhoeven
Hi Laurent, On Sat, Jan 13, 2018 at 12:14 AM, Laurent Pinchart wrote: > The LVDS encoders used to be described in DT as part of the DU. They now > have their own DT node, linked to the DU using the OF graph bindings. > This allows moving internal LVDS

Re: [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-01-15 Thread Laurent Pinchart
Hi Geert, On Monday, 15 January 2018 10:05:59 EET Geert Uytterhoeven wrote: > On Mon, Jan 15, 2018 at 7:59 AM, Laurent Pinchart wrote: > > On Monday, 15 January 2018 08:55:29 EET Simon Horman wrote: > >> On Fri, Jan 12, 2018 at 03:29:48PM +0200, Laurent Pinchart wrote: > >>> On Friday, 12 January

Re: [PATCH 05/10] ARM: dts: porter: Fix HDMI output routing

2018-01-15 Thread Laurent Pinchart
Hi Simon, On Monday, 15 January 2018 09:56:03 EET Simon Horman wrote: > On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > > The HDMI encoder is connected to the RGB output of the DU, which is > > port@0, not port@1. Fix the incorrect DT description. > > > > Signed-off-by:

Re: [PATCH 0/2] PM / core: genpd fix and pm_runtime_force_suspend|resume() rework

2018-01-15 Thread Geert Uytterhoeven
Hi Rafael, On Mon, Jan 15, 2018 at 1:04 AM, Rafael J. Wysocki wrote: > On Sun, Jan 14, 2018 at 10:48 AM, Geert Uytterhoeven > wrote: >> On Sat, Jan 13, 2018 at 1:38 AM, Rafael J. Wysocki >> wrote: >>> On Friday, January 12, 2018

Re: [PATCH 2/2] sh_eth: get Ether port # only when needed

2018-01-15 Thread Geert Uytterhoeven
On Sun, Jan 14, 2018 at 6:47 PM, Sergei Shtylyov wrote: > The dual-port Ether configurations always have a shared TSU to e.g. pass > the packets between those ports. With the TSU init. code gathered under > the single *if*, we now can only get the port #

Re: [PATCH 1/2] sh_eth: gather all TSU init code in one place

2018-01-15 Thread Geert Uytterhoeven
On Sun, Jan 14, 2018 at 6:47 PM, Sergei Shtylyov wrote: > The sh_eth_cpu_data::chip_reset() method always resets using ARSTR and > this register is always located at the start of the TSU register region. > Therefore, we can only call this method if we know

Re: [PATCH 01/10] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-01-15 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jan 15, 2018 at 7:59 AM, Laurent Pinchart wrote: > On Monday, 15 January 2018 08:55:29 EET Simon Horman wrote: >> On Fri, Jan 12, 2018 at 03:29:48PM +0200, Laurent Pinchart wrote: >> > On Friday, 12 January 2018 12:13:18 EET Geert