[PATCH 3/4] arm64: defconfig: Enable USB 3.0 PHY for R-Car

2018-02-13 Thread Yoshihiro Shimoda
Enable the R-Car's USB 3.0 PHY. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 9f55541..29650e1 100644 ---

[PATCH 1/4] arm64: defconfig: Enable PWM for R-Car

2018-02-13 Thread Yoshihiro Shimoda
Enable the Renesas R-Car's PWM controller. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a850bc5..59c11a5 100644 ---

[PATCH 4/4] arm64: defconfig: Enable USB 3.0 peripheral for R-Car

2018-02-13 Thread Yoshihiro Shimoda
Enable the R-Car's USB 3.0 peripheral controller. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 29650e1..ceafd26 100644 ---

[PATCH 0/4] arm64: defconfig: Enable PWM and USB for R-Car

2018-02-13 Thread Yoshihiro Shimoda
This patch set is based on the renesas.git / renesas-devel-20180213v2-v4.16-rc1 tag. Yoshihiro Shimoda (4): arm64: defconfig: Enable PWM for R-Car arm64: defconfig: Enable USB-DMAC for R-Car arm64: defconfig: Enable USB 3.0 PHY for R-Car arm64: defconfig: Enable USB 3.0 peripheral for

[PATCH 2/4] arm64: defconfig: Enable USB-DMAC for R-Car

2018-02-13 Thread Yoshihiro Shimoda
Enable the R-Car's USB-DMAC controller. This controller will be used by HS-USB (renesas_usbhs driver). Since the renesas_usbhs driver (CONFIG_USB_RENESAS_USBHS_UDC) is enabled as module, the USB-DMAC driver is also enabled as module. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-13 Thread Wolfram Sang
> + chosen { > + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; > + stdout-path = "serial0:38400n8"; Hmm, that would be our first board to not have 115200, or? We already have some other boards upstream where UBoot has 38400 and Linux 115200. I'd prefer

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-13 Thread Wolfram Sang
> - * The r8a7790/lager and r8a7791/koelsch development boards have da9063 and > - * da9210 regulators. Both regulators have their interrupt request lines > tied > - * to the same interrupt pin (IRQ2) on the SoC. > + * The r8a7790/lager,stout and r8a7791/koelsch development boards have da9063 >

RE: [PATCH/RFT v4] gpio: gpio-rcar: Support S2RAM

2018-02-13 Thread Yoshihiro Shimoda
Hi, > From: Yoshihiro Kaneko, Sent: Monday, February 5, 2018 4:15 AM > > From: Hien Dang > > This patch adds an implementation that saves and restores the state of > GPIO configuration on suspend and resume. > > Signed-off-by: Hien Dang >

Re: [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-13 Thread kbuild test robot
Hi Kieran, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc1 next-20180213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-13 Thread Marek Vasut
Stout base board support making use of 1 GiB of memory, the Renesas H2 r8a7790 SoC with the SCIFA0 serial port and CA15 with ARM architected timer. Furthermore, this device tree contains entries for: - 4x LEDs - SDHI SD/MMC controller - Display unit with HDMI output - SH fast ethernet

[PATCH] ARM: shmobile: Document Renesas H2-based Stout DT bindings

2018-02-13 Thread Marek Vasut
Document the Renesas H2 Stout (ADAS Starter Kit) device tree bindings, listing it as a supported board. This allows to use checkpatch.pl to validate .dts files referring to the Stout board. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-02-13 Thread Laurent Pinchart
Hi Niklas, On Wednesday, 14 February 2018 01:12:50 EET Niklas Söderlund wrote: > On 2018-02-14 00:31:21 +0200, Laurent Pinchart wrote: > > On Tuesday, 13 February 2018 18:47:04 EET Niklas Söderlund wrote: > >> On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote: > >>> On Monday, 29 January 2018

[PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-13 Thread Marek Vasut
Regulator setup is suboptimal on H2 Stout too. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Kuninori Morimoto Cc: Simon Horman Cc: Wolfram Sang

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-02-13 Thread Niklas Söderlund
Hi Laurent, On 2018-02-14 00:31:21 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Tuesday, 13 February 2018 18:47:04 EET Niklas Söderlund wrote: > > On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote: > > > On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > > >> There was

Re: [PATCH] videodev2.h: add helper to validate colorspace

2018-02-13 Thread Sakari Ailus
Hi Laurent and Niklas, On Wed, Feb 14, 2018 at 12:23:05AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Wednesday, 14 February 2018 00:08:47 EET Niklas Söderlund wrote: > > There is no way for drivers to validate a colorspace value, which could > > be provided

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-02-13 Thread Laurent Pinchart
Hi Niklas, On Tuesday, 13 February 2018 18:47:04 EET Niklas Söderlund wrote: > On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote: > > On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > >> There was never proper support in the VIN driver to deliver ALTERNATING > >> field format

Re: [PATCH] videodev2.h: add helper to validate colorspace

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday, 14 February 2018 00:08:47 EET Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part

[PATCH] videodev2.h: add helper to validate colorspace

2018-02-13 Thread Niklas Söderlund
There is no way for drivers to validate a colorspace value, which could be provided by user-space by VIDIOC_S_FMT for example. Add a helper to validate that the colorspace value is part of enum v4l2_colorspace. Signed-off-by: Niklas Söderlund ---

Re: [PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patches. On Tuesday, 13 February 2018 21:30:33 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used > as a dual-input image blender, while two VSPD

Re: [PATCH v2 3/4] arm64: dts: renesas: r8a7795: Fix register mappings on VSPs

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 21:30:36 EET Kieran Bingham wrote: > From: Kieran Bingham > > The VSPD includes a CLUT on RPF2. Ensure that the register space is > mapped correctly to support this. > > Signed-off-by:

Re: [PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 21:30:37 EET Kieran Bingham wrote: > From: Kieran Bingham > > The VSPD includes a CLUT on RPF2. Ensure that the register space is > mapped correctly to support this. > > Signed-off-by:

Re: [PATCH v2 2/4] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 21:30:35 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has a VSPBS to support image processing such as blending of > two input images, and has two VSPDs to handle

Re: [PATCH v2 1/4] arm64: dts: renesas: r8a77995: add FCPV nodes

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 21:30:34 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVB handles the interface between the VSPB and memory, while the > FCPVD handles the interface between the VSPD and

Re: [PATCH v10 30/30] rcar-vin: enable support for r8a77970

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:35 EET Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a77970. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

Re: [PATCH v10 29/30] rcar-vin: enable support for r8a7796

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:34 EET Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7796. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/platform/rcar-vin/rcar-core.c | 44

Re: [PATCH v10 29/30] rcar-vin: enable support for r8a7796

2018-02-13 Thread Laurent Pinchart
On Tuesday, 13 February 2018 23:54:55 EET Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Monday, 29 January 2018 18:34:34 EET Niklas Söderlund wrote: > > Add the SoC specific information for Renesas r8a7796. > > > > Signed-off-by: Niklas Söderlund

Re: [PATCH v10 28/30] rcar-vin: enable support for r8a7795

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:33 EET Niklas Söderlund wrote: > Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

Re: [PATCH v10 27/30] rcar-vin: extend {start,stop}_streaming to work with media controller

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:32 EET Niklas Söderlund wrote: > The procedure to start or stop streaming using the non-MC single > subdevice and the MC graph and multiple subdevices are quite different. > Create a new function to abstract which method is

Re: [PATCH v10 26/30] rcar-vin: add link notify for Gen3

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:31 EET Niklas Söderlund wrote: > Add the ability to process media device link change request. Link > enabling is a bit complicated on Gen3, whether or not it's possible to > enable a link depends on what other links already are

Re: [PATCH v10 25/30] rcar-vin: parse Gen3 OF and setup media graph

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:30 EET Niklas Söderlund wrote: > The parsing and registering CSI-2 subdevices with the v4l2 async > framework is a collaborative effort shared between the VIN instances > which are part of the group. When the last VIN in the

Re: [PATCH v10 24/30] rcar-vin: add chsel information to rvin_info

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:29 EET Niklas Söderlund wrote: > Each Gen3 SoC has a limited set of predefined routing possibilities for > which CSI-2 device and virtual channel can be routed to which VIN > instance. Prepare to store this information in the

Re: [PATCH v10 23/30] rcar-vin: change name of video device

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:28 EET Niklas Söderlund wrote: > The rcar-vin driver needs to be part of a media controller to support > Gen3. Give each VIN instance a unique name so it can be referenced from > userspace. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v10 22/30] rcar-vin: add group allocator functions

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:27 EET Niklas Söderlund wrote: > In media controller mode all VIN instances needs to be part of the same > media graph. There is also a need for each VIN instance to know about > and in some cases be able to communicate with

Re: [PATCH v10 21/30] rcar-vin: prepare for media controller mode initialization

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:26 EET Niklas Söderlund wrote: > Prepare for media controller by calling a different initialization then > for when running in device centric mode. Add trivial configuration of s/then for when/than when/ > the mbus and

Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB

2018-02-13 Thread Peter Maydell
On 13 February 2018 at 16:41, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > For

Re: [PATCH v10 20/30] rcar-vin: use different v4l2 operations in media controller mode

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:25 EET Niklas Söderlund wrote: > When the driver runs in media controller mode it should not directly > control the subdevice instead userspace will be responsible for > configuring the pipeline. To be able to run in this mode

[PATCH v2 2/4] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The r8a77995 has a VSPBS to support image processing such as blending of two input images, and has two VSPDs to handle display pipelines with a DU. Signed-off-by: Kieran Bingham --- v2: -

[PATCH v2 3/4] arm64: dts: renesas: r8a7795: Fix register mappings on VSPs

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 6 +++--- 1

[PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++--- 1

[PATCH v2 1/4] arm64: dts: renesas: r8a77995: add FCPV nodes

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The FCPVB handles the interface between the VSPB and memory, while the FCPVD handles the interface between the VSPD and memory. Signed-off-by: Kieran Bingham

[PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used as a dual-input image blender, while two VSPD instances can be utilised as part of a display (DU) pipeline. Add support for these, along with their required

[PATCH v4 0/5] Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham Back in 2014, Jean-Michel provided patches [0] to implement a means of describing software defined I2C addresses for devices through the DT nodes. The patch to implement the function "i2c_new_secondary_device()" was integrated, but

Re: [PATCH v10 19/30] rcar-vin: set a default field to fallback on

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:24 EET Niklas Söderlund wrote: > If the field is not supported by the driver it should not try to keep > the current field. Instead it should set it to a default fallback. Since > trying a format should always result in the

[PATCH v4 2/5] dt-bindings: adv7511: Extend bindings to allow specifying slave map addresses

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

[PATCH v4 4/5] media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

[PATCH v4 1/5] dt-bindings: media: adv7604: Extend bindings to allow specifying slave map addresses

2018-02-13 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

[PATCH v4 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C bus, however in low power mode the ADV7513 will reset it's slave maps to use the hardware defined default addresses. The ADV7511 driver was adapted to allow the two

[PATCH v4 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

2018-02-13 Thread Niklas Söderlund
Hi Laurent, On 2018-02-13 19:02:38 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Tuesday, 13 February 2018 18:58:09 EET Niklas Söderlund wrote: > > On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > > > On Gen3 the

Re: [PATCH v10 18/30] rcar-vin: add check for colorspace

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:23 EET Niklas Söderlund wrote: > Add a check to ensure the colorspace from user-space is good. On Gen2 it > works without this change as the sensor sets the colorspace but on Gen3 > this can fail if the colorspace provided by

Re: [PATCH v10 17/30] rcar-vin: update pixelformat check for M1

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:22 EET Niklas Söderlund wrote: > If the pixelformat is not supported it should not fail but be set to > something that works. While we are at it move the check together with > other pixelformat checks of this function. Please

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

2018-02-13 Thread Laurent Pinchart
Hi Niklas, On Tuesday, 13 February 2018 18:58:09 EET Niklas Söderlund wrote: > On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > > > feature of

Re: [PATCH v10 16/30] rcar-vin: update bytesperline and sizeimage calculation

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:21 EET Niklas Söderlund wrote: > Remove over complicated logic to calculate the value for bytesperline s/over complicated/overcomplicated/ > and sizeimage that was carried over from the soc_camera port. Update the >

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

2018-02-13 Thread Niklas Söderlund
Hi Laurent, On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > > feature of this register is that it's

Re: [PATCH v10 15/30] rcar-vin: break out format alignment and checking

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:20 EET Niklas Söderlund wrote: > Part of the format alignment and checking can be shared with the Gen3 > format handling. Break that part out to a separate function. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-02-13 Thread Niklas Söderlund
Hi Laurent, On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. Thanks for your comments. > > On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > > There was never proper support in the VIN driver to deliver ALTERNATING > > field

[PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB

2018-02-13 Thread Geert Uytterhoeven
It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE For reference, the largest arm64 DTB created from the Linux sources is 70 KiB large (93 KiB

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the

Re: [PATCH v10 11/30] rcar-vin: move media bus configuration to struct rvin_info

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:16 EET Niklas Söderlund wrote: > Bus configuration will once the driver is extended to support Gen3 > contain information not specific to only the directly connected parallel > subdevice. Move it to struct rvin_dev to show it's

[PATCH 1/2] vfio: platform: Fix reset module leak in error path

2018-02-13 Thread Geert Uytterhoeven
If the IOMMU group setup fails, the reset module is not released. Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by default") Signed-off-by: Geert Uytterhoeven --- drivers/vfio/platform/vfio_platform_common.c | 15 ++- 1 file

[PATCH 0/2] vfio: platform: Improve reset support

2018-02-13 Thread Geert Uytterhoeven
Hi all, This patch series improves reset support for vfio-platform: - The first patch fixes a bug I ran into while working on this. - The second patch implements generic DT reset support, for devices that are connected to an SoC-internal reset controller and can be reset in a

[PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-13 Thread Geert Uytterhoeven
Vfio-platform requires reset support, provided either by ACPI, or, on DT platforms, by a device-specific reset driver matching against the device's compatible value. On many SoCs, devices are connected to an SoC-internal reset controller, and can be reset in a generic way. Hence add support to

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > There was never proper support in the VIN driver to deliver ALTERNATING > field format to user-space, remove this field option. The problem is > that ALTERNATING filed order requires the

Re: [PATCH v10 09/30] rcar-vin: read subdevice format for crop only when needed

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:14 EET Niklas Söderlund wrote: > Instead of caching the subdevice format each time the video device > format is set read it directly when it's needed. As it turns out the > format is only needed when figuring out the max

Re: [PATCH v10 04/30] rcar-vin: move subdevice handling to async callbacks

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:09 EET Niklas Söderlund wrote: > In preparation for Gen3 support move the subdevice initialization and > clean up from rvin_v4l2_{register,unregister}() directly to the async > callbacks. This simplifies the addition of Gen3

Re: [PATCH v10 01/30] rcar-vin: add Gen3 devicetree bindings documentation

2018-02-13 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:06 EET Niklas Söderlund wrote: > Document the devicetree bindings for the CSI-2 inputs available on Gen3. > > There is a need to add a custom property 'renesas,id' and to define > which CSI-2 input is described in which

Re: [PATCH] ata: sata_rcar: Remove unused variable in sata_rcar_init_controller()

2018-02-13 Thread Tejun Heo
On Tue, Feb 13, 2018 at 01:43:23PM +0100, Geert Uytterhoeven wrote: > drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller': > drivers/ata/sata_rcar.c:821:8: warning: unused variable 'base' > [-Wunused-variable] > > Fixes: da77d76b95a0e894 ("sata_rcar: Reset SATA PHY when Salvator-X

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

2018-02-13 Thread Niklas Söderlund
Hi Geert, Thanks for your patch. On 2018-02-13 14:40:45 +0100, Geert Uytterhoeven wrote: > cec-clock is a fixed clock generator that is not controlled by i2c-12 > and thus should not be a child of the i2c-12 bus node. Rather, it should > be a child of the root node of the DT. > > Fixes:

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

2018-02-13 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Tuesday, 13 February 2018 15:40:45 EET Geert Uytterhoeven wrote: > cec-clock is a fixed clock generator that is not controlled by i2c-12 > and thus should not be a child of the i2c-12 bus node. Rather, it should > be a child of the root node of the DT. > >

[PATCH] ARM: dts: lager: Move cec_clock to root node

2018-02-13 Thread Geert Uytterhoeven
cec-clock is a fixed clock generator that is not controlled by i2c-12 and thus should not be a child of the i2c-12 bus node. Rather, it should be a child of the root node of the DT. Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI transmitter") Signed-off-by: Geert Uytterhoeven

renesas-drivers-2018-02-13-v4.16-rc1

2018-02-13 Thread Geert Uytterhoeven
I have pushed renesas-drivers-2018-02-13-v4.16-rc1 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, On Tuesday, 13 February 2018 15:14:43 EET Kieran Bingham wrote: > On 13/02/18 12:06, Laurent Pinchart wrote: > > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > >> From: Jean-Michel Hautbois > >> > >> The ADV7604 has thirteen

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Laurent, On 13/02/18 12:06, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thank you for your review, > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte

Re: [PATCH] ravb: add support for changing MTU

2018-02-13 Thread Niklas Söderlund
Hi Sergei, Thanks for your feedback. On 2018-02-13 13:01:04 +0300, Sergei Shtylyov wrote: > Hello! > > On 02/12/2018 11:00 PM, Niklas Söderlund wrote: > > > Allow for chancing the MTU within the limit of the maximum size of a > >Changing. :-) Yes :-) > > > descriptor (2048 bytes). Add

Re: [PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Dan Thank you for the review, On 13/02/18 07:23, Dan Carpenter wrote: > On Mon, Feb 12, 2018 at 06:11:57PM +, Kieran Bingham wrote: >> +adv7511->i2c_packet = i2c_new_secondary_device(i2c, "packet", >> +ADV7511_PACKET_I2C_ADDR_DEFAULT); >> +if

RE: [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN

2018-02-13 Thread Fabrizio Castro
Hello Simon, what do you think about enabling the watchdog in multi_v7_defconfig as a module? Thanks, Fab > Subject: [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN > > R-Car Gen2 and RZ/G1 platforms come with a watchdog IP, therefore enable > its driver by default. > >

[PATCH v6 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

2018-02-13 Thread Fabrizio Castro
mugasunda...@bp.renesas.com> --- v5->v6: * rebased on top of renesas-devel-20180213-v4.16-rc1 drivers/soc/renesas/rcar-rst.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/soc/renesas/rcar-rst.c b/drivers/soc/renesas/rcar-rst.c index e

Re: [PATCH v2 3/3] mmc: renesas_sdhi: add eMMC HS400 mode support

2018-02-13 Thread Wolfram Sang
On Tue, Feb 13, 2018 at 12:38:44PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:21:44PM +0100, Wolfram Sang wrote: > > > > > + /* Reset HS400 mode */ > > > + sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 & > > > + sd_ctrl_read16(host, CTL_SDIF_MODE)); > > > +

Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

2018-02-13 Thread Wolfram Sang
On Tue, Feb 13, 2018 at 12:33:53PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > > > Hi Simon, > > > > > + void (*disable_scc)(struct mmc_host *mmc); > > > > Do we really need this callback? I'd think it can be folded into > > reset_hs400_mode()

RE: [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

2018-02-13 Thread Fabrizio Castro
Hello Simon, > Subject: Re: [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as > reset trigger for Gen2 > > On Mon, Feb 12, 2018 at 05:44:18PM +, Fabrizio Castro wrote: > > This patch allows for platform specific quirks as some of the SoC need > > further customization for the

Re: [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning

2018-02-13 Thread Wolfram Sang
> I think we can drop this patch for now. Nice! But we should keep it in mind and recall it, if issues pop up later. signature.asc Description: PGP signature

Re: [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:29 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has two VSPDs to handle display pipelines with a DU. > > Signed-off-by: Kieran Bingham

Re: [PATCH 3/4] arm64: dts: renesas: r8a77995: add VSPBS instance

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:28 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has a VSPBS to support image processing such as blending of > 2 input images. > > Signed-off-by: Kieran Bingham

[PATCH] ata: sata_rcar: Remove unused variable in sata_rcar_init_controller()

2018-02-13 Thread Geert Uytterhoeven
drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller': drivers/ata/sata_rcar.c:821:8: warning: unused variable 'base' [-Wunused-variable] Fixes: da77d76b95a0e894 ("sata_rcar: Reset SATA PHY when Salvator-X board resumes") Signed-off-by: Geert Uytterhoeven

[PATCH v3 2/2] mmc: renesas_sdhi: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
From: Masaharu Hayakawa This patch adds processing for selecting HS400 mode. Signed-off-by: Masaharu Hayakawa Signed-off-by: Simon Horman --- v3 [Simon Horman] * Consolidate disable_scc and

[PATCH v3 0/2] mmc: renesas_sdhi: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
Hi, this patch-set provides SDHI driver support for eMMC HS400. Based on mmc/next Dependencies for applying these patches: none Dependencies to test eMMC HS400: * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting * [PATCH v2] arm64: dts: salvator-common: Enable HS400 of SDHI2 To assist

[PATCH v3 1/2] mmc: tmio: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
From: Masaharu Hayakawa This patch adds processing for selecting HS400 mode. Signed-off-by: Masaharu Hayakawa Signed-off-by: Simon Horman --- v3 [Simon Horman] * Consolidate disable_scc and

Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVD handles the interface between the VSPD and memory. > > Signed-off-by: Kieran Bingham

Re: [PATCH 1/4] arm64: dts: renesas: r8a77995: add FCPVB node

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:26 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVB handles the interface between the VSPB and memory. > > Signed-off-by: Kieran Bingham

Re: [PATCH v3 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:53 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH v3 4/5] media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:52 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH v3 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:51 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a7792 Wheat board has two ADV7513 devices sharing a single i2c > bus, however in low power mode the ADV7513 will reset

Re: [PATCH v3 2/5] dt-bindings: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:50 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N

2018-02-13 Thread Kieran Bingham
Hi Jacopo, Thanks for the patch. I haven't really looked at the rest of the patch yet - but the title stands out: [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N Should this be s/cpg-msr/cpg-mssr/ ? -- Regards Kieran On 13/02/18 09:45, Jacopo Mondi wrote: > Initial support

Re: [PATCH v2 0/3] mmc: renesas_sdhi: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
On Thu, Feb 08, 2018 at 12:37:03PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:26:30PM +0100, Wolfram Sang wrote: > > > > > * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting > > > > I tried to address this one before: > > > > [PATCH 0/3] clk: renesas: rcar-gen3-cpg: updates

Re: [PATCH 0/3] Add R8A77970/Eagle PFC support

2018-02-13 Thread Simon Horman
On Tue, Feb 13, 2018 at 01:46:58PM +0300, Sergei Shtylyov wrote: > On 02/13/2018 10:52 AM, Simon Horman wrote: > > > Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's > > 'renesas-devel-20171110-v4.14-rc8' tag. We're adding the R8A77970 PFC > > node > > and

Re: [PATCH v2 3/3] mmc: renesas_sdhi: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
On Wed, Feb 07, 2018 at 11:21:44PM +0100, Wolfram Sang wrote: > > > + /* Reset HS400 mode */ > > + sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 & > > + sd_ctrl_read16(host, CTL_SDIF_MODE)); > > + sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TMPPORT2, > > +

Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > Hi Simon, > > > + void (*disable_scc)(struct mmc_host *mmc); > > Do we really need this callback? I'd think it can be folded into > reset_hs400_mode() because it is called only once? > > > + void

Re: [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning

2018-02-13 Thread Simon Horman
On Wed, Feb 07, 2018 at 10:52:52PM +0100, Wolfram Sang wrote: > On Fri, Jan 19, 2018 at 02:39:04PM +0100, Simon Horman wrote: > > From: Masaharu Hayakawa > > > > If the return value of mmc_send_tuning() is error other than -EILSEQ, the > > tuning fails and

  1   2   >