Re: [PATCH V2] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Marek Vasut
On 02/15/2018 07:25 PM, Simon Horman wrote: > On Thu, Feb 15, 2018 at 11:11:51AM +0100, Marek Vasut wrote: >> On 02/15/2018 11:09 AM, Wolfram Sang wrote: >>> + stdout-path = "serial0:38400n8"; >>> >>> Didn't you want to change U-Boot to 115200? >> >> I did, do we care about

Re: [PATCH V3] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Wolfram Sang
On Thu, Feb 15, 2018 at 07:49:19PM +0100, Marek Vasut wrote: > Stout base board support making use of 1 GiB of memory, > the Renesas H2 r8a7790 SoC with the SCIFA0 serial port > and CA15 with ARM architected timer. > > Furthermore, this device tree contains entries for: > - 4x LEDs > - SDHI

Re: [PATCH v2 1/5] arm64: dts: renesass: r8a77970: add FCPVD support

2018-02-15 Thread Simon Horman
On Thu, Feb 08, 2018 at 04:47:16PM +0100, Niklas Söderlund wrote: > From: Sergei Shtylyov > > Describe FCPVD0 in the R8A77970 device tree; it will be used by VSPD0 in > the next patch... > > Based on the original (and large) patch by Daisuke Matsushita >

Re: [PATCH] dmaengine: rcar-dmac: fix max_chunk_size for R-Car Gen3

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 06:40:12PM +0900, Yoshihiro Shimoda wrote: > According to R-Car Gen3 Rev.0.80 manual, the DMATCR can be set to > 16,777,215 as maximum. So, this patch fixes the max_chunk_size for > safety on all of SoCs. Otherwise, a system may hang if the DMATCR > is set to 0 on R-Car

[PATCH V3] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Marek Vasut
Stout base board support making use of 1 GiB of memory, the Renesas H2 r8a7790 SoC with the SCIFA0 serial port and CA15 with ARM architected timer. Furthermore, this device tree contains entries for: - 4x LEDs - SDHI SD/MMC controller - Display unit with HDMI output - SH fast ethernet

[GIT PULL FOR renesas-drivers] d3/i2c-conflict/media

2018-02-15 Thread Kieran Bingham
Hi Geert, Please consider including this branch in renesas-drivers. -- Regards Kieran The following changes since commit 29422737017b866d4a51014cc7522fa3a99e8852: media: rc: get start time just before calling driver tx (2018-02-14 14:17:21 -0500) are available in the git repository at:

[GIT PULL FOR renesas-drivers] d3/i2c-conflict/drm

2018-02-15 Thread Kieran Bingham
Hi Geert, Please consider including this branch in renesas-drivers. -- Regards Kieran The following changes since commit 94fc27ac487a80daf42f97b1a0503d029f3c1325: Merge tag 'drm-intel-next-fixes-2018-02-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2018-02-08 08:21:37

Re: [PATCH 0/4] arm64: defconfig: Enable PWM and USB for R-Car

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 03:23:28PM +0900, Yoshihiro Shimoda wrote: > This patch set is based on the renesas.git / > renesas-devel-20180213v2-v4.16-rc1 > tag. Hi Shimoda-san, these changes look fine to me but I believe that upstream prefers such patches to be consolidated. Could you consider

Re: [PATCH V2] ARM: shmobile: Document Renesas H2-based Stout DT bindings

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 11:02:28AM +0100, Marek Vasut wrote: > Document the Renesas H2 Stout (ADAS Starterkit) device tree bindings, > listing it as a supported board. > > This allows to use checkpatch.pl to validate .dts files referring to > the Stout board. > > Signed-off-by: Marek Vasut

Re: [PATCH V2] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 11:11:51AM +0100, Marek Vasut wrote: > On 02/15/2018 11:09 AM, Wolfram Sang wrote: > > > >> + stdout-path = "serial0:38400n8"; > > > > Didn't you want to change U-Boot to 115200? > > I did, do we care about compatibility with whatever the board comes with >

Re: [PATCH v3 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 02:04:09AM +0200, Laurent Pinchart wrote: > The internal LVDS encoder now has DT bindings separate from the DU. Port > the device tree over to the new model. > > Signed-off-by: Laurent Pinchart I have marked this and the

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 06:03:56PM +0100, Simon Horman wrote: > On Thu, Feb 15, 2018 at 11:02:08AM +0100, Marek Vasut wrote: > > Regulator setup is suboptimal on H2 Stout too. The Stout newly has > > two DA9210 regulators, so the quirk is extended to handle another > > DA9210 at i2c address 0x70.

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 11:02:08AM +0100, Marek Vasut wrote: > Regulator setup is suboptimal on H2 Stout too. The Stout newly has > two DA9210 regulators, so the quirk is extended to handle another > DA9210 at i2c address 0x70. It looks like this patch has received some review that needs

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 02:58:34PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add initial support for R-Car M3-N Salvator-x and r8a77965 SoC in > > device tree with cpg-mssr, reset and clock nodes. > >

Re: [PATCH v3 2/5] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:41:58PM +, Kieran Bingham wrote: > Hi Simon, > > On 15/02/18 16:33, Simon Horman wrote: > > On Wed, Feb 14, 2018 at 09:55:05AM +, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> The r8a77995 has a VSPBS to

Re: [PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 10:45:53AM +0100, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to rcar-dmac device > tree bindings documentation. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman

Re: [PATCH 4/8] arm64: dts: renesas: r8a77995: add DU support

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:07:35PM +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:19 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > Define the generic r8a77995 part of the DU

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 02:30:28PM +, Kieran Bingham wrote: > Hi Laurent, Simon, > > On 15/02/18 14:12, Laurent Pinchart wrote: > > Hi Kieran, > > > > Thank you for the patch. > > > > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: > >> From: Kieran Bingham

Re: [PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 08:38:20AM +, Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > Signed-off-by: Kieran Bingham It looks like there

Re: [PATCH 7/8] arm64: dts: renesas: r8a77995-draak: Add HDMI Out through ADV7511

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:16:00PM +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:22 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > Provide a device node for the ADV7511 as found on

Re: [PATCH v3 2/5] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-15 Thread Kieran Bingham
Hi Simon, On 15/02/18 16:33, Simon Horman wrote: > On Wed, Feb 14, 2018 at 09:55:05AM +, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The r8a77995 has a VSPBS to support image processing such as blending of >> two input images, and has two

Re: [PATCH v2 2/2] arm64: dts: r8a77995: draak: enable SDHI2

2018-02-15 Thread Simon Horman
On Mon, Dec 04, 2017 at 10:29:00PM +0100, Wolfram Sang wrote: > On Wed, Nov 29, 2017 at 05:06:46PM +0100, Ulrich Hecht wrote: > > The single SDHI controller is connected to eMMC. > > > > Signed-off-by: Ulrich Hecht > > Acked-by: Wolfram Sang

Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:20:42PM +, Kieran Bingham wrote: > Hi Simon, > > On 15/02/18 16:14, Simon Horman wrote: > > On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: > >> Hi Kieran, > >> > >> Thank you for the patch. > >> > >> On Tuesday, 13 February 2018 00:25:27 EET

Re: [PATCH v3 0/5] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:24:46PM +, Kieran Bingham wrote: > Hi Simon, > > On 14/02/18 09:55, Kieran Bingham wrote: > > From: Kieran Bingham > > > > The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used > > as a dual-input image

Re: [PATCH v3 2/5] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 09:55:05AM +, Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has a VSPBS to support image processing such as blending of > two input images, and has two VSPDs to handle display pipelines with a > DU. > >

Re: [PATCH v3 1/5] arm64: dts: renesas: r8a77995: add FCPV nodes

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 09:55:04AM +, Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVB handles the interface between the VSPB and memory, while the > FCPVD handles the interface between the VSPD and memory. > > Signed-off-by: Kieran Bingham

Re: [PATCH/RFT v4] gpio: gpio-rcar: Support S2RAM

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 05:27:39AM +, Yoshihiro Shimoda wrote: > Hi, > > > From: Yoshihiro Kaneko, Sent: Monday, February 5, 2018 4:15 AM > > > > From: Hien Dang > > > > This patch adds an implementation that saves and restores the state of > > GPIO configuration

Re: [PATCH v3 0/5] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-15 Thread Kieran Bingham
Hi Simon, On 14/02/18 09:55, Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used > as a dual-input image blender, while two VSPD instances can be utilised as > part of a display (DU)

Re: [PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-15 Thread Kieran Bingham
On 15/02/18 16:21, Kieran Bingham wrote: > Hi Simon, > > This the correct version of this series. LIES Sorry - My hands were quicker than my head there. *this is not the lastest series*. -- Kieran > > -- > Regards > > Kieran > > On 13/02/18 19:30, Kieran Bingham wrote: >>

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 03:54:56PM +0200, Laurent Pinchart wrote: > Hi Geert, > > Thank you for the patch. > > On Tuesday, 13 February 2018 15:40:45 EET Geert Uytterhoeven wrote: > > cec-clock is a fixed clock generator that is not controlled by i2c-12 > > and thus should not be a child of the

Re: [PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-15 Thread Kieran Bingham
Hi Simon, This the correct version of this series. -- Regards Kieran On 13/02/18 19:30, Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used > as a dual-input image blender, while

Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes

2018-02-15 Thread Kieran Bingham
Hi Simon, On 15/02/18 16:14, Simon Horman wrote: > On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: >> Hi Kieran, >> >> Thank you for the patch. >> >> On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: >>> From: Kieran Bingham

Re: [PATCH v6 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 01:02:44PM +, Fabrizio Castro wrote: > This patch allows for platform specific quirks as some of the SoC need > further customization for the watchdog to work properly, like for R-Car > Gen2 and for RZ/G. > > Signed-off-by: Fabrizio Castro

Re: [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 01:08:19PM +, Fabrizio Castro wrote: > Hello Simon, > > what do you think about enabling the watchdog in multi_v7_defconfig as a > module? I think its a good idea.

Re: [PATCH 3/9] ARM: dts: kzm9d: Fix "debounce-interval" property misspelling

2018-02-15 Thread Simon Horman
[Cc linux-renesas-soc] On Tue, Feb 13, 2018 at 03:15:29PM +0100, Geert Uytterhoeven wrote: > "debounce_interval" was never supported. > > Signed-off-by: Geert Uytterhoeven > Cc: Simon Horman > Cc: Magnus Damm > --- > Please

Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > The FCPVD handles the interface between the

Re: [PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 10:46:00AM +0100, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to renesas ravb device > tree bindings documentation. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman This needs to

Re: [PATCH 1/4] arm64: dts: renesas: r8a77995: add FCPVB node

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 02:31:48PM +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 13 February 2018 00:25:26 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > The FCPVB handles the interface between the

Re: [PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 04:39:49PM +0100, Simon Horman wrote: > On Tue, Feb 13, 2018 at 10:45:53AM +0100, Jacopo Mondi wrote: > > Add documentation for r8a77965 compatible string to rcar-dmac device > > tree bindings documentation. > > > > Signed-off-by: Jacopo Mondi >

Re: [PATCH 08/15] Documentation: devicetree: renesas,sci: Add r8a77965

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 10:45:55AM +0100, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to reneass sci-serial > device tree bindings documentation. I think a better subject would be: dt-bindings: serial: sh-sci: Add support for r8a77965 (H)SCIF

Re: [PATCH v2 1/2] dt-bindings: clock: add R8A77980 CPG core clock definitions

2018-02-15 Thread Simon Horman
On Thu, Feb 15, 2018 at 02:56:53PM +0300, Sergei Shtylyov wrote: > Add macros usable by the device tree sources to reference the R8A77980 > CPG core clocks by index. The data come from the table 8.2e of the R-Car > Series, 3rd Generation User's Manual: Hardware (Rev. 0.80, Oct, 2017), > however I

Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 02:24:14PM +0300, Sergei Shtylyov wrote: > Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we > have the GPIO support (previously phylib had to resort to polling). > > Signed-off-by: Sergei Shtylyov Thanks,

Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 11:01:26AM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 13, 2018 at 12:22 PM, Sergei Shtylyov > wrote: > > Describe all 6 GPIO controllers in the R8A77970 device tree. > > > > Based on the original (and large) patch by Daisuke

Re: [PATCH 1/5] soc: renesas: Add symbols for R-Car Gen3 register offsets

2018-02-15 Thread Simon Horman
On Wed, Feb 14, 2018 at 11:25:19AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Feb 12, 2018 at 4:44 PM, Simon Horman > wrote: > > Add symbols for Gen3 register offsets. > > These may be used to improve readability of users of these offsets. > > > > This

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Kieran Bingham
Hi Laurent, Simon, On 15/02/18 14:12, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> Enable the DU, providing only the VGA output for

Re: [PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

2018-02-15 Thread Kieran Bingham
On 15/02/18 14:10, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 15 February 2018 10:38:20 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> The r8a77995 D3 platform has 2 LVDS channels connected to the DU. >>

Re: [PATCH 7/8] arm64: dts: renesas: r8a77995-draak: Add HDMI Out through ADV7511

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:22 EET Kieran Bingham wrote: > From: Kieran Bingham > > Provide a device node for the ADV7511 as found on the Draak D3 platform. > > The ADV7511 is connected to the DU through a parallel

Re: [PATCH 6/8] arm64: dts: renesas: r8a77995-draak: Enable DU

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:21 EET Kieran Bingham wrote: > From: Kieran Bingham > > Enable the DU, providing only the VGA output for now. > > Signed-off-by: Kieran Bingham

Re: [PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:20 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > Signed-off-by: Kieran Bingham

Re: [PATCH 4/8] arm64: dts: renesas: r8a77995: add DU support

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:19 EET Kieran Bingham wrote: > From: Kieran Bingham > > Define the generic r8a77995 part of the DU device node. > > Signed-off-by: Kieran Bingham

Re: [PATCH 3/8] dt-bindings: display: renesas,lvds: Add LVDS binding for D3

2018-02-15 Thread Laurent Pinchart
Hi Kieran, On Thursday, 15 February 2018 10:45:33 EET Kieran Bingham wrote: > On 15/02/18 08:38, Kieran Bingham wrote: > > From: Kieran Bingham > > > > The D3 supports two LVDS channels. Extend the binding to support them. > > > > Signed-off-by: Kieran

Re: [PATCH 3/8] dt-bindings: display: renesas,lvds: Add LVDS binding for D3

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:18 EET Kieran Bingham wrote: > From: Kieran Bingham > > The D3 supports two LVDS channels. Extend the binding to support them. > > Signed-off-by: Kieran Bingham

Re: [PATCH 2/8] dt-bindings: display: renesas,du: Document r8a77995 bindings

2018-02-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday, 15 February 2018 10:38:17 EET Kieran Bingham wrote: > From: Kieran Bingham > > Document the D3 (r8a77995) SoC in the R-Car DU bindings. > > Signed-off-by: Kieran Bingham

Re: [PATCH] serial: sh-sci: prevent lockup on full TTY buffers

2018-02-15 Thread Wolfram Sang
> This can be prevented by doing a dummy read of the RX data register. Just so I understand the issue correctly: We are reading the register to throw the content away to prevent it being used in the TTY buffers? signature.asc Description: PGP signature

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
On 02/15/2018 11:44 AM, Wolfram Sang wrote: > >>> BTW, several PPC platforms use of_device_compatible_match(of_root, ...), >>> but I believe of_root is not guaranteed to be set up. >> >> OK, subsequent patch then. Added to TODO. > > Can you place it below the PCIE patches, please? ;) Grumble,

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Laurent Pinchart
Hi Hans, On Thursday, 15 February 2018 14:32:55 EET Hans Verkuil wrote: > On 15/02/18 13:06, Laurent Pinchart wrote: > > On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: > >> On 15/02/18 12:08, Laurent Pinchart wrote: > >>> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Hans Verkuil
On 15/02/18 13:32, Hans Verkuil wrote: > On 15/02/18 13:06, Laurent Pinchart wrote: >> Hi Hans, >> >> On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: >>> On 15/02/18 12:08, Laurent Pinchart wrote: On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > On 14/02/18

Re: [PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

2018-02-15 Thread Geert Uytterhoeven
Hi Kieran, On Thu, Feb 15, 2018 at 1:41 PM, Kieran Bingham wrote: > On 15/02/18 09:07, Geert Uytterhoeven wrote: >> On Thu, Feb 15, 2018 at 9:38 AM, Kieran Bingham wrote: >>> From: Kieran Bingham >>>

Re: [PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

2018-02-15 Thread Kieran Bingham
Hi Geert, On 15/02/18 09:07, Geert Uytterhoeven wrote: > Hi Kieran, > > On Thu, Feb 15, 2018 at 9:38 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The r8a77995 D3 platform has 2 LVDS channels connected to the DU. >> >>

Re: [PATCH 4/4] pinctrl: sh-pfc: r8a77995: Add DU pins, groups and function

2018-02-15 Thread Kieran Bingham
Hi Ulrich, Thankyou for your patch, On 15/02/18 12:01, Ulrich Hecht wrote: > This patch adds DU pins, groups and function for the R8A77995 (D3) SoC. > > Signed-off-by: Ulrich Hecht All of your pin values check out. (And it highlights that I may have left a

Re: [PATCH 1/8] pinctrl: sh-pfc: r8a77995: Add DU support

2018-02-15 Thread Kieran Bingham
This patch duplicates work performed by Ulrich. Please consider this patch dropped, and no need for review. (especially the obvious error in the pin-values) Oh well - it was a fun exercise to go through :-) -- Regards Kieran On 15/02/18 08:38, Kieran Bingham wrote: > From: Kieran Bingham

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Hans Verkuil
On 15/02/18 13:06, Laurent Pinchart wrote: > Hi Hans, > > On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: >> On 15/02/18 12:08, Laurent Pinchart wrote: >>> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: On 14/02/18 16:16, Laurent Pinchart wrote: > On

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Laurent Pinchart
Hi Hans, On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: > On 15/02/18 12:08, Laurent Pinchart wrote: > > On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > >> On 14/02/18 16:16, Laurent Pinchart wrote: > >>> On Wednesday, 14 February 2018 12:36:43 EET Niklas

[PATCH] serial: sh-sci: use hrtimer for receive timeout

2018-02-15 Thread Ulrich Hecht
High latencies of classic timers cause performance issues for high- speed serial transmissions. This patch transforms rx_timer into an hrtimer to reduce the minimum latency. Signed-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 47

[PATCH] serial: sh-sci: prevent lockup on full TTY buffers

2018-02-15 Thread Ulrich Hecht
When the TTY buffers fill up to the configured maximum, a system lockup occurs: [ 598.820128] INFO: rcu_preempt detected stalls on CPUs/tasks: [ 598.825796] 0-...!: (1 GPs behind) idle=5a6/2/0 softirq=1974/1974 fqs=1 [ 598.832577] (detected by 3, t=62517 jiffies, g=296, c=295, q=126) [

[PATCH 0/4] r8a779{5,6,95} VIN and DU pin control tables

2018-02-15 Thread Ulrich Hecht
Hi! This series adds pin control tables for VIN4 (H3, M3-W, D3), VIN5 (H3, M3-W) and DU (D3). The patches for M3-W and H3 are identical, so there is no need to review both of them in detail. [The last patch overlaps with a concurrently developed PFC patch for DU on D3 ("[PATCH 1/8] pinctrl:

[PATCH 2/4] pinctrl: sh-pfc: r8a7795: Add VIN4, VIN5 pins, groups and functions

2018-02-15 Thread Ulrich Hecht
This patch adds VIN4 and VIN5 pins, groups and functions for the R8A7795 SoC. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 454 +++ 1 file changed, 454 insertions(+) diff --git

[PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

2018-02-15 Thread Ulrich Hecht
This patch adds VIN4 and VIN5 pins, groups and functions for the R8A7796 SoC. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 454 +++ 1 file changed, 454 insertions(+) diff --git

[PATCH 3/4] pinctrl: sh-pfc: r8a77995: Add VIN4 pins, groups and function

2018-02-15 Thread Ulrich Hecht
This patch adds VIN4 pins, groups and function for the R8A77995 (D3) SoC. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 192 ++ 1 file changed, 192 insertions(+) diff --git

[PATCH 4/4] pinctrl: sh-pfc: r8a77995: Add DU pins, groups and function

2018-02-15 Thread Ulrich Hecht
This patch adds DU pins, groups and function for the R8A77995 (D3) SoC. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 101 ++ 1 file changed, 101 insertions(+) diff --git

[PATCH v2 2/2] clk: renesas: cpg-mssr: add R8A77980 support

2018-02-15 Thread Sergei Shtylyov
Add R-Car V3H (R8A77980) Clock Pulse Generator / Module Standby and Software Reset support, using the CPG/MSSR driver core and the common R-Car Gen3 code. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Hans Verkuil
On 15/02/18 12:08, Laurent Pinchart wrote: > Hi Hans, > > On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: >> On 14/02/18 16:16, Laurent Pinchart wrote: >>> On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: There is no way for drivers to validate a colorspace

[PATCH v2 1/2] dt-bindings: clock: add R8A77980 CPG core clock definitions

2018-02-15 Thread Sergei Shtylyov
Add macros usable by the device tree sources to reference the R8A77980 CPG core clocks by index. The data come from the table 8.2e of the R-Car Series, 3rd Generation User's Manual: Hardware (Rev. 0.80, Oct, 2017), however I had to add the Z2 clock which is somehow present only on the figure

[PATCH v2 0/2] Renesas R8A77980 CPG/MSSR clock support

2018-02-15 Thread Sergei Shtylyov
Hello! Here's the set of 2 patches against the 'clk-renesas' branch of Geert Uytterhoeven's 'renesas-drivers.git' repo. We're adding the CPG/MSSR driver support for R8A77980... [1/2] dt-bindings: clock: add R8A77980 CPG core clock definitions [2/2] clk: renesas: cpg-mssr: add R8A77980 support

[PATCH V3] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
Regulator setup is suboptimal on H2 Stout too. The Stout newly has two DA9210 regulators, so the quirk is extended to handle another DA9210 at i2c address 0x70. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Kuninori Morimoto

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-15 Thread Geert Uytterhoeven
Hi Laurent, On Thu, Feb 15, 2018 at 12:03 PM, Laurent Pinchart wrote: > On Thursday, 15 February 2018 11:18:25 EET Geert Uytterhoeven wrote: >> On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: >> > The internal LVDS encoders now have their own DT

Re: [PATCH v3 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-02-15 Thread Laurent Pinchart
Hi Geert, On Thursday, 15 February 2018 11:20:22 EET Geert Uytterhoeven wrote: > On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: > > The internal LVDS encoder now has DT bindings separate from the DU. Port > > the device tree over to the new model. > > > > Signed-off-by: Laurent

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Geert Uytterhoeven
Hi Wolfram, On Thu, Feb 15, 2018 at 11:43 AM, Wolfram Sang wrote: >> > It sends per device, so unless there is a device named "da9210" at >> > addr 0x70, nothing will happen? Am I missing something? >> >> As soon as one of the affected devices is instantiated, it has to shut

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Laurent Pinchart
Hi Hans, On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > On 14/02/18 16:16, Laurent Pinchart wrote: > > On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: > >> There is no way for drivers to validate a colorspace value, which could > >> be provided by user-space

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-15 Thread Laurent Pinchart
Hi Geert, On Thursday, 15 February 2018 11:18:25 EET Geert Uytterhoeven wrote: > On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement > >

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-15 Thread Hans Verkuil
On 14/02/18 16:16, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: >> There is no way for drivers to validate a colorspace value, which could >> be provided by user-space by VIDIOC_S_FMT for example. Add a

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Wolfram Sang
> > It sends per device, so unless there is a device named "da9210" at > > addr 0x70, nothing will happen? Am I missing something? > > As soon as one of the affected devices is instantiated, it has to shut up > all devices. This is done by sending the whole da9xxx_msgs[] array, > which needs

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Wolfram Sang
> > BTW, several PPC platforms use of_device_compatible_match(of_root, ...), > > but I believe of_root is not guaranteed to be set up. > > OK, subsequent patch then. Added to TODO. Can you place it below the PCIE patches, please? ;) signature.asc Description: PGP signature

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Geert Uytterhoeven
Hi Wolfram, On Thu, Feb 15, 2018 at 11:19 AM, Wolfram Sang wrote: >> As the code now always sends 3 i2c msgs to all 3 possible regulators, we >> may accidentally talk to another device at 0x70 on other boards than Stout. > > It sends per device, so unless there is a device

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
On 02/15/2018 11:08 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Thu, Feb 15, 2018 at 10:44 AM, Marek Vasut wrote: >> On 02/14/2018 09:09 AM, Geert Uytterhoeven wrote: >>> On Wed, Feb 14, 2018 at 6:58 AM, Wolfram Sang wrote: > - * The

Re: [PATCH V2] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Marek Vasut
On 02/15/2018 11:09 AM, Wolfram Sang wrote: > >> +stdout-path = "serial0:38400n8"; > > Didn't you want to change U-Boot to 115200? I did, do we care about compatibility with whatever the board comes with though or not ? -- Best regards, Marek Vasut

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Wolfram Sang
> As the code now always sends 3 i2c msgs to all 3 possible regulators, we > may accidentally talk to another device at 0x70 on other boards than Stout. It sends per device, so unless there is a device named "da9210" at addr 0x70, nothing will happen? Am I missing something? signature.asc

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Geert Uytterhoeven
Hi Marek, On Thu, Feb 15, 2018 at 11:02 AM, Marek Vasut wrote: > Regulator setup is suboptimal on H2 Stout too. The Stout newly has > two DA9210 regulators, so the quirk is extended to handle another > DA9210 at i2c address 0x70. > > Signed-off-by: Marek Vasut

Re: [PATCH V2] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Wolfram Sang
> + stdout-path = "serial0:38400n8"; Didn't you want to change U-Boot to 115200? signature.asc Description: PGP signature

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Geert Uytterhoeven
Hi Marek, On Thu, Feb 15, 2018 at 10:44 AM, Marek Vasut wrote: > On 02/14/2018 09:09 AM, Geert Uytterhoeven wrote: >> On Wed, Feb 14, 2018 at 6:58 AM, Wolfram Sang wrote: - * The r8a7790/lager and r8a7791/koelsch development boards have da9063

[PATCH V2] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Marek Vasut
Stout base board support making use of 1 GiB of memory, the Renesas H2 r8a7790 SoC with the SCIFA0 serial port and CA15 with ARM architected timer. Furthermore, this device tree contains entries for: - 4x LEDs - SDHI SD/MMC controller - Display unit with HDMI output - SH fast ethernet

Re: [PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Wolfram Sang
On Thu, Feb 15, 2018 at 11:02:08AM +0100, Marek Vasut wrote: > Regulator setup is suboptimal on H2 Stout too. The Stout newly has > two DA9210 regulators, so the quirk is extended to handle another > DA9210 at i2c address 0x70. > > Signed-off-by: Marek Vasut > Cc:

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-15 Thread Marek Vasut
On 02/14/2018 10:11 AM, Geert Uytterhoeven wrote: > Hi Marek, [...] >> + partition@0 { >> + label = "loader"; >> + reg = <0x 0x0004>; >> + read-only; >> +

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
On 02/14/2018 10:14 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Wed, Feb 14, 2018 at 12:28 AM, Marek Vasut wrote: >> Regulator setup is suboptimal on H2 Stout too. > > Worse, Stout has 2 DA9210 regulators, so you have to add a check for a > DA9210 at address 0x70.

Re: [PATCH] ARM: shmobile: Document Renesas H2-based Stout DT bindings

2018-02-15 Thread Marek Vasut
On 02/14/2018 09:16 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Wed, Feb 14, 2018 at 12:29 AM, Marek Vasut wrote: >> Document the Renesas H2 Stout (ADAS Starter Kit) device tree bindings, > > Thanks for your patch! > > According to

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
On 02/14/2018 09:09 AM, Geert Uytterhoeven wrote: > On Wed, Feb 14, 2018 at 6:58 AM, Wolfram Sang wrote: >>> - * The r8a7790/lager and r8a7791/koelsch development boards have da9063 and >>> - * da9210 regulators. Both regulators have their interrupt request lines >>> tied

[PATCH V2] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-15 Thread Marek Vasut
Regulator setup is suboptimal on H2 Stout too. The Stout newly has two DA9210 regulators, so the quirk is extended to handle another DA9210 at i2c address 0x70. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Kuninori Morimoto

[PATCH V2] ARM: shmobile: Document Renesas H2-based Stout DT bindings

2018-02-15 Thread Marek Vasut
Document the Renesas H2 Stout (ADAS Starterkit) device tree bindings, listing it as a supported board. This allows to use checkpatch.pl to validate .dts files referring to the Stout board. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven

Re: [PATCH v3 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-02-15 Thread Geert Uytterhoeven
On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: > The internal LVDS encoder now has DT bindings separate from the DU. Port > the device tree over to the new model. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-15 Thread Geert Uytterhoeven
Hi Laurent, On Thu, Feb 15, 2018 at 1:04 AM, Laurent Pinchart wrote: > The internal LVDS encoders now have their own DT bindings. Before > switching the driver infrastructure to those new bindings, implement > backward-compatibility through live DT

  1   2   >