/VSP1 specific.
Kieran Bingham (2):
Revert "[media] v4l: vsp1: Supply frames to the DU continuously"
v4l: vsp1: Provide a writeback video device
drivers/media/platform/vsp1/vsp1.h | 1 +
drivers/media/platform/vsp1/vsp1_drm.c | 19
drivers/media/platform/vsp1/
eback mode if there is an
output buffer, or disable it (leaving the existing display pipeline
unharmed) otherwise.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_video.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/driver
the function without any code change.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_video.c | 74
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_vide
the partition sizes into this table.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_pipe.h | 6 ++
drivers/media/platform/vsp1/vsp1_video.c | 8 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/d
algorithm on Gen3 hardware.
Patches 2,3 and 4 clean up the calculation of the partition sizes such that they
are only calculated once at streamon - and the partition windows are stored in
the vsp1_pipeline object.
Kieran Bingham (4):
v4l: vsp1: Implement partition algorithm restrictions
v4l: vsp1
.
Utilise local variables for the processing as required.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_pipe.h | 4
drivers/media/platform/vsp1/vsp1_video.c | 19 +--
2 files changed, 9 insertions(+), 14 del
, the use of an SRU will always engage the partition
algorithm, therefore we must always ensure the restrictions are met on
Gen3 hardware utilising an SRU in the pipeline.
A pipeline with an SRU connected after the UDS will disable any scaling
features of the SRU.
Signed-off-by: Kieran Bingham
Hi Sakari,
On 14/12/16 07:28, Sakari Ailus wrote:
> Hi Kieran,
>
> On Tue, Dec 13, 2016 at 05:59:44PM +0000, Kieran Bingham wrote:
>> media_entity_pipeline_stop() can be called through error paths with a
>> NULL entity pipe object. In this instance, stopping is a no-op
Move the static vsp1_video_setup_pipeline() function in preparation for
the callee updates so that the vsp1_video_pipeline_run() call can
configure pipelines following suspend resume actions.
This commit is just a code move for clarity performing no functional
change.
Signed-off-by: Kieran
U race in a single change
v1:
- Original pipeline configuration rework
Kieran Bingham (4):
v4l: vsp1: Move vsp1_video_setup_pipeline()
v4l: vsp1: Refactor video pipeline configuration
v4l: vsp1: Use local display lists and remove global pipe->dl
media: Catch null pipes on pipe
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
The following changes since commit 69973b830859bc6529a7a0468ba0d80ee5117826:
Linux 4.9 (2016-12-11 11:17:54 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
vsp1/s
dl is set during the atomic begin hook, but it is
not utilised until the flush. Moving this should do no harm.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_drm.c | 20 +++---
drivers/media/platform/vsp1/vsp1_pipe.h |
media_entity_pipeline_stop() can be called through error paths with a
NULL entity pipe object. In this instance, stopping is a no-op, so
simply return without any action
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
I've marked this patch as RFC, although if
ent side effect of this, by specifying that the
configuration has been lost during suspend/resume actions - the
vsp1_video_pipeline_run() call can re-initialise pipelines when
necessary thus repairing resume actions for active m2m pipelines.
Signed-off-by: Kieran Bingham <kieran.bingha
Hi Sakari,
On 14/12/16 12:43, Sakari Ailus wrote:
> Hi Kieran,
>
> On Wed, Dec 14, 2016 at 12:27:37PM +0000, Kieran Bingham wrote:
>> Hi Sakari,
>>
>> On 14/12/16 07:28, Sakari Ailus wrote:
>>> Hi Kieran,
>>>
>>> On Tue,
at this.
--
Regards
Kieran
On 13/12/16 17:59, Kieran Bingham wrote:
> media_entity_pipeline_stop() can be called through error paths with a
> NULL entity pipe object. In this instance, stopping is a no-op, so
> simply return without any action
>
> Signed-off-by: Kieran Bingham <k
Hi Laurent,
On 14/12/16 16:30, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday 13 Dec 2016 17:59:42 Kieran Bingham wrote:
>> With multiple inputs through the BRU it is feasible for the streams to
>> race each other at stream-on.
&g
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Provide a utility script to execute all vsp unit tests, as well
as the option to execute multiple iterations of the suite.
Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com>
---
v2
- remove spurious uses of ';'
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Identify the size and format from the test output filename, and pass
to raw2rgbpnm for conversion to a PNM file.
>From there we can convert easily to a PNG output file.
Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Provide a test to verify the hardware completes a functional test whilst
performing a suspend resume cycle in parallel. Make use of the
/sys/power/pm_test functionality provided by CONFIG_PM_DEBUG to perform
the testing
Signed-off-by:
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Provide a test to verify the hardware is functional both before and
after entering a suspend / resume cycle. Make use of the
/sys/power/pm_test functionality provided by CONFIG_PM_DEBUG to perform
the testing
Signed-off-by: Kieran B
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Extend the logger such that it will detect the tracing system, and also
append print statement to this ring buffer.
This provides the relevant logging output interspersed in the ftrace
logs for an effective solution to ident
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Following on from previous useful feedback, I have reworked the supporting
scripts and tests.
Provide two tests for suspend/resume cycles. One will verify the VSP1 is
functional with a test before and after a suspend cycle. The
Move the static vsp1_video_setup_pipeline() function in preparation for
the callee updates so that the vsp1_video_pipeline_run() call can
configure pipelines following suspend resume actions.
This commit is just a code move for clarity performing no functional
change.
Signed-off-by: Kieran
nsider it as
blocking for the first three patches of this series.
Kieran Bingham (4):
v4l: vsp1: Move vsp1_video_setup_pipeline()
v4l: vsp1: Refactor video pipeline configuration
v4l: vsp1: Use local display lists and remove global pipe->dl
media: Catch null pipes on pipeline stop
ent side effect of this, by specifying that the
configuration has been lost during suspend/resume actions - the
vsp1_video_pipeline_run() call can re-initialise pipelines when
necessary thus repairing resume actions for active m2m pipelines.
Signed-off-by: Kieran Bingham <kieran.bingha
dl is set during the atomic begin hook, but it is
not utilised until the flush. Moving this should do no harm.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_drm.c | 20 +++---
drivers/media/platform/vsp1/vsp1_pipe.h |
media_entity_pipeline_stop() can be called through error paths with a
NULL entity pipe object. In this instance, stopping is a no-op, so
simply return without any action
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
I've marked this patch as RFC, although if
On 02/12/16 14:18, Russell King - ARM Linux wrote:
> On Fri, Dec 02, 2016 at 01:43:26AM +0200, Laurent Pinchart wrote:
>> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
>>
>> The current code hard codes the call of hdmi_phy_configure() to be 8bpp
>&
Hi Laurent,
I've been reworking this series to split things out and adapt for the
comments you've provided, but I have the following queries outstanding:
On 15/12/16 11:50, Kieran Bingham wrote:
> Hi Laurent,
>
> On 14/12/16 16:30, Laurent Pinchart wrote:
>> Hi Kieran,
nts, with a check on
NULL pipe elements instead, as this is the symptom of unbalanced
media_pipeline_stop calls.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/media-entity.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/driv
On 03/01/17 13:36, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote:
>> Drivers must not perform unbalanced calls to stop the entity pipeline,
>> however if they do they will fault in the core m
e_init to vsp1_reset_wpf()
- Clean up flag dereferencing with a local struct *
v2:
- Refactor video pipeline configuration implementation to solve both suspend
resume and the VSP BRU race in a single change
v1:
- Original pipeline configuration rework
Kieran Bingham (4):
v4l: vsp1: Prevent multiple st
The pipe->dl is used only inside vsp1_du_atomic_flush(), and can be
obtained and stored locally to simplify the code.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_drm.c | 20 ++--
drivers/media/plat
When a suspend/resume action is taken, the pipeline is reset and never
reconfigured.
To correct this, we establish a new flag pipe->configured and utilise
this to establish when we write a full configuration set to the current
display list.
Signed-off-by: Kieran Bingham <kieran.bingha
ere a display list is committed without having
called vsp1_video_setup_pipeline() first
Repair this issue, by ensuring that only the stream which configures the
pipeline is able to start it.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
v4:
- Revert and re
Move the static vsp1_video_setup_pipeline() function in preparation for
the callee updates so that the vsp1_video_pipeline_run() call can
configure pipelines following suspend resume actions.
This commit is just a code move for clarity performing no functional
change.
Signed-off-by: Kieran
is not zero).
>
> Add ".4" to the format specifier to limit the number of printed
> characters to four. The resulting format specifier "%4.4s" is also used
> by other media drivers to print pixelformat value.
>
> Signed-off-by: Nicolas Iooss <nicolas.i
Hi Laurent,
Thanks for the review,
On 03/03/17 01:57, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Wednesday 01 Mar 2017 13:12:54 Kieran Bingham wrote:
>> The DRM object does not register the pipe with the WPF object. This is
>> used inter
flips at the end of
VSP processing.
These patches have been tested by introducing artificial delays in the commit
code paths and verifying that no visual tearing or flickering occurs.
Manual start/stop testing has also been performed
Kieran Bingham (3):
v4l: vsp1: extend VSP1 module
when the full display
pipeline has completed for the frame.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
v2:
- Commit message completely re-worded for patch re-work.
- drm_crtc_handle_vblank() re-instated in event of rcrtc->pending
- removed passing of un
to be registered within the VSP DRM interface.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
v2:
- vsp1_du_setup_lif() uses config structure to set callbacks
- vsp1_du_pipeline_frame_end() moved to interrupt section
- vsp1_du_pipeline_frame_end regi
-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c | 9 +++--
drivers/media/platform/vsp1/vsp1_dl.h | 2 +-
drivers/media/platform/vsp1/vsp1_drm.c | 4 +++-
drivers/media/platform/vsp1/vsp1_pipe.c | 6 +-
drivers/media/pl
Hi Laurent, Morimoto-san,
On 06/03/17 15:16, Laurent Pinchart wrote:
> Hi Morimoto-san,
>
> On Monday 06 Mar 2017 06:17:47 Kuninori Morimoto wrote:
>> Hi Laurent, Kieran
>>
I asked it to HW team.
Please wait
>>
>> I'm still waiting from HW team's response, but can you check
>>
Hi Laurent,
On 05/03/17 21:58, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Sunday 05 Mar 2017 16:00:03 Kieran Bingham wrote:
>> To be able to perform page flips in DRM without flicker we need to be
>> able to notify the rcar-du module whe
when the full display
pipeline has completed for the frame.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 8 ++--
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 1 +
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 9 +
3
to be registered within the VSP DRM interface.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_drm.c | 17 +
drivers/media/platform/vsp1/vsp1_drm.h | 11 +++
include/media/vsp1.h
seconds in 100uS increments
for periods of 5 seconds on each delay test. These tests have successfully run
for 3 hours.
Manual start/stop testing has also been performed.
Kieran Bingham (3):
v4l: vsp1: Postpone frame end handling in event of display list race
v4l: vsp1: Extend VSP1 module API
to the user.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c | 19 +--
drivers/media/platform/vsp1/vsp1_dl.h | 2 +-
drivers/media/platform/vsp1/vsp1_pipe.c | 13 -
3 files changed, 30 inse
Hi Laurent,
On 03/03/17 02:11, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Wednesday 01 Mar 2017 13:12:55 Kieran Bingham wrote:
>> To be able to perform page flips in DRM without flicker we need to be
>> able to notify the rcar-du module
Hi Laurent,
On 03/03/17 02:17, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Wednesday 01 Mar 2017 13:12:56 Kieran Bingham wrote:
>> Updating the state in a running VSP1 requires two interrupts from the
>> VSP. Initially, the updated state w
an extra frame completion interrupt.
Track this delay, by passing the frame flip event through the VSP
module; It will be returned only when the frame has completed and can be
returned to the caller.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/gpu/drm/r
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
The unbind function dereferences the subdev->dev node to obtain the
of_node. In error paths, the subdev->dev can be set to NULL, whilst the
correct reference to the of_node is available as subdev->of_node.
Correct th
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
The current code determines the pad from the identifiers in the DTB.
This is accepted without bounds in the driver.
Invalid port/reg addresses defined in the DTB will cause a kernel panic
when dereferencing non-existin
On 01/08/17 19:47, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Tuesday 01 Aug 2017 18:35:48 Kieran Bingham wrote:
>> On 26/06/17 19:12, Laurent Pinchart wrote:
>>> The VSP supports both header and headerless display lists. The latter is
>>> easier to use when the
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
The current implementation has to search the list of controls for the
pixel rate control, each time it is set. This can be optimised easily
by storing the ctrl pointer in the CSI/TX object, and referencing that
directly.
Hi Geert,
>>
>> This series is based upon a merge of my previous pa-improvements/v4 and
>> airlied-drm/drm-next to base on top of all pending VSP1 changes.
>
> OK, so I'll drop your vsp1/pa-improvements/v2.
That sounds reasonable :D
>>
is handled by
passing the partition number to the configure call, and processing any
runtime stage actions on the first partition only.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_bru.c| 12 +-
drivers/media/platform/vsp1/vsp1
frame, for both DRM and Video API pipelines thus a
rounded 64 entries provides a suitable allocation.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Extend the display list body with a reference count, allowing bodies to
be kept as long as a reference is maintained. This provides the ability
to keep a cached copy of bodies which will not change, so that they can
be re-applied to multiple display lists.
Signed-off-by: Kieran Bingham
.
A helper, vsp1_dl_list_body() is provided to access the internal body0
from the display list.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_bru.c| 22 ++--
drivers/media/platform/vsp1/vsp1_clu.c| 22 ++--
d
is reset - our cached
configuration will be re-attached to the next committed DL.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
Our video DL usage now looks like the below output:
dl->body0 contains our disposable runtime configuration. Max 41.
dl_c
low for
expansion this is set to 128 for now to prevent unexpected overflows.
Kieran Bingham (8):
v4l: vsp1: Protect fragments against overflow
v4l: vsp1: Provide a fragment pool
v4l: vsp1: Convert display lists to use new fragment pool
v4l: vsp1: Use reference counting for fragments
v4l: v
multiple display list
bodies in a single allocation, and providing these to the display list
through a 'fragment pool'. A pool can be allocated by the display list
manager or entities which require their own body allocations.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.
ate before the hardware has committed a previous
set of tables.
Fragments are no longer 'freed' in interrupt context, but instead
released back to their respective pools. This allows us to remove the
garbage collector in the DLM.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboa
to catch any
buffer overflows.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media/platform/vsp1/vsp1_dl.c
index 8b5cbb
From: Kieran Bingham <kieran.bing...@ideasonboard.com>
Hi Geert,
Please consider pulling the following changes into renesas-drivers.
This series is based upon a merge of my previous pa-improvements/v4 and
airlied-drm/drm-next to base on top of all pending VSP1 changes.
The following c
Hi Laurent,
Thanks for your review,
On 16/08/17 22:53, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
> How about
>
> if (WARN_ONCE(dlb->num_entries >= dlb->max_entries,
> "DLB size exceeded (max %u)", dlb->max_entries))
> return;
>
implied as supported aren't mentioned - but that's
not a blocker to adding in the initial devices at all.
Therefore:
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_drv.c | 24
> drivers/
tart interrupt anymore.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Ok, I had skipped this one as I was concerned about its effects in relation to
11/14 but I see how that's working now.
Reviewed-by: Kieran Bingham <kieran.bingham+rene
igned-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
This looks good.
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1.h| 5 ++--
> drivers/media/platform/vsp1/vsp1_drm.c| 8 ++--
by two. Fix it by moving back to the VBK interrupt.
>
> Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Of course, this looks much more correct than the patch
;
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
A bit of comment merge between this and the next patch but it's minor and not
worth the effort to change that ... so I'll happily ignore it if you do :)
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonb
pinchart+rene...@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1.h| 2 +
> drivers/media/platform/vsp1/vsp1_bru.c| 45 ++
> drivers/media/platform/vsp1/vsp1_bru.
On 13/07/17 16:51, Kieran Bingham wrote:
> Hi Laurent,
>
> I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register
> access bug" and it relates directly to a comment I had in this patch:
>
> On 12/07/17 17:35, Kieran Bingham wrote:
>> H
On 14/07/17 00:31, Laurent Pinchart wrote:
> Hi Kieran,
>
> On Thursday 13 Jul 2017 18:49:19 Kieran Bingham wrote:
>> On 26/06/17 19:12, Laurent Pinchart wrote:
>>> New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL,
>>> as well as a new V
entities to participate in the partition algorithm
(2017-07-17 09:53:18 +0100)
Kieran Bingham (6):
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function
v4l: vsp1: Calculate partition sizes at stream start
Hi Maxime,
On 17/07/17 07:32, Maxime Ripard wrote:
> On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote:
>>>>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>>>>> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
>>>>> index 82b978a5dae6.
r vertical blanking when stopping a
> CRTC, as there's no need to reconfigure plane assignment at that point.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
the boards the same but is not connected in the chip.
Anyway, that's irrelevant to this patch so ...
On 21/06/17 10:04, Laurent Pinchart wrote:
> Update the device description with the HDMI output.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Revi
Hi Geert,
> Indeed.
>
> BTW, the M3-W version also has unconnected USB3 and SATA connectors.
Thanks for the heads up :) - I've just put a post it note over those, +HDMI1-OUT
(or rather the text on the top lid) to prevent any confusion for me down the
line.
--
Kieran
only have code reduction or comment suggestions below - so either with or
without those changes, feel free to add my:
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66
> --
>
ing with the
> kernel coding style are introduced, fix all multiline comments in one
> go.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Acked-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/gpu/d
Provide register definitions required for UDS phase and partition
algorithm support.
These registers are applicable to Gen3 hardware only.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
d
on the partition
struct rather than copying and duplicating the processed data
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_pipe.h | 12 +-
drivers/media/p
.
Utilise local variables for the processing as required.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
v2:
- s/current_partition/partition/
- s/partition_number/partition/
---
drivers/media/p
output to its predecessor in the pipeline.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
v2:
- vsp1_partition_rect renamed as vsp1_partition_window
- destination vsp1_partition_window made const to prevent change
- (currently) unused 'offset' removed.
- par
-calculate the partition sizes into this table.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
v2:
- Partition table allocated dynamically as required.
- loop uses unsigned int
- rebase on to
. This system allows the
entity objects to specify what they need to fulfil the output for the next
entity in the pipeline.
v2:
- Rebased to v4.12-rc1
- Partition tables dynamically allocated
- review fixups
Kieran Bingham (6):
v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function
the function without any code change.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_video.c | 73 -
1 file changed, 36 insertions(+),
Fragments are no longer 'freed' in interrupt context, but instead released back
to their respective pools.
This allows us to remove the garbage collector in the DLM.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c
multiple display list
bodies in a single allocation, and providing these to the display list
through a 'fragment pool'. A pool can be allocated by the display list
manager or entities which require their own body allocations.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.
Adapt the dl->body0 object to use an object from the fragment pool.
This greatly reduces the pressure on the TLB for IPMMU use cases, as
all of the lists use a single allocation for the main body
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media
to catch any
buffer overflows
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
drivers/media/platform/vsp1/vsp1_dl.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media/platform/vsp1/vsp1_dl.c
index 8b5cbb
Adapt the LUT to allocate a fragment pool for passing the table updates
to hardware.
Two bodies are pre-allocated in the pool to manage a userspace update
before the hardware has taken a previous set of tables.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
d
Adapt the CLU to allocate a fragment pool for passing the table updates
to hardware.
Two bodies are pre-allocated in the pool to manage a userspace update
before the hardware has taken a previous set of tables.
Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
---
d
has been tested and based on top of Laurent's recent ES2.0 patch
set at git://linuxtv.org/pinchartl/media.git drm/next/h3-es2/merged
Kieran Bingham (6):
v4l: vsp1: Protect fragments against overflow
v4l: vsp1: Provide a fragment pool
v4l: vsp1: Convert display lists to use new fragment pool
Hi Laurent,
Thankyou for these patches, bringing life to the outputs of my ES2.0 target
board.
I have tested them on my board, and including the VSP unit test suite, and
kmscube utilities.
Feel free to add a Tested-by: Kieran Bingham
<kieran.bingham+rene...@ideasonboard.com>
e headers without holding the lock.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_dl.c | 6 --
> 1 file changed, 4 ins
code already handles this correctly without
> referring to the sink pointer, which thus doesn't need to be set.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> dri
101 - 200 of 851 matches
Mail list logo
