[RFC v2 4/6] serial: core: support deferring serdev controller registration

2017-07-17 Thread Ulrich Hecht
serdev controllers may depend on other devices (such as multiplexers) and thus require deferred probing support. Signed-off-by: Ulrich Hecht --- drivers/tty/serial/serial_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial

Re: [RFC v2 1/6] mux: include compiler.h from mux/consumer.h

2017-07-31 Thread Ulrich Hecht
On Mon, Jul 31, 2017 at 11:02 AM, Peter Rosin wrote: > Hi Ulrich, > > This patch looks good to me. Let me know if I should feed this > through the mux subsystem or if it will take some other route. Please pick it up, thanks. > In case someone else ends up taking it: > Acked-by: Peter Rosin CU

[PATCH 0/6] serdev multiplexing support

2017-08-16 Thread Ulrich Hecht
t respond correctly - max9260: change a number of length-bearing variables to size_t - dt: number max9260 devices according to their "reg" node Ulrich Hecht (6): serdev: add method to set parity serdev: add multiplexer support serial: core: support deferring serdev contr

[PATCH 1/6] serdev: add method to set parity

2017-08-16 Thread Ulrich Hecht
Adds serdev_device_set_parity() and an implementation for ttyport. Signed-off-by: Ulrich Hecht --- drivers/tty/serdev/core.c | 12 drivers/tty/serdev/serdev-ttyport.c | 18 ++ include/linux/serdev.h | 10 ++ 3 files changed, 40

[PATCH 4/6] max9260: add driver for i2c over GMSL passthrough

2017-08-16 Thread Ulrich Hecht
This driver implements tunnelling of i2c requests over GMSL via a MAX9260 deserializer. It provides an i2c adapter that can be used to reach devices on the far side of the link. Signed-off-by: Ulrich Hecht --- drivers/media/i2c/Kconfig | 6 + drivers/media/i2c/Makefile | 1 + drivers

[PATCH 6/6] dt-bindings: slave-device: add reg property

2017-08-16 Thread Ulrich Hecht
This adds a new DT property to define the index used by a multiplexer to select the device. Signed-off-by: Ulrich Hecht --- Documentation/devicetree/bindings/serial/slave-device.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/slave-device.txt

[PATCH 5/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer

2017-08-16 Thread Ulrich Hecht
Adds serial port SCIF1 and the MAX9260 deserializers connected to it. Signed-off-by: Ulrich Hecht --- arch/arm/boot/dts/r8a7792-blanche.dts | 52 +++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts b/arch/arm/boot/dts/r8a7792

[PATCH 3/6] serial: core: support deferring serdev controller registration

2017-08-16 Thread Ulrich Hecht
serdev controllers may depend on other devices (such as multiplexers) and thus require deferred probing support. Signed-off-by: Ulrich Hecht --- drivers/tty/serial/serial_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial

[PATCH 2/6] serdev: add multiplexer support

2017-08-16 Thread Ulrich Hecht
Adds an interface for slave device multiplexing using the mux subsystem. Signed-off-by: Ulrich Hecht --- drivers/tty/serdev/Kconfig | 1 + drivers/tty/serdev/Makefile | 2 +- drivers/tty/serdev/core.c | 13 - drivers/tty/serdev/mux.c| 66

Re: [RFC v2 3/6] serdev: add multiplexer support

2017-08-16 Thread Ulrich Hecht
On Wed, Jul 19, 2017 at 1:06 AM, Rob Herring wrote: >> static inline struct serdev_controller *to_serdev_controller(struct device >> *d) >> @@ -172,7 +180,7 @@ static inline void serdev_controller_write_wakeup(struct >> serdev_controller *ctrl >> { >> struct serdev_device *serdev = ctr

Re: [RFC v2 5/6] max9260: add driver for i2c over GMSL passthrough

2017-08-16 Thread Ulrich Hecht
On Mon, Jul 31, 2017 at 1:13 PM, Laurent Pinchart wrote: >> +static int max9260_probe(struct serdev_device *serdev) >> +{ >> + struct max9260_device *dev; >> + struct i2c_adapter *adap; >> + int ret; >> + >> + dev = kzalloc(sizeof(*dev), GFP_KERNEL); >> + if (!dev) >> +

Re: [RFC v2 5/6] max9260: add driver for i2c over GMSL passthrough

2017-08-16 Thread Ulrich Hecht
On Wed, Jul 19, 2017 at 5:00 PM, Wolfram Sang wrote: >> +{ >> + wait_event_interruptible_timeout(dev->rx_wq, >> + dev->rx_state <= RX_FRAME_ERROR, >> + HZ/2); > > I'd suggest to drop the interruptible. It can be done but it is usually > not trivial to abort the operatio

[PATCH] arm64: dts: salvator-common: add 12V regulator to backlight

2017-09-18 Thread Ulrich Hecht
This fixes the warning "pwm-backlight backlight: backlight supply power not found, using dummy regulator". Fixes: b33be33670217533 ("arm64: dts: salvator-x: Add panel backlight support") Reported-by: Geert Uytterhoeven Signed-off-by: Ulrich Hecht --- arch/arm64/boot/

[PATCH] serial: sh-sci: Support for variable HSCIF hardware RX timeout

2017-09-19 Thread Ulrich Hecht
HSCIF has facilities that allow changing the timeout after which an RX interrupt is triggered even if the FIFO is not filled. This patch allows changing the default (15 bits of silence) using the existing sysfs attribute "rx_fifo_timeout". Signed-off-by: Ulrich Hecht --- drivers/tty

[PATCH 0/2] HSCIF tweaks support

2017-09-29 Thread Ulrich Hecht
touch-ups suggested in Geert's review of the standalone version. CU Uli Ulrich Hecht (2): serial: sh-sci: Support for variable HSCIF hardware RX timeout serial: sh-sci: Support for HSCIF RX sampling point adjustment drivers/tty/serial/sh-sci.c | 114 +-

[PATCH 1/2] serial: sh-sci: Support for variable HSCIF hardware RX timeout

2017-09-29 Thread Ulrich Hecht
HSCIF has facilities that allow changing the timeout after which an RX interrupt is triggered even if the FIFO is not filled. This patch allows changing the default (15 bits of silence) using the existing sysfs attribute "rx_fifo_timeout". Signed-off-by: Ulrich Hecht --- drivers/tty

[PATCH 2/2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

2017-09-29 Thread Ulrich Hecht
, meaning center) using the sysfs attribute "rx_sampling_point". Signed-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 62 +++-- drivers/tty/serial/sh-sci.h | 4 +++ 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/tty

Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

2018-05-23 Thread Ulrich Hecht
On Thu, May 17, 2018 at 9:56 AM, Wolfram Sang wrote: > On Wed, May 16, 2018 at 03:05:15PM +0200, Ulrich Hecht wrote: >> From: Hiromitsu Yamasaki >> >> This patch adds MSIOF device nodes for the R8A77995 SoC. >> >> Signed-off-by: Hiromitsu Yamasaki >>

[PATCH v2 1/2] arm64: dts: r8a77995: Add MSIOF device nodes

2018-06-20 Thread Ulrich Hecht
From: Hiromitsu Yamasaki This patch adds MSIOF device nodes for the R8A77995 SoC. Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Takeshi Kihara [uli: remove unimplemented ref clock, clock-names] Signed-off-by: Ulrich Hecht --- Removed clock-names and fixed the number formatting. Thanks to

[PATCH resend] dmaengine: rcar-dmac: Document R8A77990 bindings

2018-06-20 Thread Ulrich Hecht
From: Hiroyuki Yokoyama Renesas R-Car E3 (R8A77990) SoC also has the R-Car gen2/3 compatible DMA controllers, so document the SoC specific binding. Signed-off-by: Hiroyuki Yokoyama Signed-off-by: Ulrich Hecht Reviewed-by: Simon Horman Acked-by: Rob Herring Reviewed-by: Geert Uytterhoeven

[PATCH v2 2/2] spi: sh-msiof: Document R-Car D3 support

2018-06-20 Thread Ulrich Hecht
Document support for the MSIOF module in the Renesas D3 (r8a77995) SoC. No driver update is needed. Signed-off-by: Ulrich Hecht Reviewed-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- Added Reviewed-bys. CU Uli Documentation/devicetree/bindings/spi/sh-msiof.txt | 1 + 1 file changed

Re: [PATCH v3 2/2] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support

2018-07-16 Thread Ulrich Hecht
arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 106 >> > + >> > arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 120 >> > >> >> Laurent, could you review this? > > Ping For the Condor part: Reviewed-by: Ulrich Hecht Unfortunately, I do not have documentation for the other board. CU Uli

Re: [PATCH] i2c: recovery: make pin init look like STOP

2018-07-16 Thread Ulrich Hecht
t; - bri->set_sda(adap, 1); > - ndelay(RECOVERY_NDELAY); > + bri->set_sda(adap, scl); > + ndelay(RECOVERY_NDELAY / 2); > > /* > * By this time SCL is high, as we need to give 9 falling-rising edges > -- > 2.11.0 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH 2/2] i2c: rcar: implement STOP and REP_START according to docs

2018-08-16 Thread Ulrich Hecht
ceived data is the _LAST_, go to new phase. */ > + if (priv->pos + 1 == msg->len) { > + if (priv->flags & ID_LAST_MSG) { > + rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_STOP); > + } else { > + rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_START); > + priv->flags |= ID_P_REP_AFTER_RD; > + } > + } So "priv->pos + 1 <= msg->len" is an invariant? (The current code seems to imply that it isn't.) If it is, Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH 1/2] i2c: rcar: refactor private flags

2018-08-16 Thread Ulrich Hecht
sometimes */ > +#define ID_P_PM_BLOCKED BIT(31) > +#define ID_P_MASKGENMASK(31, 30) > > enum rcar_i2c_type { > I2C_RCAR_GEN1, > -- > 2.11.0 > Reviewed-by: Ulrich Hecht CU Uli

[PATCH 2/3] pinctrl: sh-pfc: r8a7795-es1: Add I2C{0,3,5} pins, groups and functions

2018-08-17 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 ES1.x SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht

[PATCH 0/3] I2C0/3/5 pin control for H3 and M3-W

2018-08-17 Thread Ulrich Hecht
Hi! This is an up-port from the BSP. Unfortunately I could not test these because none of those pins seem to be accessible on Salvator boards (not on ULCB either, AFAICT), so the best thing I can say is that they don't seem to break anything. CU Uli Takeshi Kihara (3): pinctrl: sh-pfc: r8a779

[PATCH 1/3] pinctrl: sh-pfc: r8a7795: Add I2C{0,3,5} pins, groups and functions

2018-08-17 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- drivers

[PATCH 3/3] pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions

2018-08-17 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7796 SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- drivers

[PATCH 2/5] arm64: dts: r8a7795: Add cpuidle support for CA53 cores

2018-08-17 Thread Ulrich Hecht
From: Dien Pham Enables cpuidle (core shutdown) support for R-Car H3 CA53 cores. Signed-off-by: Dien Pham Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64

[PATCH 5/5] arm64: dts: r8a7796-m3ulcb: Disable cpuidle support for CA53 cores

2018-08-17 Thread Ulrich Hecht
From: Takeshi Kihara The revision of the R8A7796 SoC on the M3ULCB board is ES1.0. This revision can not use cpuidle for CA53 cores. Therefore, this patch disables cpuidle support for CA53 cores. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas

[PATCH 3/5] arm64: dts: r8a7796: Add cpuidle support for CA57 cores

2018-08-17 Thread Ulrich Hecht
[dien.pham.ry: Apply new cpuidle parameters] Signed-off-by: Dien Pham Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index

[PATCH 1/5] arm64: dts: r8a7795: Add cpuidle support for CA57 cores

2018-08-17 Thread Ulrich Hecht
parameters] Signed-off-by: Dien Pham Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index

[PATCH 4/5] arm64: dts: r8a7796: Add cpuidle support for CA53 cores

2018-08-17 Thread Ulrich Hecht
From: Dien Pham Enable cpuidle (core shutdown) support for R-Car M3-W CA53 cores. Signed-off-by: Dien Pham Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64

[PATCH 0/5] H3/M3-W cpuidle support

2018-08-17 Thread Ulrich Hecht
Hi! This series adds CPU idle support for H3 and M3-W. It's a straight up-port from the BSP. The part that disables cpuidle for the CA53 cores on M3ULCB is a bit dodgy. Is it a valid assumption that all M3ULCB boards have an ES1.0 SoC? CU Uli Dien Pham (2): arm64: dts: r8a7795: Add cpuidle s

[RESEND PATCH] spi: sh-msiof: Document R-Car D3 support

2018-08-24 Thread Ulrich Hecht
Document support for the MSIOF module in the Renesas D3 (r8a77995) SoC. No driver update is needed. Signed-off-by: Ulrich Hecht Reviewed-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- This patch fell by the wayside, probably because I forgot to cc devicetree. CU Uli Documentation

Re: [RESEND PATCH] spi: sh-msiof: Document R-Car D3 support

2018-09-04 Thread Ulrich Hecht
> On September 4, 2018 at 9:20 AM Wolfram Sang wrote: > > > On Mon, Sep 03, 2018 at 12:02:19PM +0100, Mark Brown wrote: > > On Mon, Sep 03, 2018 at 11:28:19AM +0200, Wolfram Sang wrote: > > > On Fri, Aug 24, 2018 at 11:12:31AM +0200, Ulrich Hecht wrote: > >

Re: [PATCH 0/2] serial: sh-sci: Use pm_runtime_get_sync()/put()

2018-09-19 Thread Ulrich Hecht
Sorry for the delay... > On April 13, 2018 at 7:27 PM Geert Uytterhoeven wrote: > > On Fri, Apr 13, 2018 at 7:00 PM, Ulrich Hecht > wrote: > > These patches make sure that the device is up while the suspend/resume code > > is executed. Up-port from the BSP, t

[PATCH] serial: sh-sci: do not warn if DMA transfers are not supported

2018-10-12 Thread Ulrich Hecht
ned-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 426241d..ff6ba6d 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1516

Re: [PATCH] serial: sh-sci: Fix could not remove dev_attr_rx_fifo_timeout

2018-10-30 Thread Ulrich Hecht
(port->port.type == PORT_SCIFA || port->port.type == PORT_SCIFB || > - port->port.type == PORT_HSCIF) { > + if (type == PORT_SCIFA || type == PORT_SCIFB || type == PORT_HSCIF) { > sysfs_remove_file(&dev->dev.kobj, > &dev_attr_rx_fifo_timeout.attr); > } > -- > 1.9.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH] serial: sh-sci: Improve type-safety calling sci_receive_chars()

2018-11-07 Thread Ulrich Hecht
rx) > - sci_receive_chars(ptr); > + sci_receive_chars(port); > } > > sci_clear_SCxSR(port, SCxSR_ERROR_CLEAR(port)); > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH/RFC] dmaengine: sh: Remove R-Mobile APE6 support

2018-11-12 Thread Ulrich Hecht
sh/shdmac.c b/drivers/dma/sh/shdmac.c > index 7971ea2753877486..5aafe548ca5f3082 100644 > --- a/drivers/dma/sh/shdmac.c > +++ b/drivers/dma/sh/shdmac.c > @@ -665,12 +665,6 @@ static const struct shdma_ops sh_dmae_shdma_ops = { > .get_partial = sh_dmae_get_partial, > }; > > -static const struct of_device_id sh_dmae_of_match[] = { > - {.compatible = "renesas,shdma-r8a73a4", .data = r8a73a4_shdma_devid,}, > - {} > -}; > -MODULE_DEVICE_TABLE(of, sh_dmae_of_match); > - > static int sh_dmae_probe(struct platform_device *pdev) > { > const enum dma_slave_buswidth widths = > @@ -915,7 +909,6 @@ static struct platform_driver sh_dmae_driver = { > .driver = { > .pm = &sh_dmae_pm, > .name = SH_DMAE_DRV_NAME, > - .of_match_table = sh_dmae_of_match, > }, > .remove = sh_dmae_remove, > }; > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

[PATCH v2 0/4] I2C0/3/5 pin control for H3 and M3-W

2018-11-15 Thread Ulrich Hecht
: Add I2C{0,3,5} pins, groups and functions pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions Ulrich Hecht (1): pinctrl: sh-pfc: Add physical pin multiplexing helper macros drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 97 --- drivers/pinctrl/s

[PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-15 Thread Ulrich Hecht
Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/sh_pfc.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index 1fc1336..6bb9c6b

[PATCH v2 2/4] pinctrl: sh-pfc: r8a7795: Add I2C{0,3,5} pins, groups and functions

2018-11-15 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- drivers

[PATCH v2 3/4] pinctrl: sh-pfc: r8a7795-es1: Add I2C{0,3,5} pins, groups and functions

2018-11-15 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7795 ES1.x SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht

[PATCH v2 4/4] pinctrl: sh-pfc: r8a7796: Add I2C{0,3,5} pins, groups and functions

2018-11-15 Thread Ulrich Hecht
From: Takeshi Kihara This patch adds I2C{0,3,5} pins, groups and functions to the R8A7796 SoC. These pins are physically muxed with other pins. Therefore, setup of MOD_SEL is needed for exclusive control with other pins. Signed-off-by: Takeshi Kihara Signed-off-by: Ulrich Hecht --- drivers

Re: [PATCH v2 1/4] pinctrl: sh-pfc: Add physical pin multiplexing helper macros

2018-11-16 Thread Ulrich Hecht
> On November 16, 2018 at 9:42 AM Geert Uytterhoeven > wrote: > > > Hi Uli, > > On Fri, Nov 16, 2018 at 8:21 AM Ulrich Hecht wrote: > > Used by I2C controllers 0, 3 and 5 in R8A7795 and R8A7796 SoCs. > > > > Signed-off-by: Ulrich Hecht > > T

[PATCH v3 0/2] dt-bindings: can: rcar_can*: add R-Car D3

2018-12-04 Thread Ulrich Hecht
Hi! These are the bindings for CAN and CAN FD controllers on R-Car D3 (R8A77995). Changes since v2: - rebased - made wording less redundant in rcar_canfd.txt - added dt-bindings prefix to subjects CU Uli Ulrich Hecht (2): dt-bindings: can: rcar_can: add r8a77995 (R-Car D3) compatibility

[PATCH v3 2/2] dt-bindings: can: rcar_canfd: add r8a77995 (R-Car D3) compatibility strings

2018-12-04 Thread Ulrich Hecht
From: Ulrich Hecht Adds compatible strings for the R-Car CAN FD controller in the D3 SoC. Signed-off-by: Ulrich Hecht Acked-by: Rob Herring Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 8 1 file changed, 4

[PATCH v3 1/2] dt-bindings: can: rcar_can: add r8a77995 (R-Car D3) compatibility strings

2018-12-04 Thread Ulrich Hecht
From: Ulrich Hecht Adds compatible strings for the R-Car CAN controller in the D3 SoC. Signed-off-by: Ulrich Hecht Acked-by: Rob Herring Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 3 ++- 1 file changed, 2

Re: [PATCH v2 06/16] drm: rcar-du: Perform the initial CRTC setup from rcar_du_crtc_get()

2018-09-26 Thread Ulrich Hecht
e .atomic_enable() call that will follow. The get > + * operation in .atomic_enable() will in that case be a no-op, and the > + * CRTC will be put later in .atomic_disable(). > + * > + * If a mode set is not in progress the CRTC is enabled, and the > + * following get call will be a no-op. There is thus no need to belance *balance > + * it in .atomic_flush() either. >*/ > - if (!rcrtc->initialized) { > - rcar_du_crtc_get(rcrtc); > - rcar_du_crtc_setup(rcrtc); > - rcrtc->initialized = true; > - } > + rcar_du_crtc_get(rcrtc); > > if (rcar_du_has(rcrtc->group->dev, RCAR_DU_FEATURE_VSP1_SOURCE)) > rcar_du_vsp_atomic_begin(rcrtc); > -- > Regards, > > Laurent Pinchart > With typo fixed: Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 07/16] drm: rcar-du: Use LVDS PLL clock as dot clock when possible

2018-09-26 Thread Ulrich Hecht
DUn. Register fields > - * depend on the DU generation, but the resulting value is 0 in > - * all cases. > - * > - * On Gen2 a single register in the first group controls dot > - * clock selection for all channels, while on Gen3 dot clocks > - * are setup through per-group registers, only available when > - * the group has two channels. > - */ > - if ((rcdu->info->gen < 3 && rgrp->index == 0) || > - (rcdu->info->gen == 3 && rgrp->num_crtcs > 1)) > - rcar_du_group_write(rgrp, DIDSR, DIDSR_CODE); > + rcar_du_group_setup_didsr(rgrp); > } > > if (rcdu->info->gen >= 3) > -- Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 10/16] drm: rcar-du: Don't use TV sync mode when not supported by the hardware

2018-09-26 Thread Ulrich Hecht
ut. */ > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > index ebba9aefba6a..143c037e2c0f 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -27,6 +27,7 @@ struct rcar_du_device; > #define RCAR_DU_FEATURE_EXT_CTRL_REGSBIT(1) /* Has extended control > registers */ > #define RCAR_DU_FEATURE_VSP1_SOURCE BIT(2) /* Has inputs from VSP1 */ > #define RCAR_DU_FEATURE_INTERLACED BIT(3) /* HW supports interlaced */ > +#define RCAR_DU_FEATURE_TVM_SYNC BIT(4) /* Has TV switch/sync modes */ > > #define RCAR_DU_QUIRK_ALIGN_128B BIT(0) /* Align pitches to 128 bytes */ > > -- Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 08/16] drm: rcar-du: Enable configurable DPAD0 routing on Gen3

2018-09-26 Thread Ulrich Hecht
GB > + * output, but it is nonetheless required to ensure a valid initial > + * hardware configuration on Gen3 where DU0 can't always be connected to > + * DPAD0. > + */ > + dpad0_sources = rcdu->info->routes[RCAR_DU_OUTPUT_DPAD0].possible_crtcs; > + rcdu->dpad0_source = ffs(dpad0_sources) - 1; > + > drm_mode_config_reset(dev); > > drm_kms_helper_poll_init(dev); > -- Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 15/16] arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs

2018-09-26 Thread Ulrich Hecht
remote-endpoint = <&hdmi_con_out>; > + }; > + }; > + }; > + }; > +}; > + > +&lvds0 { > + status = "okay"; > + > + clocks = <&cpg CPG_MOD 727>, > + <&x13_clk>, > + <&extal_clk>; > + clock-names = "fck", "dclkin.0", "extal"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; > + > +&lvds1 { > + clocks = <&cpg CPG_MOD 727>, > + <&x13_clk>, > + <&extal_clk>; > + clock-names = "fck", "dclkin.0", "extal"; > +}; > + > &ohci0 { > status = "okay"; > }; > @@ -67,6 +228,11 @@ > }; > }; > > + du_pins: du { > + groups = "du_rgb888", "du_sync", "du_disp", "du_clk_out_0"; > + function = "du"; > + }; > + > usb0_pins: usb { > groups = "usb0_b"; > function = "usb0"; > -- Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 09/16] drm: rcar-du: Cache DSYSR value to ensure known initial value

2018-09-26 Thread Ulrich Hecht
rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool > start) > { > - rcar_du_group_write(rgrp, DSYSR, > - (rcar_du_group_read(rgrp, DSYSR) & ~(DSYSR_DRES | DSYSR_DEN)) | > - (start ? DSYSR_DEN : DSYSR_DRES)); > + struct rcar_du_crtc *rcrtc = &rgrp->dev->crtcs[rgrp->index * 2]; > + > + rcar_du_crtc_dsysr_clr_set(rcrtc, DSYSR_DRES | DSYSR_DEN, > +start ? DSYSR_DEN : DSYSR_DRES); > } > > void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start) > -- Reviewed-by: Ulrich Hecht CU Uli

[PATCH v3] ARM: dts: r8a7793: Add MMCIF0

2016-04-29 Thread Ulrich Hecht
Same as on r8a7791. Signed-off-by: Ulrich Hecht --- This version addresses the issues found by Geert and Simon (thank you): - change back to one DMA controller - use GIC_SPI - add max-frequency CU Uli arch/arm/boot/dts/r8a7793.dtsi | 13 + 1 file changed, 13 insertions(+) diff

[PATCH v4] ARM: dts: r8a7793: Add MMCIF0

2016-05-03 Thread Ulrich Hecht
Same as on r8a7791. Signed-off-by: Ulrich Hecht --- This revision updates the power-domains node. CU Uli Changes since v3: - set power-domains = <&sysc R8A7793_PD_ALWAYS_ON> Changes since v2: - change back to one DMA controller - use GIC_SPI - add max-frequency arch/arm/boot/d

[PATCH v5] ARM: dts: r8a7793: Add MMCIF0

2016-05-05 Thread Ulrich Hecht
Same as on r8a7791. Signed-off-by: Ulrich Hecht Acked-by: Geert Uytterhoeven --- Now with enhanced ePAPR compliance and Acked-by. CU Uli Changes since v4: - ePAPR compliance Changes since v3: - set power-domains = <&sysc R8A7793_PD_ALWAYS_ON> Changes since v2: - change back

[PATCH v4 0/8] Lager/Koelsch board HDMI input support

2016-05-11 Thread Ulrich Hecht
iver v4 - removed "adv7604: fix SPA register location for ADV7612" (picked up) - changed prefix of dts patch to "ARM: dts: lager: " Hans Verkuil (1): r8a7791-koelsch.dts: add HDMI input Laurent Pinchart (1): v4l: subdev: Add pad config allocator and init Ulrich Hecht (4)

[PATCH v4 2/8] media: adv7604: automatic "default-input" selection

2016-05-11 Thread Ulrich Hecht
h this. Signed-off-by: William Towle Signed-off-by: Ulrich Hecht --- drivers/media/i2c/adv7604.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index 41a1bfc..d722c16 100644 --- a/drivers/media/i2

[PATCH v4 8/8] r8a7791-koelsch.dts: add HDMI input

2016-05-11 Thread Ulrich Hecht
From: Hans Verkuil Add support in the dts for the HDMI input. Based on the Lager dts patch from Ultich Hecht. Signed-off-by: Hans Verkuil [uli: removed "renesas," prefixes from pfc nodes] Signed-off-by: Ulrich Hecht --- arch/arm/boot/dts/r8a7791-koelsc

[PATCH v4 4/8] media: rcar-vin: pad-aware driver initialisation

2016-05-11 Thread Ulrich Hecht
CONFIG_MEDIA_CONTROLLER, in line with requirements for building the drivers associated with it. Signed-off-by: William Towle Signed-off-by: Rob Taylor [uli: adapted to rcar-vin rewrite] Signed-off-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 16 drivers/media/platform

[PATCH v4 7/8] ARM: dts: lager: Add entries for VIN HDMI input support

2016-05-11 Thread Ulrich Hecht
t, renamed endpoint, merged default-input] Signed-off-by: Ulrich Hecht --- arch/arm/boot/dts/r8a7790-lager.dts | 39 + 1 file changed, 39 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 749ba02..7e53

[PATCH v4 6/8] media: rcar-vin: initialize EDID data

2016-05-11 Thread Ulrich Hecht
Initializes the decoder subdevice with a fixed EDID blob. Signed-off-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 46 + 1 file changed, 46 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin

[PATCH v4 5/8] media: rcar-vin: add DV timings support

2016-05-11 Thread Ulrich Hecht
Adds ioctls DV_TIMINGS_CAP, ENUM_DV_TIMINGS, G_DV_TIMINGS, S_DV_TIMINGS, and QUERY_DV_TIMINGS. Signed-off-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2

[PATCH v4 1/8] v4l: subdev: Add pad config allocator and init

2016-05-11 Thread Ulrich Hecht
From: Laurent Pinchart Add a new subdev operation to initialize a subdev pad config array, and a helper function to allocate and initialize the array. This can be used by bridge drivers to implement try format based on subdev pad operations. Signed-off-by: Laurent Pinchart Acked-by: Vaibhav Hir

[PATCH v4 3/8] media: rcar_vin: Use correct pad number in try_fmt

2016-05-11 Thread Ulrich Hecht
Fix rcar_vin_try_fmt's use of an inappropriate pad number when calling the subdev set_fmt function - for the ADV7612, IDs should be non-zero. Signed-off-by: William Towle Reviewed-by: Rob Taylor Acked-by: Hans Verkuil [uli: adapted to rcar-vin rewrite] Signed-off-by: Ulrich Hecht --- dr

[RFC 00/21] Renesas r8a7795/Salvator-X HDMI output prototype

2016-05-30 Thread Ulrich Hecht
isplay max size to 4096x2160 size arm64: dts: salvator-x: Add DU pins, HDMI connectors and encoder arm64: configs: Enable R-Car DU related config Kuninori Morimoto (1): arm64: defconfig: add VIDEO_RENESAS_FCP Ulrich Hecht (5): v4l: vsp1: Change VSP1 LIF linebuffer FIFO pinctrl: sh-pfc: r8

[RFC 06/21] drm: rcar-du: Add R8A7795 device support

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 4 +++- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 14 -- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 2 ++ 3 files changed, 17 insertions(+), 3 deletions(-)

[RFC 09/21] drm: rcar-du: Fix display registers for R-Car Gen3

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- drivers/gpu/drm/rcar-du/rcar_du_group.c | 5 + drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +++- 3 files changed, 10 insertions(+), 2 deletions(-) diff -

[RFC 05/21] drm: bridge/dw_hdmi: Fix R-Car Gen3 device support

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/dw-hdmi.c | 158 ++- include/drm/bridge/dw_hdmi.h | 9 +++ 2 files changed, 131 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/b

[RFC 07/21] drm: rcar-du: Add dw_hdmi driver startup

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka The HDMI driver in the R-Car Gen3 uses dw_hdmi driver. Signed-off-by: Koji Matsuoka [geert: Select DRM_DW_HDMI on non-r8a7795 to fix shmobile_defconfig build] Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/Kconfig | 2 + drivers/gpu/drm/rcar-du/r

[RFC 10/21] drm: rcar-du: Fix VSP plane number per devices

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 ++ drivers/gpu/drm/rcar-du/rcar_du_drv.h | 3 ++- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drive

[RFC 11/21] drm: rcar-du: Fix VSP feed plane number

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka VSP feeds plane1 and plane3 with R-Car Gen3. Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers

[RFC 08/21] drm: rcar-du: Add DPLL support

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 97 - drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 8 +++ drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + drivers/gpu/drm/rcar-du/rcar_

[RFC 01/21] drm: rcar-du: Remove i2c slave encoder interface for hdmi encoder

2016-05-30 Thread Ulrich Hecht
From: Archit Taneja The hdmi output in rcar-du uses the i2c slave encoder interface to link to the adv7511 encoder chip. The kms driver creates encoder and connector entities that internally uses the drm_encoder_slave_funcs ops provided by the slave encoder driver. Change the driver such that it

[RFC 03/21] media: vsp1: Set format to RPF input source

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka The output format of the RPF must be unified in RGB or YCbCr by specification of the H/W. To unify the output format in RGB in driver, if the input format is YCbCr, the output format must be converted to RGB by CSC (Color Space Conversion). The driver is missing the format set

[RFC 04/21] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support

2016-05-30 Thread Ulrich Hecht
From: Vladimir Zapolskiy The change adds support of internal HDMI I2C master controller, this subdevice is used by default, if "ddc-i2c-bus" DT property is omitted. The main purpose of this functionality is to support reading EDID from an HDMI monitor on boards, which don't have an I2C bus conne

[RFC 02/21] drm: i2c: adv7511: Convert to drm_bridge

2016-05-30 Thread Ulrich Hecht
From: Archit Taneja We don't want to use the old i2c slave encoder interface anymore. Remove that and make the i2c driver create a drm_bridge entity instead. Converting to bridges helps because the kms drivers don't need to exract encoder slave ops from this driver and use it within their own en

[RFC 12/21] drm: rcar-du: Add pixel format support

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka This patch supports pixel format of RGB332, ARGB, XRGB, BGR888, RGB888, BGRA, BGRX, YVYU and NV61. VYUY format is not supported by H/W. Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 58 +++

[RFC 15/21] pinctrl: sh-pfc: r8a7795: Add DU support

2016-05-30 Thread Ulrich Hecht
Adds DU pinmux support to r8a7795 SoC. Based on work by Takeshi Kihara. Signed-off-by: Ulrich Hecht Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 86 1 file changed, 86 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc

[RFC 14/21] v4l: vsp1: Change VSP1 LIF linebuffer FIFO

2016-05-30 Thread Ulrich Hecht
This patch changes to VSPD hardware recommended value. Purpose is highest pixel clock without underruns. In the default R-Car Linux BSP config this value is wrong and therefore there are many underruns. Signed-off-by: Takashi Saito Signed-off-by: Koji Matsuoka Signed-off-by: Ulrich Hecht

[RFC 13/21] drm: rcar-du: Fix display max size to 4096x2160 size

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index a8c59c3..d6d

[RFC 16/21] pinctrl: sh-pfc: r8a7795: Add HDMI CEC support

2016-05-30 Thread Ulrich Hecht
Adds DU pinmux support to r8a7795 SoC. Based on work by Takeshi Kihara. Signed-off-by: Ulrich Hecht Signed-off-by: Geert Uytterhoeven --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c

[RFC 18/21] arm64: dts: salvator-x: Add DU pins, HDMI connectors and encoder

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Based on work by Koji Matsuoka. Signed-off-by: Ulrich Hecht [geert: Re-add removed extal_clk] [geert: Modify existing du node instead of moving it around] [geert: Use generic pinctrl properties] Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795

[RFC 17/21] arm64: dts: r8a7795: Add HDMI encoder support

2016-05-30 Thread Ulrich Hecht
Based on work by Koji Matsuoka. Signed-off-by: Ulrich Hecht Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi

[RFC 20/21] arm64: dts: r8a7795: add HDMI support to DU

2016-05-30 Thread Ulrich Hecht
Signed-off-by: Ulrich Hecht Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index fcad91a

[RFC 19/21] arm64: configs: Enable R-Car DU related config

2016-05-30 Thread Ulrich Hecht
From: Koji Matsuoka Signed-off-by: Koji Matsuoka Signed-off-by: Geert Uytterhoeven --- arch/arm64/configs/defconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index aa47366..fc10983 100644 --- a/arch/arm64/con

[RFC 21/21] arm64: defconfig: add VIDEO_RENESAS_FCP

2016-05-30 Thread Ulrich Hecht
From: Kuninori Morimoto DRM_RCAR_VSP requests VIDEO_RENESAS_VSP1, and VIDEO_RENESAS_VSP1 requests VIDEO_RENESAS_FCP. But VIDEO_RENESAS_FCP is not set on defconfig. This patch adds it. Otherwise kernel goes to Oops. Signed-off-by: Kuninori Morimoto Signed-off-by: Geert Uytterhoeven --- arch/ar

Re: [RFC 00/21] Renesas r8a7795/Salvator-X HDMI output prototype

2016-05-31 Thread Ulrich Hecht
On Mon, May 30, 2016 at 5:59 PM, Ulrich Hecht wrote: > Hi! > > This is a prototype of HDMI output support for the Renesas r8a7795 SoC and > Salvator-X board. It is based on the renesas-devel-20160516-v4.6 tree and Actually, it is based on renesas-drivers-2016-05-17- v4.6, s

DRM/KMS automated tests

2016-05-31 Thread Ulrich Hecht
Hi! I have cobbled together a bunch of scripts to test the atomic updates API, based around kms++; see here: https://github.com/uli/kmsxx/tree/autotest Instructions on how to set up the environment can be found here: http://elinux.org/User:Uli/Tests:KMS Currently, tests try various sensible an

Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-02 Thread Ulrich Hecht
Thank you for your patch. On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram wrote: [...] > diff --git a/drivers/net/can/rcar/rcar_canfd.c > b/drivers/net/can/rcar/rcar_canfd.c > new file mode 100644 > index 000..e198732 > --- /dev/null > +++ b/drivers/net/can/rcar/rcar_canfd.c > @@ -0

Re: [RESEND PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-03 Thread Ulrich Hecht
On Fri, Jun 3, 2016 at 8:42 AM, Ramesh Shanmugasundaram wrote: > Hi Uli, > > Thanks for the review > >> Thank you for your patch. >> >> On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram >> wrote: >> [...] >> > diff --git a/drivers/net/can/rcar/rcar_canfd.c >> > b/drivers/net/can/rcar/rcar_

Re: [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-13 Thread Ulrich Hecht
(0x80 * (x))) > +#define RCANFD_F_RFDF(x, df) (RCANFD_F_RFOFFSET + 0x0c + \ > +(0x80 * (x)) + (0x04 * (df))) > + > +/* RSCFDnCFDCFXXk -> RCANFD_F_CFXX(ch, k) */ > +#define RCANFD_F_CFOFFSET (0x3400) > +#define RCANFD_F_CFID(ch, idx) (RCANFD_F_CFOFFSET + (0x180 * (ch)) + > \ > +(0x80 * (idx))) > +#define RCANFD_F_CFPTR(ch, idx)(RCANFD_F_CFOFFSET + 0x04 + \ > +(0x180 * (ch)) + (0x80 * (idx))) > +#define RCANFD_F_CFFDCSTS(ch, idx) (RCANFD_F_CFOFFSET + 0x08 + \ > +(0x180 * (ch)) + (0x80 * (idx))) > +#define RCANFD_F_CFDF(ch, idx, df) (RCANFD_F_CFOFFSET + 0x0c + \ > +(0x180 * (ch)) + (0x80 * (idx)) + \ > +(0x04 * (df))) > + > +/* RSCFDnCFDTMXXp -> RCANFD_F_TMXX(p) */ > +#define RCANFD_F_TMID(p) (0x4000 + (0x20 * (p))) > +#define RCANFD_F_TMPTR(p) (0x4004 + (0x20 * (p))) > +#define RCANFD_F_TMFDCTR(p)(0x4008 + (0x20 * (p))) > +#define RCANFD_F_TMDF(p, b)(0x400c + (0x20 * (p)) + (0x04 * (b))) > + > +/* RSCFDnCFDTHLACCm */ > +#define RCANFD_F_THLACC(m) (0x6000 + (0x04 * (m))) > +/* RSCFDnCFDRPGACCr */ > +#define RCANFD_F_RPGACC(r) (0x6400 + (0x04 * (r))) [...] Apart from that, all register addresses, offsets, bit positions and masks check out. With the two issues fixed: Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v4 05/13] soc: renesas: rcar-sysc: Improve SYSC interrupt config in legacy wrapper

2016-06-17 Thread Ulrich Hecht
> + pr_debug("%s: syscimr = 0x%08x\n", __func__, syscimr); > + iowrite32(syscimr, rcar_sysc_base + SYSCIMR); > + > + /* > +* SYSC needs all interrupt sources enabled to control power. > +*/ > + pr_debug("%s: syscier = 0x%08x\n", __func_

Re: [PATCH v4 04/13] soc: renesas: rcar-sysc: Move SYSC interrupt config to rcar-sysc driver

2016-06-17 Thread Ulrich Hecht
> --- a/include/linux/soc/renesas/rcar-sysc.h > +++ b/include/linux/soc/renesas/rcar-sysc.h > @@ -11,6 +11,6 @@ struct rcar_sysc_ch { > > int rcar_sysc_power_down(const struct rcar_sysc_ch *sysc_ch); > int rcar_sysc_power_up(const struct rcar_sysc_ch *sysc_ch); > -void __iomem *rcar_sysc_init(phys_addr_t base); > +void rcar_sysc_init(phys_addr_t base, u32 syscier); > > #endif /* __LINUX_SOC_RENESAS_RCAR_SYSC_H__ */ > -- > 1.9.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v4 06/13] ARM: shmobile: apmu: Move #ifdef CONFIG_SMP to cover more functions

2016-06-17 Thread Ulrich Hecht
; apmu_parse_cfg(apmu_init_cpu, apmu_config, num); > } > > -#ifdef CONFIG_SMP > int shmobile_smp_apmu_boot_secondary(unsigned int cpu, struct task_struct > *idle) > { > /* For this particular CPU register boot vector */ > -- > 1.9.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v4 03/13] soc: renesas: rcar-sysc: Make rcar_sysc_init() init the PM domains

2016-06-17 Thread Ulrich Hecht
Thanks for the patch. On Thu, Jun 16, 2016 at 12:27 PM, Geert Uytterhoeven wrote: > Let rcar_sysc_init() trigger initialization of the SYSC PM domains from > DT if called before the early_initcall. > On failure, it falls back to mapping the passed register block, as > before. > > Signed-off-by: G

<    1   2   3   4   5   6   >