Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-28 Thread Geert Uytterhoeven
Hi Greg, On Sat, Jul 28, 2018 at 4:55 PM Greg KH wrote: > On Thu, Jul 26, 2018 at 03:01:11PM +0200, Geert Uytterhoeven wrote: > > On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt > > wrote: > > > On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > > > Thanks for your series! > > > > > > > >

RE: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-28 Thread Chris Brandt
On Saturday, July 28, 2018 1, Greg KH wrote: > > > In your opinion, which one would be better (revert or rebase)? > > > > [looking at the incremental differences] > > > > I think the easiest for Greg is to rebase, and send 3 patches: > > Greg does not rebase his public trees. Nor should anyone

Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-28 Thread Greg KH
On Thu, Jul 26, 2018 at 03:01:11PM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt wrote: > > On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > > Thanks for your series! > > > > > > Unfortunately Greg has already applied your v1 (and my fix

RE: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-26 Thread Chris Brandt
Hi Geert, On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > In your opinion, which one would be better (revert or rebase)? > > [looking at the incremental differences] > > I think the easiest for Greg is to rebase, and send 3 patches: > 1. Document interrupt order in bindings, > 2.

Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-26 Thread Geert Uytterhoeven
Hi Chris, On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt wrote: > On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > Thanks for your series! > > > > Unfortunately Greg has already applied your v1 (and my fix for a > > use-after-free), so either these have to be reverted first, or you have

RE: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-26 Thread Chris Brandt
Hi Geert, On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > Thanks for your series! > > Unfortunately Greg has already applied your v1 (and my fix for a > use-after-free), so either these have to be reverted first, or you have to > rebase against tty-next. I assume you would prefer the

Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-26 Thread Geert Uytterhoeven
Hi Chris, On Wed, Jul 25, 2018 at 4:39 PM Chris Brandt wrote: > The RZ/A2 uses a modified SCIF that until recently was only used in > Renesas MCU devices (not MPU devices). > So, while it functions mostly the same as a normal SCIF, some things > needed to be shifted around. > > In the end, a

[PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2

2018-07-25 Thread Chris Brandt
The RZ/A2 uses a modified SCIF that until recently was only used in Renesas MCU devices (not MPU devices). So, while it functions mostly the same as a normal SCIF, some things needed to be shifted around. In the end, a standard compatible = "renesas,scif" is all that is really needed (not a SoC