Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

2017-01-20 Thread Wolfram Sang
> > Is this clock solely about card detection? So in cases when you have a > > GPIO card detect, the clock isn't needed? > > > > Just trying to understand things a bit better... > > According to the hardware manual, enabling the "core" clock but not the > "cd" clock is not a valid setting. So

RE: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

2017-01-20 Thread Chris Brandt
Hello Ulf, On Friday, January 20, 2017, Ulf Hansson wrote: > On 18 January 2017 at 18:25, Chris Brandt > wrote: > > Some controllers have 2 clock sources instead of 1, so they both need > > to be turned on/off. > > This doesn't tell me enough. Please elaborate. > >

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

2017-01-20 Thread Ulf Hansson
On 18 January 2017 at 18:25, Chris Brandt wrote: > Some controllers have 2 clock sources instead of 1, so they both need > to be turned on/off. This doesn't tell me enough. Please elaborate. For example, tell how you treat the clocks, which of them that is optional and

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

2017-01-19 Thread Wolfram Sang
On Wed, Jan 18, 2017 at 12:25:00PM -0500, Chris Brandt wrote: > Some controllers have 2 clock sources instead of 1, so they both need > to be turned on/off. > > Signed-off-by: Chris Brandt Reviewed-by: Wolfram Sang signature.asc

[PATCH v3 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

2017-01-18 Thread Chris Brandt
Some controllers have 2 clock sources instead of 1, so they both need to be turned on/off. Signed-off-by: Chris Brandt --- v2: * changed clk2 to clk_cd * disable clk if clk_cd enable fails * changed clock name from "carddetect" to "cd" ---