Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2017-07-17 Thread Geert Uytterhoeven
On Mon, Jun 20, 2016 at 8:40 AM, Wolfram Sang wrote: > From: Wolfram Sang > > On group configuration, bail out if setting one of the individual pins > fails. We don't need to roll-back, the pinctrl core will do this for us. > > Signed-off-by:

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2017-05-24 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, May 24, 2017 at 2:21 PM, Wolfram Sang wrote: >> This is caused by the "output-high" property for the GPIO hog. >> Due to both lcd0 pinmux and GPIO hog being part of the same device node, >> "output-high" is also applied to the lcd0 pins, which fails. >> >>

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2017-05-24 Thread Wolfram Sang
Hi Geert, > This is caused by the "output-high" property for the GPIO hog. > Due to both lcd0 pinmux and GPIO hog being part of the same device node, > "output-high" is also applied to the lcd0 pins, which fails. > > RFC fix in "[PATCH/RFC] ARM: dts: armadillo800eva: Split LCD mux and gpio" >

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2017-05-24 Thread Geert Uytterhoeven
Hi Wolfram, On Tue, Jun 21, 2016 at 3:11 PM, Geert Uytterhoeven wrote: > On Mon, Jun 20, 2016 at 8:40 AM, Wolfram Sang wrote: >> On group configuration, bail out if setting one of the individual pins >> fails. We don't need to roll-back, the pinctrl

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2016-06-21 Thread Wolfram Sang
> > On group configuration, bail out if setting one of the individual pins > > fails. We don't need to roll-back, the pinctrl core will do this for us. > > > > Signed-off-by: Wolfram Sang > > --- > > > > Tested on a Lager and Salvator-X without problems. Needs

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2016-06-21 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jun 20, 2016 at 8:40 AM, Wolfram Sang wrote: > On group configuration, bail out if setting one of the individual pins > fails. We don't need to roll-back, the pinctrl core will do this for us. > > Signed-off-by: Wolfram Sang

[RFC] pinctrl: sh-pfc: propagate errors on group config

2016-06-20 Thread Wolfram Sang
From: Wolfram Sang On group configuration, bail out if setting one of the individual pins fails. We don't need to roll-back, the pinctrl core will do this for us. Signed-off-by: Wolfram Sang --- Tested on a Lager and