Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > Hi Simon, > > > + void (*disable_scc)(struct mmc_host *mmc); > > Do we really need this callback? I'd think it can be folded into > reset_hs400_mode() because it is called only once? > > > + void

Re: [PATCH v3 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:51 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a7792 Wheat board has two ADV7513 devices sharing a single i2c > bus, however in low power mode the ADV7513 will reset

[PATCH v3 2/2] mmc: renesas_sdhi: add eMMC HS400 mode support

From: Masaharu Hayakawa This patch adds processing for selecting HS400 mode. Signed-off-by: Masaharu Hayakawa Signed-off-by: Simon Horman --- v3 [Simon Horman] * Consolidate disable_scc and

[PATCH v3 1/2] mmc: tmio: add eMMC HS400 mode support

From: Masaharu Hayakawa This patch adds processing for selecting HS400 mode. Signed-off-by: Masaharu Hayakawa Signed-off-by: Simon Horman --- v3 [Simon Horman] * Consolidate disable_scc and

[PATCH v3 0/2] mmc: renesas_sdhi: add eMMC HS400 mode support

Hi, this patch-set provides SDHI driver support for eMMC HS400. Based on mmc/next Dependencies for applying these patches: none Dependencies to test eMMC HS400: * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting * [PATCH v2] arm64: dts: salvator-common: Enable HS400 of SDHI2 To assist

RE: [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

Hello Simon, > Subject: Re: [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as > reset trigger for Gen2 > > On Mon, Feb 12, 2018 at 05:44:18PM +, Fabrizio Castro wrote: > > This patch allows for platform specific quirks as some of the SoC need > > further customization for the

renesas-drivers-2018-02-13-v4.16-rc1

I have pushed renesas-drivers-2018-02-13-v4.16-rc1 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

Hi Geert, Thank you for the patch. On Tuesday, 13 February 2018 15:40:45 EET Geert Uytterhoeven wrote: > cec-clock is a fixed clock generator that is not controlled by i2c-12 > and thus should not be a child of the i2c-12 bus node. Rather, it should > be a child of the root node of the DT. > >

Re: [PATCH] ARM: dts: lager: Move cec_clock to root node

Hi Geert, Thanks for your patch. On 2018-02-13 14:40:45 +0100, Geert Uytterhoeven wrote: > cec-clock is a fixed clock generator that is not controlled by i2c-12 > and thus should not be a child of the i2c-12 bus node. Rather, it should > be a child of the root node of the DT. > > Fixes:

Re: [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning

> I think we can drop this patch for now. Nice! But we should keep it in mind and recall it, if issues pop up later. signature.asc Description: PGP signature

RE: [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN

Hello Simon, what do you think about enabling the watchdog in multi_v7_defconfig as a module? Thanks, Fab > Subject: [PATCH v5 14/26] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN > > R-Car Gen2 and RZ/G1 platforms come with a watchdog IP, therefore enable > its driver by default. > >

[PATCH v2 0/2] Add R8A77970/Eagle GPIO support

Hello! Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180213-v4.16-rc1' tag. We're adding the R8A77970 GPIO nodes and then describing the PHY IRQ for EtherAVB device declared earlier. [1/2] arm64: dts: renesas: r8a77970: add GPIO support [2/2] arm64: dts

Re: [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N

Hi Jacopo, Thanks for the patch. I haven't really looked at the rest of the patch yet - but the title stands out: [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N Should this be s/cpg-msr/cpg-mssr/ ? -- Regards Kieran On 13/02/18 09:45, Jacopo Mondi wrote: > Initial support

Re: [PATCH v2 0/3] mmc: renesas_sdhi: add eMMC HS400 mode support

On Thu, Feb 08, 2018 at 12:37:03PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:26:30PM +0100, Wolfram Sang wrote: > > > > > * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting > > > > I tried to address this one before: > > > > [PATCH 0/3] clk: renesas: rcar-gen3-cpg: updates

Re: [PATCH 4/4] arm64: dts: renesas: r8a77995: add VSPD instances

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:29 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has two VSPDs to handle display pipelines with a DU. > > Signed-off-by: Kieran Bingham

[PATCH v6 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

mugasunda...@bp.renesas.com> --- v5->v6: * rebased on top of renesas-devel-20180213-v4.16-rc1 drivers/soc/renesas/rcar-rst.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/soc/renesas/rcar-rst.c b/drivers/soc/renesas/rcar-rst.c index e

Re: [PATCH] ravb: add support for changing MTU

Hi Sergei, Thanks for your feedback. On 2018-02-13 13:01:04 +0300, Sergei Shtylyov wrote: > Hello! > > On 02/12/2018 11:00 PM, Niklas Söderlund wrote: > > > Allow for chancing the MTU within the limit of the maximum size of a > >Changing. :-) Yes :-) > > > descriptor (2048 bytes). Add

Re: [PATCH 0/3] Add R8A77970/Eagle PFC support

On Mon, Feb 12, 2018 at 09:04:06PM +0300, Sergei Shtylyov wrote: > On 01/19/2018 01:48 PM, Kieran Bingham wrote: > > >>> Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's > >>> 'renesas-devel-20171110-v4.14-rc8' tag. We're adding the R8A77970 PFC > >>> node > >>> and then

[PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes

Add GPIO nodes to r8a77965 SoC device tree file. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 152 +++--- 1 file changed, 120 insertions(+), 32 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 14/15] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions

Add EtherAVB groups and functions definitions for R-Car M3-N. Signed-off-by: Jacopo Mondi --- drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 110 ++ 1 file changed, 110 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c

[PATCH 15/15] ARM64: dts: r8a77965: Add EtherAVB device node

Populate the ethernet@e680 device node to enable Ethernet interface for R-Car M3-N (r8a77965) SoC. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff

[PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support

Describe all 6 GPIO controllers in the R8A77970 device tree. Based on the original (and large) patch by Daisuke Matsushita . Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov

Re: [PATCH v3 2/5] dt-bindings: adv7511: Add support for i2c_new_secondary_device

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:50 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

Hi Laurent, On 13/02/18 12:06, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thank you for your review, > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte

[PATCH] ARM: dts: lager: Move cec_clock to root node

cec-clock is a fixed clock generator that is not controlled by i2c-12 and thus should not be a child of the i2c-12 bus node. Rather, it should be a child of the root node of the DT. Fixes: c5aa87977626e778 ("ARM: dts: lager: Add CEC clock for HDMI transmitter") Signed-off-by: Geert Uytterhoeven

[PATCH] ata: sata_rcar: Remove unused variable in sata_rcar_init_controller()

drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller': drivers/ata/sata_rcar.c:821:8: warning: unused variable 'base' [-Wunused-variable] Fixes: da77d76b95a0e894 ("sata_rcar: Reset SATA PHY when Salvator-X board resumes") Signed-off-by: Geert Uytterhoeven

Re: [PATCH 3/4] arm64: dts: renesas: r8a77995: add VSPBS instance

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:28 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a77995 has a VSPBS to support image processing such as blending of > 2 input images. > > Signed-off-by: Kieran Bingham

Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

On Tue, Feb 13, 2018 at 12:33:53PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > > > Hi Simon, > > > > > + void (*disable_scc)(struct mmc_host *mmc); > > > > Do we really need this callback? I'd think it can be folded into > > reset_hs400_mode()

Re: [PATCH v2 3/3] mmc: renesas_sdhi: add eMMC HS400 mode support

On Tue, Feb 13, 2018 at 12:38:44PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:21:44PM +0100, Wolfram Sang wrote: > > > > > + /* Reset HS400 mode */ > > > + sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 & > > > + sd_ctrl_read16(host, CTL_SDIF_MODE)); > > > +

Re: [PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

Hi Dan Thank you for the review, On 13/02/18 07:23, Dan Carpenter wrote: > On Mon, Feb 12, 2018 at 06:11:57PM +, Kieran Bingham wrote: >> +adv7511->i2c_packet = i2c_new_secondary_device(i2c, "packet", >> +ADV7511_PACKET_I2C_ADDR_DEFAULT); >> +if

Re: [PATCH v2 3/3] mmc: renesas_sdhi: add eMMC HS400 mode support

On Wed, Feb 07, 2018 at 11:21:44PM +0100, Wolfram Sang wrote: > > > + /* Reset HS400 mode */ > > + sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 & > > + sd_ctrl_read16(host, CTL_SDIF_MODE)); > > + sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TMPPORT2, > > +

Re: [PATCH v3 4/5] media: adv7604: Add support for i2c_new_secondary_device

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:52 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

Hi Kieran, On Tuesday, 13 February 2018 15:14:43 EET Kieran Bingham wrote: > On 13/02/18 12:06, Laurent Pinchart wrote: > > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > >> From: Jean-Michel Hautbois > >> > >> The ADV7604 has thirteen

[PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we have the GPIO support (previously phylib had to resort to polling). Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77970-eagle.dts |2 ++ 1 file changed, 2

Re: [PATCH v2 1/3] mmc: tmio: correct treatment of errors during tuning

On Wed, Feb 07, 2018 at 10:52:52PM +0100, Wolfram Sang wrote: > On Fri, Jan 19, 2018 at 02:39:04PM +0100, Simon Horman wrote: > > From: Masaharu Hayakawa > > > > If the return value of mmc_send_tuning() is error other than -EILSEQ, the > > tuning fails and

Re: [PATCH 0/3] Add R8A77970/Eagle PFC support

On Tue, Feb 13, 2018 at 01:46:58PM +0300, Sergei Shtylyov wrote: > On 02/13/2018 10:52 AM, Simon Horman wrote: > > > Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's > > 'renesas-devel-20171110-v4.14-rc8' tag. We're adding the R8A77970 PFC > > node > > and

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH v3 5/5] drm: adv7511: Add support for i2c_new_secondary_device

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:53 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVD handles the interface between the VSPD and memory. > > Signed-off-by: Kieran Bingham

Re: [PATCH 1/4] arm64: dts: renesas: r8a77995: add FCPVB node

Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:26 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVB handles the interface between the VSPB and memory. > > Signed-off-by: Kieran Bingham

Re: [PATCH v5 09/26] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

On Mon, Feb 12, 2018 at 05:44:18PM +, Fabrizio Castro wrote: > This patch allows for platform specific quirks as some of the SoC need > further customization for the watchdog to work properly, like for R-Car > Gen2 and for RZ/G. > > Signed-off-by: Fabrizio Castro

[PATCH] usb: host: xhci-plat: revert "usb: host: xhci-plat: enable clk in resume timing"

This patch reverts the commit 835e4241e714 ("usb: host: xhci-plat: enable clk in resume timing") because this driver also has runtime PM and the commit 560869100b99 ("clk: renesas: cpg-mssr: Restore module clocks during resume") will restore the clock on R-Car H3 environment. If the

[PATCH 03/15] soc: renesas: Add R-Car M3-N support

Add support for R-Car M3-N (r8a77965) power areas and reset. M3-N power areas are identical to M3-W ones, so just copy and rename them. Signed-off-by: Jacopo Mondi --- .../bindings/power/renesas,rcar-sysc.txt | 1 +

[PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

Add initial support for R-Car M3-N Salvator-x and r8a77965 SoC in device tree with cpg-mssr, reset and clock nodes. Add place-holder device nodes for all nodes referred by "salvator-common.dtsi" Signed-off-by: Jacopo Mondi --- arch/arm64/Kconfig.platforms

[PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N

Initial support for R-Car M3-N (r8a77965), including core and module clocks. Signed-off-by: Jacopo Mondi --- .../devicetree/bindings/clock/renesas,cpg-mssr.txt | 1 + drivers/clk/renesas/Kconfig| 5 + drivers/clk/renesas/Makefile

[PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac

Add documentation for r8a77965 compatible string to rcar-dmac device tree bindings documentation. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: Warning for possible circular locking dependecy on v4.16-rc1

On Mon, Feb 12, 2018 at 11:40:36PM +0100, Niklas Söderlund wrote: > Hi again, > > On 2018-02-12 21:12:48 +0100, Niklas Söderlund wrote: > > Hi Geert, > > > > When doing some testing on v4.16-rc1 I ran across this warning a couple > > of times. I was using the renesas_config from the current

[PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965

Add documentation for r8a77965 compatible string to renesas ravb device tree bindings documentation. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string

Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 + drivers/gpio/gpio-rcar.c | 4 2 files changed, 5 insertions(+)

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

On Mon, Feb 12, 2018 at 05:44:09PM +, Fabrizio Castro wrote: > Dear All, > > this series has been around for some time as RFC, and it has collected > useful comments from the community along the way. > The solution proposed by this patch set works for most R-Car Gen2 and > RZ/G1 devices, but

Re: [PATCH/RFC 00/11] ARM: dts: rcar-gen2: Enable watchdog support

On Thu, Feb 08, 2018 at 11:34:06AM +0100, Geert Uytterhoeven wrote: > Hi all, > > This patch series enables the builtin watchdog timer on R-Car Gen2 SoCs > on all supported boards, and builds on top of Fabrizio's "[RFC v4 00/26] > Fix watchdog on Renesas R-Car Gen2 and RZ/G1". It is marked

Re: Warning for possible circular locking dependecy on v4.16-rc1

On Tue, Feb 13, 2018 at 9:40 AM, Simon Horman wrote: > On Mon, Feb 12, 2018 at 11:40:36PM +0100, Niklas Söderlund wrote: >> Hi again, >> >> On 2018-02-12 21:12:48 +0100, Niklas Söderlund wrote: >> > Hi Geert, >> > >> > When doing some testing on v4.16-rc1 I ran across this

[PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings

Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965) SoC. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt

[PATCH 00/15] R-Car M3-N initial support

Hello, this series adds support for Rensas R-Car M3-N (r8a77965) Soc and M3-N based Salvator-x development board. The series introduces a cpg-mssr clock/power gating module, a power/reset controller for the SoC and initial PFC support. Clock and power areas for M3-N are identical to M3-W, with

Re: [PATCH v5 10/26] ARM: shmobile: rcar-gen2: Add watchdog support

On Mon, Feb 12, 2018 at 05:44:19PM +, Fabrizio Castro wrote: > This patch adds watchdog support by installing shmobile_boot_vector_gen2 > to ICRAM1 when enough memory is available, in which case we also keep a > copy of MPIDR to complete the reset vector logic. > > Signed-off-by: Fabrizio

[PATCH] regulator: Fix resume from suspend to idle

When resuming from idle with the new suspend mode configuration support we go through the resume callbacks with a state of PM_SUSPEND_TO_IDLE which we don't have regulator constraints for, causing an error: dpm_run_callback(): regulator_resume_early+0x0/0x64 returns -22 PM: Device

[PATCH 07/15] ARM64: dts: r8a77965: Add dmac device nods

Add dmac[0-2] device nodes for R-Car M3-N (r8a77965) SoC. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 96 ++- 1 file changed, 93 insertions(+), 3 deletions(-) diff --git

[PATCH 09/15] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions

Add SCIF[0-5] groups and pin function definitions for R-Car M3-N. Signed-off-by: Jacopo Mondi --- drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 296 ++ 1 file changed, 296 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c

[PATCH 08/15] Documentation: devicetree: renesas,sci: Add r8a77965

Add documentation for r8a77965 compatible string to reneass sci-serial device tree bindings documentation. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes

Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 85 --- 1 file changed, 79 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

Re: [PATCH] ravb: add support for changing MTU

Hello! On 02/12/2018 11:00 PM, Niklas Söderlund wrote: > Allow for chancing the MTU within the limit of the maximum size of a Changing. :-) > descriptor (2048 bytes). Add the callback to change MTU from user-space > and take the configurable MTU into account when configuring the > hardware.

Re: [PATCH 0/3] Add R8A77970/Eagle PFC support

On 02/13/2018 10:52 AM, Simon Horman wrote: > Here's the set of 3 patches against Simon Horman's 'renesas.git' repo's > 'renesas-devel-20171110-v4.14-rc8' tag. We're adding the R8A77970 PFC > node > and then describing the pins for SCIF0 and EtherAVB devices declared >

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > There was never proper support in the VIN driver to deliver ALTERNATING > field format to user-space, remove this field option. The problem is > that ALTERNATING filed order requires the

Re: [PATCH v10 01/30] rcar-vin: add Gen3 devicetree bindings documentation

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:06 EET Niklas Söderlund wrote: > Document the devicetree bindings for the CSI-2 inputs available on Gen3. > > There is a need to add a custom property 'renesas,id' and to define > which CSI-2 input is described in which

Re: [PATCH v10 04/30] rcar-vin: move subdevice handling to async callbacks

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:09 EET Niklas Söderlund wrote: > In preparation for Gen3 support move the subdevice initialization and > clean up from rvin_v4l2_{register,unregister}() directly to the async > callbacks. This simplifies the addition of Gen3

Re: [PATCH v10 09/30] rcar-vin: read subdevice format for crop only when needed

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:14 EET Niklas Söderlund wrote: > Instead of caching the subdevice format each time the video device > format is set read it directly when it's needed. As it turns out the > format is only needed when figuring out the max

Re: [PATCH] ata: sata_rcar: Remove unused variable in sata_rcar_init_controller()

On Tue, Feb 13, 2018 at 01:43:23PM +0100, Geert Uytterhoeven wrote: > drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller': > drivers/ata/sata_rcar.c:821:8: warning: unused variable 'base' > [-Wunused-variable] > > Fixes: da77d76b95a0e894 ("sata_rcar: Reset SATA PHY when Salvator-X

[PATCH v4 4/5] media: adv7604: Add support for i2c_new_secondary_device

From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

[PATCH v4 2/5] dt-bindings: adv7511: Extend bindings to allow specifying slave map addresses

From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

Re: [PATCH v10 19/30] rcar-vin: set a default field to fallback on

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:24 EET Niklas Söderlund wrote: > If the field is not supported by the driver it should not try to keep > the current field. Instead it should set it to a default fallback. Since > trying a format should always result in the

[PATCH v4 1/5] dt-bindings: media: adv7604: Extend bindings to allow specifying slave map addresses

From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

Hi Laurent, On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > > feature of this register is that it's

Re: [PATCH v10 16/30] rcar-vin: update bytesperline and sizeimage calculation

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:21 EET Niklas Söderlund wrote: > Remove over complicated logic to calculate the value for bytesperline s/over complicated/overcomplicated/ > and sizeimage that was carried over from the soc_camera port. Update the >

Re: [PATCH v10 17/30] rcar-vin: update pixelformat check for M1

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:22 EET Niklas Söderlund wrote: > If the pixelformat is not supported it should not fail but be set to > something that works. While we are at it move the check together with > other pixelformat checks of this function. Please

Re: [PATCH v10 18/30] rcar-vin: add check for colorspace

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:23 EET Niklas Söderlund wrote: > Add a check to ensure the colorspace from user-space is good. On Gen2 it > works without this change as the sensor sets the colorspace but on Gen3 > this can fail if the colorspace provided by

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

Hi Laurent, On 2018-02-13 19:02:38 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Tuesday, 13 February 2018 18:58:09 EET Niklas Söderlund wrote: > > On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > > > On Gen3 the

[PATCH 1/2] vfio: platform: Fix reset module leak in error path

If the IOMMU group setup fails, the reset module is not released. Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by default") Signed-off-by: Geert Uytterhoeven --- drivers/vfio/platform/vfio_platform_common.c | 15 ++- 1 file

[PATCH 0/2] vfio: platform: Improve reset support

Hi all, This patch series improves reset support for vfio-platform: - The first patch fixes a bug I ran into while working on this. - The second patch implements generic DT reset support, for devices that are connected to an SoC-internal reset controller and can be reset in a

[PATCH 2/2] vfio: platform: Add generic DT reset support

Vfio-platform requires reset support, provided either by ACPI, or, on DT platforms, by a device-specific reset driver matching against the device's compatible value. On many SoCs, devices are connected to an SoC-internal reset controller, and can be reset in a generic way. Hence add support to

Re: [PATCH v10 10/30] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

Hi Laurent, On 2018-02-13 18:26:34 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. Thanks for your comments. > > On Monday, 29 January 2018 18:34:15 EET Niklas Söderlund wrote: > > There was never proper support in the VIN driver to deliver ALTERNATING > > field

[PATCH v4 5/5] drm: adv7511: Add support for i2c_new_secondary_device

From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

[PATCH v4 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

From: Kieran Bingham The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C bus, however in low power mode the ADV7513 will reset it's slave maps to use the hardware defined default addresses. The ADV7511 driver was adapted to allow the two

[PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB

It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE For reference, the largest arm64 DTB created from the Linux sources is 70 KiB large (93 KiB

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the

Re: [PATCH v10 15/30] rcar-vin: break out format alignment and checking

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:20 EET Niklas Söderlund wrote: > Part of the format alignment and checking can be shared with the Gen3 > format handling. Break that part out to a separate function. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v10 13/30] rcar-vin: add function to manipulate Gen3 chsel value

Hi Niklas, On Tuesday, 13 February 2018 18:58:09 EET Niklas Söderlund wrote: > On 2018-02-13 18:41:33 +0200, Laurent Pinchart wrote: > > On Monday, 29 January 2018 18:34:18 EET Niklas Söderlund wrote: > > > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > > > feature of

[PATCH v4 0/5] Add support for i2c_new_secondary_device

From: Kieran Bingham Back in 2014, Jean-Michel provided patches [0] to implement a means of describing software defined I2C addresses for devices through the DT nodes. The patch to implement the function "i2c_new_secondary_device()" was integrated, but

Re: [PATCH v10 11/30] rcar-vin: move media bus configuration to struct rvin_info

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:16 EET Niklas Söderlund wrote: > Bus configuration will once the driver is extended to support Gen3 > contain information not specific to only the directly connected parallel > subdevice. Move it to struct rvin_dev to show it's

[PATCH v2 2/4] arm64: dts: renesas: r8a77995: add VSP instances

From: Kieran Bingham The r8a77995 has a VSPBS to support image processing such as blending of two input images, and has two VSPDs to handle display pipelines with a DU. Signed-off-by: Kieran Bingham --- v2: -

Re: [PATCH v10 22/30] rcar-vin: add group allocator functions

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:27 EET Niklas Söderlund wrote: > In media controller mode all VIN instances needs to be part of the same > media graph. There is also a need for each VIN instance to know about > and in some cases be able to communicate with

Re: [PATCH v10 24/30] rcar-vin: add chsel information to rvin_info

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:29 EET Niklas Söderlund wrote: > Each Gen3 SoC has a limited set of predefined routing possibilities for > which CSI-2 device and virtual channel can be routed to which VIN > instance. Prepare to store this information in the

Re: [PATCH v10 25/30] rcar-vin: parse Gen3 OF and setup media graph

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:30 EET Niklas Söderlund wrote: > The parsing and registering CSI-2 subdevices with the v4l2 async > framework is a collaborative effort shared between the VIN instances > which are part of the group. When the last VIN in the

Re: [PATCH v10 20/30] rcar-vin: use different v4l2 operations in media controller mode

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:25 EET Niklas Söderlund wrote: > When the driver runs in media controller mode it should not directly > control the subdevice instead userspace will be responsible for > configuring the pipeline. To be able to run in this mode

Re: [PATCH v10 21/30] rcar-vin: prepare for media controller mode initialization

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:26 EET Niklas Söderlund wrote: > Prepare for media controller by calling a different initialization then > for when running in device centric mode. Add trivial configuration of s/then for when/than when/ > the mbus and

Re: [PATCH v10 23/30] rcar-vin: change name of video device

Hi Niklas, Thank you for the patch. On Monday, 29 January 2018 18:34:28 EET Niklas Söderlund wrote: > The rcar-vin driver needs to be part of a media controller to support > Gen3. Give each VIN instance a unique name so it can be referenced from > userspace. > > Signed-off-by: Niklas Söderlund

[PATCH v2 4/4] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 +++--- 1

[PATCH v2 3/4] arm64: dts: renesas: r8a7795: Fix register mappings on VSPs

From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 6 +++--- 1

[PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

From: Kieran Bingham The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used as a dual-input image blender, while two VSPD instances can be utilised as part of a display (DU) pipeline. Add support for these, along with their required

[PATCH v2 1/4] arm64: dts: renesas: r8a77995: add FCPV nodes

From: Kieran Bingham The FCPVB handles the interface between the VSPB and memory, while the FCPVD handles the interface between the VSPD and memory. Signed-off-by: Kieran Bingham

Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB

On 13 February 2018 at 16:41, Geert Uytterhoeven wrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > For

  1   2   >